Andrew McCreight
4e675fbb74
Bug 1189369, part 9 - Use early return in nsMaybeWeakPtr<T>::GetValue(). r=mak
2015-08-04 13:55:01 -07:00
Andrew McCreight
6b14f620f1
Bug 1189369, part 8 - Clean up some minor style issues in nsMaybeWeakPtr.h. r=mak
2015-08-04 13:55:01 -07:00
Andrew McCreight
12351d4eb0
Bug 1189369, part 7 - Use nicer nsTArray functions in nsMaybeWeakPtrArray. r=mak
2015-08-04 13:55:01 -07:00
Andrew McCreight
4ebe3f9242
Bug 1189369, part 6 - Inline AppendWeakElement and RemoveWeakElement. r=mak
...
This class is only instantiated three times, so it doesn't seem worth
the contortions to save a bit of code.
2015-08-04 13:55:01 -07:00
Andrew McCreight
1ac060e051
Bug 1189369, part 5 - Use the nice cycle collector macro template for nsNavHistoryResult. r=mak
...
Also, fix up the CC template so it works.
2015-08-04 13:55:01 -07:00
Andrew McCreight
a5a94eb885
Bug 1189369, part 4 - Get rid of some old style QIs from nsMaybeWeakPtrArray. r=mak
2015-08-04 13:55:01 -07:00
Andrew McCreight
d4c75b79c4
Bug 1189369, part 3 - Inline nsMaybeWeakPtr_base. r=mak
...
nsMaybePtr<> is only ever instantiated with 3 different classes, so it
doesn't seem like it worth the contortions to save a little code.
2015-08-04 13:55:01 -07:00
Andrew McCreight
a099491825
Bug 1189369, part 2 - Don't implicitly convert nsMaybeWeakPtr to an nsCOMPtr. r=mak
...
This is only used in a few places, and it obscures what is happening.
2015-08-04 13:55:01 -07:00
Andrew McCreight
343830ddd2
Bug 1074416 - Don't AddRef or Release nav history result observers during CC traversal. r=smaug
...
Doing an AddRef or Release of a cycle collected object during CC
traversal can cause leaks. traverseResultObservers does this in two
places. First, it accidentally copies the array that is passed
in. Second, the GetValue() method that is being implicitly called in
the line with |aObservers.ElementAt(i);| does a QI.
This patch fixes the former problem by passing a reference. It fixes
the latter problem by returning the raw underlying pointer held by the
nsMaybeWeakPtrArray, which is what the CC wants anyways, because it
does not care about weak referents.
2015-07-29 20:36:00 -04:00
Ehsan Akhgari
5847679c76
Bug 1060974 - Fix more bad implicit constructors in places; r=mak
2014-09-03 18:25:36 -04:00
Benoit Jacob
91462c5c63
Bug 806279 - CC macros refactoring: part 3: fold the TRAVERSE_NATIVE and AMBIGUOUS cases - r=mccr8,smaug
2012-11-15 02:32:39 -05:00
Benoit Jacob
b20f6f40ba
Bug 806279 - CC macros refactoring: part 1: implement type-generic CC UNLINK/TRAVERSE macros - r=mccr8,smaug
2012-11-15 02:32:39 -05:00
Ehsan Akhgari
243c878d26
Bug 579517 - Part 1: Automated conversion of NSPR numeric types to stdint types in Gecko; r=bsmedberg
...
This patch was generated by a script. Here's the source of the script for
future reference:
function convert() {
echo "Converting $1 to $2..."
find . ! -wholename "*nsprpub*" \
! -wholename "*security/nss*" \
! -wholename "*/.hg*" \
! -wholename "obj-ff-dbg*" \
! -name nsXPCOMCID.h \
! -name prtypes.h \
-type f \
\( -iname "*.cpp" \
-o -iname "*.h" \
-o -iname "*.c" \
-o -iname "*.cc" \
-o -iname "*.idl" \
-o -iname "*.ipdl" \
-o -iname "*.ipdlh" \
-o -iname "*.mm" \) | \
xargs -n 1 sed -i -e "s/\b$1\b/$2/g"
}
convert PRInt8 int8_t
convert PRUint8 uint8_t
convert PRInt16 int16_t
convert PRUint16 uint16_t
convert PRInt32 int32_t
convert PRUint32 uint32_t
convert PRInt64 int64_t
convert PRUint64 uint64_t
convert PRIntn int
convert PRUintn unsigned
convert PRSize size_t
convert PROffset32 int32_t
convert PROffset64 int64_t
convert PRPtrdiff ptrdiff_t
convert PRFloat64 double
2012-08-22 11:56:38 -04:00
Gervase Markham
cb6a072c2a
Bug 716478 - update licence to MPL 2.
2012-05-21 12:12:37 +01:00
Michael Wu
0fe7772ece
Bug 675553 - Switch from PRBool to bool on a CLOSED TREE , r=bsmedberg,khuey,bz,cjones
2011-09-28 23:19:26 -07:00
Mitchell Field
8969bddd5d
Bug 595513 - Reduce makefile recursion in toolkit. r=khuey
2011-03-08 14:58:46 +11:00
