Commit Graph

1381 Commits

Author SHA1 Message Date
Kris Maglione
5a3ffd4ede Bug 1470333: Part 2 - Avoid creating ConsoleAPI instances when debug logging is not enabled. r=MattN
MozReview-Commit-ID: Edck1SgCcDA
2018-07-04 12:43:21 -07:00
Coroiu Cristina
dfd438c078 Backed out 2 changesets (bug 1470333) for xpcshell failures at browser/extensions/formautofill/test/unit/test_getFormInputDetails.js
Backed out changeset dbea1942a32f (bug 1470333)
Backed out changeset 440ee3fab72a (bug 1470333)
2018-07-05 00:24:27 +03:00
Kris Maglione
871bddafb2 Bug 1470333: Part 2 - Avoid creating ConsoleAPI instances when debug logging is not enabled. r=MattN
MozReview-Commit-ID: Edck1SgCcDA
2018-07-04 12:43:21 -07:00
Kris Maglione
ce4a4be2a3 Bug 1469719: Avoid loading LoginManagerContent before it's needed. r=felipe
The "pageshow" and "blur" event listeners in LoginManagerContent only matter
once the module has loaded and processed other events. Before that, they're
guaranteed to be no-ops.

This patch delays adding those listeners before LoginManagerContent is used
for a given frame script.

MozReview-Commit-ID: 1f5AOkRkAhp
2018-06-24 18:07:59 -07:00
shindli
6f67e8ac1d Backed out 3 changesets (bug 1470023, bug 1469719, bug 1470965) for | toolkit/components/perfmonitoring/tests/browser/browser_compartments.js on a CLOSED TREE
Backed out changeset bab121b4dd84 (bug 1469719)
Backed out changeset d28d3a80e781 (bug 1470965)
Backed out changeset 1adc0372343e (bug 1470023)
2018-06-26 22:57:54 +03:00
Kris Maglione
0851f880c0 Bug 1469719: Avoid loading LoginManagerContent before it's needed. r=felipe
The "pageshow" and "blur" event listeners in LoginManagerContent only matter
once the module has loaded and processed other events. Before that, they're
guaranteed to be no-ops.

This patch delays adding those listeners before LoginManagerContent is used
for a given frame script.

MozReview-Commit-ID: 1f5AOkRkAhp
2018-06-24 18:07:59 -07:00
Paolo Amadini
a80747f919 Bug 1446362 - Part 2 - Remove "tree" from the permission preferences. r=johannh
MozReview-Commit-ID: 9IYpH8SvsCw
2018-06-22 14:13:53 +01:00
Joel Maher
d0823df1ef Bug 1405428 - skip-if = verify on mochitests which do not pass test-verify. r=gbrown 2018-06-10 05:01:47 -04:00
Bianca Danforth
115c431296 Bug 1465685 - Add login_form probe for Savant Shield study; r=MattN
This probe will register and record (for the duration of the study only):
* When a login form is loaded
* When a login form is submitted (excluding the case from unresolved bug 1287202)

The login_form probe has an 'extra' field called 'flow_id'. This value associates actions that occur in the same tab.

It should be noted that for several reasons, we should expect a higher than 1:1 ratio between 'load' and 'submit' events:
* Some sites, like Google and Amazon, have a two-step login process, and each step fires its own 'load' event. Only the second step fires a 'submit' event.
* Some sites, like Facebook and Twitter, fire multiple 'load' events on the same page.
* A common pattern for unsuccessful logins is for the site to redirect to a page with a login form. This would be a 'load' --> 'submit' --> 'load' series.
* Unlike 'load', the 'submit' event fires only when the Password Manager is enabled and the user is in a non-private window. 'Load' events will have a 'canRecordSubmit' key in the 'extra' field which will be true if a submit event for that form can be recorded.

MozReview-Commit-ID: LOMDSN6tgRV
2018-06-07 03:24:09 -07:00
Bianca Danforth
90748a458c Bug 1465685 - Add Password Manager probes for Savant Shield study; r=MattN
These probes will register and record (for the duration of the study only):
* When the user is prompted by the Password Manager
* When the user saves their login information through the Password Manager prompt
* When the user updates their login information through the Password Manager prompt
* When the user uses login information stored by the Password Manager

Both the 'pwmgr' and 'pwmgr_use' probe have an 'extra' field called 'flow_id'. This is a tab identifier. For a given session, flow_id remains constant, even if the tab is moved to a different index within the same window. Tabs at the same index in different windows will have different flow_ids.

MozReview-Commit-ID: CoBNl6lUQmH
2018-06-07 03:23:47 -07:00
Kris Maglione
0847e8227e Bug 1464548: Part 3 - Update callers to use defineLazyGlobalGetters. r=mccr8
MozReview-Commit-ID: 9APGewiDDYB
2018-05-25 17:02:29 -07:00
Mark Banner
3b36b732b2 Bug 1463673 - Add the expected argument to Assert.throws/rejects for various tests in toolkit/. r=mossop
MozReview-Commit-ID: LsWlHC16145
2018-05-22 19:25:34 +01:00
Matthew Noorenberghe
30e408367f Bug 1462959 - Catch exceptions accessing .hostPort for non-http/ftp schemes in LoginHelper.doLoginsMatch. r=johannh
nsIURI.hostPort would throw NS_ERROR_FAILURE in this case

MozReview-Commit-ID: K4mK3X91ic0
2018-05-22 19:46:53 -07:00
Matthew Noorenberghe
c6d63d0494 Bug 1463584 - Remove invalid Assert.throws from test_empty_password. r=standard8
MozReview-Commit-ID: B4AcOaKyGPo
2018-05-22 20:02:43 -07:00
Kris Maglione
c03fa450d6 Bug 1460092: Add ESLint rule to enforce use of ChromeUtils.generateQI. r=Gijs
Also fixes existing code which fails the rule.

MozReview-Commit-ID: CkLFgsspGMU
2018-05-08 18:36:22 -07:00
Adrian Wielgosik
929be0f567 Bug 1418078 - Convert XPIDL, C++ users of nsIDOMHTMLInputElement. r=bz
MozReview-Commit-ID: 9K5wL93cZ4j
2018-04-18 22:35:09 +02:00
Adrian Wielgosik
65b770c17d Bug 1418078 - Convert JS users of nsIDOMHTMLInputElement. r=bz
MozReview-Commit-ID: 55aIiNHS0xs
2018-04-18 22:29:50 +02:00
Kris Maglione
fd7e9e6a69 Bug 1456035: Part 4 - Convert callers of XPCOMUtils.generateQI to ChromeUtils.generateQI. r=mccr8
This also removes any redundant Ci.nsISupports elements in the interface
lists.

This was done using the following script:

acecb401b7/processors/chromeutils-generateQI.jsm

MozReview-Commit-ID: AIx10P8GpZY
2018-04-22 20:55:06 -07:00
Boris Zbarsky
e3c14a1969 Bug 1455674 part 11. Remove nsIDOMElement use from xpidl in toolkit. r=mossop 2018-04-26 23:36:30 -04:00
Noemi Erli
2b5e91b94b Bug 1333264 - disabled test_master_password.html on Linux 32 debug for frequent failures. r=jmaher 2018-04-24 01:41:00 +03:00
Kris Maglione
59b2dd801c Bug 1454813: Part 2b - Rename SpawnTask.js to AddTask.js. r=florian
The old name no longer makes sense, since it no longer exports an spawn_task
symbol, and add_task is what we really care about.

MozReview-Commit-ID: IE7B8Czv8DH
2018-04-18 11:43:45 -07:00
Marco Bonardo
ffb9670998 Bug 1453580 - Remove promiseFaviconLinkUrl and fix its consumers. r=Gijs
MozReview-Commit-ID: GrY8s3l71Mp
2018-04-16 18:24:06 +02:00
Dorel Luca
af4700d8df Backed out changeset 897bbf35e781 (bug 1453580) for XPCShell failure on services/sync/tests/unit/test_syncedtabs.js. CLOSED TREE 2018-04-18 14:06:34 +03:00
Marco Bonardo
11e458b637 Bug 1453580 - Remove promiseFaviconLinkUrl and fix its consumers. r=Gijs
MozReview-Commit-ID: GrY8s3l71Mp
2018-04-16 18:24:06 +02:00
Boris Zbarsky
80b04c969c Bug 1453053 part 1. Remove useless QIs to nsIDOMNode. r=qdot
MozReview-Commit-ID: GokPD2buxzN
2018-04-12 00:06:25 -04:00
Boris Zbarsky
0e6ee1bab5 Bug 1453345 part 5. Remove pointless JS implemenations of QI to nsIDOMEventListener. r=smaug
MozReview-Commit-ID: Db0v6GZ0deo
2018-04-12 00:03:45 -04:00
Jonathan Kingston
c3449ab668 Bug 1374741 - Within toolkit/ make openUILinkIn() provide the correct triggeringPrincipal. r=Gijs
MozReview-Commit-ID: AX2S3bEKl1w
2018-02-21 23:08:42 +00:00
Kris Maglione
e9dca3c017 Bug 1451058: Follow-up: Fix some errors that show up during tests. r=me
MozReview-Commit-ID: K410z6VdHov
2018-04-06 16:34:15 -07:00
Boris Zbarsky
56da337b37 Bug 1449631 part 1. Remove JS uses of nsIDOMEventTarget. r=smaug
MozReview-Commit-ID: CCHCZjMgInu
2018-04-05 13:42:40 -04:00
Peter Van der Beken
75d03ab497 Bug 888600 - Move ContentFrameMessageManager to WebIDL. Part 6: Mark some IDL interfaces as non-scriptable. r=bz. 2018-03-01 20:19:56 +01:00
Tooru Fujisawa
f415c74b57 Bug 1442465 - Part 4.2: Stop unnecessarily awaiting on BrowserTestUtils.removeTab (simple part). r=dao 2018-03-19 11:16:45 +09:00
Adrian Wielgosik
975ac50d53 Bug 1418077 - Remove nsIDOMHTMLFormElement. r=bz
MozReview-Commit-ID: 9eQxvfIMB22
2018-03-14 21:42:25 +01:00
Sebastian Hengst
500c4f7ad2 Backed out 6 changesets (bug 888600) for beta simulation failures: build bustage on Linux and Windows opt (bug 1442036) and devtools failure browser_net_view-source-debugger.js (bug 1441961). a=backout
Backed out changeset 83c87140dc3d (bug 888600)
Backed out changeset 2efb9b1753f6 (bug 888600)
Backed out changeset af5303781961 (bug 888600)
Backed out changeset 79ef59047e63 (bug 888600)
Backed out changeset 30d568d628dd (bug 888600)
Backed out changeset c7bd4c6c9741 (bug 888600)
2018-03-01 11:51:09 +02:00
Florian Quèze
f6add2cafd Bug 1433175 - scripted patch to replace Components.classes[, Components.interfaces.nsI, Components.utils. and Components.results. with Cc, Ci, Cu and Cr, r=Mossop. 2018-02-28 18:51:33 +01:00
Peter Van der Beken
972562411b Bug 888600 - Move ContentFrameMessageManager to WebIDL. Part 6: Mark some IDL interfaces as non-scriptable. r=bz. 2018-02-22 20:22:29 +01:00
Sebastian Hengst
4e51639fe3 merge mozilla-central to autoland on a CLOSED TREE 2018-02-24 03:07:44 +02:00
Florian Quèze
f1a55f73f8 Bug 1440284 - change this.EXPORTED_SYMBOLS back to var EXPORTED_SYMBOLS in JS modules, r=mccr8. 2018-02-23 20:50:01 +01:00
Dorel Luca
9260b212cd Backed out 6 changesets (bug 888600) for Valgrind and build bustge on a CLOSED TREE
Backed out changeset 7c8317f4ad48 (bug 888600)
Backed out changeset 5b990735f1ad (bug 888600)
Backed out changeset 9eafe225b804 (bug 888600)
Backed out changeset 16af80d6cd93 (bug 888600)
Backed out changeset a109987af625 (bug 888600)
Backed out changeset 0949dba396ad (bug 888600)
2018-02-22 13:56:43 +02:00
Peter Van der Beken
5fb60d9c57 Bug 888600 - Move ContentFrameMessageManager to WebIDL. Part 6: Mark some IDL interfaces as non-scriptable. r=bz. 2017-11-23 16:27:27 +01:00
Masayuki Nakano
efaea0aaa7 Bug 1438157 - part 2: Remove unnecessary second argument of EventUtils.synthesizeKey() r=smaug
Note that this patch also replaces legacy VK_* with KEY_*, and replaces
synthesizeKey() for inputting some characters with sendString() because
it's better and clearer what it does and it sets shiftKey state properly.

MozReview-Commit-ID: De4enbjux3T
2018-02-15 04:15:39 +09:00
Thomas Wisniewski
6ba7255647 Bug 792808 - Change toolkit/ to import and instantiate XHRs from global properties rather than using Cc.createInstance(Ci.nsIXMLHttpRequest); r=aswan
MozReview-Commit-ID: CUrMOocHBNu
2018-02-08 20:09:57 -05:00
Margareta Eliza Balazs
7ec62aee45 Backed out changeset ebbcdc3e642d (bug 1433593) for X failing in toolkit/components/passwordmgr/test/unit/test_maybeImportLogin.js on a CLOSED TREE 2018-02-16 04:50:42 +02:00
Doug Thayer
2ea712bce8 Bug 1433593 - Skip test_maybeImportLogin on Android r=MattN
MozReview-Commit-ID: 9LQaK318UKU
2018-02-16 10:02:19 -08:00
Doug Thayer
2a70781cd0 Bug 1433593 - Clean up usages of LoginHelper.maybeImportLogin r=MattN
In bug 1426721 we added a bulk interface for importing logins, which
works in a background thread. This patch cleans up the single-login
interface and updates the remaining usages to consume the bulk
interface.

MozReview-Commit-ID: IziLXkO5dxQ
2018-02-15 10:26:44 -08:00
shindli
f1661b02af Backed out 2 changesets (bug 1433593) for xpcshell on /tests/unit/test_IE7_passwords.js on a CLOSED TREE
Backed out changeset c1b0ea577728 (bug 1433593)
Backed out changeset 96327b595b91 (bug 1433593)
2018-02-20 23:01:54 +02:00
Doug Thayer
5e79cd96d2 Bug 1433593 - Skip test_maybeImportLogin on Android r=MattN
MozReview-Commit-ID: 9LQaK318UKU
2018-02-16 10:02:19 -08:00
Doug Thayer
afbdc3b32b Bug 1433593 - Clean up usages of LoginHelper.maybeImportLogin r=MattN
In bug 1426721 we added a bulk interface for importing logins, which
works in a background thread. This patch cleans up the single-login
interface and updates the remaining usages to consume the bulk
interface.

MozReview-Commit-ID: IziLXkO5dxQ
2018-02-15 10:26:44 -08:00
Doug Thayer
38979fb27e Bug 1433593 - Clean up usages of LoginHelper.maybeImportLogin r=MattN
In bug 1426721 we added a bulk interface for importing logins, which
works in a background thread. This patch cleans up the single-login
interface and updates the remaining usages to consume the bulk
interface.

MozReview-Commit-ID: IziLXkO5dxQ
2018-02-15 10:26:44 -08:00
Jared Wein
d5ab8bee00 Bug 1436575 - Manually fix the errors from no-compare-against-boolean-literal that the autofix couldn't change. r=standard8
MozReview-Commit-ID: 6NtfU76sPKv
2018-02-08 13:35:53 -05:00
Masayuki Nakano
53a40055b6 Bug 1436926 - part 2: Remove unnecessary KeyboardEvent.code specification of callers of EventUtils.synthesizeKey() r=smaug
Now, callers of EventUtils.synthesizeKey() don't need to specify
KeyboardEvent.code value anymore if they assume that active keyboard layout
is US keyboard layout.

Note that this patch changes the meaning of only test_bug551434.html.
Some callers in it don't match the key value and code value but that looks
like that they don't checking such odd keyboard events.  So, they must be
bug of the test.

MozReview-Commit-ID: Itxo7yZ9rkK
2018-02-09 19:17:26 +09:00