Commit Graph

14 Commits

Author SHA1 Message Date
Emilio Cobos Álvarez
f76d60e3c8 No bug - Make servo-tidy happy. r=me
MozReview-Commit-ID: HDlgkGdvdBg
2018-05-15 12:09:25 +02:00
Emilio Cobos Álvarez
70131cfa2e Bug 1461288: Distinguish between specified and computed URLs. r=xidorn
This is needed to serialize computed URLs correctly from getComputedStyle.

MozReview-Commit-ID: 9wakhqNrszb
2018-05-14 12:29:40 +02:00
Emilio Cobos Álvarez
2d3b844bb7 Bug 1459436: Fix tidy issues. r=emilio
MozReview-Commit-ID: KXInHzAiiD8
2018-05-05 18:07:18 +02:00
Emilio Cobos Álvarez
b81a2144cd Bug 1457332: Derive ToCss for Counters. r=xidorn
MozReview-Commit-ID: 1jOglcqt1Dd
2018-04-30 05:10:22 +02:00
Xidorn Quan
d9d628bfa4 Bug 1455576 part 2 - Add a ValueInfo trait for exposing types needed by devtools. r=emilio
Most of types just derive it using proc_macro directly. Some of value
types need manual impl.

In my current plan, this new trait will be used in bug 1434130 to expose
values as well.

MozReview-Commit-ID: LI7fy45VkRw
2018-04-26 09:01:02 +10:00
Bobby Holley
196912c9bf servo: Merge #20603 - Run rustfmt on selectors, servo_arc, and style (from bholley:rustfmt_style); r=Manishearth
Now that rustfmt is getting close to stable, and work on the style system has died down a bit, it seemed like an opportune time to auto-format the style crates.

The first commit disables import reordering, since tidy and rustfmt don't currently agree on the correct ordering. The second commit does a bunch of manual fixups such that the output of rustfmt passes tidy. The third commit runs rustfmt on the three aforementioned crate.

There are a few dozen warnings in the style crate about lines longer than 100 characters. It would be good to fix these, but I don't have time for that now.

Source-Repo: https://github.com/servo/servo
Source-Revision: 9a900ef019cd643bff961d7b20db6da69f3edb29
2018-04-10 21:00:11 -04:00
Emilio Cobos Álvarez
663a9c06bb servo: Merge #20224 - Fix counter() and counters() serialization (from emilio:counter-serialization); r=nox
See https://github.com/w3c/csswg-drafts/issues/670 and https://github.com/w3c/web-platform-tests/pull/9862.

Source-Repo: https://github.com/servo/servo
Source-Revision: 7b326529db64ac27f0b956880b3b63dd12cd0c1a
2018-03-14 13:26:00 -04:00
Xidorn Quan
98847d6862 servo: Merge #20238 - Construct URLValue eagerly and share it between specified value and style structs (from upsuper:url-value); r=emilio
This is the Servo side change of [bug 1443046](https://bugzilla.mozilla.org/show_bug.cgi?id=1443046).

Source-Repo: https://github.com/servo/servo
Source-Revision: 1d122c250c906358a91b607b0fcc720546d04134
2018-03-08 08:06:35 -05:00
Anthony Ramine
741a2d8ebd servo: Merge #20211 - Improve #[derive(ToCss)] (from servo:derive-all-the-things); r=emilio
Source-Repo: https://github.com/servo/servo
Source-Revision: 785b7c7775ae13c02556c84a16469efc6c4d71e8
2018-03-06 11:42:58 -05:00
Anthony Ramine
488bb613e3 servo: Merge #20171 - Make ContentItem use a CustomIdent for counter names (from servo:content-item-counters); r=emilio
See https://github.com/w3c/csswg-drafts/pull/2377.

Source-Repo: https://github.com/servo/servo
Source-Revision: 476a0764f5398675481cbaaa040ecc061ae6e579
2018-03-02 11:18:49 -05:00
Nupur Baghel
986f62daa5 servo: Merge #20019 - Added derive(ToCss) for Content and removed manual implementation (from paavininanda:deriveToCss); r=emilio
Added derive(ToCss) annotation : WIP

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
<!--
- [ ] `./mach build -d` does not report any errors
- [ ] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).  -->

<!-- Either: -->
<!--
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because _____
 -->

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

Source-Repo: https://github.com/servo/servo
Source-Revision: 0653f3097c07cac0a44e8a1bb1d431885edd7de0
2018-02-11 14:10:48 -05:00
Igor Gutorov
408b064753 servo: Merge #19957 - style: Move content property out of mako (from gootorov:move-counter-from-mako); r=emilio
<!-- Please describe your changes on the following line: -->
r? emilio

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach build-geckolib` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #19936 (github issue number if applicable).

<!-- Either: -->
- [x] These changes do not require tests

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

Source-Repo: https://github.com/servo/servo
Source-Revision: 804b4b3db6d75d35b2f2ec8acf83207c5875aa74
2018-02-06 17:39:03 -05:00
Anthony Ramine
3d36c1c6c2 servo: Merge #19945 - Simplify counter CSS properties (from servo:derive-all-the-things); r=emilio
Source-Repo: https://github.com/servo/servo
Source-Revision: 7f7a460a15debe21117f25042059d6f24b99beda
2018-02-04 09:11:05 -05:00
Jonas Reinwald
335c57f734 servo: Merge #19529 - style: moved css longhand counter-reset out of mako (from DonatJR:counter-reset-out-of-mako); r=emilio
<!-- Please describe your changes on the following line: -->
This is a sub-PR of #19015
Code does not yet compile with `build-geckolib`.
r? emilio

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #19387

<!-- Either: -->
- [x] These changes do not require tests

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

Source-Repo: https://github.com/servo/servo
Source-Revision: 38ef515463338d1c562381fd650b80272f552dfb
2018-02-01 09:42:40 -06:00