Commit Graph

165 Commits

Author SHA1 Message Date
Sylvestre Ledru
2e20e1869a Bug 1447480 - Add a MOZ_ASSERT to make it clear that it can never fall through r=hsivonen
MozReview-Commit-ID: Hq9jG1CVwRK
2018-04-03 13:40:59 +02:00
Tiberius Oros
52c04a327f Backed out 2 changesets (bug 1447480) for build bustages at dist/include/mozilla/Assertions.h:60 a=backout on a CLOSED TREE
Backed out changeset 5dfbd42ce515 (bug 1447480)
Backed out changeset a454ed4489f2 (bug 1447480)
2018-04-05 13:36:46 +03:00
Sylvestre Ledru
31495a8776 Bug 1447480 - Add a MOZ_ASSERT to make it clear that it can never fall through r=hsivonen
MozReview-Commit-ID: Hq9jG1CVwRK
2018-04-03 13:40:59 +02:00
Margareta Eliza Balazs
cf349de057 Backed out changeset fa109105e4ea (bug 1447480) for B failures in /build/build/src/parser/html/nsHtml5TreeBuilder.cpp(402) on a CLOSED TREE 2018-04-04 16:05:06 +03:00
Sylvestre Ledru
2204107cfc Bug 1447480 - Add a MOZ_ASSERT to make it clear that it can never fall through r=hsivonen
MozReview-Commit-ID: Hq9jG1CVwRK
2018-04-03 13:40:59 +02:00
Boris Zbarsky
dba6013b27 Bug 1445983. <bdi> should be an HTMLElement, not HTMLUnknownElement. r=hsivonen
MozReview-Commit-ID: 9eJ45uXRDfR
2018-03-16 11:26:09 -04:00
Boris Zbarsky
051041fc49 Bug 1446097. Switch to "set" as the canonical nsGkAtoms name of the string "set", so it matches the actual tag name "set" in SVG. r=hsivonen,njn
Most of the noise is from the fact that clang-format on parser/html/*.{h,cpp}
reformatted all sorts of stuff.  Not running it caused lots of format changes
from the generator... I guess we changed the format rules since the last time
this got run?

MozReview-Commit-ID: IA2G87zUIKN
2018-03-16 11:26:06 -04:00
Sylvestre Ledru
e2d9c23cc4 Bug 1426997 - Add MOZ_FALLTHROUGH_ASSERT to make it clear that it can never fall through r=hsivonen
MozReview-Commit-ID: KZvVGnlJZtr
2018-01-29 09:11:08 +01:00
Henri Sivonen
2247ebdf00 Bug 1424220 - Set mCurrentHtmlScriptIsAsyncOrDefer to false when restoring tree builder state. r=smaug
MozReview-Commit-ID: 9gsFme52mOG
2018-01-15 20:07:28 +02:00
Chris Peterson
8e5d7c26d6 Bug 1424548 - Part 11: Regenerate HTML parser code with MOZ_FALLTHROUGH annotations. r=hsivonen
And stop suppressing -Wimplicit-fallthrough warnings. We no longer need to suppress these clang warnings because the generated parser code now includes MOZ_FALLTHROUGH annotations.
2017-12-01 01:05:26 -08:00
Chris Peterson
f3d0ca9013 Bug 1424548 - Part 9a: clang-format generated HTML parser code. r=hsivonen 2017-12-21 00:02:43 -08:00
Nicholas Nethercote
7dbfdaf890 Bug 1400460 - Rename nsIAtom as nsAtom. r=hiro.
(Path is actually r=froydnj.)

Bug 1400459 devirtualized nsIAtom so that it is no longer a subclass of
nsISupports. This means that nsAtom is now a better name for it than nsIAtom.

MozReview-Commit-ID: 91U22X2NydP
2017-10-03 09:05:19 +11:00
Sebastian Hengst
b36c461e52 Backed out changeset 0ce8d073a16e (bug 256180) 2017-09-28 11:30:33 +02:00
Henri Sivonen
d2c77a8997 Bug 256180 parser part - Insert elements as siblings instead of children at the Blink-defined magic depth for compatibility. r=smaug
MozReview-Commit-ID: K8fgv3rgklt
2017-09-12 16:57:05 +03:00
Henri Sivonen
fa792cb56c Bug 1375701 - Atomize class attribute value in the parser in the innerHTML case. r=Ehsan
MozReview-Commit-ID: CKyGlzYS15e
2017-08-11 09:22:57 +03:00
Sebastian Hengst
7e433bbe75 Backed out changeset fabf345eec6e (bug 1375701) for bustage at parser/html/nsHtml5String.h:143:3: bad implicit conversion constructor for 'nsHtml5String'. r=backout on a CLOSED TREE 2017-08-15 16:28:10 +02:00
Henri Sivonen
8d12eac1f2 Bug 1375701 - Atomize class attribute value in the parser in the innerHTML case. r=Ehsan
MozReview-Commit-ID: CKyGlzYS15e
2017-08-11 09:22:57 +03:00
Henri Sivonen
3b532a7391 Bug 483155 - Put content creator function pointers onto nsHtml5ElementName. r=smaug
MozReview-Commit-ID: E2AAx7Zz2UF
2017-07-04 11:00:03 +03:00
Sebastian Hengst
b20f04d43a Backed out changeset 5b706cd241cb (bug 483155) for Valgrind failure on Linux x64 opt. r=backout 2017-08-11 10:48:10 +02:00
Henri Sivonen
b2625c0d7e Bug 483155 - Put content creator function pointers onto nsHtml5ElementName. r=smaug
MozReview-Commit-ID: E2AAx7Zz2UF
2017-07-04 11:00:03 +03:00
Sylvestre Ledru
576cac5ec7 Bug 1381253 - Remove redundant control flow declarations rs=ehsan
MozReview-Commit-ID: FFxP4aMCbOL
2017-07-15 19:03:04 +02:00
Henri Sivonen
cc83c1cd0f Bug 1266495 - Remove <isindex>. r=wchen
MozReview-Commit-ID: KM0sTMM1GaD
2017-07-05 11:42:04 +03:00
William Chen
4a319f4238 Bug 1355441 - Reuse StackNode in TreeBuilder to avoid malloc. r=hsivonen.
MozReview-Commit-ID: 4QwQwISCKPk
2017-05-15 17:18:20 +03:00
Iris Hsiao
314d76a0b8 Backed out changeset 2e7615b554ee (bug 1355441) for crashing at nsHtml5TreeBuilder::getUnusedStackNode() intermittent failures 2017-05-09 17:11:28 +08:00
William Chen
b396a8a419 Bug 1355441 - Reuse StackNode in HTML parser TreeBuilder to avoid malloc. r=hsivonen 2017-05-01 17:25:05 -07:00
Henri Sivonen
43720a8e05 Bug 1269490 - Merge nsHtml5Atoms into nsGkAtoms. r=wchen
MozReview-Commit-ID: EcfnXkFuJy3
2017-04-20 11:47:02 +03:00
Henri Sivonen
3b050334d4 Bug 1358037 - Inline the methods of nsHtml5ElementName and nsHtml5AttributeName. r=wchen
Moving methods that refer to constant to the header that defines the
constants makes it infeasible to #define the constants at the end
of the header. To avoid introducing a new pass over the Java AST,
this patch turns the primitive constants that were
previously #defined into C++ contants, which, according to
Stroustrup 3rd ed., are handled at compile-time and don't consume
storage.

MozReview-Commit-ID: JnaDgW2OM7t
2017-04-20 10:34:32 +03:00
Henri Sivonen
759c770926 Bug 1355479 - Flatten attribute storage in the HTML parser to AutoTArray to avoid malloc. r=wchen
MozReview-Commit-ID: 77Hqo24F2nB
2017-04-13 11:14:48 +03:00
Henri Sivonen
6274301b73 Bug 1355769 - Avoid malloc for nsHtml5ElementName when processing a non-interned element name. r=wchen
MozReview-Commit-ID: 4In5wo0flOB
2017-04-12 13:21:03 +03:00
Henri Sivonen
cb263a268d Bug 1347737 - Introduce a new non-heap-allocated type for holding nsStringBuffer* in the HTML parser. r=wchen.
MozReview-Commit-ID: Gn9fXroxQhY
2017-03-20 14:45:15 +02:00
Henri Sivonen
751a46a740 Bug 1322938 - Make the HTML tree builder aware of <dialog>. r=wchen
Original patch by :hsivonen

MozReview-Commit-ID: C8UK7m7V9tn
2016-12-22 11:30:41 +02:00
Henri Sivonen
a6fb532484 Bug 1288084 - Expose a line number for each attribute, v2; r=wchen 2016-09-20 16:31:57 +02:00
Boris Zbarsky
e7fcf1b1a1 Bug 1268852. Change <label> elements to not be form-associated anymore. r=bkelly,hsivonen,surkov
The web platform tests changes are just a cherrypick of
https://github.com/w3c/web-platform-tests/pull/2926 so I don't have to add
failure annotations until the next test uplift.

I've audited our uses of nsIFormControl, and this patch looks to me like it
preserves existing behavior in all but the following cases:

1)  nsXBLPrototypeHandler::DispatchXBLCommand, the case of scrolling when space
is pressed while something inside a <label> is focused.  We used to not scroll
in this situation; I think this is a bug, so I'm changing that behavior to
scroll instead.

2)  In Accessible::RelationByType for the RelationType::DEFAULT_BUTTON case,
when mContent is a <label> we used to return its form's default submit element.
Now we will just return Relation().
2016-05-26 19:39:03 -04:00
Henri Sivonen
b0045c2ea7 Bug 1270381. r=wchen. 2016-05-15 17:03:06 +03:00
Henri Sivonen
56eb89ec13 Bug 1246014. r=wchen. 2016-02-10 12:39:06 +02:00
Henri Sivonen
4d0b61f3f6 Bug 1176698 - Use fallible allocator for attribute values in the HTML parser. r=wchen. 2015-08-25 18:05:46 +03:00
Henri Sivonen
bee2d42d10 Bug 489820 part 2 - Grow buffers to the worst-case size before tokenizing; fix comments. r=wchen. 2015-08-25 18:05:45 +03:00
Ehsan Akhgari
032329fc94 Bug 1109311 - Fix the -Wundefined-bool-conversion warning in nsHtml5TreeBuilder.cpp resulting from checking the value of this; r=hsivonen
Clang gives the following warning for this code:

'this' pointer cannot be null in well-defined C++ code; pointer may be assumed to always convert to true
2014-12-18 10:33:28 -05:00
William Chen
fdf3148d35 Bug 1091425 - Use the correct document when creating nodes in the HTML5 parser. r=hsivonen 2014-11-09 22:50:18 -08:00
Henri Sivonen
0542ad24ae Bug 886390 part 2 - Disable foreign content breakout in the fragment case. r=wchen. 2014-10-27 11:48:11 +02:00
Henri Sivonen
142069e90f Bug 886390 part 1 - Implement behavior equivalent to the adjusted current node concept by changing the first node on the stack. r=wchen. 2014-10-27 11:48:11 +02:00
Yuki Sekiguchi
4700627e63 Bug 1042885 - Part 1: A rp element should not auto close a rtc element. r=wchen 2014-08-18 22:33:45 -07:00
William Chen
0e896528b6 Bug 1044118 - Fix inverted check for unclosed children in ruby tag. r=hsivonen 2014-08-04 15:54:20 -07:00
Yuki Sekiguchi
510ac08043 Bug 664104 - Part 1: Implement new ruby model in HTML parser. r=wchen 2014-06-20 17:08:31 -07:00
Olli Pettay
948ecb7f4b Bug 902618 - Parser notifies about subtree roots, but not their descendants, r=hsivonen,bz 2014-06-17 02:01:22 +03:00
William Chen
19e05afc59 Bug 1005580 - Fix "after after frameset" insertion mode in HTML parser for handling characters. r=hsivonen 2014-05-06 13:29:31 -07:00
William Chen
9230accbba Bug 982285 - Update active formatting element list indices in HTML parser adoption agency algorithm. r=hsivonen 2014-03-17 17:34:47 -07:00
William Chen
8131e2f748 Bug 884795 - HTML parser AAA algorithm should only pop when the current node is not in the list of active formatting elements. r=hsivonen 2014-03-07 15:48:19 -08:00
Henri Sivonen
775e097398 Bug 959150 part 5 - Avoid reallocating the attribute holder when parsing with nsHtml5StringParser. r=smaug. 2014-03-05 21:38:50 +02:00
Henri Sivonen
d07d56d994 Bug 959150 part 4 - Avoid using tree ops when parsing with nsHtml5StringParser. r=smaug. 2014-03-05 21:38:50 +02:00