corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
546,803 Commits 1 Branch 0 Tags
80b1443c29c901b4f15e3c9d39a1f86d2e6a6cc0
Commit Graph

1094 Commits

Author SHA1 Message Date
Mats Palmgren
9b444b6c41 Bug 1398482 part 2 - [css-grid][css-flexbox][css-multicol] Add 'row-gap' and 'gap' properties; make 'grid-[column|row]-gap' and 'grid-gap' alias the respective unprefixed properties (Gecko part). r=dholbert 2018-04-24 01:52:51 +02:00
Jonathan Watt
bd03a860aa Bug 1436048: Use user defined types for font-stretch / font-style. r=jfkthame,jwatt 
Co-authored-by: Emilio Cobos Álvarez <emilio@crisal.io>

MozReview-Commit-ID: 7ONYtICeAqb
 2018-04-23 18:22:05 +02:00
James Teh
66efd523ae Bug 1454572: nsComputedDOMStyle: Don't crash when used on a detached pseudo-element. r=emilio,xidorn:emilio 
This shouldn't normally happen, but it does in some rare cases; e.g. if an accessibility client queries info for a node that is being removed.

MozReview-Commit-ID: 3nac9ITN66f
 2018-04-19 15:53:25 +10:00
Xidorn Quan
36f0210ad2 Bug 1452542 part 7 - Replace some uses of nsCSSPropList.h and nsCSSPropAliasList.h with ServoCSSPropList.h. r=emilio 
MozReview-Commit-ID: 5TVYITjAYy7
 2018-04-17 16:57:04 +10:00
Andreea Pavel
09076bc3fd Backed out 7 changesets (bug 1452542) for failing toolkit/content/tests/chrome/test_arrowpanel.xul on a CLOSED TREE 
Backed out changeset f206acff283f (bug 1452542)
Backed out changeset be97e652391f (bug 1452542)
Backed out changeset 4d3a028edaed (bug 1452542)
Backed out changeset 5619bba37cdd (bug 1452542)
Backed out changeset e83a797bdc61 (bug 1452542)
Backed out changeset 255e2feff19f (bug 1452542)
Backed out changeset fac55b1a0706 (bug 1452542)
 2018-04-18 20:10:35 +03:00
Xidorn Quan
328128f3dc Bug 1452542 part 7 - Replace some uses of nsCSSPropList.h and nsCSSPropAliasList.h with ServoCSSPropList.h. r=emilio 
MozReview-Commit-ID: 5TVYITjAYy7
 2018-04-17 16:57:04 +10:00
Xidorn Quan
f0e1981a84 Bug 1454297 - Remove CSS_PROP_LOGICAL and friends. r=emilio 
MozReview-Commit-ID: Euzbjf9qkmO
 2018-04-16 16:23:33 +10:00
Jonathan Watt
9243470005 Bug 1436048 part 1 - Use a user defined type for font weight everywhere. r=jfkthame,emilio 2018-04-13 20:34:37 +01:00
Sebastian Hengst
d91e9954eb Backed out 4 changesets (bug 525063) on request from Andi. a=backout 
Backed out changeset 516c4fb1e4b8 (bug 525063)
Backed out changeset 6ff8aaef2866 (bug 525063)
Backed out changeset bf13e4103150 (bug 525063)
Backed out changeset d7d2f08e051c (bug 525063)
 2018-04-13 16:01:28 +03:00
Emilio Cobos Álvarez
05d19748d0 Bug 1453148: Let overflow parse two values. r=xidorn 
Per https://github.com/w3c/csswg-drafts/issues/2484.

MozReview-Commit-ID: D7M3PhnTtD2
 2018-04-12 14:48:55 +02:00
Tristan Bourvon
6095241db8 Bug 525063 - Initialize uninitialized class attributes in m-c. r=ehsan 2018-04-10 21:11:02 +02:00
Emilio Cobos Álvarez
65978b31f3 Bug 1452080: Remove ComputedStyle::PresContext usage from layout and canvas code. r=xidorn 
Couldn't find an easy way of splitting these up :(

MozReview-Commit-ID: 2kTZ5McREUT
 2018-04-09 11:19:49 +02:00
Noemi Erli
b15aabf388 Backed out 3 changesets (bug 1452080) for bustage in /builds/worker/workspace/build/src/layout/base/nsCSSFrameConstructor.cpp on a CLOSED TREE 
Backed out changeset 7f5104c7a242 (bug 1452080)
Backed out changeset 806a9c95a243 (bug 1452080)
Backed out changeset bffebe8aa254 (bug 1452080)
 2018-04-09 11:18:12 +03:00
Emilio Cobos Álvarez
9c4328ca42 Bug 1452080: Remove ComputedStyle::PresContext usage from layout and canvas code. r=xidorn 
Couldn't find an easy way of splitting these up :(

MozReview-Commit-ID: 2kTZ5McREUT
 2018-04-09 09:57:55 +02:00
Emilio Cobos Álvarez
3284a9dda8 Bug 1447827: Remove ServoRestyleManager. r=xidorn 
MozReview-Commit-ID: CFafQsb4rQn
 2018-04-07 15:50:06 +02:00
Emilio Cobos Álvarez
8e43075fd5 Bug 1447827: Move members from ServoRestyleManager to RestyleManager. r=xidorn 
This leaves ServoRestyleManager as just a typedef.

MozReview-Commit-ID: 5wfTkiDc2Nr
 2018-04-07 15:40:00 +02:00
Bobby Holley
2fd8051265 Bug 1451421 - Stop using Gecko namespace ids in servo. r=xidorn 
MozReview-Commit-ID: 2532dHCGPXW
 2018-04-06 15:30:58 -07:00
Emilio Cobos Álvarez
57d84033b3 Bug 1450691: Flushing the parent document can kill our shell. r=xidorn 
Bug 1443492 made us flush the parent document for cross-doc getComputedStyle
situations. That can kill the shell we're flushing, let's handle that case
gracefully.

MozReview-Commit-ID: HpFsPQvjKcZ
 2018-04-03 08:03:35 +02:00
Daniel Holbert
dc15017b37 Bug 1105111 part 2: Add support for 'flex-basis:content' in the style system (gecko / getComputedStyle side). r=mats 
MozReview-Commit-ID: E0crFCy7Jfk
 2018-04-02 04:30:37 +02:00
Xidorn Quan
ea8b8b1e74 Bug 1449400 part 5 - Remove StyleSetHandle. r=emilio 
This patch basically does:
* remove StyleSetHandle and its corresponding files
* revisit #includes of related header files and change correspondingly
* change nsIPresShell::mStyleSet to be UniquePtr<ServoStyleSet>
* change the creating path of ServoStyleSet to pass UniquePtr
* change other mentions of StyleSetHandle to ServoStyleSet*
* remove AsServo() calls on ServoStyleSet

Some unfortunate bits:
* some methods of (Servo)StyleSet only accepts ServoStyleSheet while
  many places call into the methods with StyleSheet, so there are many
  ->AsServo() added to sheets

MozReview-Commit-ID: K4zYnuhOurA
 2018-03-29 22:15:46 +11:00
Xidorn Quan
c9b96222f4 Bug 1449039 part 12 - Keep only necessary params for CSS_PROP definitions. r=emilio 
MozReview-Commit-ID: 6LG9WjXemno
 2018-03-27 09:54:20 +11:00
Emilio Cobos Álvarez
1800e02ed5 Bug 1448665: Simplify the unanimated style setup in nsComputedDOMStyle. r=xidorn 
We never create nsComputedDOMStyle objects with an unanimated computed style, so
this can be much simpler.

MozReview-Commit-ID: 2NyBoErxRtV
 2018-03-26 09:43:58 +02:00
Emilio Cobos Álvarez
eb38415ff5 Bug 1448665: Remove assertion that is no longer relevant. rs=xidorn 
We no longer have crazy bfcache invariants since bug 1414999.

MozReview-Commit-ID: LrgURv9VAuK
 2018-03-26 09:41:52 +02:00
Emilio Cobos Álvarez
b770e5be58 Bug 1448663: Remove unused field to please the static analysis and reopen the CLOSED TREE. r=me 
Pending bug 1448665 for further cleanup.

MozReview-Commit-ID: 4YHjh3t0i7a
 2018-03-25 18:46:58 +02:00
Emilio Cobos Álvarez
ff6075119a Bug 1448661: Remove unused CSS_PROPERTY_IS_ALIAS flag. r=jwatt 
MozReview-Commit-ID: 10B4pi2Zwsx
 2018-03-25 18:24:01 +02:00
Emilio Cobos Álvarez
7171faacca Bug 1448663: Remove dead code in nsComputedDOMStyle. r=jwatt 
MozReview-Commit-ID: 4KggxmlBcRK
 2018-03-25 18:21:44 +02:00
Emilio Cobos Álvarez
3875ef1eab Bug 1424963: followup: Add a missing ClearCurrentStyleSources. r=me 
Doesn't matter too much because this is ChromeOnly, but still...

MozReview-Commit-ID: 5yyFi8Uk3hk
 2018-03-25 15:11:19 +02:00
Emilio Cobos Álvarez
1d4859a89a Bug 1447483: Merge nsStyleContext and ServoStyleContext, rename to ComputedStyle. r=jwatt on a CLOSED TREE 
MozReview-Commit-ID: JPopq0LudD
 2018-03-22 20:06:24 +01:00
Emilio Cobos Álvarez
97286b35c8 Back out changeset b683bb3f22a1 (Bug 1447483) for not landing with all the files. r=me on a CLOSED TREE 
This reverts commit 1808914126bb9f9e4a82d2c3d7ac961885fe7d62.

MozReview-Commit-ID: 5skESBseEvo
 2018-03-22 20:05:22 +01:00
Emilio Cobos Álvarez
1f5d8de5cc Bug 1447483: Merge nsStyleContext and ServoStyleContext, rename to ComputedStyle. r=jwatt 
MozReview-Commit-ID: JPopq0LudD
 2018-03-22 19:48:42 +01:00
Emilio Cobos Álvarez
b1a35fbef7 Bug 1447358: Unifdef the old style system code. r=jwatt 
Summary:
This has been automatically generated using:

  http://dotat.at/prog/unifdef/

And:

find $OBJDIR -type f -name '*.h' |
while read FILE; do
  echo "$FILE"
  unifdef -m -DMOZ_STYLO -UMOZ_OLD_STYLE "$FILE";
done

find $OBJDIR -type f -name '*.cpp' |
while read FILE; do
  echo "$FILE"
  unifdef -m -DMOZ_STYLO -UMOZ_OLD_STYLE "$FILE";
done

MozReview-Commit-ID: I4NdKqbMXzJ

Reviewers: jwatt

Bug #: 1447358

Differential Revision: https://phabricator.services.mozilla.com/D779
 2018-03-21 10:20:34 +01:00
Emilio Cobos Álvarez
68ecb0e261 Bug 1443492: Flush the document, not the shell, in cross-doc getComputedStyle situations. r=dbaron 
We flushed the style of the original doc, but not layout, and thus the iframe
resize wasn't noticed, and the style flush on the child presShell wasn't
sufficient.

Do a style flush on the child document instead, so that it flushes layout on the
parent document too if needed.

MozReview-Commit-ID: 5ZhBuxpKIUg
 2018-03-16 17:23:33 +01:00
Emilio Cobos Álvarez
7cc9505019 Bug 474655: Add a deprecation warning + use counter to GetPropertyCSSValue. r=bholley 
The use counter comes built-in with the DeprecatedOperationList stuff.

MozReview-Commit-ID: 9Opag1NMp32
 2018-03-15 18:22:32 +01:00
Emilio Cobos Álvarez
67649f5b73 Bug 1424963: Add ChromeOnly CSSStyleDeclaration::GetCSSImageURLs. r=bz 
MozReview-Commit-ID: CISe5jaQbIQ
 2018-03-14 11:07:41 +01:00
Emilio Cobos Álvarez
a373cb9e9b Bug 1443483: FlushTarget doesn't really make sense. r=xidorn 
Summary:
FlushTarget wants to decide whether we should flush the parent document or all
of them. However, the only point of flushing parent documents is that media
query changes could affect the document we really want to flush.

That's completely pointless if we actually don't flush the subdocument, so just
skip doing that. This case is already checked (see the DocumentNeedsRestyle
stuff, which is also somewhat poorly named, which walks up the document chain).

Reviewers: xidorn

Bug #: 1443483

Differential Revision: https://phabricator.services.mozilla.com/D682

MozReview-Commit-ID: LiI7IrUBeqq
 2018-03-07 01:09:46 +01:00
Jonathan Kew
73e7d73f9c Bug 1435692 - patch 2 - Implement the font-optical-sizing property in the Gecko style system, to control whether optical size is automatically applied. r=jwatt 
MozReview-Commit-ID: ClcWeX6Hsvm
 2018-03-03 22:12:11 +01:00
Emilio Cobos Álvarez
b7cd1eaa62 Bug 1432490: followup: Fix mac-only bustage on a CLOSED TREE. r=me 
MozReview-Commit-ID: TNquyPQhkL
 2018-02-25 02:44:18 +01:00
Emilio Cobos Álvarez
954d76f2db Bug 1432490: Make nsComputedDOMStyle::GetStyleContext / GetStyleContextNoFlush not take a presShell. r=bz 
Everyone calls them with the shell of the current composed document, and this
allows the multi-presShell stuff to just be in UpdateCurrentStyleSources /
DoGetStyleContextNoFlush.

The only reason we need to use OwnerDoc()->GetShell() instead of the composed
doc in GetStyleContext / GetStyleContextNoFlush is Element::GetBindingURL, which
does expect to get the binding URL for stuff outside of the composed doc (and
changing that gave me a useless browser).

That's technically a behavior change on the cases that used to pass nullptr, but
I think all callers are fine with that. I could also just add a special function
for that particular case, it may be worth it.

MozReview-Commit-ID: 2XlnkgdgDCK
 2018-02-25 02:23:59 +01:00
Xidorn Quan
689bf7cc2c Bug 1440141 part 3 - Avoid invoking GetAsGecko when old style system is disabled. r=emilio 
MozReview-Commit-ID: CisRhBr83jc
 2018-02-22 11:53:07 +11:00
Emilio Cobos Álvarez
8fef759837 Bug 1435939: Make media feature changes always async. r=bz 
Much in the spirit of bug 1434474.

We right now call MediaFeatureChanges sync or async pretty randomly. This has
caused bugs in the past like bug 1413143.

Unify media feature changes, and only post them async, and flush them from
FlushPendingNotifications.

This also fixes a pre-existing problem where style wasn't flushed correctly from
getComputedStyle when there were pending media feature values.

MozReview-Commit-ID: H9S1M8fk5H4
 2018-02-07 15:27:30 +01:00
Daniel Holbert
c4db7f7cb2 Bug 1434658: Simplify getComputedStyle behavior for "min-{width,height}:auto" to *always* return "auto" for flex/grid items, per CSSWG resolution. r=bradwerth 
This change is in response to this CSSWG resolution:
"RESOLVED: compute min-width/min-height: auto to auto"
https://github.com/w3c/csswg-drafts/issues/2230#issuecomment-362009042
...which was later clarified as only being applicable to grid/flex items (in
both axes). Other layout modes may get further min-width/min-height
clarification, but for now we'll leave that behavior the same (returning 0 from
getComputedStyle).

MozReview-Commit-ID: 2wLYDAOj9I6
 2018-01-31 13:45:11 -05:00
Cameron McCormack
34288f7f48 Bug 1430014 - Part 5: Stop building old style system classes when MOZ_OLD_STYLE is not defined. r=xidorn 
MozReview-Commit-ID: CIHyPdF7Exl
 2018-02-01 15:04:04 +11:00
Cameron McCormack
02c617875f Bug 1430014 - Part 4: #ifdef out unnecessary code when the old style system is not built. r=xidorn 
MozReview-Commit-ID: 1FZ9VzjcPzN
 2018-02-01 15:04:04 +11:00
cku
29abd5148e Bug 1207734 - Part 5. Implement the getComputedStyle API for individual transform. r=birtles 
MozReview-Commit-ID: 3w1kA6VCXsg
(grafted from ee81993c07a30fe5b8788d2ce6707967eb0a832a)
 2017-12-19 14:33:09 +08:00
Boris Zbarsky
276fce3bc4 Bug 1428610 part 7. Make the nsICSSDeclaration length API nicer. r=emilio 
MozReview-Commit-ID: 2gs8npBJFJY
 2018-01-30 14:48:27 -05:00
Boris Zbarsky
0ba88b2885 Bug 1428610 part 6. Give nsICSSDeclaration::GetPropertyPriority a nicer signature. r=emilio 
MozReview-Commit-ID: 4H2zADwdo5L
 2018-01-30 14:48:27 -05:00
Boris Zbarsky
7a1455b2cc Bug 1428610 part 5. Make nsICSSDeclaration::Get/SetCSSText have nicer signatures. r=emilio 
MozReview-Commit-ID: B25qvxKj9CW
 2018-01-30 14:48:26 -05:00
Boris Zbarsky
369b32cdf4 Bug 1428610 part 4. Move the nsCSSPropertyID overload of nsICSSDeclaration::SetPropertyValue to nsDOMCSSDeclaration. r=emilio 
MozReview-Commit-ID: 8BzCHahJjwv
 2018-01-30 14:48:26 -05:00
Boris Zbarsky
d07e03543e Bug 1428610 part 3. Move the nsCSSPropertyID overload of nsICSSDeclaration::GetPropertyValue down to nsDOMCSSDeclaration. r=emilio 
MozReview-Commit-ID: FHrkptqa2hZ
 2018-01-30 14:48:26 -05:00
Hiroyuki Ikezoe
a177b1a3e2 Bug 1433846 - Drop nsComputedDOMStyle::GetPresShellForContent(), use nsContentUtils::GetPresShellForContent(). r=xidorn 
MozReview-Commit-ID: JcpEpqP32Yi
 2018-01-29 14:19:25 +09:00