Commit Graph

2 Commits

Author SHA1 Message Date
Kyle Huey
a14a729d99 Bug 1274431: Fix some non-unified build issues. r=jld 2016-08-05 12:00:19 -07:00
Andrew McCreight
ae5629210d Bug 1268130, part 1 - Reimplement ByteLengthIsValid using CheckedInt. r=froydnj
The first check in ByteLengthIsValid() says "nsTArray only handles
sizes up to INT32_MAX", but the actual requirement is that the
capacity is no larger than UINT32_MAX. The check is overly restrictive
if sizeof(E) is 1 byte, and overly permissive if sizeof(E) is greater
than 2 bytes. I removed this check. Internal nsTArray invariants
should be enforced by nsTArray methods.

The second check is trying to check for overflow, but that should just
be done using CheckedInt.
2016-04-28 10:00:46 -07:00