Commit Graph

28 Commits

Author SHA1 Message Date
Emilio Cobos Álvarez
4b8b5e1717 Bug 1465585: Switch from mozilla::Move to std::move. r=froydnj
This was done automatically replacing:

  s/mozilla::Move/std::move/
  s/ Move(/ std::move(/
  s/(Move(/(std::move(/

Removing the 'using mozilla::Move;' lines.

And then with a few manual fixups, see the bug for the split series..

MozReview-Commit-ID: Jxze3adipUh
2018-06-01 10:45:27 +02:00
Nathan Froyd
1aad33a3a3 Bug 1451363 - part 5 - remove ProtocolName virtual function; r=mccr8
ProtocolName() is only used for producing error messages and annotating
crash reports.  But examining actual crash reports that would have used
the result of ProtocolName() indicates that we can always tell what the
erroring protocol is due to the stack backtrace.  So having this virtual
function around just provides duplicate information, and it takes up too
much space in the vtable besides.  Let's get rid of it.
2018-04-23 14:13:36 -04:00
Jed Davis
920463dbd0 Bug 1278361 - Step 2: Search-and-replace HANDLE_EINTR(close(...)) to use IGNORE_EINTR. r=froydnj
I've also manually verified that no other references to HANDLE_EINTR are
wrapping a close() in any less syntactically obvious way.

MozReview-Commit-ID: 3KkBwFIhEIq
2018-04-10 14:36:00 -06:00
Nika Layzell
65efb2775e Bug 1440511 - Part 4: Add an IPDLParamTraits implementation for FileDescriptor, r=froydnj
MozReview-Commit-ID: R1CiT5IvAi
2018-03-05 16:00:02 -05:00
Xidorn Quan
5ab193be56 Bug 1264566 followup - Fix build on VS2015u3.
MozReview-Commit-ID: Bi58Q1NCQD
2016-07-26 09:45:44 +10:00
Wei-Cheng Pan
ef8b9aa141 Bug 1264566 - Part 1: Refactor FileDescriptor to fix leaks in content processes. r=valentin, r=baku
Now FileDescriptor takes the ownership of the platform handle, in both parent
and content processes.
Copying will duplicate the underlying handle.
It also comes with a move constructor to avoid duplicating if possible.

The getter will duplicate a new handle, so a UniquePtr is needed to hold the
duplicated handle.

MozReview-Commit-ID: DgvjmTI4tpf
2016-05-27 15:58:51 +08:00
Andrew McCreight
0514236009 Bug 1276318, part 2 - Fix mode lines in ipc/glue. r=billm
MessageChannel.{h,cpp}, MessageLink.{h,cpp}, and ProtocolUtils.h are
using 4-space indent so I left those alone.
2016-05-27 14:54:31 -07:00
Jonathan Watt
70d50b8222 Bug 1253094, part 3 - Stop using DebugOnly for class/struct members in ipc/. r=billm
MozReview-Commit-ID: L16CD7xtn3V
2016-02-26 15:52:07 +00:00
Bob Owen
7517f0b07d Bug 1119878 Part 2: Change IPC code to hold ProcessID instead of ProcessHandle. r=billm, r=dvander, r=aklotz, r=cpearce 2015-04-01 09:40:35 +01:00
Shian-Yow Wu
8106d25cf8 Bug 1054598 - Don't assert when invalid file descriptor received. r=jduell 2014-09-19 15:29:36 +08:00
Justin Lebar
8cc88f21ce Bug 820686 - Remove code after MOZ_CRASH or MOZ_ASSUME_NOT_REACHED. r=(see below)
r=tbsaunde for accessible
r=jmuizelaar for gfx
r=waldo for js
r=roc for layout
r=glandium for mozglue
r=jduell for netwerk
r=khuey for everything else
2013-06-28 18:38:32 -07:00
Justin Lebar
de89040a2c Bug 802686 - s/MOZ_NOT_REACHED/MOZ_CRASH/ in Gecko. r=(see below)
r=tbsaunde for accessible
r=jmuizelaar for gfx
r=roc for layout
r=glandium for mozglue
r=jduell for netwerk
r=khuey for everything else

This is a mechanical change made with sed.  Later patches in this queue
clean up the whitespace errors and so on.
2013-06-28 18:38:30 -07:00
Ben Turner
e664859686 Bug 835698 - 'Pre-open() and send the fd for app process's application.zip'. r=jduell. 2013-02-15 14:27:21 -08:00
Ryan VanderMeulen
73f8cae197 Backed out changeset 1646e649878a (bug 835698) for causing bug 839256. 2013-02-11 17:38:41 -05:00
Ben Turner
ea4a75e9f9 Bug 835698 - 'Pre-open() and send the fd for app process's application.zip'. r=jduell. 2013-02-09 17:59:47 +00:00
Ed Morley
5065a27017 Backout 1646e649878a (bug 835698) on suspicion of causing mochitest-1 shutdown hangs on Windows on a rather sad looking CLOSED TREE 2013-02-11 15:41:36 +00:00
Ben Turner
58c235a90d Bug 835698 - 'Pre-open() and send the fd for app process's application.zip'. r=jduell. 2013-02-09 17:59:47 +00:00
Jason Duell
be2da8b4b4 Backed out changeset 1a2e34c9ebc7 (bug 835698) a=bustage_from_bug_839688 2013-02-08 17:18:28 -08:00
Ben Turner
4901b77ef3 Bug 835698 - 'Pre-open() and send the fd for app process's application.zip'. r=jduell. 2013-02-01 04:23:23 -08:00
Phil Ringnalda
c5e7f99c13 Back out 4b47185f48f8 (bug 835698) for Win debug crashes in test_jarchannel_e10s.js 2013-02-06 22:23:33 -08:00
ben turner
22546ef9f6 Bug 835698 - Pre-open() and send the fd for app process's application.zip r=jduell 2013-02-06 05:18:00 -08:00
Ben Turner
0586cfdfbc Bug 831307 - Allow invalid file handles to not crash child processes. r=cjones. 2013-01-24 17:10:39 -08:00
Ben Turner
1f134a97be Bug 827749 - Aggressively duplicate file handles. r=cjones. 2013-01-10 19:15:57 +01:00
Jared Wein
0570f6bb7a Backed out changeset 3aa492e39918 (bug 827749) for failing all tests OS X. 2013-01-10 14:15:25 -05:00
Ben Turner
577842f36d Bug 827749 - Aggressively duplicate file handles. r=cjones. 2013-01-10 19:15:57 +01:00
Ben Turner
adbb76795e Backout f3b6bc4b2590 (Bug 827749) for test failures. 2013-01-10 13:54:27 +01:00
Ben Turner
6ee27315d6 Bug 827749 - Aggressively duplicate file descriptors. r=cjones. 2013-01-10 13:00:17 +01:00
Ben Turner
c8df603ac2 Bug 781256 - 'Share FileDescriptors across processes in preparation for OS-level sandbox'. r=khuey+cjones. 2012-08-16 00:02:32 -04:00