Commit Graph

103 Commits

Author SHA1 Message Date
Andrea Marchesini
50c7591366 Bug 1455256 - Port more components to WorkerRef - part 1 - WorkerProxyToMainThreadRunnable, r=asuth 2018-06-18 16:37:21 -04:00
Emilio Cobos Álvarez
4b8b5e1717 Bug 1465585: Switch from mozilla::Move to std::move. r=froydnj
This was done automatically replacing:

  s/mozilla::Move/std::move/
  s/ Move(/ std::move(/
  s/(Move(/(std::move(/

Removing the 'using mozilla::Move;' lines.

And then with a few manual fixups, see the bug for the split series..

MozReview-Commit-ID: Jxze3adipUh
2018-06-01 10:45:27 +02:00
Jan de Mooij
e5f8a28c84 Bug 1461292 part 1 - Rename JSAutoCompartment to JSAutoRealm. r=bz,luke 2018-05-16 10:53:16 +02:00
Boris Zbarsky
be90e72263 Bug 1436902 part 3. Replace usage of NS_IMPL_ISUPPORTS_INHERITED0 with NS_INLINE_DECL_REFCOUNTING_INHERITED when possible. r=mccr8
The change to RootAccessible.cpp fixes an obvious bug introduced in bug 741707.

The visibility changes in gfx/thebes are because NS_DECL_ISUPPORTS has a
trailing "public:" that those classes were relying on to have public
constructors.

MozReview-Commit-ID: IeB8KIJCGhU
2018-02-12 15:44:40 -05:00
Andrea Marchesini
b00c0daf83 Bug 1436744 - Get rid of WorkerCheckAPIExposureOnMainThreadRunnable, r=catalinb 2018-02-12 21:02:22 +01:00
Andrea Marchesini
541e55482b Bug 1435196 - Move the webidl binding interfaces out of WorkerPrivate - part 1 - WebIDL bindings, r=bkelly 2018-02-08 08:26:05 +01:00
Andrea Marchesini
ddb4518ad1 Bug 1435174 - Remove the renaming 'using namespace workers', r=bkelly 2018-02-05 19:55:07 +01:00
Andrea Marchesini
5e357eed9f Bug 1432963 - Fixing workers headers - part 14 - WorkerPrivate without workers namespace, r=smaug 2018-01-31 08:24:08 +01:00
Andrea Marchesini
30cbccd56d Bug 1432963 - Fixing workers headers - part 13 - WorkerHolder without workers namespace, r=smaug 2018-01-31 08:23:44 +01:00
Andrea Marchesini
fac6814ce2 Bug 1432963 - Fixing workers headers - part 12 - WorkerRunnable without workers namespace, r=smaug 2018-01-31 08:22:56 +01:00
Andrea Marchesini
298aa0608e Bug 1413112 - Fixing includes in dom/workers, r=bkelly 2018-01-30 10:14:00 +01:00
Andrea Marchesini
de5ddecee3 Bug 1405290 - Improve logging of workers when shutting down - part 3 - WorkerHolder with names, r=asuth 2017-11-15 07:58:38 +01:00
Nika Layzell
d8c117bc28 Bug 1414974 - Part 2: Switch many consumers to nsGlobalWindow{Inner,Outer}, r=smaug
This is a large patch which tries to switch many of the external consumers of
nsGlobalWindow to instead use the new Inner or Outer variants.

MozReview-Commit-ID: 99648Lm46T5
2017-11-09 10:44:47 -05:00
Bill McCloskey
ce42826bdf Bug 1372405 - Provide names for all runnables in the tree (r=froydnj)
MozReview-Commit-ID: DKR6ROiHRS7
2017-06-26 14:19:58 -07:00
Carsten "Tomcat" Book
238bf154d5 Backed out changeset 4f6302a98ae4 (bug 1372405) 2017-06-21 13:59:26 +02:00
Bill McCloskey
67e8af4720 Bug 1372405 - Provide names for all runnables in the tree (r=froydnj)
MozReview-Commit-ID: DKR6ROiHRS7
2017-06-20 21:44:11 -07:00
Carsten "Tomcat" Book
bbe9441993 Backed out changeset 9846de3bd954 (bug 1372405) 2017-06-20 08:27:02 +02:00
Bill McCloskey
f69608368b Bug 1372405 - Provide names for all runnables in the tree (r=froydnj)
MozReview-Commit-ID: DKR6ROiHRS7
2017-06-19 22:25:47 -07:00
Andrea Marchesini
b9ce1f599d Bug 1368296 - Renaming WorkerProxyToMainThreadRunnable::RunBackOnWorkerThread to RunBackOnWorkerThreadForCleanup and improving the description for this method, r=asuth 2017-06-02 11:05:27 +02:00
Michael Layzell
54b0828512 Bug 1331434 - Part 7: Handle custom cleanup after throwing in /dom/workers, r=baku
MozReview-Commit-ID: 1hKUDi9Oxg7
2017-03-07 19:06:48 -05:00
Andrea Marchesini
28f084ecf0 Bug 604026 - Sync event loops in workers should be created only if compatible with the worker shutdown status, r=bkelly 2017-01-05 10:05:32 +01:00
Ben Kelly
f25fef2adc Bug 1300659 P4 Use ThrottledEventQueue in workers. r=baku 2016-11-07 12:30:17 -08:00
Andrea Marchesini
b5f3c5afcc Bug 1272066 - Add telemetry for sync worker runnables, r=bkelly 2016-10-25 15:39:30 +02:00
Ben Kelly
abba503aab Bug 1300658 P2 Make WorkerRunnable's destined for main thread use the MainThreadTaskQueue. r=baku 2016-09-13 20:14:02 -07:00
Wes Kocher
e70a727506 Backed out 6 changesets (bug 1300658) for frequent Windows VM Xpcshell failures a=backout
Backed out changeset 6cf3a60640cf (bug 1300658)
Backed out changeset c74062a27462 (bug 1300658)
Backed out changeset 39fbc61739ef (bug 1300658)
Backed out changeset 0b9d70b040a2 (bug 1300658)
Backed out changeset 4e921d61f036 (bug 1300658)
Backed out changeset 56496fad6494 (bug 1300658)
2016-09-12 16:34:08 -07:00
Ben Kelly
6988197a88 Bug 1300658 P2 Make WorkerRunnable's destined for main thread use the MainThreadTaskQueue. r=baku 2016-09-12 12:32:21 -07:00
Ben Kelly
449d185850 Backout rev 5c7368370ff9 to 980659720b86 (bug 1300118 and bug 1300658) for incorrect bug number in commit message. r=me 2016-09-12 12:29:17 -07:00
Ben Kelly
28c3944fe8 Bug 1300658 P2 Make WorkerRunnable's destined for main thread use the MainThreadTaskQueue. r=baku 2016-09-12 11:21:01 -07:00
Nicholas Nethercote
b5810a1eb4 Bug 1299384 - Use MOZ_MUST_USE with NS_warn_if_impl(). r=erahm.
This change avoids lots of false positives for Coverity's CHECKED_RETURN
warning, caused by NS_WARN_IF's current use in both statement-style and
expression-style.

In the case where the code within the NS_WARN_IF has side-effects, I made the
following change.

> NS_WARN_IF(NS_FAILED(FunctionWithSideEffects()));
> -->
> Unused << NS_WARN_IF(NS_FAILED(FunctionWithSideEffects()));

In the case where the code within the NS_WARN_IF lacks side-effects, I made the
following change.

> NS_WARN_IF(!condWithoutSideEffects);
> -->
> NS_WARNING_ASSERTION(condWithoutSideEffects, "msg");

This has two improvements.
- The condition is not evaluated in non-debug builds.
- The sense of the condition is inverted to the familiar "this condition should
  be true" sense used in assertions.

A common variation on the side-effect-free case is the following.

> nsresult rv = Fn();
> NS_WARN_IF_(NS_FAILED(rv));
> -->
> DebugOnly<nsresult rv> = Fn();
> NS_WARNING_ASSERTION(NS_SUCCEEDED(rv), "Fn failed");
2016-09-02 17:12:24 +10:00
Andrea Marchesini
7cef8da2ac Bug 1300655 - part 2 - WorkerProxyToMainThreadRunnable::PostDispatchOnMainThread::ReleaseRunnable should implement Cancel() correctly, r=me 2016-09-06 04:48:11 +02:00
Andrea Marchesini
d25ee7c3ca Bug 1300655 - WorkerProxyToMainThreadRunnable::PostDispatchOnMainThread::ReleaseRunnable should implement Cancel() correctly, r=bkelly 2016-09-06 04:35:49 +02:00
Nicholas Nethercote
887efe04d5 Bug 1299727 - Rename NS_WARN_IF_FALSE as NS_WARNING_ASSERTION. r=erahm.
The new name makes the sense of the condition much clearer. E.g. compare:

  NS_WARN_IF_FALSE(!rv.Failed());

with:

  NS_WARNING_ASSERTION(!rv.Failed());

The new name also makes it clearer that it only has effect in debug builds,
because that's standard for assertions.
2016-09-01 15:01:16 +10:00
Ben Kelly
bee31710b3 Bug 1293690 P2 Set explicit status levels to fail at when calling WorkerHolder::HoldWorker. r=baku 2016-08-18 07:11:04 -07:00
Andrea Marchesini
066cfe31e7 Bug 1286487 - WorkerProxyToMainThreadRunnable must keep alive workers using WorkerHolder, r=bkelly 2016-07-23 08:31:31 +02:00
Andrea Marchesini
fb620c74fb Bug 1288033 - Decease the busyCount when Cancel() is called in WorkerRunnable, r=khuey 2016-07-21 19:18:51 +02:00
Carsten "Tomcat" Book
933492f8f7 Backed out changeset 512f176d3de6 (bug 1288033) to fix a incomplete backout 2016-07-21 12:36:38 +02:00
Iris Hsiao
1e8ca9319d Backed out changeset 90c6741cda5d (bug 1288033) for web platform e10s failure 2016-07-21 17:52:56 +08:00
Andrea Marchesini
5fea95cd5e Bug 1288033 - part 2 - fixed a compilation error, r=me 2016-07-21 09:56:11 +02:00
Andrea Marchesini
514ee95365 Bug 1288033 - Decease the busyCount when Cancel() is called in WorkerRunnable, r=khuey 2016-07-21 09:17:41 +02:00
Andrea Marchesini
dba355cdc0 Bug 1286615 - Wrong use of ModifyBusyCountFromWorker in WorkerProxyToMainThreadRunnable, r=khuey 2016-07-18 09:17:21 +02:00
Boris Zbarsky
c3889c8b5d Bug 1279313 part 1. Simplify AutoEntryScript to not make callers pass in a JSContext. r=bholley 2016-07-07 20:08:25 -04:00
Andrea Marchesini
dc222eaba0 Bug 1282366 - Improve WorkerHolder use in Runnables, r=khuey 2016-07-04 08:19:10 +02:00
Andrea Marchesini
30d0a3f864 Bug 1269162 - part 3 - Move XHR code into dom/xhr, r=smaug 2016-06-27 19:13:40 +02:00
Andrea Marchesini
4fd580b703 Bug 1277226 - Implement MainThreadWorkerRunnable, r=sicking 2016-06-08 07:12:05 +02:00
Kyle Huey
3f438c5fd6 Bug 1272066: Slap the compiler. r=khuey 2016-05-11 11:46:36 -07:00
Wes Kocher
3f5484664a Bug 1272066 - Try to stop assertions until a better fix can land rs=khuey 2016-05-11 11:37:59 -07:00
Andrea Marchesini
bb2e171b55 Bug 1268253 - MainThreadStopSyncLoopRunnable doesn't need to be exposed, r=khuey 2016-05-11 08:05:38 +02:00
Andrea Marchesini
194c33b0e8 Bug 1268252 - XHR doesn't need to use MainThreadStopSyncLoopRunnable, r=khuey 2016-05-11 08:05:08 +02:00
Andrea Marchesini
75b2d468d5 Bug 1268231 - Get rid of StopSyncLoopRunnable, r=khuey 2016-05-03 10:21:59 +02:00
Andrea Marchesini
fddf33c51f Bug 1267904 - Add telemetry for WorkerMainThreadRunnable, r=khuey 2016-05-03 09:09:47 +02:00