Commit Graph

103 Commits

Author SHA1 Message Date
Chris Peterson
861db3cb02 Bug 645325 - Part 4: Handle null listener when xhr callbacks are called after WifiGeoPositionProvider shutdown. r=garvank r=jdm
I hit this error when testing geolocation with Wi-Fi disabled. There is a race where the WifiGeoPositionProvider gets shut down (settting this.listener to null) but the xhr request is still alive (and the xhr callback later hits the null this.listener).

MozReview-Commit-ID: E3jCFM3om5A
2018-03-09 22:20:50 -08:00
Chris Peterson
9cb384d935 Bug 645325 - Part 1: Use NaN to indicate unset optional coordinate values returned from the location providers. r=garvank r=jdm
nsGeoPositionCoords will convert NaNs returned from the location providers to null properties of the JavaScript Coordinates object.

MozReview-Commit-ID: Cmuf2aO0ClD
2018-02-25 23:35:16 -08:00
Kris Maglione
0847e8227e Bug 1464548: Part 3 - Update callers to use defineLazyGlobalGetters. r=mccr8
MozReview-Commit-ID: 9APGewiDDYB
2018-05-25 17:02:29 -07:00
Boris Zbarsky
52b398714f Bug 1466213 part 2. Remove nsIDOMGeoPositionError. r=qdot 2018-06-01 22:35:44 -04:00
Kris Maglione
fd7e9e6a69 Bug 1456035: Part 4 - Convert callers of XPCOMUtils.generateQI to ChromeUtils.generateQI. r=mccr8
This also removes any redundant Ci.nsISupports elements in the interface
lists.

This was done using the following script:

acecb401b7/processors/chromeutils-generateQI.jsm

MozReview-Commit-ID: AIx10P8GpZY
2018-04-22 20:55:06 -07:00
Thomas Wisniewski
ffef18db3e Bug 792808 - Change dom/system to import and instantiate XHRs from global properties rather than using Cc.createInstance(Ci.nsIXMLHttpRequest); r=bz,jdm
MozReview-Commit-ID: AhiiiVUoGSW
2017-09-19 11:47:37 -04:00
Andrew McCreight
272cee1e65 Bug 1432992, part 1 - Remove definitions of Ci, Cr, Cc, and Cu. r=florian
This patch was autogenerated by my decomponents.py

It covers almost every file with the extension js, jsm, html, py,
xhtml, or xul.

It removes blank lines after removed lines, when the removed lines are
preceded by either blank lines or the start of a new block. The "start
of a new block" is defined fairly hackily: either the line starts with
//, ends with */, ends with {, <![CDATA[, """ or '''. The first two
cover comments, the third one covers JS, the fourth covers JS embedded
in XUL, and the final two cover JS embedded in Python. This also
applies if the removed line was the first line of the file.

It covers the pattern matching cases like "var {classes: Cc,
interfaces: Ci, utils: Cu, results: Cr} = Components;". It'll remove
the entire thing if they are all either Ci, Cr, Cc or Cu, or it will
remove the appropriate ones and leave the residue behind. If there's
only one behind, then it will turn it into a normal, non-pattern
matching variable definition. (For instance, "const { classes: Cc,
Constructor: CC, interfaces: Ci, utils: Cu } = Components" becomes
"const CC = Components.Constructor".)

MozReview-Commit-ID: DeSHcClQ7cG
2018-02-06 09:36:57 -08:00
Kris Maglione
0bb74efdf1 Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm

MozReview-Commit-ID: 1Nc3XDu0wGl
2018-01-29 15:20:18 -08:00
Cosmin Sabou
f09d6d985d Backed out 3 changesets (bug 1431533) for Android mochitest failures on testEventDispatcher on a CLOSED TREE
Backed out changeset a1eca62826a1 (bug 1431533)
Backed out changeset 34c999fa006b (bug 1431533)
Backed out changeset e2674287e57f (bug 1431533)
2018-01-30 07:17:48 +02:00
Kris Maglione
fd67f090b2 Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm

MozReview-Commit-ID: 1Nc3XDu0wGl
2018-01-29 15:20:18 -08:00
Brindusan Cristian
483ba301cb Backed out 2 changesets (bug 1431533) for ESlint failures on a CLOSED TREE
Backed out changeset 6e56f4c8843e (bug 1431533)
Backed out changeset 12fc4dee861c (bug 1431533)
2018-01-30 02:32:43 +02:00
Kris Maglione
683a97d172 Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm

MozReview-Commit-ID: 1Nc3XDu0wGl
2018-01-29 15:20:18 -08:00
Garvan Keeley
fef6f32eb4 Bug 1363966 - Cleanup network geo provider: removed unneeded listener function wrapper and the call to non-existent listener.locationUpdatePending(). r=jdm 2017-05-24 07:22:00 -04:00
Florian Queze
6cc0b6e992 Bug 1355056 - replace (function(args) { /* do stuff using this */ }).bind(this) with arrow functions, r=jaws. 2017-04-27 00:25:45 +02:00
Michelangelo De Simone
911ccf575d Bug 1313155 - Remove dom/settings and related code. r=Ehsan
MozReview-Commit-ID: Gi7frPFQ6yW
2016-12-29 11:26:49 -08:00
Wes Kocher
fe80c35444 Backed out changeset 5566e83980ed (bug 1313155) for mass build bustage a=backout CLOSED TREE
MozReview-Commit-ID: Co3f2Vkbf4y
2017-01-12 14:16:52 -08:00
Michelangelo De Simone
acc2491ef3 Bug 1313155 - Remove dom/settings and related code. r=Ehsan
MozReview-Commit-ID: Gi7frPFQ6yW
2016-12-29 11:26:49 -08:00
Michelangelo De Simone
7afbfd107d Bug 1310864 - Remove DOM/(contacts, mobileconnection, icc) and related code. r=jst
MozReview-Commit-ID: Az4PTYFUKW8
2016-11-03 13:55:36 -07:00
Phil Ringnalda
4ef1e5747b Backed out changeset 27695ca9f8cd (bug 1310864) for failures in test_navigator_resolve_identity.html, test_bug707564.html, and test_dom_xrays.html 2016-10-31 19:39:06 -07:00
Michelangelo De Simone
3f59b09ce2 Bug 1310864 - Remove DOM/(contacts, mobileconnection, icc) and related code. r=jst
MozReview-Commit-ID: 2tWZc6hMtk5
2016-10-28 17:53:58 -07:00
Thomas Wisniewski
a1a4c002e4 Bug 918751 - Throw NetworkErrors instead of failures where appropriate for some XHR web platform tests. r=bz, r=keeler, r=Mossop, r=paul 2016-09-03 18:45:08 -04:00
Victor Ng
59527b662f Bug 1247410 - "test for _nomap ids does not work correctly". r=dougt 2016-02-11 06:23:00 +01:00
Shu-yu Guo
37989840cd Bug 1202902 - Mass replace toplevel 'let' with 'var' in preparation for global lexical scope. (rs=jorendorff) 2015-09-15 11:19:45 -07:00
Aidin Gharibnavaz
7042af13ab Bug 1177871 - Add a timeout to XHR request of WifiGeoPositionProvider. r=jdm 2015-08-02 08:45:00 -04:00
Ryan VanderMeulen
fc27bb5aff Backed out changeset 8010e0cbd228 (bug 1177871) for Windows debug test_geolocation_provider_timeout.js crashes.
CLOSED TREE
2015-07-31 15:00:12 -04:00
Aidin Gharibnavaz
a7a0c12fc9 Bug 1177871 - Timeout added to XHR request of WifiGeoPositionProvider. r=jdm
CLOSED TREE
2015-07-30 07:01:00 -04:00
"Anup Allamsetty"
ffd6e0b594 Bug 1035097 - Changed the type from 'radio' to 'radioType'. r=jdm 2015-07-21 06:43:00 -04:00
Bill McCloskey
5a327da4cf Bug 1145394 - Remove exec bit on js files (r=fabrice,gavin) 2015-03-20 11:57:38 -07:00
Chris Peterson
6724ee6be2 Bug 1121864 - Fix some minor nits in NetworkGeolocationProvider.js. r=garvank 2015-01-14 20:28:27 -08:00
Pierre Rudloff
54691f01a2 Bug 1021357 - NetworkGeolocationProvider.js: if <2 wifi APs, don't send wifi in JSON request. r=garvank 2014-12-17 13:44:00 -05:00
Alexandre Lissy
be178f6856 Bug 1075405 - Use numItems to iterate mobile connection providers. r=echen
Using .length attribute does not work anymore, probably after bug
1063304 landed. The GonkVoicemail code makes a similar use of the
MobileConnectionService and uses numItems to iterate over the providers.
2014-10-01 07:07:00 -04:00
Alexandre Lissy
bce3551352 Bug 1010284 - Add radio tech mapping for MLS. r=garvank, sr=hannosch
Having this mapping is needed in order to properly identify the radio
technology family being used by the connected network.
2014-09-30 07:11:00 -04:00
Mike Habicher
82109af909 Bug 1053966 - move mozsettings-changed Observer info from aSubject to aData, r=bz,qDot 2014-09-16 13:15:16 -04:00
Vicamo Yang
8371bf0470 Bug 1063304 - 3.c/3: accommodate other components. r=echen 2014-09-21 15:24:43 +08:00
Carsten "Tomcat" Book
7e90b88b7a Backed out changeset 9ff2889f236a (bug 1063304) 2014-09-17 13:13:08 +02:00
Ryan VanderMeulen
1ce4cc0915 Backed out changeset ed586ca080c0 (bug 1053966) for the same Mnw permafails it was backed out for previously. 2014-09-16 16:54:25 -04:00
Mike Habicher
8c5339cc7a Bug 1053966 - move mozsettings-changed Observer info from aSubject to aData, r=bz,qDot 2014-09-16 13:15:16 -04:00
Vicamo Yang
e8097c2286 Bug 1063304 - 3.c/3: accommodate other components. r=echen 2014-09-16 21:20:18 +08:00
Garvan Keeley
700d8ed75b Bug 1064266 - Use mcc and mnc from network, not from radio (ie SIM). r=kanru 2014-09-09 12:35:00 -04:00
Ryan VanderMeulen
98038e791e Backed out changeset 661f503ea524 (bug 1053966) for Mnw perma-fail. 2014-09-10 12:36:12 -04:00
Mike Habicher
08451f04cd Bug 1053966 - pass settings change notices to Observers as aSubject instead of aData, r=bz,qdot 2014-08-25 18:06:31 -04:00
Edgar Chen
463c524654 Bug 843452 - Part 4-7: [NetworkGeolocationProvider] Get dataInfo via MobileConnectionService. r=kchen 2014-08-11 16:15:59 +08:00
Ghislain 'Aus' Lacroix
eadc2f8af8 bug 1046876 - Define 'Cu'. r=gwagner 2014-07-31 13:29:14 -07:00
Doug Turner
59065313af Bug 1030542 - remove logging that includes api keys. r=garvank 2014-06-25 19:23:48 -07:00
Ghislain 'Aus' Lacroix
0a851725d6 bug 1034301 - Guard against bad listener behavior. r=kanru 2014-07-17 05:35:33 -07:00
Ghislain 'Aus' Lacroix
e4f3edcd15 Backed out changeset 3c7cff7fc71d 2014-07-17 05:34:33 -07:00
Ghislain 'Aus' Lacroix
08dbfddaa6 bug 1034301 - Guard against bad listener behavior. r=kanru 2014-07-17 05:26:25 -07:00
Garvan Keeley
3f48036ba1 Bug 1036110 - Stop the B2G UI setting from overriding the js prefs setting and turning off logging. r=dougt
If gLoggingEnabled is already on during startup, that means it was set in js prefs.
2014-07-09 09:14:00 -04:00
Garvan Keeley
065865d676 Bug 1018383 - Added request-level caching in NetworkGeolocationProvider.js. r=jdm
This is a cleanup of the patch used in the Tarako bug. I made it clearer that this is request-level caching, NOT position caching.
 This is specifically for preventing unnecessary requests to the server. It is unrelated to the W3C PositionOptions and their effect on position caching.
 Hopefully this detail is clearer in this patch.

Updated mochitests that were relying on old logic to succeed

The failing mochitests were relying on the provider to have a specific behaviour -behaviours that are incidental to the test case. I updated these to reflect the behaviour of the current system.
2014-07-07 07:16:00 +02:00
Garvan Keeley
525992e7b0 Bug 1010278 - Check if the type is gsm-ish or wcdma-ish and assign to either one of those categories. r=dougt 2014-06-19 14:45:00 -04:00