corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
546,803 Commits 1 Branch 0 Tags
80b1443c29c901b4f15e3c9d39a1f86d2e6a6cc0
Commit Graph

15 Commits

Author SHA1 Message Date
Benjamin Smedberg
6313586298 Bug 1338172 part E - make all the PPluginWidget stuff Windows-only. Rip out the GTK-specific native widget support from widget/gtk/nsWindow and elsewhere, r=jimm 
MozReview-Commit-ID: J6E8sYcyX4U
 2017-02-09 11:53:50 -05:00
Wes Kocher
48fcd00012 Backed out 5 changesets (bug 1338172) for linux crashtest failures a=backout 
Backed out changeset 9ee6c6f4e59c (bug 1338172)
Backed out changeset 1c92fbfca20a (bug 1338172)
Backed out changeset 907d9c3d1043 (bug 1338172)
Backed out changeset e4994ab9d628 (bug 1338172)
Backed out changeset 6209f07e1f26 (bug 1338172)

MozReview-Commit-ID: 3f4xBRcGPqM
 2017-02-14 14:31:54 -08:00
Benjamin Smedberg
a46c9d69c4 Bug 1338172 part E - make all the PPluginWidget stuff Windows-only. Rip out the GTK-specific native widget support from widget/gtk/nsWindow and elsewhere, r=jimm 
MozReview-Commit-ID: J6E8sYcyX4U
 2017-02-09 11:53:50 -05:00
Benjamin Smedberg
db2caa010a Bug 1290766 - Return the scroll capture information from the PPluginWidget Create method, instead of using a separate asynchronous method which is delivered later and may race with fast shutdown. r=billm 
MozReview-Commit-ID: JJA1VaIuDxL
 2016-10-05 11:36:26 -04:00
Nicholas Nethercote
b5810a1eb4 Bug 1299384 - Use MOZ_MUST_USE with NS_warn_if_impl(). r=erahm. 
This change avoids lots of false positives for Coverity's CHECKED_RETURN
warning, caused by NS_WARN_IF's current use in both statement-style and
expression-style.

In the case where the code within the NS_WARN_IF has side-effects, I made the
following change.

> NS_WARN_IF(NS_FAILED(FunctionWithSideEffects()));
> -->
> Unused << NS_WARN_IF(NS_FAILED(FunctionWithSideEffects()));

In the case where the code within the NS_WARN_IF lacks side-effects, I made the
following change.

> NS_WARN_IF(!condWithoutSideEffects);
> -->
> NS_WARNING_ASSERTION(condWithoutSideEffects, "msg");

This has two improvements.
- The condition is not evaluated in non-debug builds.
- The sense of the condition is inverted to the familiar "this condition should
  be true" sense used in assertions.

A common variation on the side-effect-free case is the following.

> nsresult rv = Fn();
> NS_WARN_IF_(NS_FAILED(rv));
> -->
> DebugOnly<nsresult rv> = Fn();
> NS_WARNING_ASSERTION(NS_SUCCEEDED(rv), "Fn failed");
 2016-09-02 17:12:24 +10:00
Kan-Ru Chen
a9b19d0584 Bug 1297276 - Rename mfbt/unused.h to mfbt/Unused.h for consistency. r=froydnj 
The patch is generated from following command:

  rgrep -l unused.h|xargs sed -i -e s,mozilla/unused.h,mozilla/Unused.h,

MozReview-Commit-ID: AtLcWApZfES
 2016-08-24 14:47:04 +08:00
Bob Owen
87003f6f32 Bug 1252877 Part 2: On Windows capture an image for windowed plugins to be displayed during APZ scroll. r=jimm, r=mattwoodrow 
MozReview-Commit-ID: ElE0GD3tLah
 2016-07-18 09:54:02 +01:00
Birunthan Mohanathas
ac37dec517 Bug 1219392 - Capitalize mozilla::unused to avoid conflicts. r=froydnj 2015-11-02 07:53:26 +02:00
Jim Mathies
0c9782b137 Bug 1132874 - Simplify PPluginWidget protocol handling, and avoid sending async messages from the parent. Addresses a problem with sub protocols that are torn down randomly from either side of the connection. r=aklotz 2015-04-07 08:17:27 -05:00
Jim Mathies
0167655cf1 Bug 1132874 - Improve PPluginWidget shutdown logic. r=aklotz 2015-02-19 07:05:12 -06:00
Jim Mathies
594850560b Backout ee13449af6e7 (bug 1127378) on the suspicion that it caused bug 1130734. 2015-02-09 12:37:46 -06:00
Jim Mathies
b1af763302 Bug 1127378 - When tabs close notify PluginWidgetChild earlier in shutdown. Prevents PluginWidgetProxy messages sent to dead parent actors triggering content process aborts. r=akotz 2015-02-03 13:58:32 -06:00
Jim Mathies
7f25d4d76a Bug 1095754 - Update PPluginWidget shutdown logic. r=aklotz 2015-01-29 13:41:56 -06:00
Jim Mathies
93665e0554 Bug 1095754 - In the content process provide a way to track and access PluginInstanceParent objects from PluginWidgetChild. r=aklotz 2015-01-29 13:41:53 -06:00
Jim Mathies
36ee9eb5e9 Bug 669200 - Implement base PPluginWidget classes for managing plugin windows via content. r=billm 2014-11-12 14:59:19 -06:00