Commit Graph

95 Commits

Author SHA1 Message Date
Jeff Gilbert
70a22b2878 Bug 1470325 - s/FooBinding/Foo_Binding/g - r=qdot
MozReview-Commit-ID: JtTcLL5OPF0
2018-06-26 17:05:01 -07:00
Emilio Cobos Álvarez
0348c342b8 Bug 1470930: Use enums for passing arguments for event dispatch. r=smaug
MozReview-Commit-ID: DsNuF7GAflJ
2018-06-26 18:22:06 +02:00
Emilio Cobos Álvarez
4b8b5e1717 Bug 1465585: Switch from mozilla::Move to std::move. r=froydnj
This was done automatically replacing:

  s/mozilla::Move/std::move/
  s/ Move(/ std::move(/
  s/(Move(/(std::move(/

Removing the 'using mozilla::Move;' lines.

And then with a few manual fixups, see the bug for the split series..

MozReview-Commit-ID: Jxze3adipUh
2018-06-01 10:45:27 +02:00
Boris Zbarsky
86d99155db Bug 1455676 part 14. Remove most use of nsIDOMNode in dom/. r=qdot 2018-05-29 22:58:49 -04:00
Boris Zbarsky
02774793c2 Bug 1377980 part 2. Remove most C++ use of nsIDOMRange. r=mccr8 2018-05-17 12:01:38 -04:00
Adrian Wielgosik
ea6df64f46 Bug 1460940 - Convert nsIDocumentEncoder to use nsIDocument. r=bz
MozReview-Commit-ID: 1Nla9DnwFiu
2018-05-11 19:46:15 +02:00
Boris Zbarsky
3efb9609f6 Bug 1387143 followup. Remove assertion that does not seem to hold and causes a CLOSED TREE. r=bzbarsky 2018-05-08 15:04:53 -04:00
Boris Zbarsky
5d017f96cf Bug 1387143 part 29. Remove nsISelection. r=mats 2018-05-08 13:52:42 -04:00
Boris Zbarsky
bcab2c9f4c Bug 1387143 part 27. Remove some unused nsISelection methods. r=mats 2018-05-08 13:52:42 -04:00
Boris Zbarsky
51ab63aa51 Bug 1387143 part 26. Remove nsISelection::Modify. r=mats 2018-05-08 13:52:42 -04:00
Boris Zbarsky
855d49e122 Bug 1387143 part 25. Remove nsISelection::DeleteFromDocument. r=mats 2018-05-08 13:52:42 -04:00
Boris Zbarsky
586f4fc92c Bug 1387143 part 24. Remove nsISelection::ContainsNode. r=mats 2018-05-08 13:52:42 -04:00
Boris Zbarsky
87fdbf744c Bug 1387143 part 23. Remove nsISelection collapse* methods. r=mats 2018-05-08 13:52:41 -04:00
Boris Zbarsky
dad97be012 Bug 1387143 part 22. Remove nsISelection isCollapsed/collapsed bits. r=mats 2018-05-08 13:52:39 -04:00
Boris Zbarsky
da3b7af4e4 Bug 1387143 part 21. Remove nsISelection getters for anchor and focus points. r=mats
Instead of copying spec-duplicating comments from nsISelection.idl to
Selection.webidl, this just points the latter to the right spec.
2018-05-08 13:52:38 -04:00
Boris Zbarsky
3d7e344fa9 Bug 1387143 part 20. Remove nsISelectionPrivate. r=mats 2018-05-08 13:52:38 -04:00
Boris Zbarsky
3a63497f5f Bug 1387143 part 19. Remove remaining methods from nsISelectionPrivate. r=mats 2018-05-08 13:52:38 -04:00
Boris Zbarsky
89160556f4 Bug 1387143 part 18. Remove ScrollIntoView bits from nsISelectionPrivate. r=mats 2018-05-08 13:52:38 -04:00
Boris Zbarsky
682fac60a9 Bug 1387143 part 17. Remove GetRangesForInterval bits from nsISelectionPrivate. r=mats 2018-05-08 13:52:38 -04:00
Boris Zbarsky
1794127e77 Bug 1387143 part 16. Remove nsISelectionPrivate::GetType. r=mats 2018-05-08 13:52:38 -04:00
Boris Zbarsky
5aadc274e5 Bug 1387143 part 15. Remove nsISelectionPrivate::Get/SetSelectionDirection. r=mats 2018-05-08 13:52:38 -04:00
Boris Zbarsky
170f0b5380 Bug 1387143 part 14. Remove nsISelectionPrivate::GetCachedFrameOffset. r=mats. 2018-05-08 13:52:37 -04:00
Boris Zbarsky
9b0537eabf Bug 1387143 part 13. Remove nsISelectionPrivate::Get/SetCanCacheFrameOffset. r=mats 2018-05-08 13:52:37 -04:00
Boris Zbarsky
50bb8b276c Bug 1387143 part 12. Remove nsISelectionPrivate::Add/RemoveSelectionListener. r=mats
None of the C++ callers of RemoveSelectionListener care about whether the
listener was already-added, and the only JS caller is in a test and knows the
listener was added.  So the behavior change to no-op instead of throwing when
trying to remove a nonexistent listener is OK.  Furthermore, the removal is
null-safe, so there's no point to explicitly failing if null is passed (which
it never is).

Since content can't directly add selection listeners, we can just use an
infallible append instead of returning errors callers don't check for anyway.

Also, no one passes null to AddSelectionListener, so we don't have to worry
about that part.
2018-05-08 13:52:37 -04:00
Boris Zbarsky
17705db640 Bug 1387143 part 10. Remove toString bits from nsISelection and nsISelectionPrivate. r=mats. 2018-05-08 13:52:37 -04:00
Boris Zbarsky
7a57b66cbc Bug 1387143 part 9. Remove nsISelectionPrivate::Get/SetAncestorLimiter. r=mats 2018-05-08 13:52:37 -04:00
Boris Zbarsky
3e12e2c02e Bug 1387143 part 8. Remove nsISelectionPrivate::Get/SetInterlinePosition. r=mats 2018-05-08 13:52:37 -04:00
Boris Zbarsky
9f543072ec Bug 1387143 part 7. Move the TABLESELECTION_* constants from nsISelectionPrivate to a TableSelection enum. r=mats 2018-05-08 13:52:36 -04:00
Boris Zbarsky
eac07d5c7b Bug 1387143 part 1. Stop using nsISelection in nsISelectionListener. r=mats 2018-05-08 13:52:35 -04:00
Chris Peterson
5d6b16ea3b Bug 1457813 - Part 2: Replace non-asserting NS_PRECONDITIONs with MOZ_ASSERTs. r=froydnj
s/NS_PRECONDITION/MOZ_ASSERT/ and reindent

MozReview-Commit-ID: KuUsnVe2h8L
2018-04-28 12:50:58 -07:00
Emilio Cobos Álvarez
f1b4833c7d Bug 1458016: Fix bad cast to Text. r=bz
I think it's harmless security-wise, since Text and char data are both
nsIContent, so the vtable offset should be the same.

I could also just do AsContent(), which may be cleaner but involve a virtual
call, or add AsCharacterData(), just let me know.

MozReview-Commit-ID: 79I9CuCmioF
2018-04-30 22:03:33 +02:00
Boris Zbarsky
45892dfa49 Bug 1456588 part 1. Change nsIFocusManager::SetFocus to take Element. r=enndeakin 2018-04-26 10:37:46 -04:00
Emilio Cobos Álvarez
11ab7d65e7 Bug 1454241: Remove nsINode::eDATA_NODE. r=bz
MozReview-Commit-ID: 6HQDAwiGgIo
2018-04-20 03:58:00 +02:00
Andrew McCreight
7a07e0c48b Bug 1449670, part 1 - Convert IsNodeOfType(nsINode::eTEXT) to IsText(). r=bz
This method is not a virtual call, and also looks nicer.

This patch was mostly generated by a Python script, but I manually
cleaned up the code in a few places where statements didn't need to be
split across multiple lines any more.

MozReview-Commit-ID: 8JExxqSRc59
2018-04-12 15:41:00 -07:00
Boris Zbarsky
2f03e52f54 Bug 1447890 part 5. Remove nsISelection::RemoveAllRanges. r=mystor
MozReview-Commit-ID: EeMje9KW6An
2018-03-27 00:35:23 -04:00
Boris Zbarsky
60cebc0348 Bug 1447890 part 4. Remove nsISelection::GetRangeCount. r=mystor
MozReview-Commit-ID: FypNZE0oQiW
2018-03-27 00:35:22 -04:00
Boris Zbarsky
769f93f814 Bug 1447890 part 3. Remove nsISelection::GetRangeAt. r=mystor
MozReview-Commit-ID: GhtZwsciRL4
2018-03-27 00:35:22 -04:00
Boris Zbarsky
2ba075cde9 Bug 1447890 part 2. Remove nsISelection::RemoveRange. r=mystor
MozReview-Commit-ID: JXq5FYNNXPJ
2018-03-27 00:35:22 -04:00
Boris Zbarsky
189e99bd19 Bug 1447890 part 1. Remove nsISelection::AddRange. r=mystor
MozReview-Commit-ID: 1JNLZp7tbII
2018-03-27 00:35:22 -04:00
Boris Zbarsky
82e160f204 Bug 1447889 part 2. Remove the XPCOM goop for creating Selection. r=mystor
It's unused; we never create these things by contract or classid.

MozReview-Commit-ID: 3Jsyb6QHlJt
2018-03-27 00:35:20 -04:00
Boris Zbarsky
ce8d780eb8 Bug 1433566 part 13. Remove nsIDOMText. r=mystor
MozReview-Commit-ID: DvaZ96j5exf
2018-03-19 15:15:39 -04:00
Emilio Cobos Álvarez
0f7c4f5d20 Bug 1024082: Remove most of the nsIPresShell::FrameManager calls. r=dholbert
Most of them just want GetRootFrame(), and there's no need to explicitly go
through the frame manager for that, we have a handy alias in the shell.

MozReview-Commit-ID: GriEqkasidY
2018-03-07 10:17:49 +01:00
Olli Pettay
fe9afade80 Bug 1066965, make contentEditable and spellchecking to work in ShadowDOM, r=mrbkap 2018-03-06 09:34:40 +09:00
Dorel Luca
ee8e21ebda Backed out changeset 38577c007450 (bug 1424371) for Marionett test failure on testing/marionette/harness/marionette_harness/tests/unit/test_window_maximize.py. CLOSED TREE 2018-02-19 22:15:23 +02:00
Milan Sreckovic
2aa2530441 Bug 1424371: Use BaseRect access methods instead of member variables in dom/ r=qdot
MozReview-Commit-ID: HXWhggOMIEK
2018-02-19 12:56:10 -05:00
Boris Zbarsky
a04420f06a Bug 1432186 part 19. Remove the nsIDOMNode::*_NODE constants. r=mccr8
MozReview-Commit-ID: KvKjeKIOB9K
2018-01-29 23:10:53 -05:00
Andrea Marchesini
8d41475807 Bug 1430997 - Rename nsINode::IndexOf to nsINode::ComputeIndexOf, r=catalinb 2018-01-23 14:30:18 +01:00
Andrea Marchesini
19f4c46ee5 Bug 1430516 - Fixing a regression when a table cell is selected, r=catalinb 2018-01-17 12:52:51 +01:00
Andrea Marchesini
3a47528e62 Bug 1425440 - Get rid of GetChildAt_Deprecated in selection, r=catalinb 2018-01-12 15:33:13 +01:00
Olli Pettay
1273f1da9e Bug 1429244 - Make Selection to use main thread only AddRef/Release, r=mccr8 2018-01-10 09:47:07 +02:00