Commit Graph

35 Commits

Author SHA1 Message Date
Gregory Szorc
e76faa3e4c Bug 1455127 - Remove --package from upload.py; r=ted
The argument is never used in the local file copying function. So let's
nuke the argument.

MozReview-Commit-ID: JeU4LaVvGD7
2018-04-19 09:31:00 -07:00
Gregory Szorc
49b0ec11eb Bug 1455127 - Remove --properties-file from upload.py; r=ted
This was only used for the remote server case. That code was recently
deleted.

MozReview-Commit-ID: 7usqWZ7CuBR
2018-04-19 09:30:52 -07:00
Gregory Szorc
612e60265e Bug 1455127 - Remove functionality for uploading to a server; r=ted
With the transition to Taskcluster, "uploads" are artifacts in a local
directory. So we don't need to support uploading to a remote server
using SCP.

This commit removes all the code to support uploading to a remote
server.

And since property files were only written out for the remote case, all
that code can be deleted as well.

Since UPLOAD_HOST no longer means anything, we no longer set it in
mozharness configs.

MozReview-Commit-ID: 66gkM8erkGk
2018-04-19 09:30:31 -07:00
Ciure Andrei
11d4195515 Backed out 3 changesets (bug 1455127) for throughing exceptions and messing with windows 2012 builds on a CLOSED TREE, a=backout
Backed out changeset ac17015816ca (bug 1455127)
Backed out changeset 8527e727b92d (bug 1455127)
Backed out changeset 8c8fe0facf52 (bug 1455127)
2018-04-19 05:43:15 +03:00
Gregory Szorc
01c93aabc1 Bug 1455127 - Remove --package from upload.py; r=ted
The argument is never used in the local file copying function. So let's
nuke the argument.

MozReview-Commit-ID: JeU4LaVvGD7
2018-04-18 15:04:53 -07:00
Gregory Szorc
60c163b0ee Bug 1455127 - Remove --properties-file from upload.py; r=ted
This was only used for the remote server case. That code was recently
deleted.

MozReview-Commit-ID: 7usqWZ7CuBR
2018-04-18 15:03:46 -07:00
Gregory Szorc
3cb13b3cb9 Bug 1455127 - Remove functionality for uploading to a server; r=ted
With the transition to Taskcluster, "uploads" are artifacts in a local
directory. So we don't need to support uploading to a remote server
using SCP.

This commit removes all the code to support uploading to a remote
server.

And since property files were only written out for the remote case, all
that code can be deleted as well.

Since UPLOAD_HOST no longer means anything, we no longer set it in
mozharness configs.

MozReview-Commit-ID: 66gkM8erkGk
2018-04-18 17:05:46 -07:00
Andrew Halberstadt
3353b79e9c Bug 1434430 - [flake8] Fix blank 'except' statements r=rwood
This is a new issue that gets linted with flake8 3.5.0. Basically you should
never use a blank except: statement.

This will catch all exceptions, including KeyboardInterrupt and SystemExit
(which is likely not intended). If a catch all is needed, use
`except: Exception`.  If you *really* mean to also catch KeyboardInterrupt et
al, use `except: BaseException`.

Of course, being specific is often better than a catch all.

MozReview-Commit-ID: FKx80MLO4RN
2018-01-31 14:32:08 -05:00
Sylvestre Ledru
69d68b3c4f Bug 1406650 - Make build/*.py and a few other files flake8 compatible and add them to the list of files to check r=chmanchester
MozReview-Commit-ID: icmFJtbWdN
2017-10-07 16:45:22 +02:00
Chris Manchester
7353b54ebf Bug 1147271 - Add ssh option to prevent hanging on password prompt in upload.py r=mshal
MozReview-Commit-ID: Lmg5SAtLuE3
2017-05-11 09:40:58 -07:00
Gregory Szorc
68318b6e2b Bug 1307482 - Upload files concurrently; r=ted
Use concurrent.futures to provide a thread pool so we upload
files concurrently. This should make uploading complete faster.

If timestamps in mozharness logs can be trusted, uploading on Linux
currently takes ~45s. Hopefully this shaves 10+s from the build.

MozReview-Commit-ID: KTww31XWN7o
2016-10-04 09:22:22 -07:00
Gregory Szorc
5d10e358ba Bug 1307482 - Log uploading when it actually happens; r=ted
In preparation of using a thread pool to call DoSCPFile().

MozReview-Commit-ID: Ab2gk8UTQWK
2016-10-04 08:46:46 -07:00
Gregory Szorc
bec0bd7b6f Bug 1307482 - Avoid excessive scp calls to make directories; r=ted
Most files go to the same directory. This should cut down on the number
of scp sessions we establish as part of directory creation.

MozReview-Commit-ID: LpKwgUZhLEO
2016-10-04 08:34:30 -07:00
Gregory Szorc
4761c8e39b Bug 1307482 - Refactor remote path logic into function; r=ted
We'll call this multiple times in a subsequent commit. I hate DRY
violations.

MozReview-Commit-ID: Khai4EZkPCS
2016-10-04 08:29:50 -07:00
Nick Alexander
d25a6b2f6b Bug 1063966 - Stop building and uploading gecko-unsigned-unaligned.apk. r=nthomas
This is still referenced out of tree, but only to optionally (!) find
it or to ignore it:

http://mxr.mozilla.org/build/search?string=unsigned-unaligned&find=&findi=&filter=%5E%5B%5E%5C0%5D*%24&hitlimit=&tree=build

MozReview-Commit-ID: Hq0TPVDzWOy
2016-03-24 13:53:41 -07:00
Mike Shal
5376245e1f Bug 1243750 - Install all SDKs into sdk/; r=glandium 2016-01-29 14:52:52 -05:00
Mike Shal
764bf5e1c9 Bug 1247490 - display ssh output if upload command fails; r=ted 2016-02-10 20:21:16 -05:00
Dustin J. Mitchell
42b9e77829 Bug 1198179: in taskcluster, have 'make upload' just copy; r=ted.mielczarek 2015-09-11 11:35:00 -04:00
Mike Shal
8d56508a11 Bug 1198179 - make upload.py write properties even if not uploading; r=ted 2015-08-26 09:46:08 -04:00
Mike Shal
11062ffc28 Bug 1198179 - Kill gen_mach_buildprops.py; r=ted 2015-08-25 11:42:44 -04:00
Mike Shal
b84a5dbd5c Bug 1194741 - Display upload output; r=nalexander 2015-08-14 13:28:54 -04:00
Mike Shal
1597c8ab79 Bug 1118778 - Write upload properties from upload.py; r=glandium 2015-08-05 15:43:15 -04:00
Mike Shal
b4ca7deb11 Bug 1118774 - Add retries to ssh/scp in upload.py; r=gps
Previously, buildbot was responsible for the retrying logic. Now that
'make upload' is part of mach build, we need to add retries here.
2015-01-07 15:48:13 -05:00
Gervase Markham
cb6a072c2a Bug 716478 - update licence to MPL 2. 2012-05-21 12:12:37 +01:00
Serge Gautherie
df6193abb3 Bug 599748 - Remove custom |def check_call()|, now that Python 2.4 is unsupported; (Av1) Remove 'util.py'.
r=ted.mielczarek.
2011-04-14 15:44:13 +02:00
Neil Rashbrook
c7d415ed48 Bug 616810 Remove extraneous CRs r=khuey a=bsmedberg 2011-01-05 23:46:04 +00:00
Gavin Sharp
656aea8316 Backed out changeset ec1525343e0b 2010-10-14 14:30:10 -04:00
Serge Gautherie
90afe24f18 Bug 599748 - Remove custom |def check_call()|, now that Python 2.4 is unsupported; (Av1) Remove 'util.py'.
r=ted.mielczarek.
2010-10-14 19:37:50 +02:00
Chris AtLee
56b64cd10c Bug 563008 - fix upload.py on python2.4. r=ted 2010-04-30 14:54:51 -04:00
Ben Hearsum
86bb449075 bug 486992: post_upload.py errors aren't caught - use sys.exit(non-zero) when exceptions are caught in upload.py. r=ted 2009-04-20 12:42:58 -04:00
Ben Hearsum
d608cb99d3 bug 455578: make sure upload.py always cleans up after itself. r=ted 2009-01-07 08:52:20 -05:00
Ben Hearsum
606736b193 bug 455578: create a post-upload script on stage to do release-to-dated, etc. - upload.py fixes and enhancements. r=ted 2008-12-24 09:05:00 -05:00
Ted Mielczarek
01c2a423f3 bug 468124 - upload.py should let UPLOAD_PORT and POST_UPLOAD_CMD actually be optional. r=bsmedberg 2008-12-10 10:26:50 -05:00
Ted Mielczarek
5bea4b1879 Followup fix for bug 454594 (need a makefile target that can upload files via ssh). r=bsmedberg, NPOB 2008-11-13 17:50:27 +01:00
Ted Mielczarek
1fc13e1a70 Bug 454594: need a makefile target that can upload files via ssh. r=bsmedberg, NPOB 2008-11-13 15:37:04 +00:00