Commit Graph

589 Commits

Author SHA1 Message Date
Michael Kelly
153a548648 Bug 1445011: Include sourceName in error report payload. r=Gijs
The module attribute for an exception is surfaced in Sentry as the "transaction"
tag, and is useful for errors that don't include stack traces.

Differential Revision: https://phabricator.services.mozilla.com/D727

MozReview-Commit-ID: JKwgmE2jBXB
2018-03-14 09:45:35 -07:00
Marco Bonardo
6a7873575a Bug 1437803 - Add telemetry to understand how many users use TAB to cycle through Address Bar results. r=adw,dzeber
MozReview-Commit-ID: 6zdiIoxVIn1
2018-02-27 18:13:59 +01:00
Prathiksha
375cc71cab Bug 1192927 - Remove plugins specific code and initialize the flash plugin row in Page Info and support flash in Site Identity. r=Felipe,johannh
MozReview-Commit-ID: 7CLfN4Io0ez
2018-02-18 00:20:11 +05:30
Andreea Pavel
15a36587f5 Backed out changeset 8e5b1525be69 (bug 1192927) or failing testing\firefox-ui\tests\functional\security\test_no_certificate.py TestNoCertificate.test_no_certificate on a CLOSED TREE 2018-03-02 13:51:15 +02:00
Prathiksha
0567731fbe Bug 1192927 - Remove plugins specific code and initialize the flash plugin row in Page Info and support flash in Site Identity. r=Felipe,johannh
MozReview-Commit-ID: 3KUbgencO3M
2018-02-18 00:20:11 +05:30
Gijs Kruitbosch
ab72cbd549 Bug 1370930 - remove DirectoryLinksProvider, r=Mardak
MozReview-Commit-ID: 4YcsNvRg7Hn
2018-03-01 16:53:49 +00:00
Florian Quèze
f6add2cafd Bug 1433175 - scripted patch to replace Components.classes[, Components.interfaces.nsI, Components.utils. and Components.results. with Cc, Ci, Cu and Cr, r=Mossop. 2018-02-28 18:51:33 +01:00
Sebastian Hengst
b120b7fb67 merge mozilla-inbound to mozilla-central. a=merge 2018-02-28 12:54:12 +02:00
Michael Kelly
9632c5bca4 Bug 1440534 Include source code in JS error reports. r=Gijs
Along with adding source code, this updates the reported to more closely follow
the Sentry SDK docs:

- Remove the "request" payload, which is for reporting errors related to HTTP
  requests.
- Include SDK info in the payload.
- Reverse the order of stack frames; they are meant to be ordered oldest to
  newest.
- Include a local UTC timestamp in the payload.
- Remove the in_app flag from stack traces, as it's not required or useful in
  the context of Firefox.

MozReview-Commit-ID: 558KrZNah6d

Differential Revision: https://phabricator.services.mozilla.com/D648
2018-02-27 11:08:38 -08:00
Mark Banner
94214ba814 Bug 1441460 - ESLint's no-define-cc-etc looks at the wrong property item when checking for Cc/Ci/Cu/Cr usage. r=florian
MozReview-Commit-ID: IkSkCWqBHOn
2018-02-23 20:42:17 +00:00
Kyle Machulis
e652cb2bd4 Bug 1201590 - WebMIDI device access permissions prompt implementation; r=baku,johannh
MozReview-Commit-ID: LxElgfdaiQs
2017-11-15 11:13:12 -08:00
Marco Bonardo
d0ccc79f34 Bug 1434414 - Locking the 'sanitize on shutdown' pref causes sanitization to happen at every startup. r=johannh
MozReview-Commit-ID: 6PvRFmaZsBC
2018-02-15 00:42:58 +01:00
Michael Kelly
d3115960aa Bug 1437696 Reset console after BrowserErrorReporter tests. r=gijs
Because BrowserErrorReporter instances process previously-logged messages when
they are initialized, multiple runs of each test case (such as during the test
verification suite) cause new instances to process messages from the previous
test run. Resetting the console at the end of each test case prevents tests from
affecting each other.

Differential Revision: https://phabricator.services.mozilla.com/D589

MozReview-Commit-ID: HwjbbE00o97
2018-02-21 15:19:26 -08:00
Masayuki Nakano
efaea0aaa7 Bug 1438157 - part 2: Remove unnecessary second argument of EventUtils.synthesizeKey() r=smaug
Note that this patch also replaces legacy VK_* with KEY_*, and replaces
synthesizeKey() for inputting some characters with sendString() because
it's better and clearer what it does and it sets shiftKey state properly.

MozReview-Commit-ID: De4enbjux3T
2018-02-15 04:15:39 +09:00
Paolo Amadini
6a3bde22d2 Bug 1437811 - Part 1 - Fix test that didn't wait for PanelMultiView events. r=Gijs
MozReview-Commit-ID: CxWMEkzGMyZ
2018-02-14 14:12:57 +00:00
Thomas Wisniewski
fb20e1dfac Bug 792808 - Change browser/[components|modules|experiments] to import and instantiate XHRs from global properties rather than using Cc.createInstance(Ci.nsIXMLHttpRequest); r=mconley
MozReview-Commit-ID: 66ubjdJssU9
2017-09-19 12:17:10 -04:00
Ed Lee
55ed5e5529 Bug 1433324 - Part 1. Assume true for browser.newtabpage.activity-stream.aboutHome.enabled. r=ursula
MozReview-Commit-ID: KOSX1qNBna8
2018-02-13 14:48:49 -08:00
Michael Kelly
895bcde6ef Bug 1426482 Report browser errors in Nightly to Mozilla. r=gijs
Errors are collected via nsIConsoleService, shaped to a Sentry-compatible
format, and sent off. Reporting is on by default, and can be disabled using a
checkbox added to the privacy prefs in about:preferences.

Collected errors are sampled to avoid overloading the collection service; the
sample rate was determined by a previous Shield study that measured the number
of errors occurring in Nightly.

The feature is hard-disabled outside of Nightly and local builds, and the
preference is disabled by default in local builds. It is intended as a prototype
that will be evaluated and replaced by a more robust collection system if it
proves helpful.

Differential Revision: https://phabricator.services.mozilla.com/D561

MozReview-Commit-ID: 6aqUatXyuYs
2018-02-12 10:59:47 -08:00
Paolo Amadini
ed0806abfd Bug 1434883 - Part 1 - Fix tests for the activated page action panel. r=Gijs
The promisePanelEvent function was unreliable because it did not raise an error if the provided panel did not exist, which caused one of the callers to ignore a missing panel silently. All the callers have now been updated based on whether they expect the panel to exist or not.

MozReview-Commit-ID: AGT4rHls4OB
2018-02-04 16:32:20 +00:00
Nathan Watson
5d40195377 Bug 1434262 - Remove PlacesTestUtils.clearHistory() r=mak
MozReview-Commit-ID: In2RaM0LBsc
2018-01-31 22:03:05 -08:00
Andrew McCreight
272cee1e65 Bug 1432992, part 1 - Remove definitions of Ci, Cr, Cc, and Cu. r=florian
This patch was autogenerated by my decomponents.py

It covers almost every file with the extension js, jsm, html, py,
xhtml, or xul.

It removes blank lines after removed lines, when the removed lines are
preceded by either blank lines or the start of a new block. The "start
of a new block" is defined fairly hackily: either the line starts with
//, ends with */, ends with {, <![CDATA[, """ or '''. The first two
cover comments, the third one covers JS, the fourth covers JS embedded
in XUL, and the final two cover JS embedded in Python. This also
applies if the removed line was the first line of the file.

It covers the pattern matching cases like "var {classes: Cc,
interfaces: Ci, utils: Cu, results: Cr} = Components;". It'll remove
the entire thing if they are all either Ci, Cr, Cc or Cu, or it will
remove the appropriate ones and leave the residue behind. If there's
only one behind, then it will turn it into a normal, non-pattern
matching variable definition. (For instance, "const { classes: Cc,
Constructor: CC, interfaces: Ci, utils: Cu } = Components" becomes
"const CC = Components.Constructor".)

MozReview-Commit-ID: DeSHcClQ7cG
2018-02-06 09:36:57 -08:00
Cosmin Sabou
27ede269b6 Backed out 3 changesets (bug 1434883) for frequent leaks in AbstractThread, AnimationTimeline, Annotators, Array, AsyncFreeSnowWhite, ... on a CLOSED TREE
Backed out changeset c8115e90ffa8 (bug 1434883)
Backed out changeset 22c83b1d417d (bug 1434883)
Backed out changeset 085796417462 (bug 1434883)
2018-02-06 16:30:56 +02:00
Paolo Amadini
b8175440fa Bug 1427350 - Part 1 - Use "autocomplete-rich-result-popup" instead of "autocomplete-result-popup" for the search bar. r=mak
MozReview-Commit-ID: AO926Wmhkbm
2018-02-04 15:00:48 +00:00
Paolo Amadini
e798559ae2 Bug 1434883 - Part 1 - Fix tests for the activated page action panel. r=Gijs
The promisePanelEvent function was unreliable because it did not raise an error if the provided panel did not exist, which caused one of the callers to ignore a missing panel silently. All the callers have now been updated based on whether they expect the panel to exist or not.

MozReview-Commit-ID: AGT4rHls4OB
2018-02-04 16:32:20 +00:00
Kris Maglione
0bb74efdf1 Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm

MozReview-Commit-ID: 1Nc3XDu0wGl
2018-01-29 15:20:18 -08:00
Cosmin Sabou
f09d6d985d Backed out 3 changesets (bug 1431533) for Android mochitest failures on testEventDispatcher on a CLOSED TREE
Backed out changeset a1eca62826a1 (bug 1431533)
Backed out changeset 34c999fa006b (bug 1431533)
Backed out changeset e2674287e57f (bug 1431533)
2018-01-30 07:17:48 +02:00
Kris Maglione
fd67f090b2 Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm

MozReview-Commit-ID: 1Nc3XDu0wGl
2018-01-29 15:20:18 -08:00
Brindusan Cristian
483ba301cb Backed out 2 changesets (bug 1431533) for ESlint failures on a CLOSED TREE
Backed out changeset 6e56f4c8843e (bug 1431533)
Backed out changeset 12fc4dee861c (bug 1431533)
2018-01-30 02:32:43 +02:00
Kris Maglione
683a97d172 Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm

MozReview-Commit-ID: 1Nc3XDu0wGl
2018-01-29 15:20:18 -08:00
Andreea Pavel
35130a6b8b Merge inbound to mozilla-centra r=merge a=merge 2017-12-22 11:54:07 +02:00
Mike Conley
cd42f6052d Bug 1424373 - Rename crash report submission pref. r=Mossop 2017-12-21 16:36:13 -05:00
Chung-Sheng Fu
b5e311db1b Bug 1413780 - Change permission name from canvas/extractData to canvas. r=johannh
MozReview-Commit-ID: 40mesFLeRWU
2017-12-14 15:59:57 -06:00
Chung-Sheng Fu
8d647cb686 Bug 1413780 - Add a test for canvas permission to test_SitePermissions.js r=johannh
MozReview-Commit-ID: 6ZS1a9nkZfQ
2017-12-14 11:42:17 -06:00
Florian Quèze
1838aa9e08 Bug 1421992 - script-generated patch to replace do_execute_soon, do_print and do_register_cleanup with executeSoon, info and registerCleanupFunction, rs=Gijs. 2017-12-21 11:10:23 +01:00
Florian Quèze
082ca8b2a3 Bug 1421992 - script-generated patch to replace do_check_* functions with their Assert.* equivalents, rs=Gijs. 2017-12-21 11:08:17 +01:00
Florian Quèze
3f662053f3 Bug 592653 - script-generated patch to replace gPrefService with Services.prefs, r=Standard8. 2017-12-19 23:45:10 +01:00
Jonathan Kingston
9d78c5eab3 Bug 1420622 - Remove feed and pcast protocols. r=Gijs
MozReview-Commit-ID: KAC9MmLiuBG
2017-12-19 16:12:29 +00:00
Masatoshi Kimura
1dfecd5932 Bug 1418914 - Move E10SUtils.jsm into toolkit/. r=mossop
MozReview-Commit-ID: EgDzEEKAeh1
2017-12-12 21:35:16 +09:00
Bill McCloskey
142c9a9dbb Bug 1412456 - Test changes to no longer use interposition (r=felipe,bgrins,mrbkap)
MozReview-Commit-ID: 2nQPOSGTr1s
2017-12-07 12:55:24 -08:00
Bogdan Tara
27b842b835 Merge mozilla-central to inbound. r=merge a=merge on a CLOSED TREE 2017-12-07 13:02:03 +02:00
Andreea Pavel
26ac595cba Backed out 9 changesets (bug 1412456) for crashing talos g2 and unexpected network connections in browser-chrome's browser_searchEngine_behaviors.js r=backout a=backout on a CLOSED TREE
Backed out changeset 0c01a98f4fd5 (bug 1412456)
Backed out changeset 27077db47231 (bug 1412456)
Backed out changeset f35ec2a884f8 (bug 1412456)
Backed out changeset 602b30ac3c69 (bug 1412456)
Backed out changeset b1ff1050c589 (bug 1412456)
Backed out changeset f100d953f9eb (bug 1412456)
Backed out changeset d85af60fe259 (bug 1412456)
Backed out changeset 736f38486832 (bug 1412456)
Backed out changeset 13a637602dc2 (bug 1412456)
2017-12-07 12:20:21 +02:00
Bill McCloskey
427710d960 Bug 1412456 - Test changes to no longer use interposition (r=felipe,bgrins,mrbkap)
MozReview-Commit-ID: 2nQPOSGTr1s
2017-12-06 21:17:05 -08:00
Dorel Luca
81b4b85d01 Backed out 8 changesets (bug 1412456) for ESlint failure on browser_urlbarKeepStateAcrossTabSwitches.js:13:49 r=backout on a CLOSED TREE
Backed out changeset 0e88de036c55 (bug 1412456)
Backed out changeset 49b93f807db0 (bug 1412456)
Backed out changeset 039e980b7dc6 (bug 1412456)
Backed out changeset c7698410ddbd (bug 1412456)
Backed out changeset e56a1ba26b7c (bug 1412456)
Backed out changeset 0c4506e124ac (bug 1412456)
Backed out changeset a7aec2ce903b (bug 1412456)
Backed out changeset 3e9fb71f1e8e (bug 1412456)
2017-12-07 07:09:33 +02:00
Bill McCloskey
a0f07d3df7 Bug 1412456 - Test changes to no longer use interposition (r=felipe,bgrins,mrbkap)
MozReview-Commit-ID: 2nQPOSGTr1s
2017-12-06 20:46:58 -08:00
Ryan VanderMeulen
6f96d4a01d Bug 1423667 - Disable some tests that fail on Windows Code Coverage builds with clang-cl r317840. rs=marco 2017-12-06 20:40:46 -05:00
Edouard Oger
cd7496e3c6 Bug 1422106 - Show broken heart when unverified in synced tabs sidebar/panel. r=markh
MozReview-Commit-ID: BDTdmcIOHmn
2017-11-30 16:01:40 -05:00
Jessica Jong
b259ca8f28 Bug 1418020: No need to hide form validation popoup onLocationChange. r=Felipe
We already hide the popup when element blurs, which is fired when navigating to
another page.

MozReview-Commit-ID: 5GvlX1CiOQL
2017-12-04 14:15:28 +08:00
Tooru Fujisawa
ad101a77f2 Bug 1421028 - Wait for stable state before starting in browser/modules/test/browser/browser_urlBar_zoom.js. r=Mossop 2017-11-29 19:59:45 +09:00
Edouard Oger
a0cee0d6b8 Bug 1417520 p1 - Show message to unverified users in synced tabs sidebar. r=markh
MozReview-Commit-ID: KYlbWLg2Kj0
2017-11-16 15:29:23 -05:00
Dan Banner
503979c95a Bug 1367704 - Enable the semi ESLint rule across the tree. r=standard8
MozReview-Commit-ID: GrlcOI9K2hJ
2017-05-28 19:57:46 +01:00