Commit Graph

78 Commits

Author SHA1 Message Date
Kris Maglione
b3990a2d91 Bug 1456686: Part 1 - Fix unused and shadowed explicit imports. r=standard8
These issues were previously ignored due to the nature of our global import
rules. They need to be fixed before that rule can be updated.

MozReview-Commit-ID: DCChktTc5TW
2018-04-24 20:18:09 -07:00
Marco Bonardo
ffb9670998 Bug 1453580 - Remove promiseFaviconLinkUrl and fix its consumers. r=Gijs
MozReview-Commit-ID: GrY8s3l71Mp
2018-04-16 18:24:06 +02:00
Dorel Luca
af4700d8df Backed out changeset 897bbf35e781 (bug 1453580) for XPCShell failure on services/sync/tests/unit/test_syncedtabs.js. CLOSED TREE 2018-04-18 14:06:34 +03:00
Marco Bonardo
11e458b637 Bug 1453580 - Remove promiseFaviconLinkUrl and fix its consumers. r=Gijs
MozReview-Commit-ID: GrY8s3l71Mp
2018-04-16 18:24:06 +02:00
Dão Gottwald
ed10c9e61e Bug 1441788 - Expose Reader View shortcut in the address bar button's tooltip. r=mikedeboer
MozReview-Commit-ID: 88p5xYUrefQ
2018-02-28 11:45:54 +01:00
Florian Quèze
f1a55f73f8 Bug 1440284 - change this.EXPORTED_SYMBOLS back to var EXPORTED_SYMBOLS in JS modules, r=mccr8. 2018-02-23 20:50:01 +01:00
Andrew McCreight
272cee1e65 Bug 1432992, part 1 - Remove definitions of Ci, Cr, Cc, and Cu. r=florian
This patch was autogenerated by my decomponents.py

It covers almost every file with the extension js, jsm, html, py,
xhtml, or xul.

It removes blank lines after removed lines, when the removed lines are
preceded by either blank lines or the start of a new block. The "start
of a new block" is defined fairly hackily: either the line starts with
//, ends with */, ends with {, <![CDATA[, """ or '''. The first two
cover comments, the third one covers JS, the fourth covers JS embedded
in XUL, and the final two cover JS embedded in Python. This also
applies if the removed line was the first line of the file.

It covers the pattern matching cases like "var {classes: Cc,
interfaces: Ci, utils: Cu, results: Cr} = Components;". It'll remove
the entire thing if they are all either Ci, Cr, Cc or Cu, or it will
remove the appropriate ones and leave the residue behind. If there's
only one behind, then it will turn it into a normal, non-pattern
matching variable definition. (For instance, "const { classes: Cc,
Constructor: CC, interfaces: Ci, utils: Cu } = Components" becomes
"const CC = Components.Constructor".)

MozReview-Commit-ID: DeSHcClQ7cG
2018-02-06 09:36:57 -08:00
arthur.iakab
384e070ea5 Merge mozilla-central to autoland 2018-01-31 00:41:58 +02:00
Gijs Kruitbosch
0c4260ddf9 Bug 1420714 - fix favicon fetching in reader mode, r=mak
MozReview-Commit-ID: KZFoKNqVPPy
2018-01-30 15:13:23 +00:00
Kris Maglione
0bb74efdf1 Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm

MozReview-Commit-ID: 1Nc3XDu0wGl
2018-01-29 15:20:18 -08:00
Cosmin Sabou
f09d6d985d Backed out 3 changesets (bug 1431533) for Android mochitest failures on testEventDispatcher on a CLOSED TREE
Backed out changeset a1eca62826a1 (bug 1431533)
Backed out changeset 34c999fa006b (bug 1431533)
Backed out changeset e2674287e57f (bug 1431533)
2018-01-30 07:17:48 +02:00
Kris Maglione
fd67f090b2 Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm

MozReview-Commit-ID: 1Nc3XDu0wGl
2018-01-29 15:20:18 -08:00
Brindusan Cristian
483ba301cb Backed out 2 changesets (bug 1431533) for ESlint failures on a CLOSED TREE
Backed out changeset 6e56f4c8843e (bug 1431533)
Backed out changeset 12fc4dee861c (bug 1431533)
2018-01-30 02:32:43 +02:00
Kris Maglione
683a97d172 Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm

MozReview-Commit-ID: 1Nc3XDu0wGl
2018-01-29 15:20:18 -08:00
James Teh
8b0f2811d9 Bug 1425541: Expose reader mode state on the browser accessible using a "reader" object attribute. r=eeejay,Gijs
This makes it easy for accessibility clients to retrieve the reader mode state programmatically.

There are three possibilities:
1. Reader mode is available for the current page (reader:available).
2. Reader mode is being used now (reader:active).
3. Reader is not available (the reader attribute is not present).

We do this by setting/removing the aria-reader attribute on the node.
This is not a real ARIA attribute, but it causes Gecko to expose it as an object attribute.

MozReview-Commit-ID: B38G3AYyBnS
2017-12-15 14:47:01 -06:00
Dorel Luca
2e121fd0bf Backed out changeset 196006c746bd (bug 1425541) for failing Mochitest on intl/l10n/test/dom/test_domloc_overlay.html on a CLOSED TREE 2018-01-16 03:11:38 +02:00
James Teh
2d555dfb63 Bug 1425541: Expose reader mode state on the browser accessible using a "reader" object attribute. r=eeejay,Gijs
This makes it easy for accessibility clients to retrieve the reader mode state programmatically.

There are three possibilities:
1. Reader mode is available for the current page (reader:available).
2. Reader mode is being used now (reader:active).
3. Reader is not available (the reader attribute is not present).

We do this by setting/removing the aria-reader attribute on the node.
This is not a real ARIA attribute, but it causes Gecko to expose it as an object attribute.

MozReview-Commit-ID: B38G3AYyBnS
2017-12-15 14:47:01 -06:00
Gijs Kruitbosch
febbc31556 Bug 1396565, make reader mode fetch the article from within the content process on desktop, r=jaws
MozReview-Commit-ID: 11uTaQYwz2Y
2017-11-14 16:53:55 +00:00
Dan Banner
5af4450327 Bug 1408777 - Automatically fix instances of missing semicolons in the tree. r=Standard8
MozReview-Commit-ID: Jm8BRgt6mIv
2017-10-15 20:50:39 +01:00
Mark Banner
b1b7a75372 Bug 1380009 - Enable the ESLint no-return-await call to avoid unnecessary intermediate promise creation. r=mossop
MozReview-Commit-ID: EnhSBHMjurr
2017-07-11 22:49:55 +01:00
Florian Quèze
ff53eb9a63 Bug 1353542 - massive script-generated patch converting Task.async and Task.spawn calls, and generators clearly identifiable as tasks, rs=Mossop. 2017-05-12 14:42:39 +02:00
Kris Maglione
a306d23c89 Bug 1358921: Lazily load ReaderParent.jsm when first needed. r=florian
MozReview-Commit-ID: 5UkSnU5sJsm
2017-04-23 13:27:35 -07:00
Mike Conley
ffb4cca140 Bug 1352501 - Remove Reader Mode promotion panel. r=jaws,MattN
Note that the UITour library can still show a panel in the event that we want to
promote the feature that way.

MozReview-Commit-ID: FzKSzO987h7
2017-04-19 16:42:10 -04:00
Sebastian Hengst
b6e693bca9 Bug 1344211 - Reader view shortcut should be shown in 'View' menu. r=Gijs
MozReview-Commit-ID: FKKTlRZhVHT
2017-03-04 19:01:19 +01:00
Jared Wein
e3149c378f Bug 1325464 - Enable object-shorthand rule and run 'mach eslint --fix' with the rule enabled. r=MattN
MozReview-Commit-ID: 7E7LPorrEje
2016-12-29 18:34:54 -05:00
Wes Kocher
2d7553dcfd Backed out 3 changesets (bug 1325464) for xpcshell failures a=backout
Backed out changeset 562ddc32cc21 (bug 1325464)
Backed out changeset cd10db6087dd (bug 1325464)
Backed out changeset 4079437c4648 (bug 1325464)
2016-12-29 14:05:44 -08:00
Jared Wein
34e228f767 Bug 1325464 - Enable object-shorthand rule and run 'mach eslint --fix' with the rule enabled. r=MattN
MozReview-Commit-ID: 8WoGr8i6oCR
2016-12-29 15:20:47 -05:00
Jared Wein
8860cdf2c1 Bug 1294547 - Enable the comma-spacing rule for eslint. r=felipe
MozReview-Commit-ID: RCSDEvvk2I
2016-08-16 15:44:15 -04:00
Horatiu
c313753756 Bug 1144749 - Add keyboard shortcut to open ReaderView. r=markh 2016-07-29 22:13:56 -04:00
Pushpankar
77a14e357c Bug 1286854 - Replace ownerDocument.defaultView with ownerGlobal in browser/. r=dao 2016-07-16 10:20:04 +02:00
Timothy Guan-tin Chien
0170ec3615 Bug 1260276 - Replace the dead reader page in history when we are being redirected, r=gijs
MozReview-Commit-ID: ChSCHuBKT1l
2016-07-13 16:14:34 +08:00
Timothy Guan-tin Chien
5b4d4682c7 Bug 1184950 - Use goBack to leave the reader view when possible, r=margaret, r=gijs
MozReview-Commit-ID: G9wn4OyUL5q
2016-04-19 05:46:58 +08:00
Carsten "Tomcat" Book
1f8ecc7182 Backed out changeset 3c369626af41 (bug 1184950) for bc7 test failures 2016-04-15 10:43:28 +02:00
Timothy Guan-tin Chien
a177f6d757 Bug 1184950 - Use goBack to leave the reader view when possible, r=margaret
MozReview-Commit-ID: G9wn4OyUL5q
2016-04-14 15:54:53 -07:00
Gijs Kruitbosch
2b8faefaba Bug 1252855 - make reader mode use AsyncPrefs, r=margaret
MozReview-Commit-ID: U6ZTyQQSHG
2016-03-15 20:40:14 +00:00
Margaret Leibovic
67b8d331fa Bug 1226238 - (Part 4) Remove reading list toggle button from reader view. r=ahunt,Gijs
MozReview-Commit-ID: 3pwOV5BjwC9
2016-02-22 10:35:32 -05:00
Margaret Leibovic
36d1c35aec Bug 1226238 - (Part 1) Remove share button from reader view. r=ahunt,Gijs
MozReview-Commit-ID: 3TFzz809KcM
2016-02-22 10:09:07 -05:00
Paolo Amadini
308d4856f1 Bug 1236229 - The showInfo API in UITour.jsm should accept JavaScript callbacks rather than callback IDs. r=MattN 2016-01-05 14:04:49 +00:00
Shane Caraveo
3d87f487dc Bug 1215694 move pocket to a system addon, r=Gijs, r=glandium
part 1: reorganize file locations, r=Gijs
  part 2: remove built-in pocket code, r=Gijs
  part 3: l10n support, r=glandium
  part 4: move code/functionality from part 2 into the addon, r=Gijs
  part 5: remove dead code, r=Gijs
  part 6: create a simple api for addons to add to reader mode, r=Gijs
  part 7: various test fixes related to cui behaviour and pocket, r=me
2015-12-29 15:40:52 -08:00
Shu-yu Guo
37989840cd Bug 1202902 - Mass replace toplevel 'let' with 'var' in preparation for global lexical scope. (rs=jorendorff) 2015-09-15 11:19:45 -07:00
Gijs Kruitbosch
412038a00a Bug 1182778, r=margaret,f=bz 2015-07-17 13:30:42 +01:00
Mark Hammond
7699a33252 Bug 1184005 - Remove readinglist. r=MattN,jaws,adw 2015-08-04 12:00:43 +10:00
Matthew Noorenberghe
556e2eb79c Bug 1134507 - Implement infopanel to promote Reader View when first available. r=jaws/Gijs
Based on a patch by Jared Wein (:jaws).
2015-04-30 13:43:47 -07:00
Jared Wein
c88c426522 Bug 1158960 - Reader view is broken in e10s mode. r=Gijs 2015-04-27 18:29:18 -04:00
Jared Wein
7cf654c3e7 Bug 1155523 - Implement Pocket toolbarbutton and subview. r=gijs 2015-04-24 14:29:05 -04:00
Jared Wein
2fd2750f7a Bug 1155304 - Right-clicking the reading list + button (in URL bar), shouldn't add the page to the reading list. r=gijs 2015-04-16 14:40:18 -04:00
Jared Wein
bd11c08616 Bug 1134501 - UITour: Force page into Reader View automatically whenever the ReaderView/ReadingList tour page is loaded. r=gijs 2015-04-15 23:45:50 -04:00
Phil Ringnalda
50fd13c868 Back out 364bc6209cc5 (bug 1134501) for jetpack bustage 2015-04-15 22:08:20 -07:00
Jared Wein
93a0f2c0b0 Bug 1134501 - UITour: Force page into Reader View automatically whenever the ReaderView/ReadingList tour page is loaded. r=gijs 2015-04-15 23:45:50 -04:00
Gijs Kruitbosch
5376266d08 Bug 1134501 - add way for UITour'd page to force-show the reader mode button, r=margaret 2015-04-13 20:12:57 +01:00