By showing users an upsell, positioned as a feature, as part of the save confirmation and make it easy for users to get the mobile app, more users will understand the value of the Pocket mobile and start using the mobile app.
The initial experiment will target existing logged in English users only.
We've added flags to the server response on the save request that:
- Set whether the user has the mobile app
- Which variant of the experiment the user should be enrolled in
If the user has an account, but they've never installed the Android or iOS app, we will display a new button inline in the current panel that will email a link to the mobile application to the user.
MozReview-Commit-ID: 2xtPv5GPVbL
***
Bug 1451840 - Add button to Pocket doorhanger to request mobile app
- Specified default color on buttons
- Removed unnecessary css styles
- Resized icon display size
- Made RTL friendly
- Simplified SVGs
- Updated buttons to be html buttons for screen readers
MozReview-Commit-ID: HdTi1CZbXdc
By showing users an upsell, positioned as a feature, as part of the save confirmation and make it easy for users to get the mobile app, more users will understand the value of the Pocket mobile and start using the mobile app.
The initial experiment will target existing logged in English users only.
We've added flags to the server response on the save request that:
- Set whether the user has the mobile app
- Which variant of the experiment the user should be enrolled in
If the user has an account, but they've never installed the Android or iOS app, we will display a new button inline in the current panel that will email a link to the mobile application to the user.
MozReview-Commit-ID: 2xtPv5GPVbL
***
Bug 1451840 - Add button to Pocket doorhanger to request mobile app
- Specified default color on buttons
- Removed unnecessary css styles
- Resized icon display size
- Made RTL friendly
- Simplified SVGs
- Updated buttons to be html buttons for screen readers
MozReview-Commit-ID: HdTi1CZbXdc
By showing users an upsell, positioned as a feature, as part of the save confirmation and make it easy for users to get the mobile app, more users will understand the value of the Pocket mobile and start using the mobile app.
The initial experiment will target existing logged in English users only.
We've added flags to the server response on the save request that:
- Set whether the user has the mobile app
- Which variant of the experiment the user should be enrolled in
If the user has an account, but they've never installed the Android or iOS app, we will display a new button inline in the current panel that will email a link to the mobile application to the user.
MozReview-Commit-ID: 2xtPv5GPVbL
***
Bug 1451840 - Add button to Pocket doorhanger to request mobile app
- Specified default color on buttons
- Removed unnecessary css styles
- Resized icon display size
- Made RTL friendly
- Simplified SVGs
- Updated buttons to be html buttons for screen readers
MozReview-Commit-ID: HdTi1CZbXdc
The animations on the pocket-button and library-button are disabled if they are not in the nav-bar due to issues with getting overflow:hidden and position:absolute to work the same way outside of #nav-bar. This is on file as bug 1382894.
MozReview-Commit-ID: Lq20GuocMkg
The animations on the pocket-button and library-button are disabled if they are not in the nav-bar due to issues with getting overflow:hidden and position:absolute to work the same way outside of #nav-bar. This is on file as bug 1382894.
MozReview-Commit-ID: Lq20GuocMkg
Running eslint with --fix didn't fix many of the issues. The majority here had to be fixed by hand but a significant majority of the issues were related to a few files that I was able to use find-and-replace with. I regret not making this in to separate commits of the hand-fixes and the fixes from --fix but I don't recall --fix fixing any of the issues.
MozReview-Commit-ID: ANyg2qfo3Qx
In cases, where the caller is looking for the locale to be used for JS Intl API,
we can now replace it with `undefined` which causes JS Intl API to use the default
locale which since bug 1346674 is resolved to the app locale.
This allows us to remove a lot of calls for the app locale.
The remaining ones are split between `AsBCP47` and `AsLangTag`.
Here, the `AsLangTag` is used, as described in the API docs, for cases where
the language string is used for localization purposes, such as language negotaition
matching to our language resources etc.
`AsBCP47` is used when the returned value is handed over to ICU API.
MozReview-Commit-ID: DzmFEUvMq3N
In cases, where the caller is looking for the locale to be used for JS Intl API,
we can now replace it with `undefined` which causes JS Intl API to use the default
locale which since bug 1346674 is resolved to the app locale.
This allows us to remove a lot of calls for the app locale.
The remaining ones are split between `AsBCP47` and `AsLangTag`.
Here, the `AsLangTag` is used, as described in the API docs, for cases where
the language string is used for localization purposes, such as language negotaition
matching to our language resources etc.
`AsBCP47` is used when the returned value is handed over to ICU API.
MozReview-Commit-ID: DzmFEUvMq3N
