Commit Graph

103 Commits

Author SHA1 Message Date
Kris Maglione
0847e8227e Bug 1464548: Part 3 - Update callers to use defineLazyGlobalGetters. r=mccr8
MozReview-Commit-ID: 9APGewiDDYB
2018-05-25 17:02:29 -07:00
Jonathan Kingston
c9c163f346 Bug 1465160 - Pass null principal to view image. r=ckerschb, r=Gijs 2018-05-30 00:42:50 +01:00
anthony
9612953a32 Bug 1451840 - Add button to Pocket doorhanger to request mobile app r=Gijs
By showing users an upsell, positioned as a feature, as part of the save confirmation and make it easy for users to get the mobile app, more users will understand the value of the Pocket mobile and start using the mobile app.

The initial experiment will target existing logged in English users only.

We've added flags to the server response on the save request that:
- Set whether the user has the mobile app
- Which variant of the experiment the user should be enrolled in

If the user has an account, but they've never installed the Android or iOS app, we will display a new button inline in the current panel that will email a link to the mobile application to the user.

MozReview-Commit-ID: 2xtPv5GPVbL
***
Bug 1451840 - Add button to Pocket doorhanger to request mobile app
- Specified default color on buttons
- Removed unnecessary css styles
- Resized icon display size
- Made RTL friendly
- Simplified SVGs
- Updated buttons to be html buttons for screen readers

MozReview-Commit-ID: HdTi1CZbXdc
2018-05-17 14:12:02 -07:00
Noemi Erli
627fe8d5e9 Backed out changeset f5cbef593cc1 (bug 1451840) for failures in browser/base/content/test/static/browser_parsable_css.js on a CLOSED TREE 2018-05-21 20:43:31 +03:00
anthony
141b6bb12d Bug 1451840 - Add button to Pocket doorhanger to request mobile app r=Gijs
By showing users an upsell, positioned as a feature, as part of the save confirmation and make it easy for users to get the mobile app, more users will understand the value of the Pocket mobile and start using the mobile app.

The initial experiment will target existing logged in English users only.

We've added flags to the server response on the save request that:
- Set whether the user has the mobile app
- Which variant of the experiment the user should be enrolled in

If the user has an account, but they've never installed the Android or iOS app, we will display a new button inline in the current panel that will email a link to the mobile application to the user.

MozReview-Commit-ID: 2xtPv5GPVbL
***
Bug 1451840 - Add button to Pocket doorhanger to request mobile app
- Specified default color on buttons
- Removed unnecessary css styles
- Resized icon display size
- Made RTL friendly
- Simplified SVGs
- Updated buttons to be html buttons for screen readers

MozReview-Commit-ID: HdTi1CZbXdc
2018-05-17 14:12:02 -07:00
Dorel Luca
e572fa7a74 Backed out changeset 2eba9608447d (bug 1451840) for linting failure. CLOSED TREE 2018-05-18 11:31:33 +03:00
anthony
e9bc99160a Bug 1451840 - Add button to Pocket doorhanger to request mobile app r=Gijs
By showing users an upsell, positioned as a feature, as part of the save confirmation and make it easy for users to get the mobile app, more users will understand the value of the Pocket mobile and start using the mobile app.

The initial experiment will target existing logged in English users only.

We've added flags to the server response on the save request that:
- Set whether the user has the mobile app
- Which variant of the experiment the user should be enrolled in

If the user has an account, but they've never installed the Android or iOS app, we will display a new button inline in the current panel that will email a link to the mobile application to the user.

MozReview-Commit-ID: 2xtPv5GPVbL
***
Bug 1451840 - Add button to Pocket doorhanger to request mobile app
- Specified default color on buttons
- Removed unnecessary css styles
- Resized icon display size
- Made RTL friendly
- Simplified SVGs
- Updated buttons to be html buttons for screen readers

MozReview-Commit-ID: HdTi1CZbXdc
2018-05-17 14:12:02 -07:00
Kris Maglione
fd7e9e6a69 Bug 1456035: Part 4 - Convert callers of XPCOMUtils.generateQI to ChromeUtils.generateQI. r=mccr8
This also removes any redundant Ci.nsISupports elements in the interface
lists.

This was done using the following script:

acecb401b7/processors/chromeutils-generateQI.jsm

MozReview-Commit-ID: AIx10P8GpZY
2018-04-22 20:55:06 -07:00
Kris Maglione
b3990a2d91 Bug 1456686: Part 1 - Fix unused and shadowed explicit imports. r=standard8
These issues were previously ignored due to the nature of our global import
rules. They need to be fixed before that rule can be updated.

MozReview-Commit-ID: DCChktTc5TW
2018-04-24 20:18:09 -07:00
Jonathan Kingston
9b880fdc20 Bug 1374741 - Within browser/ make openUILinkIn() provide the correct triggeringPrincipal. r=gijs
MozReview-Commit-ID: 1NQrlWzIBja
2018-02-21 14:28:48 +00:00
Mark Banner
ec9360ee83 Bug 1434446 - Enable no-unused-vars for global scope on jsm files in browser/. r=mossop
MozReview-Commit-ID: ERT1Fili25d
2018-03-01 20:06:06 +00:00
Ursula Sarracini
3d6b4acf5c Bug 1441931 - Use open_url provided by Pocket for 'saved to pocket' items in highlights r=Mardak
MozReview-Commit-ID: 5St8NablevZ
2018-02-28 14:16:46 -05:00
Florian Quèze
f6add2cafd Bug 1433175 - scripted patch to replace Components.classes[, Components.interfaces.nsI, Components.utils. and Components.results. with Cc, Ci, Cu and Cr, r=Mossop. 2018-02-28 18:51:33 +01:00
Florian Quèze
f1a55f73f8 Bug 1440284 - change this.EXPORTED_SYMBOLS back to var EXPORTED_SYMBOLS in JS modules, r=mccr8. 2018-02-23 20:50:01 +01:00
Ursula Sarracini
e5547ea230 Bug 1438658 - Allow pktApi.jsm to archive an item r=Mardak
MozReview-Commit-ID: JoTzYy84ZI5
2018-02-16 11:38:37 -05:00
Thomas Wisniewski
345e6bb83b Bug 792808 - Change pktApi.jsm to import and instantiate XHRs from global properties rather than using Cc.createInstance(Ci.nsIXMLHttpRequest); r=Gijs
MozReview-Commit-ID: 8jdzIb95MmB
2017-09-19 12:18:20 -04:00
Timothy Guan-tin Chien
f08391ee76 Bug 1234008 - Recompress some png images with zopflipng r=Dolske,Grisha,jryans
MozReview-Commit-ID: Cr2iMSB04uu
2018-01-27 15:57:42 +08:00
Andrew McCreight
272cee1e65 Bug 1432992, part 1 - Remove definitions of Ci, Cr, Cc, and Cu. r=florian
This patch was autogenerated by my decomponents.py

It covers almost every file with the extension js, jsm, html, py,
xhtml, or xul.

It removes blank lines after removed lines, when the removed lines are
preceded by either blank lines or the start of a new block. The "start
of a new block" is defined fairly hackily: either the line starts with
//, ends with */, ends with {, <![CDATA[, """ or '''. The first two
cover comments, the third one covers JS, the fourth covers JS embedded
in XUL, and the final two cover JS embedded in Python. This also
applies if the removed line was the first line of the file.

It covers the pattern matching cases like "var {classes: Cc,
interfaces: Ci, utils: Cu, results: Cr} = Components;". It'll remove
the entire thing if they are all either Ci, Cr, Cc or Cu, or it will
remove the appropriate ones and leave the residue behind. If there's
only one behind, then it will turn it into a normal, non-pattern
matching variable definition. (For instance, "const { classes: Cc,
Constructor: CC, interfaces: Ci, utils: Cu } = Components" becomes
"const CC = Components.Constructor".)

MozReview-Commit-ID: DeSHcClQ7cG
2018-02-06 09:36:57 -08:00
Gijs Kruitbosch
c56562d0bf Bug 1435217 - remove vestiges of dead pocket toolbar/panel button and always-hidden bookmarks menu button panel menu item, r=jaws
MozReview-Commit-ID: 9V7w9VnTZTN
2018-02-02 11:54:24 +00:00
Florian Quèze
c5f15a4700 Bug 1339461 - script-generated patch to convert foo.indexOf(...) == -1 to foo.includes(), r=Mossop. 2018-02-01 20:45:22 +01:00
Kris Maglione
0bb74efdf1 Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm

MozReview-Commit-ID: 1Nc3XDu0wGl
2018-01-29 15:20:18 -08:00
Ursula Sarracini
0b7f95edab Bug 1432659 - Expose Pocket API to get your pocket stream r=csadilek
MozReview-Commit-ID: B3mbvCaLQw7
2018-01-29 16:57:32 -05:00
Ian Moody
bb5c160f69 Bug 1426833 - Update Fx logos in Pocket extension to Photon versions. r=Gijs
MozReview-Commit-ID: FqIkd498ull
2017-12-20 00:50:06 +00:00
Mark Banner
5ab2bd1b7a Bug 1421376 - Change various instances of manually calling getService to use Services.jsm in browser/. r=mossop
MozReview-Commit-ID: FW3X2fkOwK2
2017-11-28 19:21:33 +00:00
Valentin Gosu
01fa9dd0ad Bug 1407720 - Merge nsICookieManager and nsICookieManager2 r=nwgh
MozReview-Commit-ID: HuzeeB43YZZ
2017-10-31 13:02:28 +01:00
Mark Banner
e47ccbfec3 Bug 1411368 - Automatically fix no-multi-spaces issues raised when using ESLint 4. r=mossop
MozReview-Commit-ID: H5YVp3rnzGo
2017-10-26 11:47:01 +01:00
Dan Banner
5af4450327 Bug 1408777 - Automatically fix instances of missing semicolons in the tree. r=Standard8
MozReview-Commit-ID: Jm8BRgt6mIv
2017-10-15 20:50:39 +01:00
Gijs Kruitbosch
8030db146a Bug 1389721 - fix page action menu to deal with not being passed an event, so the 'save link to pocket' context menu works, r=jaws
This also removes the now-obsolete onBeforeCommand method from the pocket code.

MozReview-Commit-ID: EjrMoAIv3xw
2017-10-02 20:34:01 +01:00
Gijs Kruitbosch
8f3750d0d6 Bug 1375806 - don't overwrite the current non-empty tab when viewing pocket list, r=mixedpuppy
This moves the logic into Pocket.jsm, and first determines the right place based on modifiers etc.
using whereToOpenLink. If that returns 'current', we override with 'tab' if and only if the current
tab is non-empty (so we'll reuse about:blank or about:newtab, but not tabs with a website / history).

MozReview-Commit-ID: H64bREBn8OU
2017-08-23 23:31:19 +01:00
Drew Willcoxon
062e2f296c Bug 1385418 - Remove disabled pocket code for the toolbar button now that it's been replaced by the item in the page action panel. r=Gijs
MozReview-Commit-ID: 1wANxaD3QaV
2017-08-16 10:13:15 -07:00
Jared Wein
a080e2809f Bug 1387077 - Reimplement Pocket animation in the Page Action area. r=adw
MozReview-Commit-ID: 5pJ96un8W5t
2017-08-08 11:56:49 -04:00
Wes Kocher
d497d08bc6 Backed out changeset d4cc2f1e5c48 (bug 1387077) for windows debug crashtest failures a=backout
MozReview-Commit-ID: kEMoucDCJY
2017-08-10 15:46:38 -07:00
Jared Wein
bb3b0a581d Bug 1387077 - Reimplement Pocket animation in the Page Action area. r=adw
MozReview-Commit-ID: 5pJ96un8W5t
2017-08-08 11:56:49 -04:00
Rajesh Kathiriya
fefc455410 Bug 1374620 - Enabled the ESLint dot-notation rule across mozilla-central r=standard8
MozReview-Commit-ID: FadrI2li43G
2017-07-25 23:45:41 +05:30
Drew Willcoxon
1840617556 Bug 1367927 - Add a "save to pocket" item to the page action menu. r=mixedpuppy
MozReview-Commit-ID: APmutOUh2Q6
2017-08-01 10:17:00 -07:00
Sebastian Hengst
1326418a49 Backed out changeset f5922a7ed25a (bug 1374620) for failing eslint at telemetry/tests/unit/test_TelemetrySend.js:358: ["os"] is better written in dot notation. r=backout 2017-07-31 14:44:34 +02:00
Rajesh Kathiriya
0d920ece6a Bug 1374620 - Enabled the ESLint dot-notation rule across mozilla-central r=standard8
MozReview-Commit-ID: FadrI2li43G
2017-07-25 23:45:41 +05:30
Jared Wein
098efc3f24 Bug 1383886 - Remove redundant element.closest() call since one call to closest() can do the work that was previously done by two calls to closest() and a property check. r=Gijs
MozReview-Commit-ID: L6weawO4qB0
2017-07-24 16:27:10 -04:00
Jared Wein
a1fe16741b Bug 1383882 - Don't show the Pocket library animation if the Pocket page was removed. r=Gijs
MozReview-Commit-ID: D6xsPEUIC96
2017-07-24 16:16:56 -04:00
Michael Kaply
7c1b81a087 Bug 1383848 - Null check library button since it's not there by default. r=jaws
MozReview-Commit-ID: 4IRASZc5icm
2017-07-24 13:58:43 -05:00
Jared Wein
7feb3f7139 Bug 1355922 - Save to Pocket should have an associated animation. r=Gijs
The animations on the pocket-button and library-button are disabled if they are not in the nav-bar due to issues with getting overflow:hidden and position:absolute to work the same way outside of #nav-bar. This is on file as bug 1382894.

MozReview-Commit-ID: Lq20GuocMkg
2017-07-21 18:00:01 -04:00
Wes Kocher
05e579c0fb Backed out changeset d4b7fc921b88 (bug 1355922) for assertions in test_display_mode.html a=backout
MozReview-Commit-ID: GQh4DRTEUJI
2017-07-21 00:36:41 -07:00
Jared Wein
a13c276668 Bug 1355922 - Save to Pocket should have an associated animation. r=Gijs
The animations on the pocket-button and library-button are disabled if they are not in the nav-bar due to issues with getting overflow:hidden and position:absolute to work the same way outside of #nav-bar. This is on file as bug 1382894.

MozReview-Commit-ID: Lq20GuocMkg
2017-07-20 09:59:22 -04:00
Rajesh Kathiriya
bfb3762076 Bug 1374670 - Enabled the ESLint no-tabs rule across mozilla-central r=standard8
MozReview-Commit-ID: RT5QTipaOW
2017-07-04 21:30:18 +05:30
Andrea Marchesini
a64229ff92 Bug 1369323 - Get rid of nsScriptSecurityManager::GetNoAppCodebasePrincipal, r=bholley 2017-06-02 11:05:28 +02:00
Gijs Kruitbosch
1c0b6f626b Bug 1354155 - fix pocket button's checks for whether it is the mainview in a panelmultiview, r=mikedeboer
MozReview-Commit-ID: 6kLNAtOmCjn
2017-05-30 16:29:45 +01:00
Honza Bambas
f3b5a77a73 backout of f9abb9c83452 (bug 1319111) for crashes, r=bz 2017-05-13 13:55:11 +02:00
Wes Kocher
7b49a483cc Backed out changeset 95ff98f1c2e5 (bug 1319111) for talos failures a=backout
MozReview-Commit-ID: Gs09moFm5rQ
2017-05-12 18:24:42 -07:00
Honza Bambas
b05b600614 backout of f9abb9c83452 (bug 1319111) for crashes, r=bz 2017-05-12 22:13:49 +02:00
Honza Bambas
e8227e774f Bug 1319111 - Expose URI to make security check against on LoadInfo (no LOAD_REPLACE flag). r=bz 2017-01-27 19:10:01 +01:00