Commit Graph

234 Commits

Author SHA1 Message Date
Emilio Cobos Álvarez
9b59aad7c6 Bug 1464782: Update references to offset-* properties in the rest of the tree. r=xidorn
MozReview-Commit-ID: AOMoLSJKySy
2018-06-27 16:12:02 +02:00
Erica Wright
d248a1d666 Bug 1448918 - Create about:welcome page in preparation for firstrun migration. r=dmose
MozReview-Commit-ID: L34uRsOeziS
2018-04-23 15:47:57 -04:00
Ricky Rosario
a1cabc5a7a Bug 1456496 - dark theme for onboarding snippets r=k88hudson
MozReview-Commit-ID: CqprUlxd2IZ
2018-04-26 12:51:42 -04:00
Kris Maglione
b3990a2d91 Bug 1456686: Part 1 - Fix unused and shadowed explicit imports. r=standard8
These issues were previously ignored due to the nature of our global import
rules. They need to be fixed before that rule can be updated.

MozReview-Commit-ID: DCChktTc5TW
2018-04-24 20:18:09 -07:00
Ricky Rosario
e5ac4d843f Bug 1449651 - Apply dark theme style to onboarding overlay and icon r=Mardak
MozReview-Commit-ID: Dr1pnNhocuy
2018-04-17 18:14:59 -04:00
Kris Maglione
c023b56e44 Bug 1440747: Don't load onboarding frame script into every frameloader. r=Gijs
Loading this script into every frameloader wasts a massive amount of memory in
every content process, even though it's only needed when we load about:home or
about:newtab.

MozReview-Commit-ID: 5YtEKLGVX4
2018-02-23 13:53:19 -05:00
Kris Maglione
3e28bf5cba Bug 1446585: Remove support for resource entries in bootstrapped chrome.manifest files. r=aswan,MattN,k88hudson
MozReview-Commit-ID: EjymzU6koYX
2018-03-16 20:18:46 -07:00
Tooru Fujisawa
f415c74b57 Bug 1442465 - Part 4.2: Stop unnecessarily awaiting on BrowserTestUtils.removeTab (simple part). r=dao 2018-03-19 11:16:45 +09:00
Kris Maglione
9d5b9190a5 Bug 1443964: Part 3 - Remove no-cpows-in-tests rule. r=mconley
The shims that this rule tests for no longer exist.

MozReview-Commit-ID: DMgP7Hczavc
2018-03-07 19:31:28 -08:00
Kris Maglione
c52d401bb4 Bug 1445551: Part 1b - Whitelist unsafe CPOW use in existing tests. r=mconley
MozReview-Commit-ID: 4ojwvjw9XGT
2018-03-14 14:35:05 -07:00
Matthew Noorenberghe
719d5ef030 Bug 1443632 - Change screenshots tour action button back to an <a>. r=kitcambridge
MozReview-Commit-ID: DeEWxnurLty
2018-03-09 17:58:18 -08:00
Masayuki Nakano
2d0037adc3 Bug 1441144 - Make browser/extensions/onboarding/content/onboarding.js handle non-printable keys with "keydown" event listener rather than "keypress" event listener r=mossop
We'll stop dispatching "keypress" event for non-printable keys and key
combinations in the default event group of web content.  Therefore,
onbording.js needs to stop handling some keys with "keypress" event listener.

This patch makes add a "keydown" event listener, handleKeydown(), and make it
handle only non-printable keys.  Note that we'll keep dispatching "keypress"
event for " " and "Enter".  So, we can keep handling them in "keypress"
event listener.

MozReview-Commit-ID: 1jFIv9N03fa
2018-02-26 22:37:11 +09:00
arthur.iakab
2b97944452 Merge mozilla-central to mozilla-inbound 2018-02-27 12:05:43 +02:00
Frederik Braun
de32e8cf24 Bug 1433929 - Replace all innerHTML usage in the onboarding extension. r=Gijs
MozReview-Commit-ID: HY9JsBb7sFQ
2018-02-16 12:34:27 +01:00
Florian Quèze
f1a55f73f8 Bug 1440284 - change this.EXPORTED_SYMBOLS back to var EXPORTED_SYMBOLS in JS modules, r=mccr8. 2018-02-23 20:50:01 +01:00
Edouard Oger
1a12c1fce4 Bug 1434706 - Add identity.fxaccounts.enabled pref to disable Sync and FxA. r=markh
MozReview-Commit-ID: 4UuppJyOi5s
2018-02-15 11:24:44 +08:00
Csoregi Natalia
5f4a31b802 Backed out changeset 22901b9f9199 (bug 1434706) for browser-chrome failures browser_contextmenu_sendtab.js. CLOSED TREE 2018-02-26 21:16:01 +02:00
Edouard Oger
cf78f22e8e Bug 1434706 - Add identity.fxaccounts.enabled pref to disable Sync and FxA. r=markh
MozReview-Commit-ID: 4UuppJyOi5s
2018-02-15 11:24:44 +08:00
Edouard Oger
38f2126fa5 Bug 1438451 - Query UIState.jsm instead of FxAccounts in sync onboarding code. r=markh
MozReview-Commit-ID: 4pXFTqDiIbS
2018-02-21 16:15:05 +08:00
Ed Lee
750f3fa273 Bug 1433324 - Part 3. Assume true for browser.newtabpage.activity-stream.enabled. r=ursula
MozReview-Commit-ID: KMgNw5QsMIX
2018-02-13 16:53:50 -08:00
Michael Kohler
c99b6fa1e5 Bug 1419996 - remove NEW_TABLE flag and legacy code for the onboarding telemetry r=Fischer,francois
MozReview-Commit-ID: Lb8G8DXRdeh
2018-01-31 19:48:56 +01:00
Andrew McCreight
272cee1e65 Bug 1432992, part 1 - Remove definitions of Ci, Cr, Cc, and Cu. r=florian
This patch was autogenerated by my decomponents.py

It covers almost every file with the extension js, jsm, html, py,
xhtml, or xul.

It removes blank lines after removed lines, when the removed lines are
preceded by either blank lines or the start of a new block. The "start
of a new block" is defined fairly hackily: either the line starts with
//, ends with */, ends with {, <![CDATA[, """ or '''. The first two
cover comments, the third one covers JS, the fourth covers JS embedded
in XUL, and the final two cover JS embedded in Python. This also
applies if the removed line was the first line of the file.

It covers the pattern matching cases like "var {classes: Cc,
interfaces: Ci, utils: Cu, results: Cr} = Components;". It'll remove
the entire thing if they are all either Ci, Cr, Cc or Cu, or it will
remove the appropriate ones and leave the residue behind. If there's
only one behind, then it will turn it into a normal, non-pattern
matching variable definition. (For instance, "const { classes: Cc,
Constructor: CC, interfaces: Ci, utils: Cu } = Components" becomes
"const CC = Components.Constructor".)

MozReview-Commit-ID: DeSHcClQ7cG
2018-02-06 09:36:57 -08:00
Kris Maglione
0bb74efdf1 Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm

MozReview-Commit-ID: 1Nc3XDu0wGl
2018-01-29 15:20:18 -08:00
Cosmin Sabou
f09d6d985d Backed out 3 changesets (bug 1431533) for Android mochitest failures on testEventDispatcher on a CLOSED TREE
Backed out changeset a1eca62826a1 (bug 1431533)
Backed out changeset 34c999fa006b (bug 1431533)
Backed out changeset e2674287e57f (bug 1431533)
2018-01-30 07:17:48 +02:00
Kris Maglione
fd67f090b2 Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm

MozReview-Commit-ID: 1Nc3XDu0wGl
2018-01-29 15:20:18 -08:00
Brindusan Cristian
483ba301cb Backed out 2 changesets (bug 1431533) for ESlint failures on a CLOSED TREE
Backed out changeset 6e56f4c8843e (bug 1431533)
Backed out changeset 12fc4dee861c (bug 1431533)
2018-01-30 02:32:43 +02:00
Kris Maglione
683a97d172 Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm

MozReview-Commit-ID: 1Nc3XDu0wGl
2018-01-29 15:20:18 -08:00
Fred Lin
78ba1b5ee6 Bug 1413830 - Data schema change for onboarding telemetry;r=fischer,francois
Implement new processPings and _sendPing, handle sessions via registerNewOnboardingSession
This patch covers all new events except onboarding-noshow-smallscreen and overlay-disapear-resize events will be implemented in bug 1417769

MozReview-Commit-ID: 3jNAmOcrvEa
2018-01-15 15:32:46 +08:00
Gurzau Raul
3413b63671 Backed out changeset b78d2b24b741 (bug 1413830) for leaking test/about/browser_aboutHome_search_telemetry.js r=backout 2018-01-10 12:02:53 +02:00
Fred Lin
ccf8eb91cd Bug 1413830 - Data schema change for onboarding telemetry;r=Fischer,francois
Implement new processPings and _sendPing, handle sessions via registerNewOnboardingSession
This patch covers all new events except onboarding-noshow-smallscreen and overlay-disapear-resize events will be implemented in bug 1417769

MozReview-Commit-ID: 3jNAmOcrvEa
2017-10-31 12:01:30 +08:00
Dorel Luca
fd7a562fd6 Backed out changeset 8ba13ef1fec4 (bug 1413830) for failing Browser-chrome on accessible/tests/browser/events/browser_test_focus_browserui.js r=backout on a CLOSED TREE 2018-01-08 16:15:38 +02:00
Fred Lin
54349daa77 Bug 1413830 - Data schema change for onboarding telemetry;r=Fischer,francois
Implement new processPings and _sendPing, handle sessions via registerNewOnboardingSession
This patch covers all new events except onboarding-noshow-smallscreen and overlay-disapear-resize events will be implemented in bug 1417769

MozReview-Commit-ID: 3jNAmOcrvEa
2017-10-31 12:01:30 +08:00
Florian Quèze
1838aa9e08 Bug 1421992 - script-generated patch to replace do_execute_soon, do_print and do_register_cleanup with executeSoon, info and registerCleanupFunction, rs=Gijs. 2017-12-21 11:10:23 +01:00
Florian Quèze
082ca8b2a3 Bug 1421992 - script-generated patch to replace do_check_* functions with their Assert.* equivalents, rs=Gijs. 2017-12-21 11:08:17 +01:00
Edouard Oger
c34b8c229e Bug 1420193 - Add Connect Another Device button to Sync onboarding panel. r=markh,mossop
MozReview-Commit-ID: 7M6JMJALz2j
2017-11-23 12:17:37 -05:00
Bill McCloskey
142c9a9dbb Bug 1412456 - Test changes to no longer use interposition (r=felipe,bgrins,mrbkap)
MozReview-Commit-ID: 2nQPOSGTr1s
2017-12-07 12:55:24 -08:00
Andreea Pavel
26ac595cba Backed out 9 changesets (bug 1412456) for crashing talos g2 and unexpected network connections in browser-chrome's browser_searchEngine_behaviors.js r=backout a=backout on a CLOSED TREE
Backed out changeset 0c01a98f4fd5 (bug 1412456)
Backed out changeset 27077db47231 (bug 1412456)
Backed out changeset f35ec2a884f8 (bug 1412456)
Backed out changeset 602b30ac3c69 (bug 1412456)
Backed out changeset b1ff1050c589 (bug 1412456)
Backed out changeset f100d953f9eb (bug 1412456)
Backed out changeset d85af60fe259 (bug 1412456)
Backed out changeset 736f38486832 (bug 1412456)
Backed out changeset 13a637602dc2 (bug 1412456)
2017-12-07 12:20:21 +02:00
Bill McCloskey
427710d960 Bug 1412456 - Test changes to no longer use interposition (r=felipe,bgrins,mrbkap)
MozReview-Commit-ID: 2nQPOSGTr1s
2017-12-06 21:17:05 -08:00
Dorel Luca
81b4b85d01 Backed out 8 changesets (bug 1412456) for ESlint failure on browser_urlbarKeepStateAcrossTabSwitches.js:13:49 r=backout on a CLOSED TREE
Backed out changeset 0e88de036c55 (bug 1412456)
Backed out changeset 49b93f807db0 (bug 1412456)
Backed out changeset 039e980b7dc6 (bug 1412456)
Backed out changeset c7698410ddbd (bug 1412456)
Backed out changeset e56a1ba26b7c (bug 1412456)
Backed out changeset 0c4506e124ac (bug 1412456)
Backed out changeset a7aec2ce903b (bug 1412456)
Backed out changeset 3e9fb71f1e8e (bug 1412456)
2017-12-07 07:09:33 +02:00
Bill McCloskey
a0f07d3df7 Bug 1412456 - Test changes to no longer use interposition (r=felipe,bgrins,mrbkap)
MozReview-Commit-ID: 2nQPOSGTr1s
2017-12-06 20:46:58 -08:00
Fred Lin
53211ff502 Bug 1418167 - validate data before send for onboarding telemetry;r=Fischer
Implement basic validation for new table events and columns, report the incorrect fields.
The change is protected by NEW_TABLE flag so not effect the current telemetry.

MozReview-Commit-ID: 78K551g0nRj
2017-11-17 10:53:46 +08:00
Ed Lee
546ee3d2bf Bug 1417017 - Check for content. usage at global and within add_task for no-cpows-in-tests. r=standard8
MozReview-Commit-ID: Asz6dM29uRJ
2017-11-14 02:17:57 -08:00
Fred Lin
eec24adb9f Bug 1418191 - not send the CTA telemetry event ping when instant complete;r=Fischer
MozReview-Commit-ID: 9KJazfZqviT
2017-11-21 13:12:56 +08:00
Fischer.json
f12e7e519f Bug 1414721 - Colors of Onboarding nav icons are inconsistent, r=gasolin
Previously we used background images to display tour icons on the nav list and on the tour notification. This caused two pitfalls: First, if fill colors were different inside svg icons, we would see inconsistent tour icon colors. Second, for one tour icon there would need two svg files.

This patch switches to the mask-image approach, which makes a icon svg as a mask filtering the background color beneath, so we can unify icon colors by the external css and remove extra colored svg files.

MozReview-Commit-ID: ErXexz15y8F
2017-11-09 11:11:50 +08:00
Fred Lin
2e4e4c6bd2 Bug 1412761 - copy editing;r=Fischer
MozReview-Commit-ID: LDZFo94cMNZ
2017-11-01 09:55:09 +08:00
Fred Lin
727c9bcd8f Bug 1412761 - remove dup test case;r=Fischer
MozReview-Commit-ID: 9MLGQI3SiIf
2017-11-01 09:54:13 +08:00
Fred Lin
1fd5cefa4c Bug 1412164 - add tour_type and timestamp column for onboarding telemetry;r=Fischer,liuche
MozReview-Commit-ID: aqeoxjR7Tu
2017-10-27 10:20:34 +08:00
Mark Banner
cfa9659d1d Bug 1412778 - Enable ESLint rule no-cpows-in-tests across the whole tree. r=florian
MozReview-Commit-ID: 8pidN7x6MYh
2017-10-30 09:55:39 +00:00
Fred Lin
b5278e9f10 Bug 1409977 - mark Onboarding tour will set as completed instantly via define a tour property;r=Fischer
MozReview-Commit-ID: 4zsPzXieZap
2017-10-30 10:44:39 +08:00
gasolin
8c02bfbd6c Bug 1404193 - enable customizable logo, speech bubble string, and hide the skip tour button;r=Fischer
MozReview-Commit-ID: 1VjDxOeYPem
2017-10-25 18:16:19 +08:00