These issues were previously ignored due to the nature of our global import
rules. They need to be fixed before that rule can be updated.
MozReview-Commit-ID: DCChktTc5TW
Loading this script into every frameloader wasts a massive amount of memory in
every content process, even though it's only needed when we load about:home or
about:newtab.
MozReview-Commit-ID: 5YtEKLGVX4
We'll stop dispatching "keypress" event for non-printable keys and key
combinations in the default event group of web content. Therefore,
onbording.js needs to stop handling some keys with "keypress" event listener.
This patch makes add a "keydown" event listener, handleKeydown(), and make it
handle only non-printable keys. Note that we'll keep dispatching "keypress"
event for " " and "Enter". So, we can keep handling them in "keypress"
event listener.
MozReview-Commit-ID: 1jFIv9N03fa
This patch was autogenerated by my decomponents.py
It covers almost every file with the extension js, jsm, html, py,
xhtml, or xul.
It removes blank lines after removed lines, when the removed lines are
preceded by either blank lines or the start of a new block. The "start
of a new block" is defined fairly hackily: either the line starts with
//, ends with */, ends with {, <![CDATA[, """ or '''. The first two
cover comments, the third one covers JS, the fourth covers JS embedded
in XUL, and the final two cover JS embedded in Python. This also
applies if the removed line was the first line of the file.
It covers the pattern matching cases like "var {classes: Cc,
interfaces: Ci, utils: Cu, results: Cr} = Components;". It'll remove
the entire thing if they are all either Ci, Cr, Cc or Cu, or it will
remove the appropriate ones and leave the residue behind. If there's
only one behind, then it will turn it into a normal, non-pattern
matching variable definition. (For instance, "const { classes: Cc,
Constructor: CC, interfaces: Ci, utils: Cu } = Components" becomes
"const CC = Components.Constructor".)
MozReview-Commit-ID: DeSHcClQ7cG
Implement new processPings and _sendPing, handle sessions via registerNewOnboardingSession
This patch covers all new events except onboarding-noshow-smallscreen and overlay-disapear-resize events will be implemented in bug 1417769
MozReview-Commit-ID: 3jNAmOcrvEa
Implement new processPings and _sendPing, handle sessions via registerNewOnboardingSession
This patch covers all new events except onboarding-noshow-smallscreen and overlay-disapear-resize events will be implemented in bug 1417769
MozReview-Commit-ID: 3jNAmOcrvEa
Implement new processPings and _sendPing, handle sessions via registerNewOnboardingSession
This patch covers all new events except onboarding-noshow-smallscreen and overlay-disapear-resize events will be implemented in bug 1417769
MozReview-Commit-ID: 3jNAmOcrvEa
Implement basic validation for new table events and columns, report the incorrect fields.
The change is protected by NEW_TABLE flag so not effect the current telemetry.
MozReview-Commit-ID: 78K551g0nRj
Previously we used background images to display tour icons on the nav list and on the tour notification. This caused two pitfalls: First, if fill colors were different inside svg icons, we would see inconsistent tour icon colors. Second, for one tour icon there would need two svg files.
This patch switches to the mask-image approach, which makes a icon svg as a mask filtering the background color beneath, so we can unify icon colors by the external css and remove extra colored svg files.
MozReview-Commit-ID: ErXexz15y8F