Commit Graph

812 Commits

Author SHA1 Message Date
Brian Grinstead
909a433f0f Bug 1466833 - Upgrade the <xul:deck> inside of search-one-offs at the beginning of the XBL constructor;r=timdream
Right now, a XBL <constructor> runs before Custom Elements inside of its
<content> get upgraded. This leads to unexpected behavior where deck.selectedIndex = N
causes selectedIndex to get set as an expando property on the DOM node rather
than running the setter defined by the Custom Element.

Once the Custom Element does finally get upgraded, the selectedIndex getter and
setter don't get attached since there's an expando property with the same name.

This isn't a case we want to have to support from calling code. So this patch fixes
this one case by manually upgrading the element inside the constructor before
anything accesses the node. In Bug 1470242 we are planning to make this happen
behind the scenes so we don't need to do this for every CE inside of <content>.

MozReview-Commit-ID: 3D0QbOOJvDI
2018-06-21 17:31:41 -07:00
Gurzau Raul
4112a78c9b Backed out changeset c1561409e431 (bug 1466833) for permafailing on browser/components/search/test/browser_oneOffHeader.js on a CLOSED TREE 2018-06-22 00:17:12 +03:00
Brian Grinstead
110d1fef27 Bug 1466833 - Upgrade the <xul:deck> inside of search-one-offs at the beginning of the XBL constructor;r=timdream
Right now, a XBL <constructor> runs before Custom Elements inside of its
<content> get upgraded. This leads to unexpected behavior where deck.selectedIndex = N
causes selectedIndex to get set as an expando property on the DOM node rather
than running the setter defined by the Custom Element.

Once the Custom Element does finally get upgraded, the selectedIndex getter and
setter don't get attached since there's an expando property with the same name.

This isn't a case we want to have to support from calling code. So this patch fixes
this one case by manually upgrading the element inside the constructor before
anything accesses the node. In Bug 1470242 we are planning to make this happen
behind the scenes so we don't need to do this for every CE inside of <content>.

MozReview-Commit-ID: LbXKKVeBYyQ
2018-06-21 10:34:55 -07:00
Mark Banner
8bd7ef0069 Bug 1453667 - Remove BrowserUITelemetry from search. r=adw
MozReview-Commit-ID: L0Fj2d7BGdt
2018-06-06 19:40:27 +01:00
Joel Maher
d0823df1ef Bug 1405428 - skip-if = verify on mochitests which do not pass test-verify. r=gbrown 2018-06-10 05:01:47 -04:00
Michael Kaply
77bdcfa59d Bug 1437942 - Remove search engines from langpacks. r=adw
MozReview-Commit-ID: GFCIbfmCc5B
2018-06-04 16:45:50 -05:00
Narcis Beleuzu
88f7131528 Backed out changeset f4a2094a00c5 (bug 1437942) as requested by pascalc. a=backout 2018-06-06 10:57:52 +03:00
Michael Kaply
7b69e191fb Bug 1437942 - Remove search engines from langpacks. r=adw.mielczarek
MozReview-Commit-ID: GFCIbfmCc5B
2018-06-04 16:45:50 -05:00
Michael Kaply
a79a560298 Bug 1462010 - Remove unused migrateRegionPrefs and isUS preference. r=adw
MozReview-Commit-ID: BkwiIUcZW7m
2018-05-18 10:10:28 -05:00
Brian Grinstead
606c2eeeaf Bug 1460977 - Load searchbar styles directly in browser.xul r=adw
This is how we load styles for other components like downloads, and
lets us remove the dependancy on XBL <resources>.

MozReview-Commit-ID: DWIyUhx9Nkh
2018-05-14 12:55:53 -07:00
Tooru Fujisawa
41aa207cb4 Bug 1420574 - Add CustomizableUITestUtils.prototype.{addSearchBar,removeSearchBar} to show search bar in nav bar and verify it does not overflow. r=Paolo 2018-05-09 09:48:40 +09:00
Michael Kaply
52791e342c Bug 1454088 - Remove use of google-nocodes. r=adw
MozReview-Commit-ID: 2UYxI0tZNsX
2018-05-04 10:55:13 -05:00
Kris Maglione
fd7e9e6a69 Bug 1456035: Part 4 - Convert callers of XPCOMUtils.generateQI to ChromeUtils.generateQI. r=mccr8
This also removes any redundant Ci.nsISupports elements in the interface
lists.

This was done using the following script:

acecb401b7/processors/chromeutils-generateQI.jsm

MozReview-Commit-ID: AIx10P8GpZY
2018-04-22 20:55:06 -07:00
Mark Banner
862ad83caa Bug 1371294 - Add a SearchTestUtils.jsm file and stop duplicating promiseNewSearchEngine. r=mikedeboer
MozReview-Commit-ID: IP5iRstshrM
2018-04-12 20:09:01 +01:00
Gurzau Raul
72748e476e Backed out 2 changesets (bug 1371294) for failing browser_contentSearchUI.js on a CLOSED TREE
Backed out changeset 74e1257f8dfb (bug 1371294)
Backed out changeset 8902ee028f58 (bug 1371294)
2018-04-20 18:04:50 +03:00
Mark Banner
2090511492 Bug 1371294 - Add a SearchTestUtils.jsm file and stop duplicating promiseNewSearchEngine. r=mikedeboer
MozReview-Commit-ID: IP5iRstshrM
2018-04-12 20:09:01 +01:00
Boris Zbarsky
9a1a04e3f8 Bug 1453487 part 2. Remove useless implements="nsIDOMEventListener" from XBL bindings. r=smaug
MozReview-Commit-ID: 4OjGuYkpXMM
2018-04-12 00:05:49 -04:00
Jonathan Kingston
9b880fdc20 Bug 1374741 - Within browser/ make openUILinkIn() provide the correct triggeringPrincipal. r=gijs
MozReview-Commit-ID: 1NQrlWzIBja
2018-02-21 14:28:48 +00:00
Paolo Amadini
27081c7b37 Bug 1444392 - Part 2 - Use test-only helpers for the main menu across the tree. r=Gijs
MozReview-Commit-ID: IpdYFaYxx4M
2018-04-04 11:34:39 +01:00
Drew Willcoxon
bd8f7faa4e Bug 1221539 - Add search engine discovery to the page action menu. Part 2: Add the new action. r=Gijs
MozReview-Commit-ID: DEEZBwmV0JD
2018-03-28 11:28:20 -07:00
Tim Nguyen
d49de43825 Bug 1444760 - Combine loadURIWithFlags and loadURI methods. r=dao
MozReview-Commit-ID: 5dsyKwvjYht
2018-03-16 23:21:46 +00:00
Margareta Eliza Balazs
8ad3204b44 Backed out 2 changesets (bug 1444760) for ES lint failure in /builds/worker/checkouts/gecko/browser/base/content/browser.js on a CLOSED TREE
Backed out changeset 71f61091a716 (bug 1444760)
Backed out changeset 4956db1e9bdd (bug 1444760)
2018-03-25 15:29:54 +03:00
Tim Nguyen
76bd43b52d Bug 1444760 - Combine loadURIWithFlags and loadURI methods. r=dao
MozReview-Commit-ID: 5dsyKwvjYht
2018-03-16 23:21:46 +00:00
Tooru Fujisawa
f415c74b57 Bug 1442465 - Part 4.2: Stop unnecessarily awaiting on BrowserTestUtils.removeTab (simple part). r=dao 2018-03-19 11:16:45 +09:00
Kris Maglione
9d5b9190a5 Bug 1443964: Part 3 - Remove no-cpows-in-tests rule. r=mconley
The shims that this rule tests for no longer exist.

MozReview-Commit-ID: DMgP7Hczavc
2018-03-07 19:31:28 -08:00
Dão Gottwald
b0318e8dee Bug 1445572 - Rename mCurrentTab / mCurrentBrowser to _selectedTab / _selectedBrowser. r=jaws
MozReview-Commit-ID: IjH4bFnf5FA
2018-03-14 09:59:06 +01:00
Kris Maglione
1d4e106467 Bug 1444338: Make sure weak progress listener is not collected too early. r=mconley
MozReview-Commit-ID: GAwko5pkcc8
2018-03-09 08:44:37 -08:00
Kris Maglione
be99d41034 Bug 1443983: Part 1 - Remove shim usage in browser_google_behavior.js. r=mconley
MozReview-Commit-ID: 3pOOkRMxXsL
2018-03-08 13:37:28 -08:00
Michael Kaply
2a08262428 Bug 1442738 - Update default search config. r=mconnor 2018-03-07 08:03:05 -06:00
Florian Quèze
f6add2cafd Bug 1433175 - scripted patch to replace Components.classes[, Components.interfaces.nsI, Components.utils. and Components.results. with Cc, Ci, Cu and Cr, r=Mossop. 2018-02-28 18:51:33 +01:00
Narcis Beleuzu
f3879f42a4 Bug 1421238 - Disable browser_oneOffHeader.js on OS.X for frequent failures. r=jmaher 2018-02-23 16:17:00 +02:00
Marco Bonardo
506fe4efc1 Bug 1435711 - Remove controller support for tree autocomplete. r=Paolo
MozReview-Commit-ID: 5NJu2ILBP5h
2018-02-17 18:11:13 +01:00
Masayuki Nakano
efaea0aaa7 Bug 1438157 - part 2: Remove unnecessary second argument of EventUtils.synthesizeKey() r=smaug
Note that this patch also replaces legacy VK_* with KEY_*, and replaces
synthesizeKey() for inputting some characters with sendString() because
it's better and clearer what it does and it sets shiftKey state properly.

MozReview-Commit-ID: De4enbjux3T
2018-02-15 04:15:39 +09:00
Sebastian Hengst
3c21120192 merge mozilla-inbound to mozilla-central. a=merge 2018-02-10 00:26:50 +02:00
Boris Zbarsky
4fd6e65c55 Bug 1436508 part 10. Remove use of nsIDOMKeyEvent in JS. r=masayuki
MozReview-Commit-ID: GGciORX62Yh
2018-02-09 11:17:09 -05:00
Gijs Kruitbosch
b34b68c23a Bug 1436559 - stop doing busy-work in setOverLink and make textToSubURI available on Services.jsm, r=florian
MozReview-Commit-ID: F63kE4GE67B
2018-02-07 22:07:08 +00:00
shindli
722e3e624e Merge inbound to mozilla-central. a=merge 2018-02-08 12:04:26 +02:00
Paolo Amadini
aa9592d486 Bug 1427364 - Remove showCommentColumn and showImageColumn. r=mak
MozReview-Commit-ID: 8RNVaLvZkrY
2018-01-10 15:22:23 +00:00
Andrew McCreight
272cee1e65 Bug 1432992, part 1 - Remove definitions of Ci, Cr, Cc, and Cu. r=florian
This patch was autogenerated by my decomponents.py

It covers almost every file with the extension js, jsm, html, py,
xhtml, or xul.

It removes blank lines after removed lines, when the removed lines are
preceded by either blank lines or the start of a new block. The "start
of a new block" is defined fairly hackily: either the line starts with
//, ends with */, ends with {, <![CDATA[, """ or '''. The first two
cover comments, the third one covers JS, the fourth covers JS embedded
in XUL, and the final two cover JS embedded in Python. This also
applies if the removed line was the first line of the file.

It covers the pattern matching cases like "var {classes: Cc,
interfaces: Ci, utils: Cu, results: Cr} = Components;". It'll remove
the entire thing if they are all either Ci, Cr, Cc or Cu, or it will
remove the appropriate ones and leave the residue behind. If there's
only one behind, then it will turn it into a normal, non-pattern
matching variable definition. (For instance, "const { classes: Cc,
Constructor: CC, interfaces: Ci, utils: Cu } = Components" becomes
"const CC = Components.Constructor".)

MozReview-Commit-ID: DeSHcClQ7cG
2018-02-06 09:36:57 -08:00
Paolo Amadini
d6f647dbbf Bug 1427350 - Part 2 - Rename _matchCount to matchCount. r=mak
MozReview-Commit-ID: 2oo0Nxp3Qot
2018-02-04 15:00:58 +00:00
Paolo Amadini
b8175440fa Bug 1427350 - Part 1 - Use "autocomplete-rich-result-popup" instead of "autocomplete-result-popup" for the search bar. r=mak
MozReview-Commit-ID: AO926Wmhkbm
2018-02-04 15:00:48 +00:00
Florian Quèze
c5f15a4700 Bug 1339461 - script-generated patch to convert foo.indexOf(...) == -1 to foo.includes(), r=Mossop. 2018-02-01 20:45:22 +01:00
Mark Banner
6ab28d012c Bug 1436389 - Switch xbl related files to a different method for determining their environment. r=mossop
MozReview-Commit-ID: JLqFrKZykw
2018-02-07 16:02:25 +00:00
Kris Maglione
5298bb7ac5 Bug 1431533: Part 5b - Fix ESLint errors left over after rewrite. r=florian
MozReview-Commit-ID: 7bVI1iM6hor
2018-01-18 16:27:26 -08:00
Kris Maglione
0bb74efdf1 Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm

MozReview-Commit-ID: 1Nc3XDu0wGl
2018-01-29 15:20:18 -08:00
Cosmin Sabou
f09d6d985d Backed out 3 changesets (bug 1431533) for Android mochitest failures on testEventDispatcher on a CLOSED TREE
Backed out changeset a1eca62826a1 (bug 1431533)
Backed out changeset 34c999fa006b (bug 1431533)
Backed out changeset e2674287e57f (bug 1431533)
2018-01-30 07:17:48 +02:00
Kris Maglione
5e845929cf Bug 1431533: Part 5b - Fix ESLint errors left over after rewrite. r=florian
MozReview-Commit-ID: 7bVI1iM6hor
2018-01-18 16:27:26 -08:00
Kris Maglione
fd67f090b2 Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm

MozReview-Commit-ID: 1Nc3XDu0wGl
2018-01-29 15:20:18 -08:00
Brindusan Cristian
483ba301cb Backed out 2 changesets (bug 1431533) for ESlint failures on a CLOSED TREE
Backed out changeset 6e56f4c8843e (bug 1431533)
Backed out changeset 12fc4dee861c (bug 1431533)
2018-01-30 02:32:43 +02:00
Kris Maglione
3aa3c6fff8 Bug 1431533: Part 5b - Fix ESLint errors left over after rewrite. r=florian
MozReview-Commit-ID: 7bVI1iM6hor
2018-01-18 16:27:26 -08:00