Commit Graph

163 Commits

Author SHA1 Message Date
Marco Bonardo
3c437dd9d9 Bug 1461685 - The bookmarks toolbar is empty if the first bookmark is a separator. r=standard8
MozReview-Commit-ID: JcDokxD2wXh
2018-05-16 15:24:23 +02:00
Gijs Kruitbosch
16ff687c65 Bug 1447619 - avoid reflowing when returning items to the toolbar from the overflow menu, r=florian
MozReview-Commit-ID: BFGRssWb9F
2018-04-20 15:09:44 +01:00
Andreea Pavel
8aa53073af Backed out changeset 1ce48405e58a (bug 1447619) for creating bug 1457257 and bug 1457289 on a CLOSED TREE 2018-04-28 20:46:51 +03:00
Kris Maglione
582a21b473 Bug 1456035: Part 5 - Convert manual QueryInterface to ChromeUtils.generateQI. r=mccr8
Manually-implemented QueryInterface functions don't benefit from the
MozQueryInterface optimizaions, and a lot of them are in hot code, and
implement a large number of interfaces.

MozReview-Commit-ID: 8OzglraowZt
2018-04-23 12:58:34 -07:00
Kris Maglione
fd7e9e6a69 Bug 1456035: Part 4 - Convert callers of XPCOMUtils.generateQI to ChromeUtils.generateQI. r=mccr8
This also removes any redundant Ci.nsISupports elements in the interface
lists.

This was done using the following script:

acecb401b7/processors/chromeutils-generateQI.jsm

MozReview-Commit-ID: AIx10P8GpZY
2018-04-22 20:55:06 -07:00
Boris Zbarsky
c9145e654e Bug 1455674 part 19. Get rid of JS uses of nsIDOMElement. r=qdot
In nsBlocklistService.js we know we're dealing with actual nodes, so .nodeType
checks should be fine.
2018-04-26 23:37:34 -04:00
Gijs Kruitbosch
e4d0017659 Bug 1447619 - avoid reflowing when returning items to the toolbar from the overflow menu, r=florian
MozReview-Commit-ID: BFGRssWb9F
2018-04-20 15:09:44 +01:00
Marco Bonardo
933b9de114 Bug 1453638 - 'Open site' in live bookmarks is not working. r=jkt
MozReview-Commit-ID: 5KV8jDRxEjf
2018-04-12 17:41:12 +02:00
Boris Zbarsky
0e6ee1bab5 Bug 1453345 part 5. Remove pointless JS implemenations of QI to nsIDOMEventListener. r=smaug
MozReview-Commit-ID: Db0v6GZ0deo
2018-04-12 00:03:45 -04:00
Jonathan Kingston
9b880fdc20 Bug 1374741 - Within browser/ make openUILinkIn() provide the correct triggeringPrincipal. r=gijs
MozReview-Commit-ID: 1NQrlWzIBja
2018-02-21 14:28:48 +00:00
Marco Bonardo
36ec58e083 Bug 1421664 - 3 - Fix the UI and tests. r=standard8
test_419731.js can be removed since it is already covered by browser_bookmarkProperties_editTagContainer.js

MozReview-Commit-ID: K0LFuTptWyW
2018-03-22 14:13:07 +01:00
Marco Bonardo
9378cf4109 Bug 1446951 - 4 - Make QueriesToQueryString and QueryStringToQueries singular. r=standard8
MozReview-Commit-ID: K8x2x0kARDn
2018-03-16 18:43:57 +01:00
Marco Bonardo
6925512606 Bug 1446951 - 1 - Remove nsINavHistory::ExecuteQueries. r=standard8
MozReview-Commit-ID: ATQLGKzMtnn
2018-03-16 15:38:05 +01:00
Mike Conley
82b8a07b09 Bug 1358719 - Get rid of synchronous layout flush in browserPlacesViews.js. r=mak
This uses promiseDocumentFlushed to make it easier to query for
layout information for the overflowing bookmark toolbar without
causing sync layout flushes. All DOM operations on the toolbar
have been moved to run within a requestAnimationFrame in order
to reduce the likelihood that other JavaScript that's about to
run will cause style or layout flushes.

MozReview-Commit-ID: 1GrARVc4RMJ
2018-02-27 19:09:27 -05:00
Paolo Amadini
6d49378793 Bug 1443189 - Places subviews are not updated while they are open. r=Gijs
MozReview-Commit-ID: 5WHDqKsHjDJ
2018-03-07 22:01:58 +00:00
Marco Bonardo
c03dbb59bd Bug 1439315 - 6 - Move some utils into PlacesController or PlacesUIUtils. r=standard8
MozReview-Commit-ID: D7J6hY7Akro
2018-02-28 13:51:28 +01:00
Marco Bonardo
47da5f79b5 Bug 1439315 - 1 - rename InsertionPoint to PlacesInsertionPoint. r=standard8
MozReview-Commit-ID: 1NfkueEUPXC
2018-02-28 12:10:12 +01:00
Florian Quèze
f6add2cafd Bug 1433175 - scripted patch to replace Components.classes[, Components.interfaces.nsI, Components.utils. and Components.results. with Cc, Ci, Cu and Cr, r=Mossop. 2018-02-28 18:51:33 +01:00
Mike Conley
a50309145a Bug 1434376 - Switch over all uses of BrowserUtils.promiseLayoutFlushed to window.promiseDocumentFlushed. r=Paolo
window.promiseDocumentFlushed will call a callback as soon as a style or layout
flush is not required for the document (which might be immediately). This is a
new ChromeOnly API introduced in an earlier patch in this series.

This patch also removes the now-unneeded BrowserUtils.promiseLayoutFlushed and
BrowserUtils.promiseReflowed methods and infrastructure.

MozReview-Commit-ID: Jv7KoxBXhHG
2018-02-11 20:15:11 -05:00
Andreea Pavel
f77494f37a Backed out 3 changesets (bug 1434376)for failing browser chrome at browser/base/content/test/performance/browser_urlbar_search_reflows.js on a CLOSED TREE
Backed out changeset b636251b75ab (bug 1434376)
Backed out changeset fccbba9cb959 (bug 1434376)
Backed out changeset b5128504011c (bug 1434376)
2018-02-25 12:44:28 +02:00
Mike Conley
7a9538a35f Bug 1434376 - Switch over all uses of BrowserUtils.promiseLayoutFlushed to window.promiseDocumentFlushed. r=Paolo
window.promiseDocumentFlushed will call a callback as soon as a style or layout
flush is not required for the document (which might be immediately). This is a
new ChromeOnly API introduced in an earlier patch in this series.

This patch also removes the now-unneeded BrowserUtils.promiseLayoutFlushed and
BrowserUtils.promiseReflowed methods and infrastructure.

MozReview-Commit-ID: Jv7KoxBXhHG
2018-02-11 20:15:11 -05:00
Cosmin Sabou
b577c1c6c0 Backed out 3 changesets (bug 1434376) for build bustages on SystemTimeConverter.h(177)
Backed out changeset 2ed5aefc5bc2 (bug 1434376)
Backed out changeset 1b474fb6d798 (bug 1434376)
Backed out changeset 4e6a21e50be0 (bug 1434376)
2018-02-23 23:17:42 +02:00
Mike Conley
5165a5889d Bug 1434376 - Switch over all uses of BrowserUtils.promiseLayoutFlushed to window.promiseDocumentFlushed. r=Paolo
window.promiseDocumentFlushed will call a callback as soon as a style or layout
flush is not required for the document (which might be immediately). This is a
new ChromeOnly API introduced in an earlier patch in this series.

This patch also removes the now-unneeded BrowserUtils.promiseLayoutFlushed and
BrowserUtils.promiseReflowed methods and infrastructure.

MozReview-Commit-ID: Jv7KoxBXhHG
2018-02-11 20:15:11 -05:00
Gijs Kruitbosch
4d1843fa65 Bug 1350349 - collect data for feed reader usage to evaluate its future, r=mak,data-review=liuche
This patch adds data collection for 6 different data points:
- number of live bookmarks the user has
- number of times the user subscribes to a feed
- number of times we attempt to open feed preview
- number of times the user opens a feed popup in the UI
- number of times the user opens an entry from a feed popup in the UI.

MozReview-Commit-ID: DG9JDFXCjai
2018-02-16 19:18:00 +00:00
Paolo Amadini
265883cc33 Bug 1439358 - Part 6 - Decouple view events from view visibility. r=Gijs
This stops redundant ViewHiding and late ViewShown events from being dispatched when the panel is closed during a ViewShowing event or a transition, and stops dispatching ViewHiding events when a view becomes invisible but is still open.

The panelMultiView property on "panelview" nodes is now set to null when the view is closed, indicating that the view can be immediately reused in a different panel. The Places view had to be updated so it doesn't rely on this property during the PanelMultiViewHidden event.

MozReview-Commit-ID: B1yU6si3eD3
2018-02-22 14:20:11 +00:00
Paolo Amadini
f95df42e39 Bug 1439358 - Part 3 - Always raise ViewShowing events and don't update the "current" property. r=Gijs
The ViewShowing event is now called earlier and unconditionally, since we don't set the "current" attribute and call showMainView while the panel is closing anymore.

It is already the case that the ViewShowing event handlers don't depend on the "current" property, so we don't need to keep track of it before ViewShown events are dispatched.

MozReview-Commit-ID: Ii4SN03KjwW
2018-02-19 11:17:52 +00:00
Mark Banner
5e632ca5e3 Bug 1437651 - Remove unused simulated-places-node references. r=mak
MozReview-Commit-ID: 6JzFXRykF2W
2018-02-12 20:33:07 +00:00
Gijs Kruitbosch
ea90569376 Bug 1424672 - stop removing the header in the recently closed places views, r=mak,Paolo
MozReview-Commit-ID: J5HlyA8nxe2
2017-12-12 16:20:49 -06:00
Tawny Hoover
35be16f8ab Bug 1398992 = Make 'Recently Bookmarked' in Photon panels support browser.bookmarks.openInTabClosesMenu pref. r=jaws
MozReview-Commit-ID: 3Rio9EjwilT
2017-11-24 21:54:54 -05:00
Mark Banner
e47ccbfec3 Bug 1411368 - Automatically fix no-multi-spaces issues raised when using ESLint 4. r=mossop
MozReview-Commit-ID: H5YVp3rnzGo
2017-10-26 11:47:01 +01:00
Marco Bonardo
dcbda9bca0 Bug 1405722 - Remove the IsLivemark() bookmarks observer from PlacesUIUtils. r=standard8
MozReview-Commit-ID: 586IR54ggbm
2017-10-10 12:05:19 +02:00
Sebastian Hengst
7a15678a21 Backed out changeset af8fdfac66fa (bug 1405722) for failing xpcshell's browser/components/places/tests/unit/test_PUIU_livemarksCache.js, at least on OS X 10.10 opt. r=backout on a CLOSED TREE 2017-10-17 00:55:53 +02:00
Marco Bonardo
6652796654 Bug 1405722 - Remove the IsLivemark() bookmarks observer from PlacesUIUtils. r=standard8
MozReview-Commit-ID: 586IR54ggbm
2017-10-10 12:05:19 +02:00
Dan Banner
5af4450327 Bug 1408777 - Automatically fix instances of missing semicolons in the tree. r=Standard8
MozReview-Commit-ID: Jm8BRgt6mIv
2017-10-15 20:50:39 +01:00
Marco Bonardo
f5fe23e92e Bug 1398019 - Favicons missing in Bookmarks toolbar on startup. r=past
This is due to the fact now we set the icons only when the nodes visibility is updated.
The patch always updates nodes visibility when we rebuild the toolbar.
updateChevron() is being renamed accordingly and acts regardless of chevron.collapsed.

MozReview-Commit-ID: Cz1U710J42M
2017-09-08 11:43:08 +02:00
Marco Bonardo
5ed042500e Bug 1392081 - Mochitest browser test for bookmarks toolbar overflow. r=Gijs
MozReview-Commit-ID: DwDZl2AELXC
2017-08-28 14:43:59 +02:00
Marco Bonardo
8479d70360 Bug 1392081 - Only build a subset of the buttons that may become visible on the bookmarks toolbar. r=Gijs
MozReview-Commit-ID: GOlQzUKw2go
2017-08-25 17:14:31 +02:00
Marco Bonardo
04be1e5b4f Bug 1392081 - Set the image attribute on bookmarks toolbar buttons only when they are visible. r=Gijs
MozReview-Commit-ID: HIalcxcCBsv
2017-08-25 15:31:06 +02:00
Marco Bonardo
aa09f9812a Bug 1392081 - Use a document fragment to populate toolbar and menu Places views. r=Gijs
MozReview-Commit-ID: 1Q4U3xXfF4Y
2017-08-25 15:20:00 +02:00
Sebastian Hengst
3ba9799497 Backed out changeset 2b76c3b079d9 (bug 1392081) for failing browser/components/places/tests/browser/browser_toolbar_overflow.js. r=backout 2017-09-05 23:12:13 +02:00
Sebastian Hengst
ff4d94ab09 Backed out changeset ecd61b92f9b3 (bug 1392081) 2017-09-05 23:11:25 +02:00
Sebastian Hengst
c56b52bcef Backed out changeset 8998e0bed6ff (bug 1392081) 2017-09-05 23:11:20 +02:00
Sebastian Hengst
5042f49c45 Backed out changeset 882a40327e5a (bug 1392081) 2017-09-05 23:11:14 +02:00
Marco Bonardo
4d15ff5861 Bug 1392081 - Mochitest browser test for bookmarks toolbar overflow. r=Gijs
MozReview-Commit-ID: DwDZl2AELXC
2017-08-28 14:43:59 +02:00
Marco Bonardo
8bb782dfeb Bug 1392081 - Only build a subset of the buttons that may become visible on the bookmarks toolbar. r=Gijs
MozReview-Commit-ID: GOlQzUKw2go
2017-08-25 17:14:31 +02:00
Marco Bonardo
3a5abde62b Bug 1392081 - Set the image attribute on bookmarks toolbar buttons only when they are visible. r=Gijs
MozReview-Commit-ID: HIalcxcCBsv
2017-08-25 15:31:06 +02:00
Marco Bonardo
34a37131ae Bug 1392081 - Use a document fragment to populate toolbar and menu Places views. r=Gijs
MozReview-Commit-ID: 1Q4U3xXfF4Y
2017-08-25 15:20:00 +02:00
Gijs Kruitbosch
d6670b90dc Bug 1377967 - make middle clicking history, bookmarks and closed tabs items work correctly, r=mikedeboer
MozReview-Commit-ID: VQUuQHyCXi
2017-08-10 23:05:33 +01:00
Gijs Kruitbosch
279127e720 Bug 1388753 - unbreak bookmarks/history item clicks and tidy up code in browserPlacesViews.js, r=mikedeboer
MozReview-Commit-ID: 1vjP6IeIiPz
2017-08-10 23:04:54 +01:00
Sebastian Hengst
d476fe4639 Backed out changeset bf603affd1e0 (bug 1388753) for failing browser-chrome's browser_947914_button_history.js. r=backout a=merge
MozReview-Commit-ID: AHOsaTvCWms
2017-08-10 20:02:44 +02:00