Commit Graph

63 Commits

Author SHA1 Message Date
Jared Wein
22f312c0b6 Bug 1427961 - Implement error tooltip styling. r=MattN
MozReview-Commit-ID: CBNUhIRGD1A
2018-06-20 23:27:56 -04:00
Jared Wein
c653c8c236 Bug 1427961 - Put the asterisk next to required fields. r=MattN
MozReview-Commit-ID: 9KMFB9bS9hD
2018-06-20 19:06:38 -04:00
Jared Wein
e0f9bc267b Bug 1427961 - Regular expression validation for zip/postal codes. r=MattN
MozReview-Commit-ID: 208vx9SBcrq
2018-06-20 17:46:05 -04:00
Jared Wein
2b1c2b5e37 Bug 1427961 - Basic shipping address validation for state/province and zip/postal code. r=MattN
MozReview-Commit-ID: DCjr13QxP5Z
2018-06-07 17:02:42 -04:00
Sam Foster
cd93abfd0b Bug 1471263 - Unbork and un-skip the test_show_field_specific_error_on_addresschange test. r=jaws,MattN
MozReview-Commit-ID: BNvWDBF5HDH
2018-06-26 16:56:20 -07:00
Sam Foster
f704ec5021 Bug 1463608 - Expose FormAutofill computeFields methods, use them for temporary records in payments. r=MattN
* Test helpers for cards
* Refactor the test_add_link test to test in private & non-private window

MozReview-Commit-ID: AeVJOkSwQps
2018-05-30 16:56:25 -07:00
Sam Foster
d696f5cfdd Bug 1463608 - Add test helpers for payment address and cards. r=jaws
* addSampleAddressesAndBasicCard now accepts arrays of addresses and card, but with no args defaults to its original behavior
* addAddressRecord and addCardRecord helpers
* New helpers for each step in the sequence of clicking through to add a new address

MozReview-Commit-ID: Dto5MSekJTV
2018-06-04 09:36:21 -07:00
prathiksha
aefce9e084 Bug 1435892 - Test that the back button is hidden if the basic card page is shown first during on-boarding. r=MattN
MozReview-Commit-ID: 4xl7QuGSnQd
2018-06-19 16:31:31 -07:00
prathiksha
def9846400 Bug 1462461 - Show the back button in the basic card page during on-boarding.r=MattN
MozReview-Commit-ID: 1a8YtdbtV2M
2018-05-25 13:13:02 -07:00
Dorel Luca
4d8013e1b2 Backed out changeset d76b9bf7d97c (bug 1462461) for BC and TV failures on browser/components/payments/test/browser/browser_payments_onboarding_wizard.js 2018-06-20 03:18:52 +03:00
prathiksha
ae9cf03ec7 Bug 1462461 - Show the back button in the basic card page during on-boarding. r=MattN
MozReview-Commit-ID: 7Vxgp2vkKKN
2018-05-25 13:13:02 -07:00
Mark Banner
9af64d461a Bug 1456762 - Remove now unnecessary import-globals-from statements in html files. r=mossop
Depends on D1643

MozReview-Commit-ID: 84M50HDg0wl

Differential Revision: https://phabricator.services.mozilla.com/D1644
2018-06-16 08:21:33 +00:00
Mark Banner
ea6c3b2e37 Bug 1456762 - Add parsing of HTML files to ESLint to discover their script tags and the globals that are imported. r=mossop
MozReview-Commit-ID: 6jiEbZnyv6e

Differential Revision: https://phabricator.services.mozilla.com/D1643
2018-06-16 08:20:38 +00:00
Matthew Noorenberghe
391c7a410b Bug 1466720 - Make PR shipping options use inline amounts followed by labels. r=sfoster
MozReview-Commit-ID: n13dUARIH
2018-06-13 11:18:52 -07:00
Matthew Noorenberghe
0af67e543d Bug 1466720 - Default PaymentRequest dialog styles for background, <a>, and debugging.html. r=jaws
MozReview-Commit-ID: 5WFzbFFBvYj
2018-06-13 11:40:11 -07:00
Matthew Noorenberghe
4dd71f263a Bug 1466720 - Don't reload l10n.js in the PaymentRequest scope on a refresh. r=sfoster
There was an error trying to redefine variables from l10n.js via loadSubScript. We really only need
it loaded once like a frame script but I had to fix the l10n.js code to handle this properly.

MozReview-Commit-ID: EbNrEaRQJbs
2018-06-11 00:03:47 -07:00
Joel Maher
d0823df1ef Bug 1405428 - skip-if = verify on mochitests which do not pass test-verify. r=gbrown 2018-06-10 05:01:47 -04:00
Jared Wein
b0fc9890f1 Bug 1461477 - Create a CreditCard.jsm to consolidate various credit card handling and validation. r=MattN
MozReview-Commit-ID: 3tJdzU3hBvY
2018-05-15 12:41:35 -04:00
Csoregi Natalia
6a9464cac1 Backed out changeset 9b26de736798 (bug 1461477) for multiple CreditCards failures e.g. browser_manageCreditCardsDialog.js . CLOSED TREE 2018-06-01 21:04:39 +03:00
Jared Wein
d7d5af6823 Bug 1461477 - Create a CreditCard.jsm to consolidate various credit card handling and validation. r=MattN
MozReview-Commit-ID: 3tJdzU3hBvY
2018-05-15 12:41:35 -04:00
prathiksha
5d1a79ec4d Bug 1462779 - Auto-select appropriate addresses in select dropdowns in on-boarding forms. r=MattN
MozReview-Commit-ID: 5Lm3djwSeuG
2018-05-23 16:24:58 -07:00
prathiksha
d0213418ea Bug 1462779 - Show the billing address page during on-boarding if requestShipping is false and there are no saved addresses. r=MattN
MozReview-Commit-ID: E7KM4cIielG
2018-05-18 16:44:25 -07:00
Sam Foster
a2942b603e Bug 1429260 - Add tests to verify handling of payment detail properties it is possible to updateWith. r=jaws
* Check update of displayItems, additionalDisplay items and total (via a modifier.)

MozReview-Commit-ID: B4L7Ev9yR2f
2018-05-24 17:34:42 -07:00
Sam Foster
d3af0ff017 Bug 1429260 - Refactor PTU.Details data to only include the expected properties. r=jaws
MozReview-Commit-ID: 29qBnnY61V9
2018-05-24 10:55:44 -07:00
Jared Wein
aa636b9d5c Bug 1427959 - Add some basic styling for the error text on the address-form. r=MattN
MozReview-Commit-ID: 6ZLm53aJj6P
2018-05-23 15:19:46 -04:00
Jared Wein
af45682f86 Bug 1427959 - Show field-specific shippingaddresschange errors on the add/edit screen. r=MattN
MozReview-Commit-ID: 1Bd2v9yy7iR
2018-05-14 11:32:46 -04:00
Jared Wein
664639d009 Bug 1427959 - Clean up some tests WebPayments UI tests. r=MattN
- Remove getTextContent since it was too verbose and unneeded.
- Replace isElementVisible with content-available isVisible and isHidden since it is more convenient to check these within content tasks.
- Removed browser_request_summary.js test since what it was testing is now covered by many other tests.
- Added a checkPaymentMethodDetailsMatchesCard function to head.js to reduce duplication of card verification tests.
- Changed some tests to use pre-defined addresses and cards instead of supplying their own.

MozReview-Commit-ID: FLwDKFJQNUY
2018-05-23 14:23:36 -04:00
arthur.iakab
7151460bd0 Backed out 3 changesets (bug 1427959) for failing browser-chrome tests on browser/components/payments/test/browser/browser_payments_onboarding_wizard.js
Backed out changeset afaba93c711b (bug 1427959)
Backed out changeset 6003ece89387 (bug 1427959)
Backed out changeset 5e0368784d17 (bug 1427959)
2018-05-25 23:30:37 +03:00
Jared Wein
ed81874626 Bug 1464102 - Uncomment the shippingOptions portion of browser_request_serialization now that todo_is is supported. r=MattN
MozReview-Commit-ID: GdOLGW2i4O1
2018-05-24 12:15:07 -04:00
Jared Wein
e552392a23 Bug 1427959 - Add some basic styling for the error text on the address-form. r=MattN
MozReview-Commit-ID: 6ZLm53aJj6P
2018-05-23 15:19:46 -04:00
Jared Wein
8d68985868 Bug 1427959 - Show field-specific shippingaddresschange errors on the add/edit screen. r=MattN
MozReview-Commit-ID: 1Bd2v9yy7iR
2018-05-14 11:32:46 -04:00
Jared Wein
6946ed72bd Bug 1427959 - Clean up some tests WebPayments UI tests. r=MattN
- Remove getTextContent since it was too verbose and unneeded.
- Replace isElementVisible with content-available isVisible and isHidden since it is more convenient to check these within content tasks.
- Removed browser_request_summary.js test since what it was testing is now covered by many other tests.
- Added a checkPaymentMethodDetailsMatchesCard function to head.js to reduce duplication of card verification tests.
- Changed some tests to use pre-defined addresses and cards instead of supplying their own.

MozReview-Commit-ID: FLwDKFJQNUY
2018-05-23 14:23:36 -04:00
Mark Hammond
1784f6874b Bug 1463956 - allow Sync to remove all address and credit-card records. r=kitcambridge,MattN
MozReview-Commit-ID: KSeJJfAGmRh
2018-05-24 12:36:37 +10:00
Narcis Beleuzu
b0911e02e1 Backed out 3 changesets (bug 1464102) for browser-chrome failures on siteData/browser_siteData.js. CLOSED TREE
Backed out changeset 460cd874757f (bug 1464102)
Backed out changeset 3c227d911b2f (bug 1464102)
Backed out changeset 43b864db2e34 (bug 1464102)
2018-05-25 01:42:37 +03:00
Jared Wein
66b16d46b3 Bug 1464102 - Uncomment the shippingOptions portion of browser_request_serialization now that todo_is is supported. r=MattN
MozReview-Commit-ID: GdOLGW2i4O1
2018-05-24 12:15:07 -04:00
prathiksha
516cc3b7a1 Bug 1461886 - Pass appropriate properties to the FTU onboarding address page. r=MattN
MozReview-Commit-ID: Fn8beZELyFG
2018-05-17 17:41:25 -07:00
Matthew Noorenberghe
bbd032aa87 Bug 1462149 - Use &brandShortName; instead of hard-coded Firefox in strings for the payments UI. r=sfoster
MozReview-Commit-ID: 5VgPnVbi1Zm
2018-05-22 15:53:38 -07:00
Sylvestre Ledru
0245bfccee bug 1463425 - Fix flake8 in browser/ r=ahal,gps
MozReview-Commit-ID: 11Kil84u0TP
2018-05-21 23:13:07 +02:00
Jared Wein
4f99e1e183 Bug 1429180 - Change selectedStateKey to an array that defines the path within the state object that should be updated. r=MattN
MozReview-Commit-ID: IjJfmUtvjdz
2018-05-21 22:05:47 -04:00
Jared Wein
33bb7942c7 Bug 1429180 - Option to use a new billing address when adding a new payment method. r=MattN
MozReview-Commit-ID: 5LrpUw1LdT3
2018-05-10 15:12:01 -04:00
Matthew Noorenberghe
b8fd767583 Bug 1463292 - Use form autofill's l10n.js in the PaymentRequest dialog. r=sfoster
MozReview-Commit-ID: GUX3Gia293X
2018-05-22 10:37:54 -07:00
Sam Foster
f37f93e022 Bug 1427960 - Add temporary addresses to state, add toggle to enable saving/not new addresses. r=MattN
* Implement store in paymentDialogWrapper for temporary addresses & creditCards
* Add the persist checkbox to the add/edit address form. Defaults to unchecked when adding an address in a private session.
* The union of saved and temporary addresses can be retrieved from paymentRequest.getAddresses(). References to state.savedAddresses updated to use this when appropriate
* New tests for adding and editing addresses from a private window


MozReview-Commit-ID: KyD2BPNFYtZ
2018-04-26 15:05:10 -07:00
prathiksha
68910b7193 Bug 1432927 - Show a payment card input form before the summary view for users without a saved payment card. r=MattN
MozReview-Commit-ID: BmGG8OFzCjJ
2018-05-17 19:37:17 -07:00
Csoregi Natalia
39a4f8dda5 Backed out changeset 3aa4ee6077c5 (bug 1432927) for failing on payments/test/mochitest/test_basic_card_form.html. CLOSED TREE 2018-05-18 05:26:12 +03:00
prathiksha
cb46300df5 Bug 1432927 - Show a payment card input form before the summary view for users without a saved payment card. r=MattN
MozReview-Commit-ID: BmGG8OFzCjJ
2018-05-11 12:26:54 -07:00
Matthew Noorenberghe
2a4798b08c Bug 1443735 - Don't select a PaymentRequest shipping address by default. r=sfoster
This is possibly a temporary solution to avoid sending the user's address to the merchant until they've interacted with the shipping address picker.

MozReview-Commit-ID: 5q8BYr1rLwP
2018-05-17 15:48:04 -07:00
Matthew Noorenberghe
c23a0d596a Bug 1443735 - Use better selectors to find payment request add/edit links. r=sfoster
MozReview-Commit-ID: KSjAiY8QfIz
2018-05-16 13:28:21 -07:00
Sebastian Hengst
ccae4423ae Bug 1457287 - Update Bugzilla Product for WebPayments UI. r=me DONTBUILD 2018-05-17 12:36:31 +03:00
prathiksha
4a45c9737d Bug 1461455 - Show the total header in FTU wizard pages. r=MattN
MozReview-Commit-ID: 3EMT3nZ2sYe
2018-05-15 11:08:19 -07:00
Matthew Noorenberghe
49eaa3e033 Bug 1458376 - Use a <xul:browser> to display the PaymentRequest UI to fix <select> dropdowns. r=jaws
This fixes <select> dropdowns and also gets rid of the thin bottom gray line in the dialog.

MozReview-Commit-ID: I7v0mVjAnQZ
2018-05-10 22:05:04 -07:00