corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
546,803 Commits 1 Branch 0 Tags
80b1443c29c901b4f15e3c9d39a1f86d2e6a6cc0
Commit Graph

65 Commits

Author SHA1 Message Date
Kris Maglione
0847e8227e Bug 1464548: Part 3 - Update callers to use defineLazyGlobalGetters. r=mccr8 
MozReview-Commit-ID: 9APGewiDDYB
 2018-05-25 17:02:29 -07:00
Kris Maglione
fd7e9e6a69 Bug 1456035: Part 4 - Convert callers of XPCOMUtils.generateQI to ChromeUtils.generateQI. r=mccr8 
This also removes any redundant Ci.nsISupports elements in the interface
lists.

This was done using the following script:

acecb401b7/processors/chromeutils-generateQI.jsm

MozReview-Commit-ID: AIx10P8GpZY
 2018-04-22 20:55:06 -07:00
Jonathan Kingston
9b880fdc20 Bug 1374741 - Within browser/ make openUILinkIn() provide the correct triggeringPrincipal. r=gijs 
MozReview-Commit-ID: 1NQrlWzIBja
 2018-02-21 14:28:48 +00:00
Ganesh Chaitanya Kale
67bb868656 Bug 1282770 - Convert uses of PU.asyncHistory.updatePlaces in browser/components/migration to PU.history.insertMany. r=mak 
Patch originally by Ganesh, updated by Standard8

MozReview-Commit-ID: AihTLo5OyK1
 2018-03-20 12:36:31 +00:00
Florian Quèze
f1a55f73f8 Bug 1440284 - change this.EXPORTED_SYMBOLS back to var EXPORTED_SYMBOLS in JS modules, r=mccr8. 2018-02-23 20:50:01 +01:00
Andrew McCreight
272cee1e65 Bug 1432992, part 1 - Remove definitions of Ci, Cr, Cc, and Cu. r=florian 
This patch was autogenerated by my decomponents.py

It covers almost every file with the extension js, jsm, html, py,
xhtml, or xul.

It removes blank lines after removed lines, when the removed lines are
preceded by either blank lines or the start of a new block. The "start
of a new block" is defined fairly hackily: either the line starts with
//, ends with */, ends with {, <![CDATA[, """ or '''. The first two
cover comments, the third one covers JS, the fourth covers JS embedded
in XUL, and the final two cover JS embedded in Python. This also
applies if the removed line was the first line of the file.

It covers the pattern matching cases like "var {classes: Cc,
interfaces: Ci, utils: Cu, results: Cr} = Components;". It'll remove
the entire thing if they are all either Ci, Cr, Cc or Cu, or it will
remove the appropriate ones and leave the residue behind. If there's
only one behind, then it will turn it into a normal, non-pattern
matching variable definition. (For instance, "const { classes: Cc,
Constructor: CC, interfaces: Ci, utils: Cu } = Components" becomes
"const CC = Components.Constructor".)

MozReview-Commit-ID: DeSHcClQ7cG
 2018-02-06 09:36:57 -08:00
Kris Maglione
0bb74efdf1 Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian 
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm

MozReview-Commit-ID: 1Nc3XDu0wGl
 2018-01-29 15:20:18 -08:00
Cosmin Sabou
f09d6d985d Backed out 3 changesets (bug 1431533) for Android mochitest failures on testEventDispatcher on a CLOSED TREE 
Backed out changeset a1eca62826a1 (bug 1431533)
Backed out changeset 34c999fa006b (bug 1431533)
Backed out changeset e2674287e57f (bug 1431533)
 2018-01-30 07:17:48 +02:00
Kris Maglione
fd67f090b2 Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian 
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm

MozReview-Commit-ID: 1Nc3XDu0wGl
 2018-01-29 15:20:18 -08:00
Brindusan Cristian
483ba301cb Backed out 2 changesets (bug 1431533) for ESlint failures on a CLOSED TREE 
Backed out changeset 6e56f4c8843e (bug 1431533)
Backed out changeset 12fc4dee861c (bug 1431533)
 2018-01-30 02:32:43 +02:00
Kris Maglione
683a97d172 Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian 
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm

MozReview-Commit-ID: 1Nc3XDu0wGl
 2018-01-29 15:20:18 -08:00
Doug Thayer
015377398b Bug 862127 - Make migration interfaces more async r=Gijs 
In order to clean up sync IO within our profile migrators, we
need to have async interfaces for those parts which are currently
doing sync IO. This converts the sync interfaces and adjusts most
of the call sites (migration.js call site changes are addressed
in a separate patch to break it out a bit).


MozReview-Commit-ID: 2Kcrxco4iYr
 2018-01-12 09:06:21 -08:00
Dan Banner
503979c95a Bug 1367704 - Enable the semi ESLint rule across the tree. r=standard8 
MozReview-Commit-ID: GrlcOI9K2hJ
 2017-05-28 19:57:46 +01:00
gasolin
159f88a860 Bug 1361286 - add in-page messages support for Automigration module; r=Gijs 
MozReview-Commit-ID: I4xK2PkuHp3
 2017-05-24 16:56:00 +08:00
Sebastian Hengst
7b7ea06c4f Backed out changeset 2612892f2785 (bug 1361286) for typos in its strings. r=backout 2017-05-27 10:27:02 +02:00
gasolin
35b39a589e Bug 1361286 - add in-page messages support for Automigration module; r=Gijs 
MozReview-Commit-ID: I4xK2PkuHp3
 2017-05-24 16:56:00 +08:00
Mark Banner
9fc03b12e9 Bug 1365412 - Clean up various ESLint global definitions in browser/. r=mossop 
MozReview-Commit-ID: JqAm9x1XGCM
 2017-05-16 22:22:42 +01:00
Florian Quèze
ff53eb9a63 Bug 1353542 - massive script-generated patch converting Task.async and Task.spawn calls, and generators clearly identifiable as tasks, rs=Mossop. 2017-05-12 14:42:39 +02:00
Florian Queze
d3c36892fa Bug 1356569 - Remove addObserver's last parameter when it is false, r=jaws. 2017-04-14 21:51:38 +02:00
Sebastian Hengst
42670ceca0 Backed out changeset 322fde2d53bf (bug 1356569) so bug 1355161 can be backed out. r=backout 2017-04-14 23:39:22 +02:00
Florian Queze
9b4f73599f Bug 1356569 - Remove addObserver's last parameter when it is false, r=jaws. 2017-04-14 21:51:38 +02:00
Zibi Braniecki
e1617486a8 Bug 1347314 - Migrate calls to ChromeRegistry::GetSelectedLocale to use LocaleService::GetAppLocale. r=jfkthame,Pike 
In cases, where the caller is looking for the locale to be used for JS Intl API,
we can now replace it with `undefined` which causes JS Intl API to use the default
locale which since bug 1346674 is resolved to the app locale.

This allows us to remove a lot of calls for the app locale.

The remaining ones are split between `AsBCP47` and `AsLangTag`.
Here, the `AsLangTag` is used, as described in the API docs, for cases where
the language string is used for localization purposes, such as language negotaition
matching to our language resources etc.
`AsBCP47` is used when the returned value is handed over to ICU API.

MozReview-Commit-ID: DzmFEUvMq3N
 2017-03-14 16:09:54 -07:00
Sebastian Hengst
1f6ea2382a Backed out changeset cc308a73ad05 (bug 1347314) for eslint failure in test_device.html. r=backout 2017-03-22 18:20:26 +01:00
Zibi Braniecki
a56e4c7360 Bug 1347314 - Migrate calls to ChromeRegistry::GetSelectedLocale to use LocaleService::GetAppLocale. r=jfkthame,Pike 
In cases, where the caller is looking for the locale to be used for JS Intl API,
we can now replace it with `undefined` which causes JS Intl API to use the default
locale which since bug 1346674 is resolved to the app locale.

This allows us to remove a lot of calls for the app locale.

The remaining ones are split between `AsBCP47` and `AsLangTag`.
Here, the `AsLangTag` is used, as described in the API docs, for cases where
the language string is used for localization purposes, such as language negotaition
matching to our language resources etc.
`AsBCP47` is used when the returned value is handed over to ICU API.

MozReview-Commit-ID: DzmFEUvMq3N
 2017-03-14 16:09:54 -07:00
Gijs Kruitbosch
6fd139c0ac Bug 1335442 - update wording of automigration notification bar and add tests, r=jaws 
MozReview-Commit-ID: EkuOQmRjqOF
 2017-02-03 14:04:40 +00:00
Gijs Kruitbosch
d8ac970efb Bug 1335442 - deal correctly with not importing anything, r=jaws 
MozReview-Commit-ID: 3WZCxXV48Ms
 2017-02-03 14:04:23 +00:00
Gijs Kruitbosch
a89bdb9b5d Bug 1335349 - add survey link option to 'undo' for automigration, r=Dolske 
MozReview-Commit-ID: BGsxAdsTu7X
 2017-01-31 12:32:27 +01:00
Gijs Kruitbosch
a09465abe7 Bug 1333233 - part 2: add telemetry for the time it takes to do individual undo operations, r=bsmedberg,Dolske 
MozReview-Commit-ID: Lf7roH3EswB
 2017-01-26 17:00:00 +00:00
Gijs Kruitbosch
72cc1c8b09 Bug 1333233 - part 1: add telemetry for error counts from undo operations, r=bsmedberg,Dolske 
MozReview-Commit-ID: EdelbiibVWi
 2017-01-26 15:54:41 +00:00
Gijs Kruitbosch
bb9d4d9bcc Bug 1331800 - catch errors from history removals and don't block undo on them, r=Dolske 
MozReview-Commit-ID: JhWAs6rvBnW
 2017-01-18 18:07:47 +00:00
Gijs Kruitbosch
e413139a90 Bug 1331888 - immediately remove (and don't reshow) notification bars once user chooses to undo, r=dao 
The automated test verifies that we remove the notification bars immediately.
Unfortunately, I couldn't think of a way to verify we won't allow reshowing the notification bar while an undo is ongoing,
because for that to happen I'd need to get one to show while an undo is ongoing, which isn't reliably possible in an
automated test.

MozReview-Commit-ID: EYHNIPEaOOo
 2017-01-18 11:07:47 +00:00
Gijs Kruitbosch
45937d187a Bug 1330384 - force a refresh of the new tab page after automigration undo, r=jaws 
MozReview-Commit-ID: KoqbAgPkcLC
 2017-01-12 16:00:27 +00:00
Gijs Kruitbosch
7d09e4d45e Bug 1322730 - display undo migration message on about:newtab, r=Dolske 
MozReview-Commit-ID: 8nIGdD9XyFH
 2017-01-04 19:05:50 +00:00
Sebastian Hengst
6d6d937b45 Backed out changeset 9647d2c82af4 (bug 1322730) for eslint failures. r=backout 2017-01-04 20:05:06 +01:00
Gijs Kruitbosch
7fba8ab892 Bug 1322730 - display undo migration message on about:newtab, r=Dolske 
MozReview-Commit-ID: 8nIGdD9XyFH
 2016-12-15 16:54:36 +00:00
Gijs Kruitbosch
898e262c96 Bug 1285577 - part 4: save, use and delete implementations for import undo state, r=mak 
MozReview-Commit-ID: FVy2MMpvV65
 2016-12-20 22:49:05 +00:00
Gijs Kruitbosch
a9c9eea221 Bug 1285577 - part 3: keep track of added visits in an import and allow removing them, r=mak 
MozReview-Commit-ID: 7HCA7cKhws4
 2016-11-30 11:56:25 +00:00
Gijs Kruitbosch
7c7e220663 Bug 1285577 - part 2: keep track of added logins in an import and allow removing them, r=MattN 
MozReview-Commit-ID: JZbOkmZ7ZZG
 2016-11-30 11:50:38 +00:00
Gijs Kruitbosch
e6f654cf66 Bug 1285577 - part 1: keep track of added bookmarks in an import and allow removing them, r=mak 
MozReview-Commit-ID: 8pKlBmDVX5X
 2016-11-30 11:48:03 +00:00
Sebastian Hengst
13307cb1ae Backed out changeset 12aa73f4a982 (bug 1285577) 2016-12-20 22:54:35 +01:00
Sebastian Hengst
5148a28841 Backed out changeset 78a3cd5bf313 (bug 1285577) 2016-12-20 22:54:31 +01:00
Sebastian Hengst
0d72a880f2 Backed out changeset 10388e609fe3 (bug 1285577) 2016-12-20 22:54:26 +01:00
Sebastian Hengst
cea8d53329 Backed out changeset 1ffe78f2ab5a (bug 1285577) 2016-12-20 22:53:48 +01:00
Gijs Kruitbosch
a71437c514 Bug 1285577 - part 4: save, use and delete implementations for import undo state, r=mak 
MozReview-Commit-ID: FVy2MMpvV65
 2016-12-19 21:56:20 +00:00
Gijs Kruitbosch
362bb9cc96 Bug 1285577 - part 3: keep track of added visits in an import and allow removing them, r=mak 
MozReview-Commit-ID: 7HCA7cKhws4
 2016-11-30 11:56:25 +00:00
Gijs Kruitbosch
95acef5be1 Bug 1285577 - part 2: keep track of added logins in an import and allow removing them, r=MattN 
MozReview-Commit-ID: JZbOkmZ7ZZG
 2016-11-30 11:50:38 +00:00
Gijs Kruitbosch
477f5615db Bug 1285577 - part 1: keep track of added bookmarks in an import and allow removing them, r=mak 
MozReview-Commit-ID: 8pKlBmDVX5X
 2016-11-30 11:48:03 +00:00
Gijs Kruitbosch
1b441533b6 Bug 1319816 - fix default browser determination on Windows 7 and below in the automigration case, r=jaws 
As noted on the bug, because we call getMigratorKeyForDefaultBrowser() multiple times,
its value no longer reflects the (deleted) registry key for subsequent calls.

While we can fix this for the automigrate case by just passing the default we determined a few
lines earlier (and that seems worth doing to avoid busywork), there are 2 small problems
with this:

1) if the default browser has no data, `migratorKey` won't be set, and so we'll call the same
method again anyway, and the message reported in the error console will be that we can't
migrate from Firefox, when the real problem is that we can't migrate from the original
default browser.

2) there are other callers besides AutoMigrate. Specifically, migration.js also calls this
method.

To deal with these, I've fixed getMigratorKeyForDefaultBrowser() to return the same
registry-based value for its lifetime if we hit the 'the default is firefox, go look for an
earlier default' case.

I've verified that either the s/aMigratorKey/migratorKey/ or the change to
getMigratorKeyForDefaultBrowser() are sufficient to make this work properly in the
automigration case.

While I was here, I also updated one of the error messages to be more explicit.

MozReview-Commit-ID: GeUNTfScMMB
 2016-11-23 16:06:00 +00:00
Gijs Kruitbosch
72cef5f839 Bug 1309617 - add telemetry indicating when we show the 'would you like to undo automigration' notification, r=bsmedberg,Dolske 
MozReview-Commit-ID: 7RdDyn9dQNq
 2016-10-19 23:10:46 +01:00
Gijs Kruitbosch
bbf79f28ea Bug 1311043 - make eslint much more strict in browser/components/migration/, and fix issues, r=mikedeboer 
MozReview-Commit-ID: RXO68w3Kv3
 2016-10-18 16:03:06 +01:00