Commit Graph

76 Commits

Author SHA1 Message Date
Paolo Amadini
f08ea56f7b Bug 1472635 - Prevent suppressing executable warnings using the "don't ask me this again" checkbox. r=Gijs
A hidden preference matching "browser.download.manager.alertOnEXEOpen" is kept, but is renamed in order to recover cases where the checkbox was used accidentally.

This also cleans up duplicate unused strings in the "browser" folder.

MozReview-Commit-ID: GyccRiyoVGs
2018-07-02 15:42:58 +01:00
Kris Maglione
fd7e9e6a69 Bug 1456035: Part 4 - Convert callers of XPCOMUtils.generateQI to ChromeUtils.generateQI. r=mccr8
This also removes any redundant Ci.nsISupports elements in the interface
lists.

This was done using the following script:

acecb401b7/processors/chromeutils-generateQI.jsm

MozReview-Commit-ID: AIx10P8GpZY
2018-04-22 20:55:06 -07:00
Kris Maglione
b3990a2d91 Bug 1456686: Part 1 - Fix unused and shadowed explicit imports. r=standard8
These issues were previously ignored due to the nature of our global import
rules. They need to be fixed before that rule can be updated.

MozReview-Commit-ID: DCChktTc5TW
2018-04-24 20:18:09 -07:00
Mike de Boer
15e60d9e71 Bug 1034036 - Part 2: Rename and shorten getMostRecentBrowserWindow to getTopWindow and modernize the style used in BrowserWindowTracker.jsm. r=dao
MozReview-Commit-ID: EvgAhq4uR3a
2018-04-11 12:05:59 +02:00
Mike de Boer
2271d50b55 Bug 1034036 - Part 1: Merge RecentWindow.jsm and UpdateTopLevelContentWindowIDHelper.jsm into one module called 'BrowserWindowTracker.jsm'. r=dao
MozReview-Commit-ID: 9qzq1aGvjDu
2018-04-11 12:05:56 +02:00
Florian Quèze
97f9a1fe21 Bug 854464 - round the percentComplete value of the download indicator before setting it to set it at most 100 times, r=paolo. 2018-04-16 14:27:13 +02:00
Mark Banner
ec9360ee83 Bug 1434446 - Enable no-unused-vars for global scope on jsm files in browser/. r=mossop
MozReview-Commit-ID: ERT1Fili25d
2018-03-01 20:06:06 +00:00
Florian Quèze
f6add2cafd Bug 1433175 - scripted patch to replace Components.classes[, Components.interfaces.nsI, Components.utils. and Components.results. with Cc, Ci, Cu and Cr, r=Mossop. 2018-02-28 18:51:33 +01:00
Florian Quèze
f1a55f73f8 Bug 1440284 - change this.EXPORTED_SYMBOLS back to var EXPORTED_SYMBOLS in JS modules, r=mccr8. 2018-02-23 20:50:01 +01:00
Andrew McCreight
272cee1e65 Bug 1432992, part 1 - Remove definitions of Ci, Cr, Cc, and Cu. r=florian
This patch was autogenerated by my decomponents.py

It covers almost every file with the extension js, jsm, html, py,
xhtml, or xul.

It removes blank lines after removed lines, when the removed lines are
preceded by either blank lines or the start of a new block. The "start
of a new block" is defined fairly hackily: either the line starts with
//, ends with */, ends with {, <![CDATA[, """ or '''. The first two
cover comments, the third one covers JS, the fourth covers JS embedded
in XUL, and the final two cover JS embedded in Python. This also
applies if the removed line was the first line of the file.

It covers the pattern matching cases like "var {classes: Cc,
interfaces: Ci, utils: Cu, results: Cr} = Components;". It'll remove
the entire thing if they are all either Ci, Cr, Cc or Cu, or it will
remove the appropriate ones and leave the residue behind. If there's
only one behind, then it will turn it into a normal, non-pattern
matching variable definition. (For instance, "const { classes: Cc,
Constructor: CC, interfaces: Ci, utils: Cu } = Components" becomes
"const CC = Components.Constructor".)

MozReview-Commit-ID: DeSHcClQ7cG
2018-02-06 09:36:57 -08:00
Kris Maglione
0bb74efdf1 Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm

MozReview-Commit-ID: 1Nc3XDu0wGl
2018-01-29 15:20:18 -08:00
Cosmin Sabou
f09d6d985d Backed out 3 changesets (bug 1431533) for Android mochitest failures on testEventDispatcher on a CLOSED TREE
Backed out changeset a1eca62826a1 (bug 1431533)
Backed out changeset 34c999fa006b (bug 1431533)
Backed out changeset e2674287e57f (bug 1431533)
2018-01-30 07:17:48 +02:00
Kris Maglione
fd67f090b2 Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm

MozReview-Commit-ID: 1Nc3XDu0wGl
2018-01-29 15:20:18 -08:00
Brindusan Cristian
483ba301cb Backed out 2 changesets (bug 1431533) for ESlint failures on a CLOSED TREE
Backed out changeset 6e56f4c8843e (bug 1431533)
Backed out changeset 12fc4dee861c (bug 1431533)
2018-01-30 02:32:43 +02:00
Kris Maglione
683a97d172 Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm

MozReview-Commit-ID: 1Nc3XDu0wGl
2018-01-29 15:20:18 -08:00
Paolo Amadini
f708b42b64 Bug 1425736 - Don't show the attention badge for download failures on the application menu button. r=Gijs
MozReview-Commit-ID: A882hXl5o0
2018-01-09 15:51:19 +00:00
Mark Banner
4de85b3d5b Bug 1230373 - Enable mozilla/use-services for browser/components/ r=mossop
MozReview-Commit-ID: 9m9iss3jUJJ
2017-10-11 15:43:51 +01:00
Dan Banner
5af4450327 Bug 1408777 - Automatically fix instances of missing semicolons in the tree. r=Standard8
MozReview-Commit-ID: Jm8BRgt6mIv
2017-10-15 20:50:39 +01:00
Mike de Boer
0ba9d2ea57 Bug 1354532 - Part 2 - To facilitate the DownloadsSubview, add a 'LimitedHistoryDownloadsData' and 'LimitedPrivateHistoryDownloadData' dataview. r=Paolo
MozReview-Commit-ID: Jkyj2SQ7F00
2017-09-06 17:16:02 +02:00
Sebastian Hengst
eb87dfe3a7 Backed out changeset 63909748b3ce (bug 1354532) 2017-09-06 16:47:12 +02:00
Mike de Boer
d4875abbf5 Bug 1354532 - Part 2 - To facilitate the DownloadsSubview, add a 'LimitedHistoryDownloadsData' and 'LimitedPrivateHistoryDownloadData' dataview. r=Paolo
MozReview-Commit-ID: Jkyj2SQ7F00
2017-09-06 16:23:06 +02:00
Gijs Kruitbosch
663af591de Back out changeset 97f7f5175b2f (bug 1371765) because we're changing the plan for the downloads button, rs=backout,firebot,paolo
MozReview-Commit-ID: FTvFDV5nuG6
2017-08-25 13:32:47 +01:00
Paolo Amadini
f5f47cca11 Bug 1393418 - Fix initialization of the Downloads Indicator on startup. r=mak
MozReview-Commit-ID: GEQZoak5MFl
2017-08-24 13:34:08 +01:00
Gijs Kruitbosch
89a0e2f431 Bug 1371765 - make downloads button non-customizable, r=jaws,Paolo
MozReview-Commit-ID: E9izQpa4fFZ
2017-08-16 15:54:36 +01:00
Paolo Amadini
03576258d2 Bug 1296554 - Show a static progress bar for downloads of unknown size. r=jaws
MozReview-Commit-ID: HgRl7vlTp3Z
2017-08-21 14:52:33 +01:00
Kris Maglione
0fb6b2e73c Bug 1388215: Part 3 - Use JIT-friendly defineLazy*Getters methods when defining many lazy imports. r=florian
MozReview-Commit-ID: APoFwUhDFdj
2017-08-09 13:03:36 -07:00
Masatoshi Kimura
29a4322fe8 Bug 389565 - Remove nsIExternalProtocolService::LoadUrl. r=Paolo
MozReview-Commit-ID: lMq06cPWYB
2017-08-06 11:25:42 +09:00
Paolo Amadini
d1e1b518d1 Bug 1381411 - Implement the DownloadHistoryList object. r=mak
This also changes the Library window to use the newly added back-end object. The only user-visible change should be how the selection behaves when retrying downloads.

MozReview-Commit-ID: 7CQr1m21rcB
2017-08-04 14:48:53 +01:00
Paolo Amadini
f26759a7e8 Bug 830415 - Part 2 - Move the front-end code that stores download metadata in history to the DownloadHistory module. r=mak
Regression tests will be added in bug 1381411 when methods to retrieve the metadata will be available.

MozReview-Commit-ID: I3MgwM0EOty
2017-07-26 16:12:57 +01:00
Paolo Amadini
1a2766e349 Bug 1381409 - Part 3 - Use DownloadList notifications directly in front-end download views. r=mak
The DownloadList object now provides batch notifications directly, in preparation for linking front-end views to other types of download lists without having to use the DownloadsData indirection.

MozReview-Commit-ID: FOTz1YwGRE1
2017-07-17 12:05:12 +01:00
Paolo Amadini
81fd3d7bde Bug 1381409 - Part 2 - Let each view keep the state of downloads relevant to it. r=mak
The front-end download views now maintain the old download state themselves, instead of relying on the DownloadsData object dispatching the onDownloadStateChanged notification.

This allows each view to keep only the state relevant to it, for example the Downloads Panel already keeps the state only for the visible items. This also makes it possible for each view to use a different hash than the one provided by the legacy stateOfDownload method, and allows bypassing the DownloadsData indirection entirely.

MozReview-Commit-ID: 2D1ixsZCkCa
2017-07-17 12:07:17 +01:00
Paolo Amadini
1907d28bdd Bug 1381409 - Part 1 - Always add Download objects in their original order. r=mak
When a new front-end view is added to the DownloadsData object, the Download objects it contains are loaded into the view starting with the newest, which is the opposite of the order used by the underlying DownloadList.

This was originally implemented as an optimization for the Downloads Panel, at a time when the full list of completed downloads was persisted in the same SQLite database as session downloads. This difference is now unnecessary given the low number of session downloads, and can be removed in preparation for bypassing the DownloadsData indirection entirely.

MozReview-Commit-ID: 5EBkqvyXFq4
2017-07-16 17:36:00 +01:00
Florian Quèze
b622c2b081 Bug 1368456 - Remove imports of Promise.jsm from Firefox, r=mconley. 2017-06-23 11:25:18 +02:00
Paolo Amadini
7afba17088 Bug 1362970 - Part 2 - Script-generated patch to convert .then(null, ...) to .catch(...). r=florian
Changes to Promise tests designed to test .then(null) have been reverted, and the browser/extensions directory was excluded because the projects it contains have a separate process for accepting changes.

MozReview-Commit-ID: 1buqgX1EP4P
2017-06-19 11:32:37 +01:00
Mark Striemer
afce04b9ce Bug 1369771 - Confirm launch of executables other than .exe on Windows r=Paolo
MozReview-Commit-ID: 2TbLbdMc3d3
2017-05-29 16:38:54 -05:00
Doug Thayer
21ea798d89 Bug 1359733 - (pt. 5) Pull out indicator.js badges r=Gijs
See also pt. 4. We are moving app menu notification state
into a jsm since it is not specific to one window and this
simplifies work for the new app update UI.

MozReview-Commit-ID: InEp5b0y2n0
2017-05-15 11:57:58 -07:00
Paolo Amadini
4182e1c784 Bug 1364050 - Part 5 - Update obsolete references in code comments. r=mak
MozReview-Commit-ID: 9EUn7vcSfe3
2017-05-05 13:11:49 +01:00
Florian Quèze
ff53eb9a63 Bug 1353542 - massive script-generated patch converting Task.async and Task.spawn calls, and generators clearly identifiable as tasks, rs=Mossop. 2017-05-12 14:42:39 +02:00
Wes Kocher
76ce4b0d6d Merge m-c to autoland, a=merge
MozReview-Commit-ID: 3BrkDVl7521
2017-05-08 16:24:51 -07:00
Sam Foster
799e3c8af3 Bug 1329109 - remove unused time and progressbar code from downloads toolbar icon. r=Paolo
This removes the arrowStyledIndicator killswitch and the associated ability for system add-ons to restore the previous design of the Downloads Indicator in the toolbar. The removal includes all the related code, styles, and strings. Based on the original patch by :rexboy.

MozReview-Commit-ID: 2OEBzPNzl0O
2017-05-08 10:11:52 -07:00
Paolo Amadini
b972e9cc0c Bug 1362207 - Remove the dropdown menu from the footer of the Downloads Panel. r=mak
MozReview-Commit-ID: CFrHklbB7TK
2017-05-05 15:37:00 +01:00
Paolo Amadini
fece3c6437 Bug 1281186 - Remove uses of nsIDownloadManager from DownloadsCommon.jsm, DownloadsViewUI.jsm, and allDownloadsViewOverlay.js. r=mak
MozReview-Commit-ID: 28nc8aTea5v
2017-05-05 11:20:53 +01:00
Yiren Wang
fd7cf240a8 Bug 1264206 - Enable ESLint for browser/components/downloads and fix the existing issues. r=Standard8
MozReview-Commit-ID: HDjTxdFCnRp
2017-04-03 10:25:05 +01:00
Rex Lee
d0e1630d30 Bug 1270006 - Fill portion of the icon on download button as indicator to download progress r=Paolo
MozReview-Commit-ID: BqYow8jWCVD
2016-08-24 18:39:53 +08:00
Florian Quèze
91f7a2ef3a Bug 1331599 - script-generated patch to replace removeEventListener calls with the once option when possible, r=jaws. 2017-01-25 07:01:52 +01:00
Rex Lee
1511fe0218 Bug 1270014 - Show an alert icon on the downloads button when a download fails. r=Paolo
MozReview-Commit-ID: LVfRT24SHqN
2017-01-06 19:45:23 +08:00
Sean Lee
b6c6188136 Bug 1269958 - Change the information details of the summary section in Downloads Panel. r=Paolo
MozReview-Commit-ID: 1hKBRXOBH6c
2016-08-18 14:45:57 +08:00
Sean Lee
4a6aa72b89 Bug 1297039 - Implement the preference for showing dropmarker or not in Downloads Panel., r=Paolo
MozReview-Commit-ID: ArmPPgLABtA
2016-08-22 18:44:24 +08:00
Sean Lee
904b253968 Bug 1269962 - Implement a popup menu for showing a submenu in Downloads Panel Footer., r=Paolo
MozReview-Commit-ID: 7K1W15039W8
2016-07-13 13:39:00 +08:00
Panos Astithas
c45849d52b Bug 1139472 - Extend the attention state of the Downloads Indicator to indicate success or failure. r=paolo
With this change two new attention states are introduced, "severe" and "warning",
along with the previous "success" and "no attention" states. "No attention" is
still a falsy value in order to mitigate any add-on compatibility issues.
"severe" and "warning states" now display an icon badge to the downloads button
(or the hamburger button if the downloads button is tucked away).

MozReview-Commit-ID: 3gc9Ji7zCXY
2016-04-22 23:09:07 +03:00