* Let popup code initially measure and place the panel without maxHeight, this ensures alignmentPosition is a reasonable value
* Assign maxHeight from a popuppositioned handler and update the comment explaining the role of the autoPosition property
* Refactor to move the maxHeight calculation into a method on PMV
* panel autoPosition now gets reset to false in popuppositioned (was popupshowing) as the ShowWithPositionedEvent on popupFrame sets it back to true every time
* Update reflow tests with new signatures, and elimination of 1 reflow
* In appMenu reflow test, we must now wait for popupshown before opening subviews
MozReview-Commit-ID: KfHxngnajM3
This allows dragging them via touch gestures.
I'm not adding this attribute to all tabs (so that you need
to select a tab before dragging it), because the tab
strip can also be scrolled with touch gestures and
the two touch move actions would easily conflict
otherwise. It would also make it easier to accidentally
mess up your tabs when touching your window somehow.
MozReview-Commit-ID: IVWQtVGFE9j
The site security subview is now implemented using the "photonpanelmultiview" element, replacing the last instance of the "panelmultiview" element. The subview features a standard Photon header, hence the connection state icon was moved to the element below it. This makes the styles more similar between the main view and the subview. The connection state styles are now applied using a class name, and the tests have been updated accordingly.
This change required some fixes in the "photonpanelmultiview" implementation to make sure the height of the subview is correct and to allow keyboard navigation back to the main view.
Since the expander button and the permission controls in the main view are not visible anymore after the subview is shown, some code related to focus and hover could be removed as well.
MozReview-Commit-ID: 4nIAPWJPV8k
Giving all these nodes ids doesn't seem like the right fix. `buildArea` already ignores skipintoolbarset
items before doing anything else with nodes, so bailing out early seemed like the right solution here.
MozReview-Commit-ID: H3EyqoospNR
When the locale has a slightly longer label for 'Zoom', the popup auto-sizing
code starts having trouble with the inline start padding of that label and doesn't
size the popup correctly anymore.
When I change this to using a spacer element, this issue no longer occurs and the
label may become as large as localizers may need, as long as it doesn't exceed
the max-width of a panelview - 30em, currently.
MozReview-Commit-ID: CHRheMqazrj
mconley helped with the initial setup here and they were reviewed by myself (jaws). His changes have been folded in to this patch since they didn't work as a standalone changeset.
MozReview-Commit-ID: E7U1ZciJl4D
The only thing that I didn't remove was the process ID on the tab tooltip, which I find to be super helpful. For that, I changed the check from E10S_TESTING_ONLY to NIGHTLY_BUILD.
MozReview-Commit-ID: 2qNWebBpsMY
The only thing that I didn't remove was the process ID on the tab tooltip, which I find to be super helpful. For that, I changed the check from E10S_TESTING_ONLY to NIGHTLY_BUILD.
MozReview-Commit-ID: 8wbjdYIC3gb
DevTools are adding a hidden menuitem "Enable DevTools..." that will be used to
propose an onboarding screen to users. This hidden button makes a customizable ui
test fail. It needs to be filtered out.
MozReview-Commit-ID: IX4SlpDHdsT
