Commit Graph

200 Commits

Author SHA1 Message Date
Gijs Kruitbosch
4e9eb5f188 Bug 1438490 - move overflow/underflow event handling out of toolbar.xml, r=jaws
MozReview-Commit-ID: CwkCOIm9wNk
2018-05-01 15:44:19 +01:00
Gijs Kruitbosch
16ff687c65 Bug 1447619 - avoid reflowing when returning items to the toolbar from the overflow menu, r=florian
MozReview-Commit-ID: BFGRssWb9F
2018-04-20 15:09:44 +01:00
Andreea Pavel
8aa53073af Backed out changeset 1ce48405e58a (bug 1447619) for creating bug 1457257 and bug 1457289 on a CLOSED TREE 2018-04-28 20:46:51 +03:00
Gijs Kruitbosch
e4d0017659 Bug 1447619 - avoid reflowing when returning items to the toolbar from the overflow menu, r=florian
MozReview-Commit-ID: BFGRssWb9F
2018-04-20 15:09:44 +01:00
Tim Nguyen
9698f93bd0 Bug 1372694 - Stop making the default theme a heavyweight theme. r=kmag,aswan
MozReview-Commit-ID: 30wMauuc9oo
2018-04-01 13:53:31 +02:00
Kris Maglione
2b54d6ac16 Bug 1442187: Wait until next tick after popupshown before resolving show(). r=Gijs
With the migration of Promise microtasks to the main microtask queue, promise
resolution handlers are now called immediately after any JS event listener
returns. The result of this is that in the case of the show() method, the
resolution handlers now run before the view's own popupshown handlers run and
the view is set active, which breaks handlers which expect it to act more
sensibly.

By deferring the resolution until the next tick, the resolution handlers are
called when the view is visible and in a consistent state.

MozReview-Commit-ID: C7697CBoHFt
2018-03-01 18:31:14 -08:00
Mark Banner
75e89108e3 Bug 1442377 - Move fillSubviewFromMenuItems/clearSubview to CustomizableUI.jsm. r=Gijs
MozReview-Commit-ID: BQ8V39C68WO
2018-03-01 19:53:07 +00:00
Paolo Amadini
6c9f8f1df2 Bug 1441284 - Part 3 - Remove the "showingSubView" property. r=Gijs
The value "single" for the "closemenu" attribute on panel buttons is unused, so the only consumer of the "showingSubView" property can be removed.

MozReview-Commit-ID: 2jf5YE4Uyd
2018-02-27 14:08:58 +00:00
Florian Quèze
f1a55f73f8 Bug 1440284 - change this.EXPORTED_SYMBOLS back to var EXPORTED_SYMBOLS in JS modules, r=mccr8. 2018-02-23 20:50:01 +01:00
Paolo Amadini
ff1ddd6adf Bug 1434883 - Part 2 - Use an asynchronous API to open PanelMultiView panels. r=Gijs
MozReview-Commit-ID: 3VzoxJ3Ociy
2018-02-06 09:02:27 +00:00
Andrew McCreight
272cee1e65 Bug 1432992, part 1 - Remove definitions of Ci, Cr, Cc, and Cu. r=florian
This patch was autogenerated by my decomponents.py

It covers almost every file with the extension js, jsm, html, py,
xhtml, or xul.

It removes blank lines after removed lines, when the removed lines are
preceded by either blank lines or the start of a new block. The "start
of a new block" is defined fairly hackily: either the line starts with
//, ends with */, ends with {, <![CDATA[, """ or '''. The first two
cover comments, the third one covers JS, the fourth covers JS embedded
in XUL, and the final two cover JS embedded in Python. This also
applies if the removed line was the first line of the file.

It covers the pattern matching cases like "var {classes: Cc,
interfaces: Ci, utils: Cu, results: Cr} = Components;". It'll remove
the entire thing if they are all either Ci, Cr, Cc or Cu, or it will
remove the appropriate ones and leave the residue behind. If there's
only one behind, then it will turn it into a normal, non-pattern
matching variable definition. (For instance, "const { classes: Cc,
Constructor: CC, interfaces: Ci, utils: Cu } = Components" becomes
"const CC = Components.Constructor".)

MozReview-Commit-ID: DeSHcClQ7cG
2018-02-06 09:36:57 -08:00
Florian Quèze
c5f15a4700 Bug 1339461 - script-generated patch to convert foo.indexOf(...) == -1 to foo.includes(), r=Mossop. 2018-02-01 20:45:22 +01:00
Kris Maglione
0bb74efdf1 Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm

MozReview-Commit-ID: 1Nc3XDu0wGl
2018-01-29 15:20:18 -08:00
Cosmin Sabou
f09d6d985d Backed out 3 changesets (bug 1431533) for Android mochitest failures on testEventDispatcher on a CLOSED TREE
Backed out changeset a1eca62826a1 (bug 1431533)
Backed out changeset 34c999fa006b (bug 1431533)
Backed out changeset e2674287e57f (bug 1431533)
2018-01-30 07:17:48 +02:00
Kris Maglione
fd67f090b2 Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm

MozReview-Commit-ID: 1Nc3XDu0wGl
2018-01-29 15:20:18 -08:00
Brindusan Cristian
483ba301cb Backed out 2 changesets (bug 1431533) for ESlint failures on a CLOSED TREE
Backed out changeset 6e56f4c8843e (bug 1431533)
Backed out changeset 12fc4dee861c (bug 1431533)
2018-01-30 02:32:43 +02:00
Kris Maglione
683a97d172 Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm

MozReview-Commit-ID: 1Nc3XDu0wGl
2018-01-29 15:20:18 -08:00
Gijs Kruitbosch
c48f97be11 Bug 1426250 - allow changing log preference at runtime for CUI.jsm, r=jaws
MozReview-Commit-ID: 9kYBC27wowg
2018-01-05 21:31:53 +00:00
Tim Nguyen
e0347f3526 Bug 1428938 - Remove legacy toolbar customization code. r=Gijs
MozReview-Commit-ID: 1ppfxI7yYJW
2018-01-11 16:35:17 +00:00
Gijs Kruitbosch
447d01f074 Bug 1424452 - stop having 2 different values for the 'panel' area type, r=jaws
MozReview-Commit-ID: 3spDhRhlOTF
2017-12-09 12:37:20 +00:00
Paolo Amadini
ea9b09c38d Bug 1414244 - Part 7 - Remove unused code paths from PanelMultiview.jsm. r=Gijs
MozReview-Commit-ID: 9cwaAZXqDGO
2017-11-23 15:18:14 +00:00
Paolo Amadini
192bb221a0 Bug 1414244 - Part 6 - Fold the "photonpanelmultiview" binding into "panelmultiview". r=Gijs
MozReview-Commit-ID: IjvSZZUHUMt
2017-11-21 14:21:32 +00:00
Gijs Kruitbosch
f4281f60f4 Bug 1388029 - remove the remaining uses of AREA_PANEL, r=jaws
MozReview-Commit-ID: L017kRfHfOv
2017-11-07 12:15:18 +00:00
Gijs Kruitbosch
fd9bc93522 Bug 1388029 - remove notion of 'wide' widget and panel columns from the tree, r=jaws
MozReview-Commit-ID: IrCB3zn1BIT
2017-11-07 12:00:18 +00:00
Gijs Kruitbosch
e64b940f37 Bug 1388029 - remove useless param from PanelUI.showSubView, r=jaws
MozReview-Commit-ID: 9hkYtLxAOtQ
2017-11-07 11:54:47 +00:00
Gijs Kruitbosch
5a30f740d7 Bug 1411011 - stop offering context menu (re)move options on skipintoolbarset items, r=jaws
Giving all these nodes ids doesn't seem like the right fix. `buildArea` already ignores skipintoolbarset
items before doing anything else with nodes, so bailing out early seemed like the right solution here.

MozReview-Commit-ID: H3EyqoospNR
2017-11-06 14:49:37 +00:00
Johann Hofmann
8fea5f8aa7 Bug 1410352 - Make the overflow menu adhere to touchmode sizing. r=nhnt11
MozReview-Commit-ID: JhMIp65wuaq
2017-10-25 13:07:46 +02:00
Sebastian Hengst
009b9b29b1 Backed out changeset cc55d4e3d13d (bug 1410352) for eslint failure at browser/components/customizableui/CustomizableUI.jsm:4339: 'aEvent' is already declared in the upper scope. r=backout 2017-10-25 16:53:27 +02:00
Johann Hofmann
bb08d8718f Bug 1410352 - Make the overflow menu adhere to touchmode sizing. r=nhnt11
MozReview-Commit-ID: JhMIp65wuaq
2017-10-25 13:07:46 +02:00
Felipe Gomes
0f344c77d4 Bug 1407351 - Remove nightly-only e10s testing features from the main browser window. r=mikedeboer
The only thing that I didn't remove was the process ID on the tab tooltip, which I find to be super helpful. For that, I changed the check from E10S_TESTING_ONLY to NIGHTLY_BUILD.

MozReview-Commit-ID: 2qNWebBpsMY
2017-10-17 13:39:50 -02:00
Ryan VanderMeulen
99112e9931 Backed out 5 changesets (bug 1407351) for causing bug 1409395 and breaking nightlies.
Backed out changeset e6ee25ad6a9f (bug 1407351)
Backed out changeset 8e04412824b5 (bug 1407351)
Backed out changeset effeee94316e (bug 1407351)
Backed out changeset a53f34a45f9b (bug 1407351)
Backed out changeset 86a360e12b8a (bug 1407351)
2017-10-17 10:07:55 -04:00
Felipe Gomes
3f29526da6 Bug 1407351 - Remove nightly-only e10s testing features from the main browser window. r=mikedeboer
The only thing that I didn't remove was the process ID on the tab tooltip, which I find to be super helpful. For that, I changed the check from E10S_TESTING_ONLY to NIGHTLY_BUILD.

MozReview-Commit-ID: 8wbjdYIC3gb
2017-10-16 14:00:30 -02:00
Dan Banner
5af4450327 Bug 1408777 - Automatically fix instances of missing semicolons in the tree. r=Standard8
MozReview-Commit-ID: Jm8BRgt6mIv
2017-10-15 20:50:39 +01:00
Gijs Kruitbosch
d7b6a1a48c Bug 1406738 - do not set the 'overflowing' attribute if the overflow menu only contains 'special' widgets (like flexible spaces), r=jaws
MozReview-Commit-ID: 1C5XaTCIUKA
2017-10-11 12:05:15 +01:00
Dão Gottwald
d09618162c Bug 1406625 - Remove leftover code and styling for <toolbarbutton type="menu-button"> r=mikedeboer
MozReview-Commit-ID: 8wBsluIMZHq
2017-10-07 20:10:24 +02:00
Sam Foster
e75b24280f Bug 1395674 - Adding subviewbutton-nav class to menu-type toolbarbuttons and display the '>' in the overflow list. r=Gijs
MozReview-Commit-ID: I1pGXA3ecxT
2017-09-25 19:29:04 -07:00
Gijs Kruitbosch
8281aeeff3 Bug 1399517 - remove CustomizableUI placements for old buttons to avoid saved state corruption, r=mikedeboer
MozReview-Commit-ID: 3XKPuz9KwlD
2017-09-18 17:34:50 +01:00
Gijs Kruitbosch
4d8b290d17 Bug 1399517 - CustomizableUI shouldn't try to insert items next to nodes that aren't in the right container, r=mikedeboer
MozReview-Commit-ID: H9KY7YQwmlQ
2017-09-18 16:36:46 +01:00
Mike de Boer
8e58f24a71 Bug 1388180 - Update the overflow panel styling in Customize Mode and show the overflow button as in the opened state, but with a disabled looking icon. r=Gijs
MozReview-Commit-ID: 387PZ2jp1SS
2017-09-13 19:28:45 +02:00
Johann Hofmann
28991ef174 Bug 1349552 - Part 2 - Add an extra drag space setting to customize mode. r=nhnt11
MozReview-Commit-ID: IWxdOeRwDeu
2017-09-10 20:38:19 +02:00
Gijs Kruitbosch
89bf690512 Bug 1397447 - ensure the button is in the navbar by default, r=mak
MozReview-Commit-ID: H6r3dAEg4r1
2017-09-08 14:07:05 +01:00
Gijs Kruitbosch
d48e2eaf65 Bug 1397447 - make downloads button autohide by default, r=mak
MozReview-Commit-ID: E9izQpa4fFZ
2017-09-08 14:16:36 +01:00
Kris Maglione
d7f8583c5a Bug 1391707: Follow-up: Skip idle in more places that incorrectly expect strict timing. r=me CLOSED TREE
MozReview-Commit-ID: BbMB5qk4F4e
2017-09-11 21:26:04 -07:00
Zibi Braniecki
424682e3b6 Bug 1398390 - Only react to mousedown if it is a left-click. r=Gijs
MozReview-Commit-ID: Ie2Xgasg2eN
2017-09-09 22:17:19 -07:00
Sebastian Hengst
3a807c09ee Backed out changeset 1a8147d55b02 (bug 1398390) for failing browser-chrome's browser_overflow_anchor.js at least on macOS and Windows. r=backout 2017-09-10 09:37:30 +02:00
Zibi Braniecki
8c25be70ea Bug 1398390 - Only react to mousedown if it is a left-click. r=Gijs
MozReview-Commit-ID: Ie2Xgasg2eN
2017-09-09 22:17:19 -07:00
Sebastian Hengst
1197f950f9 merge mozilla-inbound to mozilla-central. r=merge a=merge
MozReview-Commit-ID: JSRVc5yW6Kx
2017-09-07 12:39:12 +02:00
Paolo Amadini
7c101fe117 Bug 1387416 - Place the search bar in the customization palette for new profiles. r=Gijs
MozReview-Commit-ID: Tq8YrZWG6P
2017-09-06 13:09:27 +01:00
Zibi Braniecki
58ed110740 Bug 1395871 - Open toolbar menus on mousedown, rather than oncommand.
MozReview-Commit-ID: A3P4QBBgcB8
2017-09-01 01:54:34 -07:00
Gijs Kruitbosch
7bcdebbdbc Bug 1393574 - fix flexible spacers not being removable in some circumstances, r=jaws
The goal of this patch is to ensure that:
- in default placements, specials have no unique ids
- in actual placements as stored by CUI, they do
- we reset the counter for those unique ids on reset.
- we re-number specials when building an area (like on startup, or when resetting),
  ensuring that the actual nodes always match the placements for a given area.
- we force saves after resetting, to ensure that the gNewElementCount is always persisted correctly.

This last part will also fix bug 1393661

MozReview-Commit-ID: HAS5J5ZSgB5
2017-09-06 10:02:44 +01:00