We've improved the startup IO situation in bug 887889 by not synchronously
initializing a connection to the contentprefs db. However, this means
we are loading Sqlite.jsm earlier than we were, which isn't ideal and
can be avoided. However, this isn't completely trivial so I'd like to
move this work to a follow-up.
MozReview-Commit-ID: 6Em0rN26Qj3
These issues were previously ignored due to the nature of our global import
rules. They need to be fixed before that rule can be updated.
MozReview-Commit-ID: DCChktTc5TW
(This also fixes Bug 879740 and Bug 1204543.)
build/pgo/certs contains an NSS database set that has a bunch of hand-generated
certificates, and many of these hand-generated certificates are specifically
depended upon for a variety of unit tests. This patch changes all of these to
use the "pycert.py" and "pykey.py" utilities that produce deterministic keys
and certificates.
The naming convention here is new, and defined in the README. It is based on
the mochitest runtest.py naming convention that imports .ca and .client
PEM-encoded certificates.
Unfortunately, the updates to build/pgo/genpgocert.py to generate these files
depends on OpenSSL in order to produce PKCS12 archives for pk11tool to import
into NSS. This could be done with pure-NSS tooling, but it'd require some new
command line functionality, which is out-of-scope for this change.
Note that build/pgo/genpgocert.py no longer takes arguments when run. It's not
run automatically anywhere that I can see, but could (reasonably) be, now.
Differential Revision: https://phabricator.services.mozilla.com/D971
***
Bug 1454202: Part 1a - Auto-replace uses of callback-based AddonManager APIs with Promise-based versions. r=aswan
This was done using the following script:
4cd5ae9597/processors/aom-api-generators.jsm
MozReview-Commit-ID: 8hobLz15a66
***
Bug 1454202: Part 1b - Manually fix eslint errors after auto-rewrite. r=aswan
This also deletes an obsolete test whose xpcshell variant was already deleted.
MozReview-Commit-ID: DM9W9Q2SVIE
***
Bug 1454202: Part 1c - Manually fix non-eslint issues after auto-rewrite. r=aswan
MozReview-Commit-ID: DtMscWZuExc
The OfflineAppCacheHelper was apparently introduced after the Sanitizer had been
forked for Fennec and so far nobody bothered to use it there as well.
MozReview-Commit-ID: 42Uk5hfvf9y
The OfflineAppCacheHelper was apparently introduced after the Sanitizer had been
forked for Fennec and so far nobody bothered to use it there as well.
MozReview-Commit-ID: 42Uk5hfvf9y
This patch fixes a bunch of intermittent/perma failures in sanitize-offlineData.js by:
- Ignoring localStorage for now. LocalStorage is cleared by sending an
observer notification. The flush often happens after several seconds, heavily
interfering with our own test or with subsequent tests. We can not reliably wait
on the operation to finish. Waiting for "domstorage-test-flushed" after calling
Sanitizer.sanitize() fixes the problem, but that notification is intermittently
not triggered for other unknown reasons, which makes it not really viable to use.
- Creating and checking indexedDB data in the chrome process (using SiteDataTestUtils).
- Cleaning up after running the test.
- Ignoring a stray NS_ERROR_ABORT that's hard to track down and doesn't seem to
do any damage right now.
I've also moved the ServiceWorker utility functions into SiteDataTestUtils,
which we're planning to use in all other browser tests that handle site data.