Commit Graph

86 Commits

Author SHA1 Message Date
Nicholas Nethercote
7fabd8754f Bug 1231550 - Use DrawTarget instead of gfxContext and/or nsRenderingContext in many places in font/text code. r=jfkthame.
AutoTextRun now only needs a DrawTarget instead of an nsRenderingContext, and
similar nsRenderingContext/gfxContext-to-DrawTarget replacements can be
propagated a long way up the call graph. This patch replaces 93 occurrences of
nsRenderingContext and 135 occurrences of gfxContext with DrawTarget; that's
13% of them.

The patch is mostly plumbing changes. A couple of not-entirely-plumbing
changes:

- It adds a comment about the null check in
  gfxGlyphExtents::GetTightGlyphExtentsAppUnits().

- A couple of functions simply had an unused gfxContext or nsRenderingContext
  parameter removed, e.g. SetLineBreaks().
2015-12-15 13:56:41 -08:00
Nicholas Nethercote
fe73890223 Bug 1230413 (part 4) - Remove unused nsRenderingContext argument from ForceBreak() and OptionallyBreak(). r=mattwoodrow. 2015-12-06 14:13:57 -08:00
Xidorn Quan
e2a9789117 Backed out 8 changesets (bug 1225018, bug 1229278, bug 1224013) for reftest failures on CLOSED TREE 2015-12-04 13:08:17 +11:00
Xidorn Quan
039afa606a Bug 1224013 part 2 - Move leading fix to ruby base container. r=dholbert
Per spec, the additional leading is added on side of ruby base container, not
ruby container. This could lead to some trivial behavior changes on edge cases.
2015-12-04 12:02:41 +11:00
Jonathan Kew
e418782b93 Bug 1224230 - Explicitly store the lineContainer's writing mode in InlineIntrinsicISizeData. r=dbaron 2015-11-14 08:46:11 +00:00
Xidorn Quan
f78a9c1678 Bug 1197765 - Compare text content inside frame instead of the content node for ruby autohiding. r=dbaron 2015-09-01 09:24:37 +10:00
Xidorn Quan
b4f4bab661 Bug 1180443 - Consider whitespace collapse when calculating intrinsic isize of ruby. r=dbaron 2015-07-09 16:05:26 +10:00
David Major
c96edf50f2 Bug 1167189: Add an infallible version of nsContentUtils::GetNodeTextContent. r=jst 2015-05-22 14:16:20 -04:00
Xidorn Quan
a62163b2a7 Bug 1153764 - Avoid explicitly doing break before when there is ruby span. r=roc 2015-04-16 13:42:45 +12:00
Xidorn Quan
047e13c1f1 Bug 1141931 part 7 - Move [Auto]RubyTextContainerArray to RubyUtils and merge RubyTextContainerIterator into AutoRubyTextContainerArray. r=dholbert 2015-04-08 11:22:34 +12:00
Xidorn Quan
b5f85c6d89 Bug 1141931 part 6 - Move Ruby{Segment,Column}Enumerator to RubyUtils. r=dholbert 2015-04-08 11:22:34 +12:00
Xidorn Quan
dc1ae63caf Bug 1141931 part 5 - Eliminate unnecessary includes in header files of ruby frames. r=dholbert 2015-04-08 11:22:34 +12:00
Xidorn Quan
bd95394de6 Bug 1141931 part 2 - Eliminate writing-mode mismatch in ruby reflow. r=dholbert 2015-04-08 11:22:34 +12:00
Wes Kocher
95d8beba17 Backed out 10 changesets (bug 1141931) for mochitest-5 failures CLOSED TREE
Backed out changeset c90940067de6 (bug 1141931)
Backed out changeset 96b48288abab (bug 1141931)
Backed out changeset 87281c7ded34 (bug 1141931)
Backed out changeset 6a914ba0b8ec (bug 1141931)
Backed out changeset 9cfea55b5e95 (bug 1141931)
Backed out changeset f432612b6475 (bug 1141931)
Backed out changeset 48cf9568a4b1 (bug 1141931)
Backed out changeset f1ab848b3fa6 (bug 1141931)
Backed out changeset 8a3c71a3b525 (bug 1141931)
Backed out changeset 119d3c0fd0f6 (bug 1141931)
2015-04-07 14:23:57 -07:00
Xidorn Quan
60c7c57faf Bug 1141931 part 7 - Move [Auto]RubyTextContainerArray to RubyUtils and merge RubyTextContainerIterator into AutoRubyTextContainerArray. r=dholbert 2015-04-08 08:40:31 +12:00
Xidorn Quan
99f77b6bd1 Bug 1141931 part 6 - Move Ruby{Segment,Column}Enumerator to RubyUtils. r=dholbert 2015-04-08 08:40:31 +12:00
Xidorn Quan
4ae13330f4 Bug 1141931 part 5 - Eliminate unnecessary includes in header files of ruby frames. r=dholbert 2015-04-08 08:40:31 +12:00
Xidorn Quan
7c6fa4cc1e Bug 1141931 part 2 - Eliminate writing-mode mismatch in ruby reflow. r=dholbert 2015-04-08 08:40:31 +12:00
Xidorn Quan
25e5616bf2 Bug 1146107 - Replace MOZ_ASSERT with NS_WARN_IF_FALSE on isize check in ruby base container. r=dholbert 2015-03-31 16:30:29 +11:00
Mats Palmgren
3f92be8fe8 Bug 1148833 part 3 - Remove nsIFrame::WillReflow and add a non-virtual MarkInReflow method instead that sets NS_FRAME_IN_REFLOW. Call it at the start of Reflow(). r=roc 2015-03-29 22:38:40 +00:00
Cameron McCormack
a562bdc57f Bug 1120300 - Export WritingModes.h as mozilla/WritingModes.h. r=jfkthame 2015-03-26 18:29:31 +11:00
Xidorn Quan
a6a32774c3 Bug 1141919 part 2 - Drain overflow list of ruby content frame if line break suppression fails somewhere. r=dbaron 2015-03-14 16:29:06 +11:00
Xidorn Quan
d59168f5f4 Bug 1141842 - Add LastOptionalBreakPriority to nsLineLayout to simplify some code. r=roc 2015-03-11 14:14:48 +11:00
Xidorn Quan
63683132d2 Bug 1140264 part 3 - Rename IsInlineDescendantOfRuby to ShouldSuppressLineBreak and exclude rbc/rtc from it. r=dbaron 2015-03-11 10:28:21 +11:00
Xidorn Quan
511087ea04 Bug 1140264 part 2 - Move and merge line breaking code in rbc reflow to reduce useless computation and fix undesired break point. r=dbaron 2015-03-11 10:28:21 +11:00
Xidorn Quan
f86dcc7d07 Bug 1140264 part 1 - Avoid expanding auto-hidden ruby annotations. r=dbaron
This could sometimes cause undesired overflow area.
2015-03-11 10:28:21 +11:00
Xidorn Quan
0f15030920 Bug 1134432 part 5 - Fix line breaks for intrinsic min isize calculation of ruby base container. r=dbaron 2015-02-22 00:39:33 +13:00
Xidorn Quan
a2b1692fa1 Bug 1134432 part 4 - Move line break checking code to an independent method for reuse. r=dbaron 2015-02-22 00:39:33 +13:00
Xidorn Quan
f2fb945dc1 Bug 1134432 part 3 - Move a function upwards for reuse. r=dbaron 2015-02-22 00:39:33 +13:00
Xidorn Quan
3e94568e76 Bug 1134432 part 2 - Fix basic inline min/pref isize calculation of ruby frames. r=dbaron 2015-02-22 00:39:33 +13:00
Xidorn Quan
cdb84ae6fd Bug 1134667 - Check length of text run before checking line break in reflow of ruby base container. r=jfkthame 2015-02-20 13:43:35 +13:00
Xidorn Quan
7caaa0049c Bug 1133697 part 3 - Make ruby text frame not continue text run. r=roc 2015-02-18 17:20:02 +13:00
Xidorn Quan
7db92724c8 Bug 1132008 part 1 - Calculate bsize of rtc according to its children. r=dbaron 2015-02-17 14:25:18 +13:00
Xidorn Quan
0dbed1338f Bug 1133573 - Fix available size calculation of ruby text container. r=roc 2015-02-17 11:07:55 +13:00
Simon Montagu
f9ca39cffa Bug 1131013: when setting the position of inline frames in vertical writing modes with right-to-left direction, subtract the inline start from the container height to get the correct vertical position. r=jfkthame 2015-02-11 01:43:03 -08:00
Xidorn Quan
ae1d61d2a8 Bug 1089431 part 3 - Make line breaking inside ruby be triggered at correct time. r=jfkthame 2015-02-11 10:26:56 +11:00
Xidorn Quan
d8f699817b Bug 1089431 part 2 - Break between ruby bases according to line-breaking rules. r=jfkthame 2015-02-11 10:26:56 +11:00
L. David Baron
d5dd9493b9 Bug 1121738 - Ruby base container frames should not support CSS transforms. r=xidorn
Following bug 1055667 patch 5, nsRubyBaseContainerFrame is the only ruby
frame type with this bug.  It should not support CSS transforms given
the spec wording in
http://dev.w3.org/csswg/css-transforms/#transformable-element
2015-01-15 15:07:50 -08:00
Xidorn Quan
07bccd491c Bug 1055667 part 3 - Suppress border/padding space on rbc/rtc frames. r=dbaron 2015-01-15 20:02:11 +11:00
Xidorn Quan
660e809d5e Bug 1055667 part 2 - Remove unnecessary param of SetBSizeFromFontMetrics. r=dbaron 2015-01-15 20:02:11 +11:00
Xidorn Quan
11c36cd9e1 Bug 1055667 part 1 - Allow inline direction margin of ruby base/text boxes. r=dbaron 2015-01-15 20:02:11 +11:00
Xidorn Quan
18a293b76d Bug 1115262 - Fix position of ruby annotation when writing mode is vertical-rl. r=jfkthame 2015-01-13 20:04:41 +11:00
Xidorn Quan
0549a155fe Bug 1055658 part 4 - Revert RubyReflowState. r=dbaron 2015-01-13 20:04:41 +11:00
Nigel Babu
2492f633d1 Backed out 4 changesets (bug 1055658) for M5 bustage on a CLOSED TREE
Backed out changeset 3cbd9323c896 (bug 1055658)
Backed out changeset 99e071295c42 (bug 1055658)
Backed out changeset 55119d19e4c5 (bug 1055658)
Backed out changeset e82f640cb53f (bug 1055658)
2015-01-12 10:43:11 +05:30
Xidorn Quan
cdb8162daf Bug 1055658 part 4 - Revert RubyReflowState. r=dbaron 2015-01-12 14:31:55 +11:00
Xidorn Quan
3848b04cde Bug 1099807 part 4 - Fix line breaking around ruby intra-level whitespaces. r=dholbert 2015-01-08 18:28:09 +11:00
Xidorn Quan
8206cd35a3 Bug 1099807 part 3 - Use specific frame type in RubyColumn. r=dholbert 2015-01-08 18:28:09 +11:00
Xidorn Quan
f3ebefa8a7 Bug 1099807 part 2 - Implement intra-level whitespace pairing. r=dholbert
Line breaking is not handled properly in this patch.
It would be fixed in the part 4.
2015-01-08 18:28:09 +11:00
Xidorn Quan
3117e03451 Bug 1116631 - Fix isize reservation of ruby base container. r=roc 2015-01-07 12:47:09 +11:00
Xidorn Quan
2dffaa6260 Bug 1116037 part 12 - Move mLineSize to RubyReflowState. r=dbaron 2014-12-30 11:20:10 +11:00