corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
982,144 Commits 1 Branch 0 Tags
7f8d24c80529e8b7d51c9ebf39381e43b8a7ced4
Commit Graph

60 Commits

Author SHA1 Message Date
Sam Foster
829925fc2c Bug 1954056 - Avoid closing the sidebar launcher when just closing the open panel. r=sidebar-reviewers,kcochrane 
* Remove some of the overloading of SidebarState.updateVisibility
* Remove the no-longer-used #previousLauncherExpanded property
* SidebarController.hide() just hides the panel (same as legacy/original API)
* Skip the browser_toolbarKeyNav.js test when sidebar.revamp=true, this should have been failing all along.

Differential Revision: https://phabricator.services.mozilla.com/D242240
 2025-03-28 00:27:49 +00:00
Cosmin Sabou
a6f42c65a8 Backed out changeset a99655962ea6 (bug 1954056) for turning browser_toolbarKeyNav.js into permafail. CLOSED TREE 2025-03-27 06:41:26 +02:00
Sam Foster
b87c7b1846 Bug 1954056 - Avoid closing the sidebar launcher when just closing the open panel. r=sidebar-reviewers,kcochrane 
* Remove some of the overloading of SidebarState.updateVisibility
* Remove the no-longer-used #previousLauncherExpanded property
* SidebarController.hide() just hides the panel (same as legacy/original API)

Differential Revision: https://phabricator.services.mozilla.com/D242240
 2025-03-26 23:00:27 +00:00
mark
c2958a4a93 Bug 1936120 - Enforce no quotes around Lit expressions r=reusable-components-reviewers,credential-management-reviewers,fxview-reviewers,omc-reviewers,backup-reviewers,sidebar-reviewers,frontend-codestyle-reviewers,profiles-reviewers,mtigley,mconley,hjones,jsudiaman,niklas,Standard8,pdahiya 
* Enables lit/quoted-expressions rule to enforce that no surrounding
  quotes when expressions are bound to attributes and properties in Lit templates.
  See f71ea1741e/docs/rules/quoted-expressions.md

* Updates all violations to adhere to lit/quoted-expressions rule

Differential Revision: https://phabricator.services.mozilla.com/D237657
 2025-02-19 16:19:42 +00:00
Nikki Sharpley
70e23c057f Bug 1941625 - Add context menu items for sidebar main r=sidebar-reviewers,fluent-reviewers,bolsson,kcochrane 
On right clicking the sidebar main element when vertical tabs are disabled,
show options for hiding the sidebar, customizing the sidebar and turning on
vertical tabs.

Differential Revision: https://phabricator.services.mozilla.com/D237264
 2025-02-18 19:26:53 +00:00
Cosmin Sabou
f14010e66b Backed out changeset 650ff35a3ff0 (bug 1941625) for causing browser_sidebar related failures. CLOSED TREE 2025-02-14 21:22:29 +02:00
Nikki Sharpley
4d1b9a0447 Bug 1941625 - Add context menu items for sidebar main r=sidebar-reviewers,fluent-reviewers,bolsson,kcochrane 
On right clicking the sidebar main element when vertical tabs are disabled,
show options for hiding the sidebar, customizing the sidebar and turning on
vertical tabs.

Differential Revision: https://phabricator.services.mozilla.com/D237264
 2025-02-14 15:55:45 +00:00
Nikki Sharpley
410e500446 Bug 1944576 - Fix accessibility issue causing failures in browser_glean_sidebar.js r=sidebar-reviewers,kcochrane 
Differential Revision: https://phabricator.services.mozilla.com/D236737
 2025-02-05 14:56:26 +00:00
Tim Xia
1e483f4009 Bug 1922595 - Change icon and label in sidebar to be that of the selected provider, r=Mardak,firefox-ai-ml-reviewers,fluent-reviewers,jsudiaman 
- implement handling for unset ChatProvider selections
- add `iconUrl` attribute to ChatProvider object
- ensure icon and label synchronization when opening new windows or switching providers
- update tooltip l10nId string template to include `{ $provider } ({ $shortcut })`
- replace existing l10nId strings, sidebar-menu-open-ai-chatbot-tooltip
- use fluent strings for fallback
- fix ftl file: wrap shortcut in ()
- add property getter currentChatProviderInfo
- use lazy.chatProvider
- remove fallbackProvider10nId
- add new test_genai_chat_sidebar_tooltip test

Differential Revision: https://phabricator.services.mozilla.com/D231963
 2025-01-24 23:29:22 +00:00
Nikki Sharpley
80815e4664 Bug 1938301 - Wrap tools and extensions when sidebar is expanded r=sidebar-reviewers,desktop-theme-reviewers,kcochrane 
Differential Revision: https://phabricator.services.mozilla.com/D232675
 2024-12-26 15:17:48 +00:00
Logan Rosen
d24c9d9ff4 Bug 1857834 - auto-formatting with Prettier v3 r=linter-reviewers,webdriver-reviewers,perftest-reviewers,search-reviewers,devtools-reviewers,sync-reviewers,reusable-components-reviewers,profiler-reviewers,dom-storage-reviewers,android-reviewers,firefox-ai-ml-reviewers,hjones,mcheang,mstange,sparky,janv,nchevobbe,tarek,Standard8,markh 
# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D230598
 2024-11-29 15:18:25 +00:00
Nikki Sharpley
2bd823760a Bug 1931939 - Don't show extension context menu if clicking sidebar blank area r=sidebar-reviewers,jsudiaman 
It seems we were hitting a console error and not reaching the block of code prevents the popup:
`JavaScript error: chrome://browser/content/sidebar/sidebar-main.mjs, line 140: TypeError: can't access property "getAttribute", this.contextMenuTarget is null`

Differential Revision: https://phabricator.services.mozilla.com/D229669
 2024-11-25 15:00:24 +00:00
Kelly Cochrane
f28de57311 Bug 1929972 - Fix for new sidebar callout trigger being called as sidebar panel is closing instead of opening r=sidebar-reviewers,sclements 
Differential Revision: https://phabricator.services.mozilla.com/D228380
 2024-11-08 13:45:00 +00:00
Jonathan Sudiaman
fab02dfc13 Bug 1926116 - Update tooltips for sidebar tools that have shortcuts r=sidebar-reviewers,fluent-reviewers,nsharpley 
Differential Revision: https://phabricator.services.mozilla.com/D227070
 2024-11-08 12:59:22 +00:00
Kelly Cochrane
23b06d590b Bug 1902667 - Add new trigger and callout for sidebar survey r=sidebar-reviewers,mviar,omc-reviewers,jsudiaman 
Differential Revision: https://phabricator.services.mozilla.com/D226831
 2024-11-05 14:39:47 +00:00
Stanca Serban
005c9bd515 Backed out changeset 3a50257f49c6 (bug 1902667) for causing mochitests fai;ures in browser_glean_sidebar.js/ CLOSED TREE 2024-11-05 03:33:45 +02:00
Kelly Cochrane
15189eebf1 Bug 1902667 - Add new trigger and callout for sidebar survey r=sidebar-reviewers,mviar,omc-reviewers,jsudiaman 
Differential Revision: https://phabricator.services.mozilla.com/D226831
 2024-11-04 21:31:17 +00:00
Stanca Serban
fbc301289e Backed out changeset 97f44f6b0d88 (bug 1902667) for causing mochitests failures. 2024-10-30 20:59:54 +02:00
Kelly Cochrane
e0e4fc4145 Bug 1902667 - Add new trigger and callout for sidebar survey r=sidebar-reviewers,mviar,omc-reviewers,jsudiaman 
Differential Revision: https://phabricator.services.mozilla.com/D226831
 2024-10-30 17:56:14 +00:00
Jonathan Sudiaman
a2e2548835 Bug 1923972 - Telemetry for icons on the sidebar r=sidebar-reviewers,nsharpley 
Differential Revision: https://phabricator.services.mozilla.com/D226681
 2024-10-23 22:25:58 +00:00
Kelly Cochrane
8f5fec9e89 Bug 1924126 - Ensure context menu can be opened via keyboard for sidebar tab items r=sidebar-reviewers,Gijs,sclements,ayeddi 
Differential Revision: https://phabricator.services.mozilla.com/D225722
 2024-10-21 20:57:34 +00:00
Sandor Molnar
1e666694aa Backed out changeset 7e2dae749d42 (bug 1924126) for causing bc failures @ browser_sidebar_context_menu CLOSED TREE 2024-10-21 20:59:58 +03:00
Kelly Cochrane
60bcf55097 Bug 1924126 - Ensure context menu can be opened via keyboard for sidebar tab items r=sidebar-reviewers,Gijs,sclements,ayeddi 
Differential Revision: https://phabricator.services.mozilla.com/D225722
 2024-10-21 16:13:46 +00:00
Kelly Cochrane
031773ad96 Bug 1899599 - Change orientation of tools and extensions in expanded sidebar when more than 5 tools/extensions r=desktop-theme-reviewers,reusable-components-reviewers,sidebar-reviewers,hjones,jsudiaman 
Differential Revision: https://phabricator.services.mozilla.com/D224983
 2024-10-15 19:56:52 +00:00
Nikki Sharpley
4059d1dd9f Bug 1922264 - Show container menu on right click of vertical tabs new tab button r=sidebar-reviewers,Gijs 
Differential Revision: https://phabricator.services.mozilla.com/D225087
 2024-10-10 13:10:44 +00:00
Nikki Sharpley
2051b4e47d Bug 1920575 - Fix right click on new tab to show container tab menu r=sidebar-reviewers,Gijs,sfoster 
Differential Revision: https://phabricator.services.mozilla.com/D223771
 2024-10-01 14:28:12 +00:00
Iulian Moraru
37eb704754 Backed out changeset 8aaffdf63d09 (bug 1920575) for causing bc failures on browser_sidebar_context_menu.js. CLOSED TREE 2024-09-27 22:15:35 +03:00
Nikki Sharpley
ff0d565288 Bug 1920575 - Fix right click on new tab to show container tab menu r=sidebar-reviewers,Gijs 
Differential Revision: https://phabricator.services.mozilla.com/D223771
 2024-09-27 14:07:12 +00:00
Kelly Cochrane
8cacd1c229 Bug 1906888 - Update focus order and move new tab button to the bottom for vertical tabs r=desktop-theme-reviewers,tabbrowser-reviewers,dao,sidebar-reviewers,ayeddi 
Differential Revision: https://phabricator.services.mozilla.com/D221244
 2024-09-20 11:40:04 +00:00
Butkovits Atila
5a9a789f82 Backed out changeset fb2f7f9f6def (bug 1906888) for causing failures at browser_newtabButton.js. CLOSED TREE 2024-09-19 22:04:46 +03:00
Kelly Cochrane
a83714bc93 Bug 1906888 - Update focus order and move new tab button to the bottom for vertical tabs r=desktop-theme-reviewers,tabbrowser-reviewers,dao,sidebar-reviewers,ayeddi 
Differential Revision: https://phabricator.services.mozilla.com/D221244
 2024-09-19 15:54:02 +00:00
Jonathan Sudiaman
15ad15eecf Bug 1898250 - Add telemetry to sidebar r=sidebar-reviewers,fxview-reviewers,sclements 
Differential Revision: https://phabricator.services.mozilla.com/D220720
 2024-09-16 15:42:48 +00:00
Dave Townsend
c88e214a59 Bug 1916961: Right clicking in the vertical tabs sidebar should show the tabs context menu. r=sidebar-reviewers,kcochrane 
Differential Revision: https://phabricator.services.mozilla.com/D221129
 2024-09-05 16:32:59 +00:00
Tamas Szentpeteri
6c877ec7e8 Backed out changeset 3423c859c8be (bug 1916961) for causing mochitest failures on browser_UsageTelemetry_toolbars.js. CLOSED TREE 2024-09-05 18:30:38 +03:00
Dave Townsend
59044cc9ba Bug 1916961: Right clicking in the vertical tabs sidebar should show the tabs context menu. r=sidebar-reviewers,kcochrane 
Differential Revision: https://phabricator.services.mozilla.com/D221129
 2024-09-05 14:16:37 +00:00
Luca Greco
0d6b227db3 Bug 1910581 - Context menu doesn't respect the add-on permissions/prefs. r=sidebar-reviewers,nsharpley 
Differential Revision: https://phabricator.services.mozilla.com/D220397
 2024-08-28 17:08:46 +00:00
Nikki Sharpley
a441acbbaa Bug 1886847 - Styling and UI polish for sidebar r=sidebar-reviewers,desktop-theme-reviewers,fxview-reviewers,reusable-components-reviewers,dao,settings-reviewers,tgiles,mconley,jsudiaman,kcochrane 
- styled synced tabs and history
- styled sidebar search
- styled customize settings
- added sidebar right icon to customize input

Differential Revision: https://phabricator.services.mozilla.com/D216748
 2024-08-02 19:10:14 +00:00
Butkovits Atila
dd41b6e962 Backed out changeset 397b2df59338 (bug 1886847) for causing failures at browser-custom-colors.css. CLOSED TREE 2024-08-02 19:18:43 +03:00
Nikki Sharpley
54d0b76fd9 Bug 1886847 - Styling and UI polish for sidebar r=sidebar-reviewers,desktop-theme-reviewers,fxview-reviewers,reusable-components-reviewers,dao,settings-reviewers,tgiles,mconley,jsudiaman,kcochrane 
- styled synced tabs and history
- styled sidebar search
- styled customize settings
- added sidebar right icon to customize input

Differential Revision: https://phabricator.services.mozilla.com/D216748
 2024-08-02 15:26:00 +00:00
Jonathan Sudiaman
1a0bf393fe Bug 1910685 - Expose sidebar strings for localization r=sidebar-reviewers,fluent-reviewers,bolsson,nsharpley 
Differential Revision: https://phabricator.services.mozilla.com/D218325
 2024-08-01 22:35:43 +00:00
Jonathan Sudiaman
93a0b7bce5 Bug 1900979 - Fix empty strings assigned in Sidebar.ftl r=sidebar-reviewers,fluent-reviewers,kcochrane 
The empty strings were used as a workaround to clear out labels when switching from expanded to collapsed state. This really should have been the component's responsibility.

Differential Revision: https://phabricator.services.mozilla.com/D218087
 2024-07-31 15:18:42 +00:00
Ed Lee
1bac981cb5 Bug 1900915 - Include chat as tool for new sidebar r=sidebar-reviewers,sclements 
Update default tool ordering. Conditionally render tool if not hidden for both main and customize.

Differential Revision: https://phabricator.services.mozilla.com/D215721
 2024-07-04 14:44:11 +00:00
Jonathan Sudiaman
fec725412b Bug 1892430 - Add a "Hide" sidebar visibility setting r=sidebar-reviewers,sessionstore-reviewers,sclements 
The toggle was there to begin with, but this commit actually gets it working to spec.

Differential Revision: https://phabricator.services.mozilla.com/D214181
 2024-06-27 19:34:08 +00:00
Jonathan Sudiaman
52e63f2908 Bug 1892941 - Add a "Always Show" sidebar visibility setting r=sidebar-reviewers,fluent-reviewers,sessionstore-reviewers,bolsson,sclements,reusable-components-reviewers,mstriemer 
Differential Revision: https://phabricator.services.mozilla.com/D212285
 2024-06-27 19:34:08 +00:00
Sarah Clements
92d796abdd Bug 1893655 - Set up the tabstrip to work vertically r=dao,sidebar-reviewers,desktop-theme-reviewers,tabbrowser-reviewers,Gijs 
* Add ability to move tabstrip into the sidebar based on a pref

Differential Revision: https://phabricator.services.mozilla.com/D212287
 2024-06-15 10:43:19 +00:00
Iulian Moraru
7af9a3a07c Backed out changeset 7c5bb1ba9d20 (bug 1893655) for causing bc failures on browser_vertical_tabs.js. 2024-06-14 18:43:35 +03:00
Sarah Clements
4758236bb0 Bug 1893655 - Set up the tabstrip to work vertically r=dao,sidebar-reviewers,desktop-theme-reviewers,tabbrowser-reviewers,Gijs 
* Add ability to move tabstrip into the sidebar based on a pref

Differential Revision: https://phabricator.services.mozilla.com/D212287
 2024-06-14 13:01:40 +00:00
Jonathan Sudiaman
6ccee8c69b Bug 1892429 - Create an expanded sidebar state r=sidebar-reviewers,fluent-reviewers,kcochrane,sclements,extension-reviewers,robwu 
Adds an `expanded` property, which, if enabled, shows labels along with their respective icons within the sidebar menu. Currently, this property is not controllable from the UI. As I understand it, the follow-up bugs are responsible for addressing that.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=f269729808eed19051bea5fe4eb41550ff94ce03

Differential Revision: https://phabricator.services.mozilla.com/D210187
 2024-05-28 15:55:49 +00:00
Kelly Cochrane
0b3b1956ca Bug 1896658 - Add bookmarks to sidebar customization panel r=sidebar-reviewers,fluent-reviewers,nsharpley,jsudiaman 
Differential Revision: https://phabricator.services.mozilla.com/D210378
 2024-05-15 19:48:00 +00:00
Nikki Sharpley
f0a31cbd25 Bug 1893505 - Add custom right-click menu to sidebar extension r=sidebar-reviewers,fluent-reviewers,Gijs,sfoster 
This patch creates a new context menu for the revamped sidebar, including existing
options for managing extensions. We should be able to build off the `onSidebarPopupShowing`
function to customize what we want to show based on what sidebar item we right click.

Differential Revision: https://phabricator.services.mozilla.com/D208951
 2024-05-15 14:30:31 +00:00