corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
864,259 Commits 1 Branch 0 Tags
7e650b7436bd46ceffec4b98075d6bda2cc487d1
Commit Graph

1876 Commits

Author SHA1 Message Date
Mark Banner
6efe8618e0 Bug 1901208 - Add an integration test to ensure that searchWith pings are correctly recorded. r=search-reviewers,mcheang 
Differential Revision: https://phabricator.services.mozilla.com/D212921
 2024-06-09 10:22:53 +00:00
Barret Rennie
871e74ca58 Bug 1829412 - Simplify NimbusTestUtils.enrollmentHelper r=chumphreys,settings-reviewers,pip-reviewers,credential-management-reviewers,search-reviewers,anti-tracking-reviewers,omc-reviewers,home-newtab-reviewers,thecount,issammani,aminomancer,mconley 
The enrollmentHelper was much more complicated than it needed to be. The
internal asynchrony that required awaiting an additional promise was fixed in
bug 1773583.

The returned cleanup function is no longer async, so unnecessary awaits have
been removed. This also applies to enrollWithFeatureConfig, as it is a wrapper
around enrollmentHelper.

Differential Revision: https://phabricator.services.mozilla.com/D212318
 2024-06-06 14:42:00 +00:00
Dale Harvey
bea695c636 Bug 1900900 - Enable trending suggestions and recent searches for release. r=daisuke 
Differential Revision: https://phabricator.services.mozilla.com/D212750
 2024-06-06 11:27:28 +00:00
Stephanie Cunnane
c0d3659ae2 Bug 1891799 - Update search-telemetry-v2 schema as part of Google account signed-in status work. r=jteow 
Differential Revision: https://phabricator.services.mozilla.com/D207627
 2024-06-05 16:13:05 +00:00
Chris H-C
85b4052c71 Bug 1900085 - Disable builtin Glean pings during tests r=TravisLong,perftest-reviewers,sparky,search-reviewers,jteow 
This patch specifically disables "baseline" and "events" pings through not
telling Glean about user (in)activity, which triggers their submission.
"baseline" should matter less, but if an "events" ping is submitted during a
test it could contain a test's recorded events that it will later want to
assert are present.

"metrics" pings are already suppressed in automation via the `MOZ_AUTOMATION`
envvar. So update the docs to note that.

"deletion-request" pings are permitted at all times for all reasons and are not
included in the builtin pings we're disabling.

Differential Revision: https://phabricator.services.mozilla.com/D212315
 2024-06-04 18:15:26 +00:00
Moritz Beier
8193d431ac Bug 1894910 - Remove function to open search page from search bar with an empty search. r=Standard8 
Differential Revision: https://phabricator.services.mozilla.com/D211832
 2024-06-03 11:09:24 +00:00
Stephanie Cunnane
260f31ac91 Bug 1892332 - Distinguish between private and regular browsing modes wrt Google signed-in telemetry. r=jteow 
Differential Revision: https://phabricator.services.mozilla.com/D212040
 2024-06-01 02:52:17 +00:00
James Teow
1e7012698d Bug 1899663 - Change _checkURLForSerpMatch and updateTrackingStatus to have less impression logic - r=scunnane 
Differential Revision: https://phabricator.services.mozilla.com/D212100
 2024-05-30 19:04:14 +00:00
James Teow
6c465da1a8 Bug 1899625 - Update search telemetry impression definition for historical context - r=scunnane DONTBUILD 
Differential Revision: https://phabricator.services.mozilla.com/D212143
 2024-05-30 18:12:21 +00:00
ujas.thakkar
7acd32b983 Bug 1874917 - Rename SearchTestUtils.promiseNewSearchEngine to SearchTestUtils.installOpenSearchEngine r=Standard8 
Differential Revision: https://phabricator.services.mozilla.com/D211309
 2024-05-23 16:17:00 +00:00
Mark Banner
bb7cb93cc2 Bug 1836804 - Remove support for {moz:locale} parameter replacements in search URLs. r=search-reviewers,daleharvey 
Differential Revision: https://phabricator.services.mozilla.com/D209972
 2024-05-13 22:10:30 +00:00
Leeya
281cc0f354 Bug 1742889 - Rewrite consumers of whereToOpenLink to use BrowserUtils.whereToOpenLink. r=Gijs,search-reviewers,places-reviewers,firefox-desktop-core-reviewers ,home-newtab-reviewers,reusable-components-reviewers,hjones,nbarrett 
Differential Revision: https://phabricator.services.mozilla.com/D208680
 2024-05-08 14:33:17 +00:00
Yazan Al Macki
deeab6e381 Bug 1887966 - Remove unnecessary async from schema test and make the UI ordering consistent with the schema. r=jteow,search-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D209803
 2024-05-08 14:04:59 +00:00
Stanca Serban
abbf8b4412 Backed out changeset ede7a0b15af0 (bug 1742889) for causing node tests failures. CLOSED TREE 2024-05-03 23:12:24 +03:00
Leeya
23b26e9421 Bug 1742889 - Rewrite consumers of whereToOpenLink to use BrowserUtils.whereToOpenLink. r=Gijs,search-reviewers,places-reviewers,firefox-desktop-core-reviewers ,home-newtab-reviewers,reusable-components-reviewers,hjones,nbarrett 
Differential Revision: https://phabricator.services.mozilla.com/D208680
 2024-05-03 19:05:59 +00:00
James Teow
cfe7e470ff Bug 1851907 - Remove SERP Telemetry v1 feature gating pref - r=scunnane 
Differential Revision: https://phabricator.services.mozilla.com/D207947
 2024-05-01 17:41:04 +00:00
James Teow
b70500ad86 Bug 1892267 - Add ads hidden and ads loaded to the categorization event - r=scunnane 
This augments the existing metric that contains the number of ads that were visible at the
time the page was snapshot.

Differential Revision: https://phabricator.services.mozilla.com/D207935
 2024-04-19 00:11:56 +00:00
Stephanie Cunnane
924cbf7d28 Bug 1877494 - Collect telemetry on Google account signed-in status. r=jteow 
Differential Revision: https://phabricator.services.mozilla.com/D207206
 2024-04-15 19:30:24 +00:00
James Teow
8c082e0c2c Bug 1889677 - Modify SERP categorization tests to wait for events - r=scunnane 
Differential Revision: https://phabricator.services.mozilla.com/D206909
 2024-04-08 19:24:50 +00:00
Mark Banner
6699dcb7f8 Bug 1799465 - Enable require-jsdoc rules by default, disabling on code where there are existing failures. r=frontend-codestyle-reviewers,migration-reviewers,backup-reviewers,mossop,mconley 
Differential Revision: https://phabricator.services.mozilla.com/D206878
 2024-04-08 13:34:13 +00:00
James Teow
0ff995ac8c Bug 1889940 - Add additional logging for domain extraction - r=scunnane 
Differential Revision: https://phabricator.services.mozilla.com/D206777
 2024-04-05 15:32:52 +00:00
James Teow
4935a2a56a Bug 1886095 - Store hashed domain to categories inside Sqlite - r=mak,scunnane 
Differential Revision: https://phabricator.services.mozilla.com/D205025
 2024-04-04 12:25:52 +00:00
Stephanie Cunnane
4c9a2ed714 Bug 1887943 - Refine textContent domain extraction method. r=jteow 
Differential Revision: https://phabricator.services.mozilla.com/D205928
 2024-04-02 16:08:19 +00:00
James Teow
d668670dc8 Bug 1887227 - Allow the ability to reset CategorizationRecorder from tests - r=scunnane 
When turning the feature gating pref on and running tests, it revealed one oversight:
When test files are run and we reset telemetry, we don't properly unload the internal
state of CategorizationRecorder. Doing so means that we can keep the "threshold" variable
in a non-zero state despite reseting all telemetry, which can cause submit() to fire when
we don't expect it.

Differential Revision: https://phabricator.services.mozilla.com/D205507
 2024-03-26 17:25:19 +00:00
James Teow
14a4f21eb3 Bug 1887233 - Don't count non-sponsored components as visible ads - r=scunnane 
Differential Revision: https://phabricator.services.mozilla.com/D205570
 2024-03-26 01:57:31 +00:00
Stephanie Cunnane
14eeeccf77 Bug 1887686 - Add shopping page property to SERP categorization event. r=jteow 
Differential Revision: https://phabricator.services.mozilla.com/D205607
 2024-03-25 21:31:28 +00:00
Mark Banner
937ef9b2d2 Bug 1878834 - Rename search-telemetry-schema to include v2 and add ui schema tests. r=scunnane 
Depends on D205250

Differential Revision: https://phabricator.services.mozilla.com/D205341
 2024-03-25 14:06:37 +00:00
Stephanie Cunnane
b0eb07fcf2 Bug 1880212 - Update search-telemetry-v2 schema as part of SERP categorization work. r=jteow 
Differential Revision: https://phabricator.services.mozilla.com/D205250
 2024-03-25 14:06:36 +00:00
Stephanie Cunnane
ae45f2ecde Bug 1872935 - Reconcile original categorization ping patches with updated code. r=jteow,firefox-desktop-core-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D197826
 2024-03-22 17:57:09 +00:00
Noemi Erli
10a10f24fb Backed out changeset bc969033195f (bug 1872935) for causing failures in test_ping_submitted.py 2024-03-21 00:56:09 +02:00
Stephanie Cunnane
b44b0f6d2d Bug 1872935 - Reconcile original categorization ping patches with updated code. r=jteow 
Differential Revision: https://phabricator.services.mozilla.com/D197826
 2024-03-20 21:12:19 +00:00
Stephanie Cunnane
c31535c61f Bug 1868476 - Part 2 - Create the SERP categorization event. r=jteow 
Differential Revision: https://phabricator.services.mozilla.com/D204418
 2024-03-20 21:12:19 +00:00
Cristian Tuns
6053c16cee Backed out changeset e38df2dd9c60 (bug 1872935) for causing bc failures in browser_search_glean_serp_event_telemetry_categorization_enabled_by_nimbus_variable.js CLOSED TREE 2024-03-20 16:33:47 -04:00
Stephanie Cunnane
6830f8d52e Bug 1872935 - Reconcile original categorization ping patches with updated code. r=jteow 
Differential Revision: https://phabricator.services.mozilla.com/D197826
 2024-03-20 19:26:39 +00:00
Stephanie Cunnane
7d50f2f3d7 Bug 1885169 - Make 'skipCount' in search-telemetry-schema a definition rather than a possible property on each element. r=jteow 
Differential Revision: https://phabricator.services.mozilla.com/D204793
 2024-03-15 19:46:34 +00:00
Stephanie Cunnane
c628d16a82 Bug 1846367 - Extract domains from text content if other methods won't work. r=jteow 
Differential Revision: https://phabricator.services.mozilla.com/D204420
 2024-03-14 22:53:34 +00:00
Stephanie Cunnane
e87c47ee40 Bug 1868476 - Part 1 - Create the SERP categorization custom ping. r=jteow 
Differential Revision: https://phabricator.services.mozilla.com/D196217
 2024-03-14 15:47:55 +00:00
Mark Banner
99b2331403 Bug 1867288 - Load application provided search engine icons from remote settings. r=search-reviewers,mcheang,mconley 
Depends on D204529

Differential Revision: https://phabricator.services.mozilla.com/D204263
 2024-03-13 22:14:28 +00:00
mcheang
9cff78d6ec Bug 1885177 - Fix test_settings_persist, browser_rich_suggestions and browser_searchEngine_behaviors with search-config-v2 enabled. r=Standard8 
Differential Revision: https://phabricator.services.mozilla.com/D204529
 2024-03-13 22:14:27 +00:00
Butkovits Atila
f35ecbe910 Backed out 3 changesets (bug 1885193, bug 1885177, bug 1867288) for causing documentation failure. CLOSED TREE 
Backed out changeset 80f62f285117 (bug 1885193)
Backed out changeset 91c5d5cb698c (bug 1867288)
Backed out changeset e0611f8935ff (bug 1885177)
 2024-03-13 23:25:16 +02:00
Mark Banner
8432a66c33 Bug 1867288 - Load application provided search engine icons from remote settings. r=search-reviewers,mcheang,mconley 
Differential Revision: https://phabricator.services.mozilla.com/D204263
 2024-03-13 20:25:06 +00:00
mcheang
fe2c92c581 Bug 1885177 - Fix test_settings_persist, browser_rich_suggestions and browser_searchEngine_behaviors with search-config-v2 enabled. r=Standard8 
Differential Revision: https://phabricator.services.mozilla.com/D204529
 2024-03-13 20:25:06 +00:00
Mark Banner
db1c82325d Bug 1885121 - Fix a few more tests that are broken with search-config-v2 enabled. r=mcheang 
Differential Revision: https://phabricator.services.mozilla.com/D204500
 2024-03-13 14:51:07 +00:00
Mark Banner
f65518c3c0 Bug 1882577 - Make nsISearchEngine.getIconURL an async function. r=search-reviewers,extension-reviewers,settings-reviewers,robwu,mcheang,mak 
Differential Revision: https://phabricator.services.mozilla.com/D203026
 2024-03-13 14:51:06 +00:00
James Teow
d891b571f2 Bug 1883916 - Add nonAdsLinkQueryParamNames to search-telemetry-schema - r=Standard8 
Adds a new property that will be used to extract the intended href to load on SERPs
that contain the actual URL in a query param key not known until they click on the
actual link.

Differential Revision: https://phabricator.services.mozilla.com/D204355
 2024-03-13 00:34:56 +00:00
James Teow
e7c6bac76d Bug 1875287 - Extract urls from query param values in links when required - r=scunnane 
Differential Revision: https://phabricator.services.mozilla.com/D201841
 2024-03-12 01:31:11 +00:00
mcheang
e86c953b7b Bug 1870685 - Ensure mochi browser chrome tests pass with search-config-v2 enabled. r=Standard8 
Depends on D202637

Differential Revision: https://phabricator.services.mozilla.com/D204133
 2024-03-11 17:07:13 +00:00
Mark Banner
afdbce2ec3 Bug 1884623 - Update more jsm references in production code and docs in browser/. r=mossop,extension-reviewers,omc-reviewers,migration-reviewers,robwu,mconley,aminomancer 
Differential Revision: https://phabricator.services.mozilla.com/D204182
 2024-03-11 15:26:28 +00:00
Karandeep
d54583fc7d Bug 1849371 - Add cookie banner as a possible serp.ad_impression component and the user choice as one of the serp.engagement targets. r=jteow 
Differential Revision: https://phabricator.services.mozilla.com/D200862
 2024-03-08 11:47:46 +00:00
James Teow
eea7373fb2 Bug 1884219 - Don't extract hrefs from elements if it contains Javascript - r=scunnane 
The extractHrefs method is used to retrieve hrefs from components before passing it
SearchSERPTelemetry to store for future use when observer activity in the network process.
Javascript URLs are uncommon but can accidentally be extracted, especially if a topDown
search for elements is used. No test is added because the presence of the element in an
categorized component will break existing tests.

Differential Revision: https://phabricator.services.mozilla.com/D203957
 2024-03-08 11:26:48 +00:00