Sammy Khamis
075b628967
Bug 1925377: Refactor updateFxAPanel r=sync-reviewers,markh
...
Differential Revision: https://phabricator.services.mozilla.com/D226434
2024-11-12 23:30:57 +00:00
Sammy Khamis
b3423d6a97
Bug 1925377: Update treatment of 'Turn on Syncing...' option r=sync-reviewers,fluent-reviewers,desktop-theme-reviewers,markh,hjones
...
Differential Revision: https://phabricator.services.mozilla.com/D226202
2024-10-28 23:10:47 +00:00
Mike Conley
a52a1d1d9f
Bug 1922594 - Add strings for FxA menu messages and the ability to experiment with the sign-in CTA on both panels. r=fluent-reviewers,omc-reviewers,skhamis,desktop-theme-reviewers,bolsson,pdahiya,hjones
...
The CTAs for the AppMenu have a collapsed state (since the AppMenu has a Sign In
button to the right of the CTA taking up space), whereas the CTAs for
the FxA avatar panel do not.
Differential Revision: https://phabricator.services.mozilla.com/D224948
2024-10-19 20:45:50 +00:00
Norisz Fay
295237067d
Backed out 2 changesets (bug 1922594) for causing bc failures on browser_sync.js CLOSED TREE
...
Backed out changeset 32bbfcc1607a (bug 1922594)
Backed out changeset 9372edf868fe (bug 1922594)
2024-10-19 03:25:51 +03:00
Mike Conley
53a3f31513
Bug 1922594 - Add strings for FxA menu messages and the ability to experiment with the sign-in CTA on both panels. r=fluent-reviewers,omc-reviewers,skhamis,desktop-theme-reviewers,bolsson,pdahiya,hjones
...
The CTAs for the AppMenu have a collapsed state (since the AppMenu has a Sign In
button to the right of the CTA taking up space), whereas the CTAs for
the FxA avatar panel do not.
Differential Revision: https://phabricator.services.mozilla.com/D224948
2024-10-18 20:43:29 +00:00
Mike Conley
dd4373aecb
Bug 1920799 - Add a new messaging surface to the AppMenu and PXI menus for describing the value of signing into an FxA. r=pdahiya,Gijs,desktop-theme-reviewers,omc-reviewers,home-newtab-reviewers,fluent-reviewers,hjones,skhamis,nbarrett
...
Developing tests in a later patch in this series.
Differential Revision: https://phabricator.services.mozilla.com/D223409
2024-10-15 16:15:09 +00:00
Florian Quèze
c5a791b369
Bug 1918702 - Migrate telemetry events to use Glean APIs for sync, r=chutten.
...
Differential Revision: https://phabricator.services.mozilla.com/D222807
2024-09-25 02:46:36 +00:00
Sammy Khamis
b0ede54e8f
Bug 1908282: Add tooltip to close tab button r=markh,fluent-reviewers,bolsson
...
Differential Revision: https://phabricator.services.mozilla.com/D216886
2024-07-19 20:43:17 +00:00
Sammy Khamis
3bdb7ad62c
Bug 1908686: FxA sign in entrypoint should match clients r=markh
...
Differential Revision: https://phabricator.services.mozilla.com/D217048
2024-07-19 18:43:03 +00:00
Sammy Khamis
5cd803a66b
Bug 1905172: UI tweaks to closing tabs remotely r=sync-reviewers,desktop-theme-reviewers,markh,sfoster
...
Differential Revision: https://phabricator.services.mozilla.com/D216079
2024-07-12 00:33:20 +00:00
Sammy Khamis
fc20d583be
Bug 1905172: UI tweaks to closing tabs remotely r=markh,desktop-theme-reviewers,jules,dao
...
Differential Revision: https://phabricator.services.mozilla.com/D215173
2024-07-02 20:53:44 +00:00
Sammy Khamis
596a425412
Bug 1901868: Remove last remotely closed tab fom list r=markh,desktop-theme-reviewers,sfoster
...
Differential Revision: https://phabricator.services.mozilla.com/D213357
2024-06-17 19:02:41 +00:00
Sammy Khamis
a05f284d32
Bug 1892340: Hide pending remote tab closures r=lina,markh,desktop-theme-reviewers,sync-reviewers,dao
...
Differential Revision: https://phabricator.services.mozilla.com/D208419
2024-06-10 19:57:25 +00:00
Sammy Khamis
5e669d4bf1
Bug 1900131: Fix FxA toolbar telemetry bug r=markh
...
Differential Revision: https://phabricator.services.mozilla.com/D212332
2024-06-06 19:49:05 +00:00
Mark Hammond
236a4184ef
Bug 1895521 - fix fxa telemetry in the main browser UI. r=skhamis
...
browser-sync.js has got a bit disorganized over time. This patch tries to consolidate
all checks for which part of the UI is being interacted with and ensures both client
and server telemetry agree on the interaction, and as a part of this, ensures that
interactions with the fxa-toolbar item and the app menu are reported correctly.
Differential Revision: https://phabricator.services.mozilla.com/D209696
2024-05-23 19:54:46 +00:00
Aron Cseh
217809cd6b
Backed out changeset 4db006d78935 (bug 1895521) for causing mochitest failures on browser_synced_tabs_menu.js CLOSED TREE
2024-05-21 23:25:04 +03:00
Mark Hammond
0100e17f73
Bug 1895521 - fix fxa telemetry in the main browser UI. r=skhamis
...
browser-sync.js has got a bit disorganized over time. This patch tries to consolidate
all checks for which part of the UI is being interacted with and ensures both client
and server telemetry agree on the interaction, and as a part of this, ensures that
interactions with the fxa-toolbar item and the app menu are reported correctly.
Differential Revision: https://phabricator.services.mozilla.com/D209696
2024-05-21 19:20:40 +00:00
Tarik Eshaq
8ff840ac17
Bug 1887739: Removes force_auth fxa path and uses connect path instead.r=markh,settings-reviewers
...
Differential Revision: https://phabricator.services.mozilla.com/D208783
2024-05-17 18:00:06 +00:00
Leeya
281cc0f354
Bug 1742889 - Rewrite consumers of whereToOpenLink to use BrowserUtils.whereToOpenLink. r=Gijs,search-reviewers,places-reviewers,firefox-desktop-core-reviewers ,home-newtab-reviewers,reusable-components-reviewers,hjones,nbarrett
...
Differential Revision: https://phabricator.services.mozilla.com/D208680
2024-05-08 14:33:17 +00:00
Stanca Serban
abbf8b4412
Backed out changeset ede7a0b15af0 (bug 1742889) for causing node tests failures. CLOSED TREE
2024-05-03 23:12:24 +03:00
Leeya
23b26e9421
Bug 1742889 - Rewrite consumers of whereToOpenLink to use BrowserUtils.whereToOpenLink. r=Gijs,search-reviewers,places-reviewers,firefox-desktop-core-reviewers ,home-newtab-reviewers,reusable-components-reviewers,hjones,nbarrett
...
Differential Revision: https://phabricator.services.mozilla.com/D208680
2024-05-03 19:05:59 +00:00
Mark Hammond
cf93ae331c
Bug 1893657 - Inactive tabs from other devices show in a panel subview. r=skhamis,fluent-reviewers,bolsson
...
Differential Revision: https://phabricator.services.mozilla.com/D208750
2024-05-02 19:08:20 +00:00
Sammy Khamis
8b5458495a
Bug 1885645: Update FxA sign in menu r=markh,teshaq,desktop-theme-reviewers
...
Differential Revision: https://phabricator.services.mozilla.com/D208249
2024-05-02 14:22:16 +00:00
dschomburg
9f03a40c4f
Bug 1853818 - Remove toolkit/branding/accounts.ftl file r=flod,fluent-reviewers,settings-reviewers,credential-management-reviewers,fxview-reviewers,omc-reviewers,firefox-desktop-core-reviewers ,mconley,aminomancer,mak,sgalich,nsharpley,mkaply
...
Differential Revision: https://phabricator.services.mozilla.com/D190612
2024-04-22 16:24:30 +00:00
Gijs Kruitbosch
18d848d0c7
Bug 1890718 - move send tab event handlers to not use inline event attributes, r=sync-reviewers,lina
...
This also reorganizes some duplicated handlers a little and fixes an eslint warning for lexical declarations inside case blocks.
Differential Revision: https://phabricator.services.mozilla.com/D207878
2024-04-22 13:07:24 +00:00
Gijs Kruitbosch
dc38a85d9b
Bug 1890718 - move mouseover sync panel handlers away from inline handlers, r=sync-reviewers,lina
...
Differential Revision: https://phabricator.services.mozilla.com/D207877
2024-04-22 13:07:23 +00:00
Sammy Khamis
9ad1c9d961
Bug 1885064 - Ability to send and receive close remote tab pushes r=lina,desktop-theme-reviewers,firefox-desktop-core-reviewers ,emilio,Gijs,tabbrowser-reviewers,dao
...
Differential Revision: https://phabricator.services.mozilla.com/D204556
2024-04-19 20:13:16 +00:00
Cristian Tuns
8904d3681a
Backed out changeset ab9a461da1ee (bug 1885064) for causing xpcshell failures in test_commands_closetab.js CLOSED TREE
2024-04-19 15:45:22 -04:00
Sammy Khamis
4e28b48a03
Bug 1885064 - Ability to send and receive close remote tab pushes r=lina,desktop-theme-reviewers,firefox-desktop-core-reviewers ,emilio,Gijs,tabbrowser-reviewers,dao
...
Differential Revision: https://phabricator.services.mozilla.com/D204556
2024-04-19 18:44:43 +00:00
Gijs Kruitbosch
b60eb110cc
Bug 1890718 - remove sync/fxa pane inline command listeners, r=sync-reviewers,lina
...
This also tidies up some variable naming (we were passing 'panel's that were not, in fact, panels)
and removes some methods that we no longer call.
Bug 1690131 removed the last call to 'showRemoteTabsFromFxaMenu', bug 1562006 removed the last
call to 'showSidebarFromFxaMenu', AFAICT.
Differential Revision: https://phabricator.services.mozilla.com/D207452
2024-04-15 23:23:52 +00:00
Dave Townsend
ab57b0fdc1
Bug 1864896: Autofix unused function arguments (browser/base/content). r=Gijs,application-update-reviewers,tabbrowser-reviewers,places-reviewers,bytesized,dao
...
Differential Revision: https://phabricator.services.mozilla.com/D202949
2024-03-19 14:59:20 +00:00
Sammy Khamis
42873ca3cc
Bug 1882888: Sync and save data btn should go directly to fxa sign in r=markh
...
Differential Revision: https://phabricator.services.mozilla.com/D203204
2024-03-01 18:40:22 +00:00
Sammy Khamis
cbcf1c8bcb
Bug 1880556: Add toggles for FxA products r=sync-reviewers,markh
...
Differential Revision: https://phabricator.services.mozilla.com/D202365
2024-02-22 19:32:34 +00:00
Sammy Khamis
67ebc3f19f
Bug 1879610: Update PXI panel link entrypoints r=markh
...
Differential Revision: https://phabricator.services.mozilla.com/D201272
2024-02-15 19:43:02 +00:00
Sammy Khamis
5e8457cfe7
Bug 1879211: Move PXI toolbar strings into localization tree r=markh,flod
...
Differential Revision: https://phabricator.services.mozilla.com/D201025
2024-02-13 18:42:17 +00:00
Sammy Khamis
e25765a5d1
Bug 1878808: Update FxA toolbar button link r=markh
...
Differential Revision: https://phabricator.services.mozilla.com/D201017
2024-02-08 19:26:52 +00:00
Mark Hammond
4be4e61f1a
Bug 1878310 - remote tabs marked as hidden are hidden in the synced tabs menu by default. r=sclements,skhamis,fluent-reviewers,sync-reviewers
...
Differential Revision: https://phabricator.services.mozilla.com/D200450
2024-02-06 18:53:06 +00:00
Sammy Khamis
19756af686
Bug 1873766: Fix VPN icon in light mode r=teshaq,desktop-theme-reviewers,sfoster
...
Differential Revision: https://phabricator.services.mozilla.com/D198442
2024-01-12 23:32:16 +00:00
Norisz Fay
f6d4a1089a
Backed out changeset 4bb3bb7ae82a (bug 1873766) for causing bc failures on browser_sync.js CLOSED TREE
2024-01-13 00:21:19 +02:00
Sammy Khamis
0fe2dcf823
Bug 1873766: Fix VPN icon in light mode r=teshaq,desktop-theme-reviewers,sfoster
...
Differential Revision: https://phabricator.services.mozilla.com/D198442
2024-01-12 19:43:01 +00:00
Sammy Khamis
249dd51c48
Bug 1867098: FxA PXI Toolbar experiment r=teshaq,desktop-theme-reviewers,flod,dao
...
Differential Revision: https://phabricator.services.mozilla.com/D194916
2023-12-13 22:08:33 +00:00
Stanca Serban
2e220c68ae
Backed out changeset 2499ef5644ea (bug 1867098) as requested for causing Bug 1869728.
2023-12-13 16:21:31 +02:00
Sammy Khamis
4250cfa9bc
Bug 1867098: FxA PXI Toolbar experiment r=teshaq,desktop-theme-reviewers,flod,dao
...
Differential Revision: https://phabricator.services.mozilla.com/D194916
2023-12-11 21:53:53 +00:00
Tarik Eshaq
698216944d
Bug 1855513: Move in-browser verification to open web content. r=markh,fluent-reviewers,settings-reviewers,Gijs,bolsson
...
Differential Revision: https://phabricator.services.mozilla.com/D193678
2023-11-22 17:58:18 +00:00
dschomburg
3f4ce2547c
Bug 1853815 - Remove "Firefox account" branding from FxA app menu. r=flod,fluent-reviewers
...
This replaces the term Firefox account with Account in FxA's app menu.
This replaces the term Firefox account with your account in FxA's sign out pop up.
Differential Revision: https://phabricator.services.mozilla.com/D188615
2023-09-20 06:23:35 +00:00
Itiel
213e2bd9a9
Bug 1830679 - Convert element.setAttribute(data-l10n-{id,args}) uses in the codebase to document.l10n.setAttributes(element, id, args) r=eemeli,Gijs,willdurand,extension-reviewers,settings-reviewers,search-reviewers,devtools-reviewers,fxview-reviewers,mconley,Standard8,jdescottes,kcochrane,tabbrowser-reviewers
...
Differential Revision: https://phabricator.services.mozilla.com/D176791
2023-06-14 17:16:39 +00:00
Iulian Moraru
ff572127aa
Backed out changeset 76c5afdda762 (bug 1830679) for causing xpcshell failures on test_VariablesView_filtering-without-controller.js. CLOSED TREE
2023-06-12 22:03:43 +03:00
Itiel
548aeccf66
Bug 1830679 - Convert element.setAttribute(data-l10n-{id,args}) uses in the codebase to document.l10n.setAttributes(element, id, args) r=eemeli,Gijs,willdurand,extension-reviewers,settings-reviewers,search-reviewers,devtools-reviewers,fxview-reviewers,mconley,Standard8,jdescottes,kcochrane,tabbrowser-reviewers
...
Differential Revision: https://phabricator.services.mozilla.com/D176791
2023-06-12 17:16:35 +00:00
Mark Hammond
7ce4df6ae2
Bug 1710338 - Prefer the FxA displayName over the email address in the app menu. r=Gijs
...
Differential Revision: https://phabricator.services.mozilla.com/D180437
2023-06-12 13:10:00 +00:00
Eemeli Aro
9ee28b3a4e
Bug 1448444 - Drop signInToSync.description string as unused. r=markh,sync-reviewers
...
This was only used to format the tooltip of the "Sync now" button in the Firefox Accounts app menu pane when the UI's state was such that the whole pane would not be displayed.
Differential Revision: https://phabricator.services.mozilla.com/D178804
2023-05-29 15:24:38 +00:00