My main motivation is that it is easier to type Maps than Objects-as-maps, but
using Objects as maps can have some odd behavior if you aren't careful, so I
think it is probably a better idea to use anyways for this data that might
be coming from a compromised child process.
This slightly alters the behavior of autofillFields because it modifies
the existing map in place rather than creating a new one from scratch,
but I think that is preferable because nothing seems to have an external
reference so there's no need to preserve the old map.
Differential Revision: https://phabricator.services.mozilla.com/D219361
It turns out that many sites are modifying the field state immediately after a value has been autofilled, typically to format the value such as add spaces between parts of a credit card number
Differential Revision: https://phabricator.services.mozilla.com/D215113
This patch makes the following changes:
1. Converts the xpcshell tests test_clearPopulatedForm.js and test_previewFormFields.js to browser tests.
This change is necessary because the logic is moved from the child to the parent, requiring integration
tests instead.
2. Replaces the custom popup listener in FormAutofillChild with `BrowserTestUtils.waitForPopupEvent`
3. Updates add_heuristic_tests to align with the new architecture.
4. Updates unit tests that use the 'active' section because there is no "active" section anymore.
Differential Revision: https://phabricator.services.mozilla.com/D211554
We have moved most of the logic from the child to the parent. This patch updates
the locations where telemetry is now recorded in the parent. Additionally,
it updates the API of AutofillTelemetry to comply with the new architecture.
Differential Revision: https://phabricator.services.mozilla.com/D211552
This patch makes the following changes:
1. Converts the xpcshell tests test_clearPopulatedForm.js and test_previewFormFields.js to browser tests.
This change is necessary because the logic is moved from the child to the parent, requiring integration
tests instead.
2. Replaces the custom popup listener in FormAutofillChild with `BrowserTestUtils.waitForPopupEvent`
3. Updates add_heuristic_tests to align with the new architecture.
4. Updates unit tests that use the 'active' section because there is no "active" section anymore.
Differential Revision: https://phabricator.services.mozilla.com/D211554
We have moved most of the logic from the child to the parent. This patch updates
the locations where telemetry is now recorded in the parent. Additionally,
it updates the API of AutofillTelemetry to comply with the new architecture.
Differential Revision: https://phabricator.services.mozilla.com/D211552
Remove the automatic assignment of the preference extensions.formautofill.addresses.capture.requiredFields in tests and force each test to manually set it since using the preference is no longer expected.
Differential Revision: https://phabricator.services.mozilla.com/D213779
This is shorter, and has the advantage that it behaves properly on Linux (not
just ubuntu). Also, it is more future-proof.
Differential Revision: https://phabricator.services.mozilla.com/D213880
The enrollmentHelper was much more complicated than it needed to be. The
internal asynchrony that required awaiting an additional promise was fixed in
bug 1773583.
The returned cleanup function is no longer async, so unnecessary awaits have
been removed. This also applies to enrollWithFeatureConfig, as it is a wrapper
around enrollmentHelper.
Differential Revision: https://phabricator.services.mozilla.com/D212318
***
Bug 1898323 - follow-up: fix tests now that beta/release default to not enabling CC/pwd autofill os reauth
***
Bug 1898323 - fix about:logins and formautofill tests better given the disabling of OS reauth on beta/release
***
Bug 1898323 - Fix OsAuth migration for beta and have it disabled by default on Beta and Release. r=ssachdev!,issammani!
***
Bug 1899368 - Disable OS Auth for new users in Beta and Release. r=issammani!,gijs!
***
Aligned anti_clickjacking with beta
Differential Revision: https://phabricator.services.mozilla.com/D212577
