Commit Graph

89 Commits

Author SHA1 Message Date
aminomancer
7aebd7f3db Bug 1591040 - show both fullscreen and normal toolbar/tabstrip context menus in full screen, r=jaws,Gijs
Differential Revision: https://phabricator.services.mozilla.com/D131493
2022-01-21 22:52:24 +00:00
Norisz Fay
d35104b746 Backed out changeset e23259733a51 (bug 1591040) for causing bc failures on browser_fullscreen_context_menu.js CLOSED TREE 2022-01-19 13:32:54 +02:00
aminomancer
3394fc2082 Bug 1591040 - show both fullscreen and normal toolbar/tabstrip context menus in full screen, r=jaws,Gijs
Differential Revision: https://phabricator.services.mozilla.com/D131493
2022-01-19 10:14:34 +00:00
Edgar Chen
55e49c6194 Bug 1739220 - Handle fullscreen state in a more reliable way; r=smaug,Gijs
Differential Revision: https://phabricator.services.mozilla.com/D131185
2021-12-17 09:15:10 +00:00
Csoregi Natalia
f20254ab82 Backed out 2 changesets (bug 1739220) for causing multiple failures e.g.browser_media_control_non_eligible_media.js. CLOSED TREE
Backed out changeset 20bce7cd571c (bug 1739220)
Backed out changeset f69aa1b07b51 (bug 1739220)
2021-12-14 20:32:26 +02:00
Edgar Chen
8add597890 Bug 1739220 - Handle fullscreen state in a more reliable way; r=smaug,Gijs
Differential Revision: https://phabricator.services.mozilla.com/D131185
2021-12-14 15:23:54 +00:00
Paul Zuehlcke
0ca511ff0f Bug 1739091, r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D131268
2021-11-22 16:11:45 +00:00
Harry Twyford
45025048ce Bug 1701929 - Define positioning required for Mac fullscreen slide in CSS to avoid frame reconstruction. r=mstange,Gijs
Baseline profile: https://share.firefox.dev/3p5PgDn (jank)
Profile with just setting pinned tab position to absolute: https://share.firefox.dev/30jKR5p (jank)
Profile with just moving relative positioning to CSS: https://share.firefox.dev/3p6c5a7 (jank)
Profile with this patch: https://share.firefox.dev/3FRLmnK (no jank)

Markus said setting abspos pinned tabs would be safe as long as there were no relative-positioned ancestors in the tab overflow scrollbox. The only notable ancestor of a pinned tab is the tab arrowscrollbox itself, so there aren't any surprise ancestors here. Manual testing indicates things work fine.

I also confirmed that this patch fixes bug 1725151.

Differential Revision: https://phabricator.services.mozilla.com/D121403
2021-10-20 13:59:23 +00:00
Emilio Cobos Alvarez
2edef0e001 Bug 1735318 - Unify "native" vs. "fullscreen" window controls. r=desktop-theme-reviewers,dao
I've tested this (both with and without titlebar) in Linux, Win10,
Win11, Win7 and macOS.

 * On macOS behavior doesn't change at all (since on fullscreen we didn't
show the buttons to begin with).

 * Linux now shows "native" buttons on fullscreen (which is also an
improvement).

 * On Windows 10/11 the sizing of the buttons is now the same when
fullscreen vs. not (which is an improvement).

 * On Windows 7 we now use regular native-looking buttons (like on
   windows 10) instead of the custom windowControls.png. That could be
   considered a slight regression I guess, but is consistent with win10.

Differential Revision: https://phabricator.services.mozilla.com/D128196
2021-10-12 13:20:13 +00:00
Harry Twyford
3468883144 Bug 1706901 - Allow the toolbar to shift with position: relative. r=mstange,desktop-theme-reviewers,dao
Differential Revision: https://phabricator.services.mozilla.com/D113612
2021-04-28 20:15:38 +00:00
Harry Twyford
787f35839a Bug 740148 - Allow toolbar autohide in fullscreen on macOS, but disable it by default. r=mac-reviewers,mstange,bradwerth
Differential Revision: https://phabricator.services.mozilla.com/D110573
2021-04-01 18:16:25 +00:00
Harry Twyford
2be160a28f Bug 1695921 - Rename OSXLionFullscreen to macOSNativeFullscreen. r=mac-reviewers,mstange
Differential Revision: https://phabricator.services.mozilla.com/D109931
2021-03-26 16:34:54 +00:00
Harry Twyford
bd1a4f8ca2 Bug 1699506 - Part 2 - Add CSS rules to shift the toolbar over the content when the macOS menubar is shown. r=mstange
Differential Revision: https://phabricator.services.mozilla.com/D106847
2021-03-18 20:20:40 +00:00
james
c8a67215e0 Bug 1691274 - Use DOM hidden property methods instead of attribute methods in browser/ directory. r=ntim,preferences-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D104552
2021-02-13 23:33:51 +00:00
Narcis Beleuzu
d5390af0ba Backed out changeset b3fcb4fcea64 (bug 1691274) for bc failures on browser_pointerlock_warning.js . CLOSED TREE 2021-02-13 21:46:51 +02:00
james
1c970f6297 Bug 1691274 - Use DOM hidden property methods instead of attribute methods in browser/ directory. r=ntim,preferences-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D104552
2021-02-13 18:11:18 +00:00
Emma Malysz
779c8f15b9 Bug 1678211, remove unused fullscreen.used telemetry probe r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D98124
2020-12-01 16:59:30 +00:00
Xidorn Quan
ddbb4074f5 Bug 729011 - Make fullscr-toggler not affect viewport size. r=dao
Differential Revision: https://phabricator.services.mozilla.com/D97736
2020-11-20 11:21:03 +00:00
Steven MacLeod
c75aa0c6fc Bug 1656741, r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D91760
2020-10-05 22:38:03 +00:00
Gijs Kruitbosch
38116bcd2a Bug 1663879 - do not show 'pdf.js' as the origin of the full screen request, r=jaws
Depends on D89675

Differential Revision: https://phabricator.services.mozilla.com/D89676
2020-09-11 15:05:50 +00:00
Gijs Kruitbosch
ff8194eb68 Bug 1663879 - migrate fullscreen and pointer lock warnings to fluent, r=jaws,fluent-reviewers,flod
Differential Revision: https://phabricator.services.mozilla.com/D89675
2020-09-12 20:09:26 +00:00
Alphan Chen
edb5050b7e Bug 1644484 - Handle the TypeError and InvalidStateError when calling FullScreen.cleanupDomFullscreen() from DOMFullscreenParent.didDestroy() r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D81716
2020-07-03 03:00:53 +00:00
Jan Horak
fa84722e46 Bug 1594738 Remove top black line from kiosk mode; r=mkaply
There is a fullscr-toggler still shown in kiosk mode. This patch
disables it showing when in kiosk mode.

Differential Revision: https://phabricator.services.mozilla.com/D81828
2020-07-01 13:31:14 +00:00
Emma Malysz
f713450311 Bug 1645460, switch from the expired FX_BROWSER_FULLSCREEN_USED to a scalar that we actually collect until Fx86 r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D79519
2020-06-17 18:07:40 +00:00
Xidorn Quan
6caaa147cd Bug 1276537 part 3 - Remove OS X detection code from full screen handling. r=dao
Differential Revision: https://phabricator.services.mozilla.com/D74556
2020-05-13 12:43:09 +00:00
Gijs Kruitbosch
ac92dd370a Bug 1631229 - make popup hiding exiting fullscreen work correctly for tooltips, r=dao
Differential Revision: https://phabricator.services.mozilla.com/D72461
2020-04-27 09:30:40 +00:00
Dão Gottwald
724f548867 Bug 1632166 - Obey prefers-reduced-motion when animating toolbars for fullscreen mode. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D71959
2020-04-23 22:15:53 +00:00
Drew Willcoxon
ba131af622 Bug 1610200 - In full screen, properly hide the toolbars after the user picks a result in the urlbar. r=dao
Two fixes:

* The urlbar view isn't a popup anymore, so `FullScreen` should listen for `onViewOpen` and `onViewClose` on the urlbar controller instead of popup events.
* Change the keypress listeners to keydown to listen for enter events in the urlbar and hide the toolbars.

Differential Revision: https://phabricator.services.mozilla.com/D62123
2020-02-13 21:39:08 +00:00
Abdoulaye Oumar Ly
ae0f59c088 Bug 1590138 - Handle the case where the actor is already destroyed during fullscreen exit so that chrome UI is fully restored. r=smaug,NeilDeakin
Differential Revision: https://phabricator.services.mozilla.com/D51339
2019-11-05 23:29:26 +00:00
Dão Gottwald
05613d9736 Bug 1589018 - Remove global-scope pollution from browser-fullScreenAndPointerLock.js. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D49393
2019-10-16 12:34:22 +00:00
Dão Gottwald
97086934c1 Bug 1588813 - Remove redundant imports and service getters from browser-fullScreenAndPointerLock.js and nsContextMenu.js. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D49298
2019-10-15 15:06:22 +00:00
Abdoulaye Oumar Ly
a56875675a Bug 1505916 - [Fission] Part 2: Make the fullscreen code work with oop iframes. r=NeilDeakin,smaug
e10s scenario:
1. An DOM element request fulscreen mode.
2. The request is redirected to the parent.
3. Parent enters fullscreen.
4. Parent notifies child that it has finished entering fullscreen.
5. Child goes fullscreen.
6. Then, child notifies parent that it has finished transitioning to fullscreen.
4. Finally, parent notify observers that fullscreen paint has finished.

Let's go into the details of how step 5 works in the above scenario.
5.a The element that made the request is set to fullscreen.
5.b Then, the document where that element lives is set to fullscreen as well as all of its ancestors until we reach the top level document. (see Document::ApplyFulscreen method)

Now in Fission world, we may have a request comming from an oop iframe. And it that case since we won't have  to ancestor documents living in different content process(es), we will first notiy those content processes (one after another from bottom to top) to go fullscreen. Once they all do, the content process where the request originated will be told to enter fullscreen.

Differential Revision: https://phabricator.services.mozilla.com/D45972
2019-10-11 14:30:28 +00:00
Abdoulaye Oumar Ly
404b13dc0f Bug 1505916 - [Fission] Part 1: Make the fullscreen code work with JSWindowActors. r=NeilDeakin,dao,smaug
At this point, fullscreen is not regressed but it doesn't work with oop iframes yet.

Differential Revision: https://phabricator.services.mozilla.com/D35026
2019-10-11 14:30:28 +00:00
Paul Zuehlcke
b83b198c79 Bug 1583665 - Fixed AddonManager.jsm fullscreen check to only cancel installation for DOM fullscreen. r=johannh
Differential Revision: https://phabricator.services.mozilla.com/D47933
2019-10-09 09:28:19 +00:00
Michael Kaply
e45d30657d Bug 158968 - Implement kiosk mode. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D41848
2019-10-04 19:47:56 +00:00
monikamaheshwari
edb30ffaec Bug 1578683 Turn on ESLint rule prefer-boolean-length-check for toolkit and browser r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D45629
2019-09-14 09:39:26 +00:00
Paul Zuehlcke
4b1331c439 Bug 1577478 - Log warning to website console when permission prompt / fullscreen is canceled. r=johannh,flod
Differential Revision: https://phabricator.services.mozilla.com/D44166
2019-09-04 17:37:59 +00:00
Paul Zuehlcke
ccad3843c5 Bug 1558439 - Log warning to web console when add-on installation was blocked due to fullscreen. r=johannh,mixedpuppy
Differential Revision: https://phabricator.services.mozilla.com/D44161
2019-08-30 16:34:08 +00:00
Paul Zuehlcke
f65f2fbccb Bug 1522120 - Remove permission prompts when entering full-screen and leave full-screen when a permission prompt is shown. r=johannh
Differential Revision: https://phabricator.services.mozilla.com/D36932
2019-07-24 16:17:54 +00:00
Xidorn Quan
4da97ca4f8 Bug 1403085 - Add a pref to use native full screen for Fullscreen API on macOS. r=spohl,dao
Differential Revision: https://phabricator.services.mozilla.com/D37151
2019-07-17 13:31:41 +00:00
Victor Porof
a3641f184a Bug 1561435 - Format browser/base/, a=automatic-formatting
# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D36041
2019-07-05 09:48:57 +02:00
Neil Deakin
c1eb92539d Bug 1533948, change BrowserTabChild to inherit from JSWindowActor, r=mconley 2019-06-11 09:05:33 -04:00
Paul Zuehlcke
ceb398035a Bug 1412561 - Block addon installation prompts in fullscreen mode. r=johannh,aswan
Differential Revision: https://phabricator.services.mozilla.com/D27734
2019-05-03 21:44:24 +00:00
Marco Bonardo
a040dd21a3 Bug 1528751 - Add a custom eslint rule to check "consistent" if bracing. r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D20753
2019-02-28 08:39:33 +00:00
Myk Melez
5ecc2c1225 Bug 1518283 - prohibit blank lines at the beginning and end of blocks (eslint padded-blocks) r=mossop,Standard8
Differential Revision: https://phabricator.services.mozilla.com/D17526
2019-01-30 17:26:25 +00:00
Mike Conley
6843181e5a Bug 1506026 - Don't accidentally hide the navigator-toolbox if fullscreen has been exited. r=jaws
Differential Revision: https://phabricator.services.mozilla.com/D12594
2018-11-21 23:28:45 +00:00
Dão Gottwald
d5dbede2f3 Bug 1499706 - Remove external calls to TabsInTitlebar.update and make it private. r=mconley
Differential Revision: https://phabricator.services.mozilla.com/D11311
2018-11-08 18:41:04 +00:00
Mike Conley
e41c91f892 Bug 1492950 - Get browser-fullScreenAndPointerLock.js off of getBrowserForContentWindow. r=jaws
Depends on D6712

Differential Revision: https://phabricator.services.mozilla.com/D6713
2018-10-02 17:52:56 +00:00
Xidorn Quan
e5662367ba Bug 1477525 part 2 - Try hiding toolbox again when input in chrome loses the focus. r=dao
MozReview-Commit-ID: LnwVXN4oS2Z

Depends on D6750

Differential Revision: https://phabricator.services.mozilla.com/D6751
2018-10-02 12:57:40 +00:00
Xidorn Quan
21466b4931 Bug 1477525 part 1 - Merge the logic of _safeToCollapse into hideNavToolbox. r=dao
MozReview-Commit-ID: 1SEUVGprmv3

Differential Revision: https://phabricator.services.mozilla.com/D6750
2018-10-02 12:57:37 +00:00