- add telemetry "tab" field for start, cardlink, cardClose
- add labsCheckbox event for shift, shift_option, long_press, key_points, link_previews
- add _getTabContextValue to get the filepath for any about: pages
- update optin telemetry
- add metrics
- shift_alt and long_press name normalization
- add key_points (boolean) to card_link
- update test to test against blank
- refactor _getTabContextValue
- add tests for new metric and prefChanged
Original Revision: https://phabricator.services.mozilla.com/D251779
Differential Revision: https://phabricator.services.mozilla.com/D252692
- entrypoint logic
- add close button
- update text and image on onboarding card
- don't re-render card if user hover around different urls
- use -panel-color for .og-card-title and .og-card-description
- add telemetry and tests
- add browser_link_preview_onboarding.js
- add link-preview-card-onboarding.css
- update failure message for failed test wait statement
- remove alt text for onboarding image
- refactor panel rendering code to initOrResetPreviewPanel
- refactor _onLinkPreview() to switch between linkpreview and onboarding card directly
- add openAtCurrentLocation
- add telemetry tests and onboarding test
- avoid adding multiple listeners
- replace without hide and reopen
Differential Revision: https://phabricator.services.mozilla.com/D249855
ExperimentManager.unenroll() is now effectively async when running in a
browser test (because we are now executing SQL queries during
unenrollment) so all cleanup functions that trigger unenrollment are
async as well.
Differential Revision: https://phabricator.services.mozilla.com/D250551
- Change isGenerationErrorState to generationError, an object with the error from inference
- determine whether to showRetryLink based on error.name
Differential Revision: https://phabricator.services.mozilla.com/D250259
- integration with opt-in
- fix skeleton alignment issues
- add test for toggle expand/collapse
- update optin telemetry tests
- add key_points_toggle telemetry and tests
- prevent key point generation if in-process or keypoints already exist for the card
- add todo comment for chevron icon
- reset telemery state
- update h3 to be available for accessibility api
- update for accessibility API
- remove feedback from metric description
Differential Revision: https://phabricator.services.mozilla.com/D249851
This reverts commit ec5fa1d4c0.
Revert "Bug 1606785 - Format Firefox CSS files with Prettier r=desktop-theme-reviewers,perftest-reviewers,places-reviewers,translations-reviewers,omc-reviewers,backup-reviewers,browser-installer-reviewers,sparky,dao,pdahiya,nrishel,kpatenio"
This reverts commit baa5d72bbd.
Revert "Bug 1606785 - Format browser/themes and toolkit/themes CSS files with Prettier r=desktop-theme-reviewers,pip-reviewers,tabbrowser-reviewers,places-reviewers,dao,mconley"
This reverts commit 9604b0a8ae.
Revert "Bug 1606785 - Format browser/themes/preferences CSS files with Prettier r=settings-reviewers,desktop-theme-reviewers,dao,mconley"
This reverts commit 686c1cf85f.
Revert "Bug 1606785 - Format urlbar CSS files with Prettier r=urlbar-reviewers,desktop-theme-reviewers,dao"
This reverts commit a7a4f31251.
Revert "Bug 1606785 - Format webcompat CSS files with Prettier r=webcompat-reviewers,denschub"
This reverts commit 41bc4d5237.
Revert "Bug 1606785 - Format search CSS files with Prettier r=search-reviewers,jteow"
This reverts commit 7bb7f82374.
Revert "Bug 1606785 - Format dom CSS files with Prettier r=emilio"
This reverts commit c22e910235.
Revert "Bug 1606785 - Format android CSS files with Prettier r=geckoview-reviewers,hiro"
This reverts commit c08e43fc3d.
Revert "Bug 1606785 - Format layout CSS files with Prettier r=layout-reviewers,dholbert"
This reverts commit 4f2a32d1a4.
Revert "Bug 1606785 - Format devtools CSS files with Prettier r=devtools-reviewers,nchevobbe,frontend-codestyle-reviewers"
This reverts commit c05f675ddf.
Revert "Bug 1606785 - Format recomp CSS files with Prettier r=reusable-components-reviewers,desktop-theme-reviewers,dao,mkennedy"
This reverts commit b10c7de8d0.
Revert "Bug 1606785 - Format sidebar CSS files with Prettier r=sidebar-reviewers,desktop-theme-reviewers,dao,nsharpley"
This reverts commit d32c555e37.
Revert "Bug 1606785 - Format shopping CSS files with Prettier r=shopping-reviewers,desktop-theme-reviewers,dao,rking"
This reverts commit 965887a708.
Revert "Bug 1606785 - Format profiles CSS files with Prettier r=profiles-reviewers,desktop-theme-reviewers,dao,mossop"
This reverts commit 8338860f74.
Revert "Bug 1606785 - Format genai and ml CSS files with Prettier r=firefox-ai-ml-reviewers,Mardak"
This reverts commit d66681f553.
Revert "Bug 1606785 - Format firefoxview CSS files with Prettier r=fxview-reviewers,desktop-theme-reviewers,dao,jsudiaman"
This reverts commit 530b815cad.
Revert "Bug 1606785 - Format aboutlogins, megalist, and form autofill CSS files with Prettier r=credential-management-reviewers,mtigley,desktop-theme-reviewers,dao"
This reverts commit 813c864381.
- integration with opt-in
- fix skeleton alignment issues
- add test for toggle expand/collapse
- update optin telemetry tests
- add key_points_toggle telemetry and tests
- prevent key point generation if in-process or keypoints already exist for the card
Differential Revision: https://phabricator.services.mozilla.com/D249851
- static skeleton animation
- start download / inference only after opt-in
- update model-optin to allow placing icon on either right or left depending on iconAtEnd
- update background-color of optin-wrapper
- add new prefs browser.ml.linkPreview.optin and browser.ml.linkPreview.collapse
- use css order attribute for placement of icon
- update to final text for opt-in modal
- don't generate key points if collapsed is true
- add optin test suite in browser_link_preview_optin.js
- add telemetry to link review optin
- remove learn more link
- refactor updateCardProperty
Differential Revision: https://phabricator.services.mozilla.com/D249104
- conditionally add menu item
- place of preview link is under Open Link in New Private Window
- .accesskey = r
- buildLinkPreviewMenu -> handleContextMenuClick
- add context menu test
- add more context menu conditionals, don't show it for non-link menus
- fix spacing in browser-context.inc
- fix tests by setting browser.ml.linkPreview.prefetchOnEnable to false
Differential Revision: https://phabricator.services.mozilla.com/D247404
- conditionally add menu item
- place of preview link is under Open Link in New Private Window
- .accesskey = r
- buildLinkPreviewMenu -> handleContextMenuClick
- add context menu test
- add more context menu conditionals, don't show it for non-link menus
- fix spacing in browser-context.inc
Differential Revision: https://phabricator.services.mozilla.com/D247404
- retry for generation error
- update error message for when page is not supported
- Revert "error state update for eu region check"
- change from --text-color-disabled to --text-color-deemphasized
- update generation error message to "Something went wrong."
- only show "Visit Link" when generation is finished, same as footer
- move region check out of data check conditions
- refactor for fluent strings
- minor refactor logic flow for renderKeyPointsSection
- comment change for link-preview-generation-error-missing-data fluent string
- hotfix test
Differential Revision: https://phabricator.services.mozilla.com/D246485
- retry for generation error
- update error message for when page is not supported
- Revert "error state update for eu region check"
- change from --text-color-disabled to --text-color-deemphasized
- update generation error message to "Something went wrong."
- only show "Visit Link" when generation is finished, same as footer
- move region check out of data check conditions
- refactor for fluent strings
- minor refactor logic flow for renderKeyPointsSection
- comment change for link-preview-generation-error-missing-data fluent string
Differential Revision: https://phabricator.services.mozilla.com/D246485
- use "link-preview-visit-link" and "link-preview-error-message" directly
- move loading of linkPreview.ftl to inside lit component
Differential Revision: https://phabricator.services.mozilla.com/D243691
Refactor nested logic out of handleShortcutsMessage to set up on first usage instead of each ShowShortcuts. Remove duplicate states: active, type and panel. Restore #ask-chat-shortcuts to limit width of warning.
Differential Revision: https://phabricator.services.mozilla.com/D246698
This diff was generated as follows:
List all toml files in the tree:
`find * -name '*.toml' > /tmp/toml`
Manually edited /tmp/toml to drop non-relevant entries (objdir).
Ran the toml linter for all files:
`cat /tmp/toml | xargs ./mach lint -l test-manifest-toml --fix`
Differential Revision: https://phabricator.services.mozilla.com/D240948
- use tab-group-suggestions loading animation color
- set progressPercentage to init to 0
- add non-impactful references to the CSS variables to satisfy the test browser_parsable_css
Differential Revision: https://phabricator.services.mozilla.com/D243322
