Commit Graph

1163 Commits

Author SHA1 Message Date
pbz
effe61dd05 Bug 1615588 - SearchOneOffs: Use prompt service instead of nsIPrompt. r=johannh
Differential Revision: https://phabricator.services.mozilla.com/D66447
2020-04-16 14:44:25 +00:00
Ved Dandekar
03f2f01b8a Bug 1629939 - Remove obsolete code that is setting the iconURI in MozSearchbar.updateDisplay. r=Standard8
The searchbar widget no longer displays the search engine icon on the toolbar.

Differential Revision: https://phabricator.services.mozilla.com/D71004
2020-04-16 07:21:41 +00:00
Drew Willcoxon
d88de4b8ed Bug 1628926 - Remove the browser.urlbar.oneOffSearches pref. r=dao
Differential Revision: https://phabricator.services.mozilla.com/D70921
2020-04-16 00:00:55 +00:00
Arthur Iakab
51f239e00a Backed out changeset 0c8a5b5094b6 (bug 1628926) for Eslint failure on UrlbarView.jsm
CLOSED TREE
2020-04-16 01:38:49 +03:00
Drew Willcoxon
0b703a560d Bug 1628926 - Remove the browser.urlbar.oneOffSearches pref. r=dao
Differential Revision: https://phabricator.services.mozilla.com/D70921
2020-04-15 08:56:16 +00:00
Emilio Cobos Álvarez
6869665d58 Bug 1627520 - Use keydown instead of keypress for autocomplete event listeners. r=mak,Gijs
This is so that we can avoid needing mozSystemGroup (to get keypress for
non-printable keys), which in turn prevents racing with the native key event
listeners, see the second patch in bug 1624657.

This turned out to be a bit tricky, because we need to guarantee the ordering of
the search one-offs handling in the searchbar with the usual autocomplete-input
handling. We could try to move this to the popup subclass but this is already a
bigger patch than what I'd like.

We can also revert the customElements.js change I did in bug 1624657, as the bug
is no longer relevant.

Differential Revision: https://phabricator.services.mozilla.com/D69743
2020-04-14 20:48:26 +00:00
Bogdan Tara
8df8611a4f Backed out changeset b92904ec121f (bug 1627520) for browser_searchbar_keyboard_navigation.js failures CLOSED TREE 2020-04-14 16:58:35 +03:00
Emilio Cobos Álvarez
773cbf50dc Bug 1627520 - Use keydown instead of keypress for autocomplete event listeners. r=mak,Gijs
This is so that we can avoid needing mozSystemGroup (to get keypress for
non-printable keys), which in turn prevents racing with the native key event
listeners, see the second patch in bug 1624657.

This turned out to be a bit tricky, because we need to guarantee the ordering of
the search one-offs handling in the searchbar with the usual autocomplete-input
handling. We could try to move this to the popup subclass but this is already a
bigger patch than what I'd like.

We can also revert the customElements.js change I did in bug 1624657, as the bug
is no longer relevant.

Differential Revision: https://phabricator.services.mozilla.com/D69743
2020-04-14 12:42:16 +00:00
Csoregi Natalia
a3c8408007 Backed out 5 changesets (bug 1615588) for browser-chrome failures e.g. browser_beforeunload_duplicate_dialogs.js. CLOSED TREE
Backed out changeset 751cca7566a8 (bug 1615588)
Backed out changeset 474aca043834 (bug 1615588)
Backed out changeset 7839b95ef76c (bug 1615588)
Backed out changeset 32bb87f48b13 (bug 1615588)
Backed out changeset 264e642042b1 (bug 1615588)
2020-04-10 21:19:15 +03:00
pbz
9fd9d9b4b7 Bug 1615588 - SearchOneOffs: Use prompt service instead of nsIPrompt. r=johannh
Differential Revision: https://phabricator.services.mozilla.com/D66447
2020-04-10 16:45:05 +00:00
Emma Malysz
e4397c159d Bug 1590573, create a unified approach for caching fragments in our Custom Elements r=emilio
Differential Revision: https://phabricator.services.mozilla.com/D58866
2020-04-08 16:17:50 +00:00
Razvan Maries
155eb99120 Backed out changeset 6b7c81561ecc (bug 1590573) for marionette perma failures on test_refresh_firefox.py. CLOSED TREE 2020-04-08 07:43:49 +03:00
Emma Malysz
5944c8268e Bug 1590573, create a unified approach for caching fragments in our Custom Elements r=emilio
Differential Revision: https://phabricator.services.mozilla.com/D58866
2020-04-07 23:56:45 +00:00
Mark Banner
38fc844f26 Bug 1542269 - Make the modern search engine configuration be loaded from Remote Settings. r=daleharvey
Differential Revision: https://phabricator.services.mozilla.com/D55464
2020-03-19 14:11:40 +00:00
Sylvestre Ledru
640e18de6a Bug 1622328 - add license info to all eslintrc files r=Standard8,webcompat-reviewers,miketaylr
Differential Revision: https://phabricator.services.mozilla.com/D67319
2020-03-19 13:47:51 +00:00
Mike Conley
433cb79c97 Bug 1604402 - Ensure about:newtab has loaded before running browser_google_behavior.js subtest. r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D66622
2020-03-13 16:28:16 +00:00
Mike Conley
65f0c27c0e Bug 1617983 - Re-enable separate privileged about content process for about:home, about:newtab, about:welcome on Nightly. r=NeilDeakin
Differential Revision: https://phabricator.services.mozilla.com/D64376
2020-03-09 18:37:58 +00:00
Mark Banner
1cc76add79 Bug 1620218 - Automatic code fixes for Prettier 1.18.2 upgrade. r=mossop,webcompat-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D65509
2020-03-08 21:45:16 +00:00
Mark Banner
d375cfec54 Bug 1620542 - Automatically fix ESLint errors in .eslintrc.js files. r=mossop
# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D65703
2020-03-07 10:09:44 +00:00
Liang-Heng Chen
e392a52128 Bug 1620239 - ensure not to access null pointer; r=Ehsan
Differential Revision: https://phabricator.services.mozilla.com/D65576
2020-03-06 17:20:49 +00:00
Dale Harvey
fdb5f2a723 Bug 1615901 - Dont send Origin header with context menu searches. r=ckerschb,Standard8
Differential Revision: https://phabricator.services.mozilla.com/D63630
2020-03-06 14:18:34 +00:00
Neil Deakin
719ac435f5 Bug 1614769, convert SearchTelemetry actor into a JSWindowActor, r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D65108
2020-03-04 12:28:12 +00:00
Marco Bonardo
1bcd09d8aa Bug 333714 - Unify clickSelectsAll behavior across all platforms. r=dao
Differential Revision: https://phabricator.services.mozilla.com/D64783
2020-03-02 18:34:17 +00:00
Liang-Heng Chen
6664a58829 Bug 1618764 - Ensure test page is not in the cache; r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D64716
2020-02-28 12:10:04 +00:00
Liang-Heng Chen
49a087e1bb Bug 1614777 - Part 4: Test cases; r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D64379
2020-02-28 00:09:46 +00:00
Liang-Heng Chen
e71435cf34 Bug 1614777 - Part 3: report telemetry; r=Ehsan,chutten,Standard8
Differential Revision: https://phabricator.services.mozilla.com/D63099
2020-02-28 00:09:43 +00:00
Liang-Heng Chen
8a3869c630 Bug 1614777 - Part 1: collect bandwidth in search telemetry; r=Ehsan,Standard8
Differential Revision: https://phabricator.services.mozilla.com/D63096
2020-02-28 00:09:28 +00:00
Razvan Maries
e4b8ac6108 Backed out 4 changesets (bug 1614777) for perma failures on test_bug884693.xhtml. CLOSED TREE
Backed out changeset 202ec043db19 (bug 1614777)
Backed out changeset 17aebb8d75f1 (bug 1614777)
Backed out changeset c4f931b08de3 (bug 1614777)
Backed out changeset 0ab2a4da406f (bug 1614777)
2020-02-28 01:46:30 +02:00
Liang-Heng Chen
0f6efd462b Bug 1614777 - Part 4: Test cases; r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D64379
2020-02-27 21:40:04 +00:00
Liang-Heng Chen
7a196df8f9 Bug 1614777 - Part 3: report telemetry; r=Ehsan,chutten,Standard8
Differential Revision: https://phabricator.services.mozilla.com/D63099
2020-02-27 21:39:57 +00:00
Liang-Heng Chen
4972817026 Bug 1614777 - Part 1: collect bandwidth in search telemetry; r=Ehsan,Standard8
Differential Revision: https://phabricator.services.mozilla.com/D63096
2020-02-27 21:39:50 +00:00
Mark Banner
8de61a1e76 Bug 1617193 - eBay should only be offered on select en-US regions for modern configuration. r=daleharvey
Differential Revision: https://phabricator.services.mozilla.com/D63669
2020-02-23 19:18:59 +00:00
Mark Banner
fa3633afbb Bug 1615629 - Fix browser_searchbar_context.js leaking a window when run in test-verify mode. r=daleharvey
Differential Revision: https://phabricator.services.mozilla.com/D63088
2020-02-20 14:05:22 +00:00
Tim Nguyen
d7c1bcfd46 Bug 1612122 - Set disabled state of searchbar context menu items. r=daleharvey
Usually, editMenuOverlay.js or moz-input-box would handle this, but searchbar.js uses its own implementation to append its own menu items. Ideally, editMenuOverlay.js would provide a mechanism for this, which would allow both moz-input-box and searchbar.js to stop existing, but that's out of scope.

Patch by ntim, test by Standard8

Differential Revision: https://phabricator.services.mozilla.com/D61665
2020-02-14 14:15:34 +00:00
James Teh
70c723135b Bug 1608554: Initialize toolbartabstops in dynamically added widgets. r=Gijs
When ToolbarKeyboardNavigator initializes, it sets aria-hidden and adds a focus listener on toolbartabstop elements.
This is necessary for proper functionality of toolbar keyboard navigation.
However, widgets can be dynamically added by CustomizableUI after ToolbarKeyboardNavigator initializes.
The search bar is one such widget and it does contain toolbartabstop elements.
We now watch for this and initialize any toolbartabstop elements inside added widgets.

Differential Revision: https://phabricator.services.mozilla.com/D62178
2020-02-12 01:03:18 +00:00
Mark Banner
ea196d0135 Bug 1610840 - Remove webExtension.version from the Search Engine configuration schema and config as we don't need it. r=daleharvey
Differential Revision: https://phabricator.services.mozilla.com/D60869
2020-01-28 13:33:11 +00:00
Mark Banner
6beb5e311a Bug 1582720 - Clean up references to recently removed locales (as, crh, en-ZA, mai, ml, or) in the Search Engine lists. r=daleharvey
Depends on D59085

Differential Revision: https://phabricator.services.mozilla.com/D59119
2020-01-09 15:38:18 +00:00
Mark Banner
20764b12b9 Bug 1596860 - Remove default region setting for various search engines in the modern config as it is different to the legacy config. r=daleharvey
Also adds tests for checking the search engine lists when falling back to a default region.

Differential Revision: https://phabricator.services.mozilla.com/D59084
2020-01-09 16:18:23 +00:00
Zibi Braniecki
23db7362be Bug 1604960 - Migrate all text actions to use Fluent. r=fluent-reviewers,Gijs,flod
Differential Revision: https://phabricator.services.mozilla.com/D57713
2019-12-25 10:01:46 +00:00
Ciure Andrei
b6e7bbf4c7 Backed out changeset 0267e42c0db5 (bug 1604960) for causing bc permafails 2019-12-25 05:15:16 +02:00
Zibi Braniecki
f15a322935 Bug 1604960 - Migrate all text actions to use Fluent. r=fluent-reviewers,Gijs,flod
Differential Revision: https://phabricator.services.mozilla.com/D57713
2019-12-24 20:43:17 +00:00
Mark Banner
26d3efb681 Bug 1601894 - Ensure the search engine configuration tests check the details for each locale/region pair, and fix eBay setup in the modern configuration. r=mikedeboer
Depends on D57682

Differential Revision: https://phabricator.services.mozilla.com/D57841
2019-12-23 12:00:48 +00:00
Francesco Lodolo (:flod)
866c25eedc Bug 1604415 - Add Sicilian (scn) to Firefox Nightly Builds r=Pike,Standard8
Differential Revision: https://phabricator.services.mozilla.com/D57433
2019-12-20 14:47:51 +00:00
Mark Banner
2e65ccc642 Bug 1604929 - In the modern search config, fix handling of telemetry Ids and WebExtensions which are installed twice with different locales. r=mikedeboer
Differential Revision: https://phabricator.services.mozilla.com/D57682
2019-12-19 21:57:53 +00:00
Andreea Pavel
5bbd609377 Backed out 3 changesets (bug 1604929) for breaking xpcshell at test_async_addon.js on a CLOSED TREE
Backed out changeset 8a36d9f67974 (bug 1604929)
Backed out changeset 030684aff17b (bug 1604929)
Backed out changeset 897fef11fe80 (bug 1604929)
2019-12-19 22:49:11 +02:00
Mark Banner
5a76af68e5 Bug 1604929 - In the modern search config, fix handling of telemetry Ids and WebExtensions which are installed twice with different locales. r=mikedeboer
Differential Revision: https://phabricator.services.mozilla.com/D57682
2019-12-19 18:37:12 +00:00
Kris Maglione
ac36cf0bd5 Bug 1596918: Part 4g - Misc cleanup/fixes. r=mccr8
Differential Revision: https://phabricator.services.mozilla.com/D53748
2019-12-13 20:36:48 +00:00
Kris Maglione
7b2657b231 Bug 1596918: Part 3b - Run code formatters on files changed by previous patch. r=mccr8,remote-protocol-reviewers,ato
Differential Revision: https://phabricator.services.mozilla.com/D53741
2019-12-13 20:36:24 +00:00
Kris Maglione
8c0d38f33d Bug 1596918: Part 3a - Scripted rewrite of most ContentTask.spawn calls to SpecialPowers.spawn calls. r=mccr8,remote-protocol-reviewers,ato
This is generally pretty straightforward, and rewrites nearly all calls. It
skips the ones that it can detect using frame script globals like
`sendAsyncMessage`, though.

Differential Revision: https://phabricator.services.mozilla.com/D53740
2019-12-13 20:36:16 +00:00
Emma Malysz
ba6b2f0a9b Bug 1601093, Rename the remaining .xul files to .xhtml in toolkit/ r=marionette-reviewers,mossop,whimboo
Differential Revision: https://phabricator.services.mozilla.com/D55857
2019-12-11 17:44:54 +00:00