Commit Graph

108 Commits

Author SHA1 Message Date
Mark Banner
b7230156ea Bug 1590803 - Clean up uses of SearchService.getDefaultEngines where we can now use engine.isAppProvided. r=daleharvey
Differential Revision: https://phabricator.services.mozilla.com/D69235
2020-04-03 11:36:35 +00:00
Dorel Luca
7eec6ba613 Backed out 2 changesets (bug 1590803) for browser-chrome failures in browser/browser_placeholder.js. CLOSED TREE
Backed out changeset 6256694a9047 (bug 1590803)
Backed out changeset efd1d1868d70 (bug 1590803)
2020-04-02 18:39:32 +03:00
Mark Banner
ba85723ecd Bug 1590803 - Clean up uses of SearchService.getDefaultEngines where we can now use engine.isAppProvided. r=daleharvey
Depends on D69233

Differential Revision: https://phabricator.services.mozilla.com/D69235
2020-04-02 14:31:45 +00:00
Shane Caraveo
2e1df1cee5 Bug 1548700 support selecting what controls an extension setting r=robwu
This adds support for selecting a specific extension to control a setting,
as well as allowing a user to take control without requiring the extension
to be disabled.

Differential Revision: https://phabricator.services.mozilla.com/D52609
2019-12-02 22:00:34 +00:00
Noemi Erli
85dc679614 Backed out changeset 6df3b83636f9 (bug 1548700) for causing failures in browser_searchDefaultEngine.js CLOSED TREE 2019-12-02 22:01:49 +02:00
Shane Caraveo
1887870de9 Bug 1548700 support selecting what controls an extension setting r=robwu
This adds support for selecting a specific extension to control a setting,
as well as allowing a user to take control without requiring the extension
to be disabled.

Differential Revision: https://phabricator.services.mozilla.com/D52609
2019-12-02 18:28:06 +00:00
Gijs Kruitbosch
8c27526c38 Bug 1597403 - remove superfluous search tree blur code now that the tree widget handles this correctly, r=mconley
Differential Revision: https://phabricator.services.mozilla.com/D54230
2019-11-22 15:30:03 +00:00
Emilio Cobos Álvarez
b611228b3d Bug 1596800 - Remove document.getBindingParent usage from preferences search. r=mconley
When the focus moves elsewhere inside the <tree> blur events aren't dispatched
outside the shadow tree (as expected), so checking the originalTarget is always
bogus.

Furthermore, the event handler does nothing if the input isn't focused, and
when the input is blurred the tree takes care of calling stopEditing itself, so
this change should be pretty safe in general:

  https://searchfox.org/mozilla-central/rev/492214c05cde6e6db5feff9465ece4920400acc3/toolkit/content/widgets/tree.js#1083

It's not clear to me whether the blur event handler is doing anything at all
after bug 1547382 (before this patch), as the binding parent is not a
<xul:textbox> anymore, so <input>.getBindingParent() will return the <tree>...

Depends on D53338

Differential Revision: https://phabricator.services.mozilla.com/D53339
2019-11-18 19:07:47 +00:00
Mark Banner
77363e15b9 Bug 1589848 - Don't try and update the separate private engine selector in preferences when the UI isn't shown. r=mak
Differential Revision: https://phabricator.services.mozilla.com/D49885
2019-10-21 10:14:30 +00:00
Mark Banner
0bf392d1dc Bug 1583162 - Add an option in preferences to allow search suggestions in private windows. r=mak,fluent-reviewers,flod
Differential Revision: https://phabricator.services.mozilla.com/D48972
2019-10-11 14:57:44 +00:00
Mark Banner
cf77616e72 Bug 1563021 - Add preferences UI to allow enabling and selection of a separate default private engine. r=fluent-reviewers,jaws,flod
Differential Revision: https://phabricator.services.mozilla.com/D46971
2019-09-30 19:18:26 +00:00
Alex Vincent
0a4e7a7185 Bug 1508169, Remove performAction* from nsITreeView.idl in mozilla-central. r=peterv, johannh
performAction, performActionOnRow and performActionOnCell are methods of the
nsITreeView interface that are never called.  This is to remove these methods.
A comm-central patch will be along shortly.

Differential Revision: https://phabricator.services.mozilla.com/D39273
2019-08-24 00:49:55 +02:00
Victor Porof
8eb72fd3fc Bug 1561435 - Format browser/components/, a=automatic-formatting
# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D36042
2019-07-05 09:53:32 +02:00
Gijs Kruitbosch
cff78a6d12 Bug 1546147 - fix broken search keyword textbox when switching categories, r=vporof
Differential Revision: https://phabricator.services.mozilla.com/D28674
2019-04-24 17:32:16 +00:00
Mike de Boer
4685c831da Bug 1518545 - Remove the superfluous 'engine-current' Search Service observer topic in favour of 'engine-default'. r=daleharvey
Differential Revision: https://phabricator.services.mozilla.com/D27857
2019-04-17 09:45:24 +00:00
Mike de Boer
2d0c35cc74 Bug 1532997 - Properly await the default engines restoration process to finish, before refreshing the list in about:preferences. r=florian
Differential Revision: https://phabricator.services.mozilla.com/D23646
2019-03-15 11:41:08 +00:00
Mike de Boer
39f20cd843 Bug 1524593 - nsISearchService (aka nsIBrowserSearchService, previously) refactor to be mostly an asynchronous, in preparation of WebExtension engines. r=daleharvey
This is a rollup of all the patches that have landed on the cedar project branch:

891252fdd0
Bug 1492475 - Part 1: Migrate most, if not all nsSearchService consumers to use async APIs. r=florian

79b2eb2367
Bug 1492475 - Part 2: Move nsIBrowserSearchService.idl to toolkit/components/search/nsISearchService.idl and update references. r=florian

a947d3cdf0
Bug 1492475 - Part 3: The search service init() method should simply return a Promise. r=florian

c1e172dfac
Bug 1492475 - Part 4: Remove the synchronous initialization flow. r=florian

cd41189eac
Bug 1492475 - Part 5: Since async initialization of the search service now is implicit behavior, remove the distinctive verbiage used internally. r=florian

2ae7189dfa
Bug 1492475 - Part 6: Update the cache build task to work with an actual Promise and re-initialize only once at the same time - all to fix race conditions here. r=florian

c8ee92973f
Bug 1492475 - Part 7: Make the region fetch not block the init flow, to ensure it's as fast as possible. r=florian

c44e674e16
Bug 1492475 - Part 8: Introduce an init flag, which can only be used privately, that allows to explicitly skip waiting for the region check process to complete. r=florian

6c79eaf1d3
Bug 1492475 - Part 9: Update unit tests to stop using 'currentEngine', in favor of 'defaultEngine'. r=Standard8

21b3aa17ee
Bug 1492475 - Part 10: Update unit tests to be fully aware of the new, async signatures of the search service API and remove sync init flow tests. r=mkaply,florian

ce5ba69019
Bug 1492475 - Part 11: Repair incorrect usage of the `identifier` property of nsISearchEngine instances. r=florian

fd177a7994
Bug 1518543 - Fix up the Android (Fennec) nsISearchService shim to work with the new asynchronous API. r=florian

3653d8ee22
Bug 1523708 - Change the search service interaction in the show-heartbeat action to use the new async API. r=florian

Differential Revision: https://phabricator.services.mozilla.com/D18355
2019-02-02 11:27:21 +00:00
Kris Maglione
f498964d86 Bug 1519596: Part 1 - Remove several unnecessary/unused ChromeUtils.import() calls. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D16377
2019-01-11 16:59:23 -08:00
Neil Deakin
2f5fea237e Bug 1482389, replace TreeBoxObject with XULTreeElement inherited from XULElement, r=peterv,paolo 2018-12-04 11:25:30 -05:00
Neil Deakin
43952f9363 Bug 1482389, remove deprecated getCellAt and getCoordsForCellItem methods from TreeBoxObject, r=peterv 2018-12-04 11:24:16 -05:00
Tim Nguyen
790f9a6593 Bug 1508142 - Remove remains of tree cell-based selection code. r=bzbarsky,bgrins
Differential Revision: https://phabricator.services.mozilla.com/D12225
2018-11-22 09:59:02 +00:00
Siddhant085
8ee1087713 Bug 1493483 - Use nsIBrowserSearchService::defaultEngine instead of currentEngine (in production code) r=Standard8
nsIBrowserSearchService::currentEngine and nsIBrowserSearchService::defaultEngine are the same thing.
The use of defaultEngine makes more sense and thus we are phasing out the use of currentEngine and replace it with defaultEngine.

Differential Revision: https://phabricator.services.mozilla.com/D7972
2018-10-27 16:52:02 +00:00
Csoregi Natalia
c42d79525b Backed out changeset c35bab726b03 (bug 1493483) for multiple browser-chrome failures e.g browser_extension_controlled.js. CLOSED TREE 2018-10-09 23:26:24 +03:00
Siddhant085
0a154604f3 Bug 1493483 - Use nsIBrowserSearchService::defaultEngine instead of currentEngine (in production code) r=Standard8
nsIBrowserSearchService::currentEngine and nsIBrowserSearchService::defaultEngine are the same thing.
The use of defaultEngine makes more sense and thus we are phasing out the use of currentEngine and replace it with defaultEngine.

Differential Revision: https://phabricator.services.mozilla.com/D7972
2018-10-09 18:40:08 +00:00
Mark Banner
462116b7f9 Bug 1486739 - Add missing dangling commas in browser/, services/, taskcluster/ and toolkit/. r=mossop
Automatic changes by ESLint, except for manual corrections for .xml files.

Differential Revision: https://phabricator.services.mozilla.com/D4439
2018-08-31 05:59:17 +00:00
Zibi Braniecki
25701066bc Bug 1461048 - Convert Fluent API calls to FluentDOM 0.3.0. r=mossop
MozReview-Commit-ID: K3eA8blcP2x
2018-05-14 12:37:41 -07:00
Kirk Steuber
48df44549c Bug 1428948 - Add policies to modify the available search engines r=Felipe,florian
This adds a policy with the capability of adding search engines, choosing the default search engine, and blocking the installation of new search engines.

Additionally, fixes the messages for errors reported by MainProcessSingleton.addSearchEngine so that the offending URL is printed rather than "[xpconnect wrapped nsIURI]".

MozReview-Commit-ID: HuLT15Rnq0r
2018-03-02 12:11:16 -08:00
Zibi Braniecki
43f71f91b6 Bug 1415733 - Migrate the "Search" section of Preferences to the new Localization API. r=flod,Gijs
MozReview-Commit-ID: ltXNOkdnOV
2018-03-12 17:17:13 -07:00
Gijs Kruitbosch
4e71107eb3 Bug 1443229 - follow-up: use correct checkbox state, r=jaws
It seems `doCommand` runs through a different codepath than just clicking the checkbox,
and as a result the outcome of the command handler is different that way.

This aligns the automated test closer to what happens when you 'manually'
click the checkbox, and fixes the bug in the command handler.

MozReview-Commit-ID: ACxRUxB35px
2018-03-06 15:00:12 +00:00
Jared Wein
03cd2673e1 Bug 1443229 - Add a 'command' event listener for the urlbar search suggestions checkbox. r=Gijs
This was inadvertently removed when the preference attribute was removed to clean up a race condition.

MozReview-Commit-ID: 8yNPMwkGS3u
2018-03-05 16:17:25 -05:00
Florian Quèze
f6add2cafd Bug 1433175 - scripted patch to replace Components.classes[, Components.interfaces.nsI, Components.utils. and Components.results. with Cc, Ci, Cu and Cr, r=Mossop. 2018-02-28 18:51:33 +01:00
Dão Gottwald
22cfe90814 Bug 1432716 - Group the "Show search suggestions ahead of browsing history in address bar results" checkbox with other search suggestion checkboxes. ui=shorlander r=adw
MozReview-Commit-ID: CSuNpA0Yq0w
2018-02-09 10:44:28 +01:00
Csoregi Natalia
e67e472427 Backed out changeset 98b4549200aa (bug 1432716) expected to fail. 2018-02-09 11:46:03 +02:00
Dão Gottwald
a55620e3b3 Bug 1432716 - Group the "Show search suggestions ahead of browsing history in address bar results" checkbox with other search suggestion checkboxes. ui=shorlander r=adw
MozReview-Commit-ID: 6Xt8MixhV3x
2018-01-24 08:48:27 +01:00
Bob Silverberg
313de813ef Bug 1429593 - Part 1: Extract functions for dealing with extensions into a separate file, r=jaws,mstriemer
This moves all the functions that manage/change the UI because of extensions being in
control of certain preferences to a separate file, so it can be included in SubDialogs.

MozReview-Commit-ID: 7OkEn478Pus
2018-01-22 14:40:20 -05:00
Coroiu Cristina
1affbb39f9 Backed out 2 changesets (bug 1429593) for for mass failing browser-chrome, e.g. browser/components/preferences/in-content/tests/browser_extension_controlled.js on a CLOSED TREE
Backed out changeset 9ce1b89f8744 (bug 1429593)
Backed out changeset fa845d221e7a (bug 1429593)
2018-02-07 16:03:58 +02:00
Bob Silverberg
fa349f8a38 Bug 1429593 - Part 1: Extract functions for dealing with extensions into a separate file, r=jaws,mstriemer
This moves all the functions that manage/change the UI because of extensions being in
control of certain preferences to a separate file, so it can be included in SubDialogs.

MozReview-Commit-ID: 7OkEn478Pus
2018-01-22 14:40:20 -05:00
Gurzau Raul
82749346c0 Backed out 2 changesets (bug 1429593) for l10n issues
Backed out changeset 9dfaa0724a42 (bug 1429593)
Backed out changeset 20829d727fdf (bug 1429593)
2018-02-06 22:03:23 +02:00
Bob Silverberg
e9b15452db Bug 1429593 - Part 1: Extract functions for dealing with extensions into a separate file, r=jaws,mstriemer
This moves all the functions that manage/change the UI because of extensions being in
control of certain preferences to a separate file, so it can be included in SubDialogs.

MozReview-Commit-ID: 7OkEn478Pus
2018-01-22 14:40:20 -05:00
Florian Quèze
c5f15a4700 Bug 1339461 - script-generated patch to convert foo.indexOf(...) == -1 to foo.includes(), r=Mossop. 2018-02-01 20:45:22 +01:00
Kris Maglione
0bb74efdf1 Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm

MozReview-Commit-ID: 1Nc3XDu0wGl
2018-01-29 15:20:18 -08:00
Cosmin Sabou
f09d6d985d Backed out 3 changesets (bug 1431533) for Android mochitest failures on testEventDispatcher on a CLOSED TREE
Backed out changeset a1eca62826a1 (bug 1431533)
Backed out changeset 34c999fa006b (bug 1431533)
Backed out changeset e2674287e57f (bug 1431533)
2018-01-30 07:17:48 +02:00
Kris Maglione
fd67f090b2 Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm

MozReview-Commit-ID: 1Nc3XDu0wGl
2018-01-29 15:20:18 -08:00
Brindusan Cristian
483ba301cb Backed out 2 changesets (bug 1431533) for ESlint failures on a CLOSED TREE
Backed out changeset 6e56f4c8843e (bug 1431533)
Backed out changeset 12fc4dee861c (bug 1431533)
2018-01-30 02:32:43 +02:00
Kris Maglione
683a97d172 Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm

MozReview-Commit-ID: 1Nc3XDu0wGl
2018-01-29 15:20:18 -08:00
Drew Willcoxon
82c8b68e27 Bug 1432263 - Make matchBuckets string parsing the same everywhere it's done. r=mak
MozReview-Commit-ID: GmGCHl4RtWB
2018-01-22 11:21:55 -08:00
Tim Nguyen
0f11886f22 Bug 1430374 - Remove support for progressmeter tree cells. r=bz,dao
MozReview-Commit-ID: 3hydkeoneC0
2018-01-18 10:36:05 +00:00
Drew Willcoxon
544f06cfca Bug 1429974 - TypeError: this.syncFromShowSearchSuggestionsFirstPref is not a function. r=mak
MozReview-Commit-ID: GgNiyRWKpEL
2018-01-16 16:20:14 -08:00
Drew Willcoxon
cd64a5cda7 Bug 1426216 - Allow users to choose whether search suggestions or history suggestions come first in the address bar. r=mak,past
MozReview-Commit-ID: HVWRyEu19Dv
2018-01-10 08:41:16 -08:00
Myk Melez
30f98a841a Bug 1379338 - scriptify preferences XBL; r=jaws
MozReview-Commit-ID: Egyzs2KxhzH
2018-01-04 21:37:47 -08:00