Commit Graph

204 Commits

Author SHA1 Message Date
Dão Gottwald
3961c7018e Bug 1627988 - Remove the browser.urlbar.update1.view.stripHttps pref. r=mak
Differential Revision: https://phabricator.services.mozilla.com/D70208
2020-04-09 13:54:19 +00:00
Drew Willcoxon
dc8efc33d5 Bug 1616752 - Part 2: Add payload schemas for each result type and validate payloads against them. r=mak
Differential Revision: https://phabricator.services.mozilla.com/D64300
2020-03-26 15:27:12 +00:00
Ed Lee
361cbdb4a5 Bug 1620556 - Automatic code fixes for Prettier 1.19.1 upgrade. r=Standard8,remote-protocol-reviewers,marionette-reviewers,webcompat-reviewers,perftest-reviewers,sparky,whimboo,denschub
Differential Revision: https://phabricator.services.mozilla.com/D66128
2020-03-13 23:38:52 +00:00
Mike Conley
527cf6e02a Bug 1619992 - Split AboutNewTabService into AboutNewTabParentService and AboutNewTabChildService. r=perftest-reviewers,Mardak,sparky
This patch does the following:
* Moves most logic for initiating about:home / about:newtab into AboutNewTab.jsm
* Makes AboutNewTab the API surface for overriding the default about:newtab URLs.
* Reduces the surface of nsIAboutNewTabService, and makes the properties read-only
* Splits the remaining code in the nsIAboutNewTabService into an implementation for
  the parent process, and one for content processes.

This split will hopefully help reduce confusion about which code in
AboutNewTabService is running in which process.

Differential Revision: https://phabricator.services.mozilla.com/D65569
2020-03-11 03:10:29 +00:00
Dorel Luca
e6edb45133 Backed out changeset 9160f18bc24e (bug 1619992) for XPCshell failures in newtab/test/xpcshell/test_AboutNewTab.js 2020-03-11 04:20:31 +02:00
Mike Conley
f431383314 Bug 1619992 - Split AboutNewTabService into AboutNewTabParentService and AboutNewTabChildService. r=perftest-reviewers,Mardak,sparky
This patch does the following:
* Moves most logic for initiating about:home / about:newtab into AboutNewTab.jsm
* Makes AboutNewTab the API surface for overriding the default about:newtab URLs.
* Reduces the surface of nsIAboutNewTabService, and makes the properties read-only
* Splits the remaining code in the nsIAboutNewTabService into an implementation for
  the parent process, and one for content processes.

This split will hopefully help reduce confusion about which code in
AboutNewTabService is running in which process.

Differential Revision: https://phabricator.services.mozilla.com/D65569
2020-03-11 01:25:31 +00:00
Mark Banner
1cc76add79 Bug 1620218 - Automatic code fixes for Prettier 1.18.2 upgrade. r=mossop,webcompat-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D65509
2020-03-08 21:45:16 +00:00
Mark Banner
d375cfec54 Bug 1620542 - Automatically fix ESLint errors in .eslintrc.js files. r=mossop
# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D65703
2020-03-07 10:09:44 +00:00
Mark Banner
e37540d559 Bug 1612416 - Fix failing tests for when the Search Service modern configuration is turned on. r=daleharvey
Differential Revision: https://phabricator.services.mozilla.com/D61485
2020-02-12 17:11:23 +00:00
Christian Holler
668050c50e Bug 1612707 - Disable various slow tests under TSan. r=froydnj
Differential Revision: https://phabricator.services.mozilla.com/D61562
2020-02-04 14:34:07 +00:00
Drew Willcoxon
d3e9856501 Bug 1608597 - Quantumbar: Replace restricting providers with a priority system. r=mak
Replace `isRestricting` with `getPriority` -- i.e., replace the binary restricting system with a general priority system. Instead of choosing restricting providers, the providers manager chooses the highest-priority providers.

Differential Revision: https://phabricator.services.mozilla.com/D60093
2020-01-17 20:50:45 +00:00
Cosmin Sabou
e9fcd0f800 Backed out changeset c516b5d716f1 (bug 1608597) for browser chrome failures on browser_search_tips. 2020-01-17 20:10:21 +02:00
Drew Willcoxon
a5f48fa02d Bug 1608597 - Quantumbar: Replace restricting providers with a priority system. r=mak
Replace `isRestricting` with `getPriority` -- i.e., replace the binary restricting system with a general priority system. Instead of choosing restricting providers, the providers manager chooses the highest-priority providers.

Differential Revision: https://phabricator.services.mozilla.com/D60093
2020-01-17 16:11:31 +00:00
Luca Greco
1947b63641 Bug 1606389 - Fix race in test_ext_urlbar test_engagementTelemetry. r=mixedpuppy
Differential Revision: https://phabricator.services.mozilla.com/D58617
2020-01-03 17:46:53 +00:00
Shane Caraveo
5862df766b Bug 1603946 fix perma fail on 73 merge due to loading pageinfo before creating appinfo r=twisniewski
Differential Revision: https://phabricator.services.mozilla.com/D58470
2019-12-31 21:34:30 +00:00
Harry Twyford
d8ebb9fb16 Bug 1605958 - Disable openViewOnFocus WebExt API. r=mikedeboer
This API is no longer needed, seeing as the Top Sites experiment is over. Dao suggested in bug 1605958 comment 1 that it be removed.

Differential Revision: https://phabricator.services.mozilla.com/D58375
2019-12-30 16:30:35 +00:00
Dão Gottwald
eac6059eba Bug 1603778 - Enable openViewOnFocus in Nightly. r=mak
Differential Revision: https://phabricator.services.mozilla.com/D57466
2019-12-24 16:10:41 +00:00
Marco Bonardo
9918983f83 Bug 1599839 - Merge sources and acceptableSources in UrlbarQueryContext. r=adw,mixedpuppy
Rename acceptableSources to just sources, merge it with the existing sources property.

Differential Revision: https://phabricator.services.mozilla.com/D55082
2019-12-02 17:20:39 +00:00
Shane Caraveo
82889634a5 Bug 1578513 make disable/enable during safe mode update extension settings r=robwu
Differential Revision: https://phabricator.services.mozilla.com/D44595
2019-11-27 20:00:08 +00:00
Shane Caraveo
f559d8e729 Bug 1578513 make uninstall during safemode remove extension settings r=robwu
Differential Revision: https://phabricator.services.mozilla.com/D44594
2019-11-27 22:19:15 +00:00
Shane Caraveo
4e7733502e Bug 1599708 fix setting newtab when setting is updated r=robwu
Differential Revision: https://phabricator.services.mozilla.com/D55022
2019-11-27 21:51:51 +00:00
Harry Twyford
46e835b4a6 Bug 1597698 - Move all megabar prefs under a urlbar.update1 branch. r=mak,dao
Differential Revision: https://phabricator.services.mozilla.com/D54146
2019-11-26 17:15:31 +00:00
Drew Willcoxon
411091c60b Bug 1597610 - Add browser.urlbar.onEngagement WebExtensions API. r=mak,mixedpuppy
Adds a `browser.urlbar.onEngagement` event. Listeners are passed the current engagement state: start, engagement, abandonment, or discard. The extension could use this to record its own parallel telemetry (scalars, event telemetry, etc.) per engagement.

Differential Revision: https://phabricator.services.mozilla.com/D53897
2019-11-25 23:52:56 +00:00
Matthew Noorenberghe
109be48583 Bug 1595656 - Only clear user-facing passwords with the browsingData API. r=rpl
FxA/Sync stores a credential in login storage but this is no longer user-facing so users shouldn't expect it to be cleared. Users can still diconnect Sync properly from about:preferences.

Differential Revision: https://phabricator.services.mozilla.com/D53834
2019-11-21 14:42:57 +00:00
Narcis Beleuzu
3793f89eb9 Backed out 2 changesets (bug 1595656) for xpcshell failures on test_load_all_api_modules.js . CLOSED TREE
Backed out changeset 061c92c4b95c (bug 1595656)
Backed out changeset ef8d5090979a (bug 1595656)
2019-11-21 03:22:06 +02:00
Matthew Noorenberghe
d09f92f3c0 Bug 1595656 - Only clear user-facing passwords with the browsingData API. r=rpl
FxA/Sync stores a credential in login storage but this is no longer user-facing so users shouldn't expect it to be cleared. Users can still diconnect Sync properly from about:preferences.

Differential Revision: https://phabricator.services.mozilla.com/D53834
2019-11-20 15:07:32 +00:00
Tomislav Jovanovic
aeeaab99c2 Bug 1577498 - Part 1: ExtensionsActor and Conduits design for Fission IPC r=rpl,kmag
Differential Revision: https://phabricator.services.mozilla.com/D44368
2019-11-17 10:18:34 +00:00
Drew Willcoxon
4565a3926d Bug 1594622 - Quantumbar: Remove the context.preselected property and rely on result.heuristic instead r=mak
Please see bug 1594622 for a description.

Differential Revision: https://phabricator.services.mozilla.com/D52120
2019-11-08 18:50:00 +00:00
Dão Gottwald
7071d834ef Bug 1589923 - Strip https:// instead of http:// from URLs in the results view. r=mak
Differential Revision: https://phabricator.services.mozilla.com/D49842
2019-10-22 07:22:55 +00:00
Mihai Alexandru Michis
41b665edb9 Backed out 2 changesets (bug 1588469, bug 1588464) for causing bc failures in browser_test_focus_urlbar.js CLOSED TREE
Backed out changeset c5bff62e1640 (bug 1588464)
Backed out changeset b85a79175973 (bug 1588469)
2019-10-17 02:09:57 +03:00
Marco Bonardo
fb226f9c11 Bug 1588469 - Show Search in a Private Window even if search suggestions in address bar are disabled. r=Standard8
Split the SEARCH source into SEARCH_NETWORK or SEARCH_LOCAL to distinguish
search results coming from a remote source, from those generated locally.
browser.urlbar.suggest.searches will only affect SEARCH_NETWORK results.

Differential Revision: https://phabricator.services.mozilla.com/D49172
2019-10-16 22:07:14 +00:00
Mark Banner
3358293a8f Bug 1576160 - Turn on the display of default private search engine feature for nightly/early beta users. r=mak
Differential Revision: https://phabricator.services.mozilla.com/D47223
2019-10-11 07:22:23 +00:00
Mark Banner
acbaedb306 Bug 1578381 - When resetting the homepage preference due to an ignore list update, ensure WebExtension settings are reset correctly. r=mixedpuppy
Differential Revision: https://phabricator.services.mozilla.com/D48196
2019-10-07 17:05:16 +00:00
Marco Bonardo
32ad78de63 Bug 1579923 - WebExt API: Add suggestedIndex property to Result type. r=adw,mixedpuppy
Differential Revision: https://phabricator.services.mozilla.com/D46941
2019-09-30 17:14:20 +00:00
Drew Willcoxon
595081a203 Bug 1578439 - Quantumbar WebExt API: Add "tip" to ResultType enum and UrlbarProviderExtension.RESULT_TYPES. r=harry,mixedpuppy
Add "tip" to the ResultType enum and UrlbarProviderExtension.RESULT_TYPES, corresponding to the new TIP type. Update the existing test.

Differential Revision: https://phabricator.services.mozilla.com/D46248
2019-09-19 17:02:39 +00:00
Shane Caraveo
d1ef597b01 Bug 1411046 fix emiting uninstall events on startup if extensions were removed r=robwu
Differential Revision: https://phabricator.services.mozilla.com/D43551
2019-09-11 14:00:20 +00:00
Luca Greco
99de27e9c5 Bug 1562117 - Fix race in test_ext_normandyAddonStudy test cases. r=mixedpuppy
Differential Revision: https://phabricator.services.mozilla.com/D43742
2019-08-28 17:32:28 +00:00
Shane Caraveo
7dda2b1664 Bug 1513705 remove non-oop tests from extension browser tests r=robwu
Differential Revision: https://phabricator.services.mozilla.com/D42941
2019-08-26 18:04:03 +00:00
mandy cheang
861abbb961 Bug 1566489 - Avoid reading extension-setting.json on start-up, read it lazily. r=aswan,mixedpuppy
Differential Revision: https://phabricator.services.mozilla.com/D40860
2019-08-08 16:15:17 +00:00
Mark Banner
bf6f936245 Bug 1535049 - Disallow setting homepages to ignored urls. r=daleharvey,mixedpuppy
Differential Revision: https://phabricator.services.mozilla.com/D40393
2019-08-05 21:52:59 +00:00
Marco Bonardo
dcf02274b4 Bug 1570434 - Add an API to toggle engagement event telemetry. r=adw,mixedpuppy
Differential Revision: https://phabricator.services.mozilla.com/D40194
2019-08-01 16:37:17 +00:00
Drew Willcoxon
9e7fab37a2 Bug 1569812 - Quantumbar: Allow extensions to specify search engines by name, URL, or alias. r=mak
`UrlbarResult` objects for search results have a `payload.engine` property, the name of the engine, but extensions won't always know the name Firefox uses internally or even any name at all. For example, the top sites API returns search results with aliases but not names. We should let extensions specify engine URLs and aliases, and we can use them to look up the engine name.

The UrlbarResult.jsm change is unrelated but fixes a minor annoyance I found while working on the top-sites extension. My background script returns results with `isKeywordOffer: true`, but that causes an error in `UrlbarResult.payloadAndSimpleHighlights` because it converts string values to arrays and then expects non-string values to be arrays. Instead, it should be converting non-array values to arrays.

Differential Revision: https://phabricator.services.mozilla.com/D39800
2019-07-31 17:00:07 +00:00
Drew Willcoxon
1541151a21 Bug 1569366 - Move the top sites API from toolkit to browser r=mixedpuppy
Bug 1547669 added some things to the top sites API, but it turned out to be not quite what we (the quantumbar team) needed (see bug 1568617). What we need is the list of top sites exactly as it appears on newtab. That list is determined by activity stream, which lives in browser. But the top sites API lives in toolkit.

There was an earlier, now abandoned revision for that bug [1] where it was suggested that top sites be moved to browser. So we should do that.

[1] https://phabricator.services.mozilla.com/D36200

Differential Revision: https://phabricator.services.mozilla.com/D39589
2019-07-29 17:00:19 +00:00
Brindusan Cristian
fa58466122 Backed out 2 changesets (bug 1556789) on request from aryx for causing Bug 1565836. a=backout
Backed out changeset ca5fdf3a0ddd (bug 1556789)
Backed out changeset 19419ff4e756 (bug 1556789)
2019-07-13 20:52:45 +03:00
Shane Caraveo
d24d4ba91c Bug 1556789 - Refactor extension install in searchservice to use promises r=robwu,daleharvey
This provides a set of promises that the searchservice resolves once the search engine has been configured

Differential Revision: https://phabricator.services.mozilla.com/D33660
2019-07-12 19:33:32 +00:00
Gurzau Raul
719f78a402 Backed out 2 changesets (bug 1556789) for assertion failures in FF functional tests on a CLOSED TREE.
Backed out changeset 2d10e95cf0cd (bug 1556789)
Backed out changeset 0acf6bafda0f (bug 1556789)
2019-07-12 04:45:46 +03:00
Shane Caraveo
5e55c6af34 Bug 1556789 - Refactor extension install in searchservice to use promises r=robwu,daleharvey
This provides a set of promises that the searchservice resolves once the search engine has been configured

Differential Revision: https://phabricator.services.mozilla.com/D33660
2019-07-11 18:42:00 +00:00
Noemi Erli
b0fe69e20f Backed out 2 changesets (bug 1556789) for failures in test_engines_on_restart.py
Backed out changeset 5488dbd0fa34 (bug 1556789)
Backed out changeset 021d8cd8ba70 (bug 1556789)
2019-07-11 03:37:26 +03:00
Shane Caraveo
3aca06f599 Bug 1556789 - Refactor extension install in searchservice to use promises r=robwu,daleharvey
This provides a set of promises that the searchservice resolves once the search engine has been configured

Differential Revision: https://phabricator.services.mozilla.com/D33660
2019-07-10 22:47:02 +00:00
Victor Porof
8eb72fd3fc Bug 1561435 - Format browser/components/, a=automatic-formatting
# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D36042
2019-07-05 09:53:32 +02:00