Commit Graph

1304 Commits

Author SHA1 Message Date
Dave Townsend
f45a67da21 Bug 1518632: Show the first-run experience for users that get pushed to a new profile. r=Gijs, r=flod, r=stomlinson
On startup of a fresh dedicated profile show a welcome page and a modal dialog
to explain what has happened.
2019-01-30 11:31:13 -08:00
Coroiu Cristina
62e622b69e Backed out 7 changesets (bug 1518632, bug 1463198, bug 1455707, bug 1522934, bug 1322797, bug 1474285) for build bustages at /builds/worker/workspace/build/src/toolkit/xre/nsAppRunner.cpp on a CLOSED TREE
Backed out changeset 82355ab7e063 (bug 1455707)
Backed out changeset b965981c9ce0 (bug 1463198)
Backed out changeset 21a801ca5f6d (bug 1455707)
Backed out changeset 05200c5388b4 (bug 1518632)
Backed out changeset ebcd8225434a (bug 1522934)
Backed out changeset e69cac07b209 (bug 1474285)
Backed out changeset 35af79575f54 (bug 1322797)
2019-01-31 03:34:49 +02:00
Dave Townsend
e235df8278 Bug 1518632: Show the first-run experience for users that get pushed to a new profile. r=Gijs, r=flod, r=stomlinson
On startup of a fresh dedicated profile show a welcome page and a modal dialog
to explain what has happened.
2019-01-30 11:31:13 -08:00
Myk Melez
5ecc2c1225 Bug 1518283 - prohibit blank lines at the beginning and end of blocks (eslint padded-blocks) r=mossop,Standard8
Differential Revision: https://phabricator.services.mozilla.com/D17526
2019-01-30 17:26:25 +00:00
Sebastian Hengst
b68993967d Merge mozilla-central to mozilla-inbound 2019-01-29 02:55:55 +02:00
Johann Hofmann
baee00c304 Bug 1522794 - Properly record content blocking telemetry in nsBrowserGlue.js. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D17619
2019-01-28 12:49:34 +00:00
Alastor Wu
858975a3e7 Bug 1521947 - add telemetry to know what default blocking-autoplay setting users usually use. r=johannh,janerik
Add a scalar 'autoplay_default_blocked' which records a boolean value which indicates whether user is blocking autoplay by default.

Differential Revision: https://phabricator.services.mozilla.com/D17298
2019-01-24 18:44:09 +00:00
Kris Maglione
856fa07b17 Bug 1514594: Part 3 - Change ChromeUtils.import API.
***
Bug 1514594: Part 3a - Change ChromeUtils.import to return an exports object; not pollute global. r=mccr8

This changes the behavior of ChromeUtils.import() to return an exports object,
rather than a module global, in all cases except when `null` is passed as a
second argument, and changes the default behavior not to pollute the global
scope with the module's exports. Thus, the following code written for the old
model:

  ChromeUtils.import("resource://gre/modules/Services.jsm");

is approximately the same as the following, in the new model:

  var {Services} = ChromeUtils.import("resource://gre/modules/Services.jsm");

Since the two behaviors are mutually incompatible, this patch will land with a
scripted rewrite to update all existing callers to use the new model rather
than the old.
***
Bug 1514594: Part 3b - Mass rewrite all JS code to use the new ChromeUtils.import API. rs=Gijs

This was done using the followng script:

https://bitbucket.org/kmaglione/m-c-rewrites/src/tip/processors/cu-import-exports.jsm
***
Bug 1514594: Part 3c - Update ESLint plugin for ChromeUtils.import API changes. r=Standard8

Differential Revision: https://phabricator.services.mozilla.com/D16747
***
Bug 1514594: Part 3d - Remove/fix hundreds of duplicate imports from sync tests. r=Gijs

Differential Revision: https://phabricator.services.mozilla.com/D16748
***
Bug 1514594: Part 3e - Remove no-op ChromeUtils.import() calls. r=Gijs

Differential Revision: https://phabricator.services.mozilla.com/D16749
***
Bug 1514594: Part 3f.1 - Cleanup various test corner cases after mass rewrite. r=Gijs
***
Bug 1514594: Part 3f.2 - Cleanup various non-test corner cases after mass rewrite. r=Gijs

Differential Revision: https://phabricator.services.mozilla.com/D16750
2019-01-17 10:18:31 -08:00
Ricky Rosario
8feb24c93c Bug 1508364 - New UI for Private Browsing with Search r=andreio
MozReview-Commit-ID: 4WSGpL5Gvde

Differential Revision: https://phabricator.services.mozilla.com/D16854
2019-01-21 20:14:26 +00:00
cowlesni
2907f7fcc3 Bug 1517529 - Migrate safeMode dialog to Fluent for localization, r=Gijs,flod
Differential Revision: https://phabricator.services.mozilla.com/D16987
2019-01-21 21:51:10 +00:00
arthur.iakab
8809d06ba4 Backed out changeset 13f379946829 (bug 1508364) for functional ui test failures on private_browsing/test_about_private_browsing.py CLOSED TREE 2019-01-21 21:38:29 +02:00
Ricky Rosario
02438f79cc Bug 1508364 - New UI for Private Browsing with Search r=andreio
MozReview-Commit-ID: 4WSGpL5Gvde

Differential Revision: https://phabricator.services.mozilla.com/D16854
2019-01-21 17:05:08 +00:00
Martin Stransky
7537bb8b84 Bug 1490344 - [Linux/Gtk] Enable hidden system titlebar by default on Gnome, r=dao
This patch implements -moz-gtk-csd-hide-titlebar-by-default media query
to check if the system titlebar should be disabled by default on Linux systems
(it's already disabled on Window/Mac).

It also removes explicit definition of browser.tabs.drawInTitlebar preference on Linux.
When browser.tabs.drawInTitlebar is missing the -moz-gtk-csd-hide-titlebar-by-default
is used to obtain the titlebar state. When browser.tabs.drawInTitlebar is set
in about:config or by Customize menu, the user peference is used instead of the default.

It also fixes a -moz-gtk-csd-available media query,
it was always true regardless the actual system setting.

Differential Revision: https://phabricator.services.mozilla.com/D16036
2019-01-17 12:44:49 +00:00
Michael Kaply
42bc510bca Bug 1518326 - Sanity check US region against timezone. r=adw
Differential Revision: https://phabricator.services.mozilla.com/D16073
2019-01-15 22:16:52 +00:00
Andreea Pavel
72a77bbbaf Backed out changeset aa442da7cfd8 (bug 1490344) for failing bc at browser/components/customizableui/test/browser_970511_undo_restore_default.js on a CLOSED TREE 2019-01-16 13:33:24 +02:00
Martin Stransky
8df9ea2c71 Bug 1490344 - [Linux/Gtk] Enable hidden system titlebar by default on Gnome, r=dao
This patch implements -moz-gtk-csd-hide-titlebar-by-default media query
to check if the system titlebar should be disabled by default on Linux systems
(it's already disabled on Window/Mac).

It also removes explicit definition of browser.tabs.drawInTitlebar preference on Linux.
When browser.tabs.drawInTitlebar is missing the -moz-gtk-csd-hide-titlebar-by-default
is used to obtain the titlebar state. When browser.tabs.drawInTitlebar is set
in about:config or by Customize menu, the user peference is used instead of the default.

It also fixes a -moz-gtk-csd-available media query,
it was always true regardless the actual system setting.

Differential Revision: https://phabricator.services.mozilla.com/D16036
2019-01-15 14:47:03 +00:00
Michael Kelly
e5e71e3d0a Bug 1509888: Remove Browser Error Collection. r=Gijs,flod
Differential Revision: https://phabricator.services.mozilla.com/D15879
2019-01-15 18:04:28 +00:00
Dave Townsend
6cbe0e9a02 Bug 1518591: Make the profile service responsible for protecting against downgrading to builds before dev-edition had a separate profile. r=froydnj
Because older versions of Firefox auto-select a profile if there is only one in
the database when running dev-edition which uses its own profile we create a
default for normal channels to use. Currently the browser code is responsible
for doing this but it uses a bad heuristic for deciding when to do that. It's
much easier to do it from the profile manager when the dev-edition profile is
created.

Differential Revision: https://phabricator.services.mozilla.com/D16117
2019-01-10 21:15:53 +00:00
Gijs Kruitbosch
1cdf5e75ba Bug 1498295 - simplify pocket reader code a bit, r=mconley
Differential Revision: https://phabricator.services.mozilla.com/D15525
2019-01-08 12:36:08 +00:00
alwu
d63dfd7846 Bug 1513039 - part8 : remove autoplay prompt front-end codes. r=florian,daleharvey,flod
Remove autoplay prompt related js codes.

Differential Revision: https://phabricator.services.mozilla.com/D14333
2019-01-07 18:38:26 +00:00
Jan de Mooij
5b1f401737 Bug 1515611 part 2 - QI nsIWritablePropertyBag instead of nsIPropertyBag on nsIUpdate. r=rstrong
If we QI nsIPropertyBag on an XPCWrappedNative wrapping an XPCWrappedJS, calling
the getProperty method might incorrectly end up calling .getProperty on the
XPCWrappedJS itself, because it also implements nsIPropertyBag.

This became a problem with same-compartment chrome globals because if we no longer
cross a compartment boundary, we don't create a new WrappedNative and can now end up
seeing the nsIPropertyBag if it got queried before nsIWritablePropertyBag.

Depends on D15076

Differential Revision: https://phabricator.services.mozilla.com/D15077
2018-12-20 17:47:32 +00:00
Mark Banner
ae7d62129f Bug 1503674 - Remove unused PageMetadata. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D14678
2018-12-17 09:33:12 +00:00
Gijs Kruitbosch
8e611f710c Bug 1511820 - clarify private browsing tabs for quit warning, r=flod
Differential Revision: https://phabricator.services.mozilla.com/D14470
2018-12-14 12:08:33 +00:00
Gijs Kruitbosch
fd54eb0f3b Bug 1499092 - move bulk of registerProtocolHandler checks into compiled code so we don't need a dedicated component in the child process, r=nika
Differential Revision: https://phabricator.services.mozilla.com/D13697
2018-12-13 13:47:39 +00:00
Erica Wright
6c32745513 Bug 1510734 - Content Blocking strict setting now uses network.cookie.cookieBehavior=4. r=johannh,flod
The strict category should block third-party tracking cookies instead of all third-party cookies. This changes the requirements to match that category, so existing strict users will be moved to custom.

Differential Revision: https://phabricator.services.mozilla.com/D13325
2018-12-06 18:03:44 +00:00
Mark Banner
396e01ae12 Bug 1505411 - Add basic monitoring for partner search pages with ads and clicks. Depends on D11188 r=adw,Felipe,chutten
Differential Revision: https://phabricator.services.mozilla.com/D11656
2018-12-05 20:33:01 +00:00
Ciure Andrei
3f303ab161 Backed out changeset a5acc2768905 (bug 1510734) for browser_contentblocking.js failures CLOSED TREE 2018-12-04 20:57:55 +02:00
Erica Wright
e689b5b8a8 Bug 1510734 - Content Blocking strict setting now uses network.cookie.cookieBehavior=4. r=johannh,flod
The strict category should block third-party tracking cookies instead of all third-party cookies. This changes the requirements to match that category, so existing strict users will be moved to custom.

Differential Revision: https://phabricator.services.mozilla.com/D13325
2018-12-04 16:45:55 +00:00
Gijs Kruitbosch
3c50ed662a Bug 1506173 - use separate pref for warning on quit with sessionstore enabled, r=jaws,flod
Differential Revision: https://phabricator.services.mozilla.com/D13535
2018-11-30 20:21:59 +00:00
Shane Caraveo
94c82f0400 Bug 1510700 wait for ContextualIdentityService before updating Discovery cookies r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D13291
2018-11-28 19:14:10 +00:00
Ehsan Akhgari
f14967e85c Bug 1490811 - Part 1: Add a permission doorhanger for the storage access API r=baku,johannh
Differential Revision: https://phabricator.services.mozilla.com/D12467
2018-11-26 21:23:16 +00:00
Erica Wright
bfd228cd0d Bug 1501990 - Add a mode label to the Content Blocking section in the control center. r=johannh,flod
Differential Revision: https://phabricator.services.mozilla.com/D12717
2018-11-26 16:59:19 +00:00
Shane Caraveo
ea43c7c27c Bug 1489531 Expose telemetry client_id hash to about:addons via cookie r=Gijs,chutten
Differential Revision: https://phabricator.services.mozilla.com/D9317
2018-11-26 15:26:39 +00:00
Erica Wright
9595afd768 Bug 1508806 - Toggling between content blocking categories correctly changes when there are multiple windows. r=johannh
We no longer set up a listener on a per-window basis for category preference changes.

Differential Revision: https://phabricator.services.mozilla.com/D12667
2018-11-23 16:08:58 +00:00
Mark Hammond
ac38cfcac6 Bug 1506271 - BrowserGlue._setSyncAutoconnectDelay() now checks win.gBrowser before using it. r=MattN
Differential Revision: https://phabricator.services.mozilla.com/D11817
2018-11-13 22:17:01 +00:00
Jared Hirsch
95401163bc Bug 1503893 - Ensure Screenshots disable pref is checked at startup; r=aswan
MozReview-Commit-ID: FGUaKbXhit2

Differential Revision: https://phabricator.services.mozilla.com/D11086
2018-11-10 17:37:33 +00:00
Paolo Amadini
ecaee75fcc Bug 1471403 - Part 2 - Lazify the creation of "notificationbox" elements. r=dao,bgrins
Differential Revision: https://phabricator.services.mozilla.com/D10892
2018-11-09 14:38:49 +00:00
Dão Gottwald
d4b85d2c2f Bug 1505311 - Stop overriding --toolbarbutton-icon-fill-opacity for Dark and Light themes. r=ntim
Differential Revision: https://phabricator.services.mozilla.com/D11151
2018-11-07 10:45:17 +00:00
Gijs Kruitbosch
3f7c972148 Bug 550559 - also show close warnings when session restore is active, r=jaws,flod
Differential Revision: https://phabricator.services.mozilla.com/D10217
2018-11-02 20:03:50 +00:00
Dão Gottwald
0fde64013d Bug 1503306 - Properly set accentcolor and textcolor properties for Light and Dark themes. r=ntim
Differential Revision: https://phabricator.services.mozilla.com/D10542
2018-11-01 12:40:20 +00:00
Dão Gottwald
faec7595e7 Bug 1503301 - Set tab_line property for Light and Dark themes. r=ntim
Differential Revision: https://phabricator.services.mozilla.com/D10345
2018-10-31 12:04:08 +00:00
Dão Gottwald
f613d85360 Bug 1455924 - Clean up Dark/Light theme CSS. r=ntim
Differential Revision: https://phabricator.services.mozilla.com/D9998
2018-10-29 18:36:21 +00:00
Ehsan Akhgari
8d2d305cf3 Bug 1502760 - Stop honouring browser.contentblocking.enabled in the control centre code r=johannh
Differential Revision: https://phabricator.services.mozilla.com/D10020
2018-10-29 14:44:12 +00:00
Siddhant085
8ee1087713 Bug 1493483 - Use nsIBrowserSearchService::defaultEngine instead of currentEngine (in production code) r=Standard8
nsIBrowserSearchService::currentEngine and nsIBrowserSearchService::defaultEngine are the same thing.
The use of defaultEngine makes more sense and thus we are phasing out the use of currentEngine and replace it with defaultEngine.

Differential Revision: https://phabricator.services.mozilla.com/D7972
2018-10-27 16:52:02 +00:00
Ehsan Akhgari
1c1438a50f Bug 1502076 - Part 2: Remove the fastblock UI from the Control Centre r=johannh
Depends on D9794

Differential Revision: https://phabricator.services.mozilla.com/D9795
2018-10-26 06:55:20 +00:00
Matthew Noorenberghe
9e371424a0 Bug 1501552 - Link directly to permission preferences from web notifications. r=jaws
Differential Revision: https://phabricator.services.mozilla.com/D9619
2018-10-24 15:11:13 +00:00
Gijs Kruitbosch
cbb2ba1edc Bug 1500268 - remove legacy toolbar and currentset support from customizableui, r=jaws
Differential Revision: https://phabricator.services.mozilla.com/D9172
2018-10-22 16:02:07 +00:00
Francesco Lodolo (:flod)
ae3e19d109 Bug 1500823 - Dialog displayed when closing multiple windows shows unreplaced %1$S placeholder r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D9361
2018-10-22 08:38:19 +00:00
Thomas Wisniewski
1709e5b8d1 Bug 1498827 - Ensure the webcompat report addon is disabled upon load, if extensions.webcompat-reporter.enabled=false, take two r=aswan,mixedpuppy
Ensure the webcompat report addon is disabled upon load, if extensions.webcompat-reporter.enabled=false, take two

Differential Revision: https://phabricator.services.mozilla.com/D8678
2018-10-17 15:56:27 +00:00
Johann Hofmann
bd1813f9f4 Bug 1484255 - Add Telemetry Events for the certificate error pages. r=nhnt11,keeler
Differential Revision: https://phabricator.services.mozilla.com/D8281
2018-10-17 13:10:26 +00:00