corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
744,671 Commits 1 Branch 0 Tags
75329af4b9bb203b51e4b2c7536a252b9d42fce0
Commit Graph

268 Commits

Author SHA1 Message Date
Barret Rennie
ad911a3922 Bug 1771073 - Make make-schemas.py executable r=dmose 
Depends on D147332

Differential Revision: https://phabricator.services.mozilla.com/D150398
 2022-06-29 23:01:37 +00:00
Barret Rennie
b3e2605f2b Bug 1771073 - Correct FxMS features and keep them up to date with tests r=dmose,pdahiya 
The Nimbus Features corresponding to FxMS messaging surfaces are actually
intended to map to FxMS message groups, which can accept *any* FxMS message.
The features have been updated with schemas that accept any FxMS message.

As part of this, all FxMS schemas have been updated with an `$id` so that they
can be bundled into feature schemas and have their internal `$ref`s work.
(Otherwise, a `$ref` would be relative to the top-level schema instead of the
sub-schema).

Schemas for individual message types are no longer exposed as resource:// URIs,
except in tests, as indivual schemas are no longer required at runtime.

Additionally, each FxMS schema has had its `template` field become required and
requires a constant value for that schema (e.g., Spotlight requires a template
value of "spotlight").

A test has been added to ensure that if any of the messaging surfaces schemas
change that the feature schemas are also updated. The feature schemas can be
regenerated via:

```
cd ./browser/components/newtab/content-src/asrouter/schemas
../../../../../../mach make-schemas.py
```

Differential Revision: https://phabricator.services.mozilla.com/D147332
 2022-06-29 23:01:37 +00:00
Meg Viar
4c527f9886 Bug 1772025 - Add targeting for users who have private Firefox browser pinned r=pdahiya,barret 
Differential Revision: https://phabricator.services.mozilla.com/D148446
 2022-06-22 18:30:03 +00:00
Barret Rennie
f86903b198 Bug 1768727 - Make messaging systems more backwards compatible and update schemas to match in-flight messages r=emcminn 
Differential Revision: https://phabricator.services.mozilla.com/D146028
 2022-05-12 21:39:18 +00:00
Barret Rennie
188cd9ed5c Bug 1767302 - Fix UpdateAction.schema.json, again r=emcminn 
Differential Revision: https://phabricator.services.mozilla.com/D145239
 2022-05-04 01:26:48 +00:00
Barret Rennie
bbdc3c3536 Bug 1767266 - Make ExtensionDoorhanger.schema.json more lenient r=Mardak 
Differential Revision: https://phabricator.services.mozilla.com/D145241
 2022-05-03 16:37:19 +00:00
Barret Rennie
f726644db9 Bug 1766430 - Allow additional properties in Spotlight content r=Mardak 
Differential Revision: https://phabricator.services.mozilla.com/D144722
 2022-04-26 16:22:50 +00:00
Barret Rennie
ad38c46862 Bug 1766091 - Fix UpdateAction.schema.json r=emcminn 
Differential Revision: https://phabricator.services.mozilla.com/D144504
 2022-04-25 18:34:03 +00:00
Meg Viar
9bf58262eb Bug 1762273 - Adjust thank you screen square-ish sizing with noodles, transitions, auto advance without showing Home r=Mardak 
Differential Revision: https://phabricator.services.mozilla.com/D142839
 2022-04-04 17:27:24 +00:00
Meg Viar
48fd34f067 Bug 1762242 - Conditionally show Private Browsing page Focus promo r=dmose 
Differential Revision: https://phabricator.services.mozilla.com/D142551
 2022-04-01 12:36:30 +00:00
Barret Rennie
af694af439 Bug 1752665 - Make the Spotlight schema less strict with respect to images r=emcminn 
The previous changes to the Spotlight schema made one of the logo.imageURL or
logo.imageId required. However, this is not backwards compatible with the older
Firefoxen, so we have to support the case where `logo` is present (e.g., for
`image.size`) without either of those properties, but `logoImageURL` *is*
present.

Differential Revision: https://phabricator.services.mozilla.com/D140761
 2022-03-25 00:01:21 +00:00
Barret Rennie
4db190e51d Bug 1752665 - Rewrite PanelTestProvider test as xpcshell test with new json schema validator r=andreio 
Differential Revision: https://phabricator.services.mozilla.com/D138927
 2022-03-25 00:01:20 +00:00
Barret Rennie
570a0f103e Bug 1757809 - Provide a JsonSchema module that supports additional Mozilla-specific formats r=mossop,emcminn 
In migrating from Ajv 6 to @cfworker/json-schema, some schemas will no longer
validate due to the `format: uri` annotation only being a suggestion for
strings in Ajv 6. Our URLs that use %PLACEHOLDERS% (e.g., `%LOCALE%`) will not
pass validation as URIs due to being interpreted as invalid URL encoding.

Here we add a facade in front of @cfworker/json-schema which defines a
`moz-url-format` format for strings, which runs them through
Services.urlFormatter.formatURL before attempting to validate them as URIs. We
don't simply find-replace all %PLACEHOLDERS% because the URL formatter service
only supports certain variables and will leave undefined variables as-is,
leading to a validation error (which is what we want).

Differential Revision: https://phabricator.services.mozilla.com/D138926
 2022-03-25 00:01:18 +00:00
Marian-Vasile Laza
7cd6c33676 Backed out 3 changesets (bug 1757809, bug 1755599) for causing bc failures on browser_all_files_referenced.js. CLOSED TREE 
Backed out changeset 63ae4c9485e9 (bug 1757809)
Backed out changeset 2297b7533b97 (bug 1755599)
Backed out changeset e021f9e97c76 (bug 1755599)
 2022-03-10 12:08:13 -08:00
Barret Rennie
7fc61d9b42 Bug 1757809 - Provide a JsonSchema module that supports additional Mozilla-specific formats r=mossop,emcminn 
In migrating from Ajv 6 to @cfworker/json-schema, some schemas will no longer
validate due to the `format: uri` annotation only being a suggestion for
strings in Ajv 6. Our URLs that use %PLACEHOLDERS% (e.g., `%LOCALE%`) will not
pass validation as URIs due to being interpreted as invalid URL encoding.

Here we add a facade in front of @cfworker/json-schema which defines a
`moz-url-format` format for strings, which runs them through
Services.urlFormatter.formatURL before attempting to validate them as URIs. We
don't simply find-replace all %PLACEHOLDERS% because the URL formatter service
only supports certain variables and will leave undefined variables as-is,
leading to a validation error (which is what we want).

Differential Revision: https://phabricator.services.mozilla.com/D138926
 2022-03-10 18:53:32 +00:00
Punam Dahiya
e63e57f8d2 Bug 1754089 - Update Messaging System source docs r=andreio 
Differential Revision: https://phabricator.services.mozilla.com/D138074
 2022-02-22 16:40:04 +00:00
Ed Lee
44942cfc9a Bug 1752935 - Reuse welcome bundle from Spotlight for multistage template r=pdahiya,andreio 
Detect about:welcome template usage and move modal shadow styling to content. Remove 93-backwards-compatible logoImageURL and update schema. Only basic functionality for initial testing.

Differential Revision: https://phabricator.services.mozilla.com/D138866
 2022-02-16 19:05:22 +00:00
Sylvestre Ledru
aa55fd2be8 Bug 1753413 - fx doc: Remove whitespaces, trailing lines & windows CR r=andi,perftest-reviewers,sparky 
Differential Revision: https://phabricator.services.mozilla.com/D137741
 2022-02-03 18:34:58 +00:00
Barret Rennie
2762bdaa49 Bug 1752183 - Support remote images in Spotlight r=Mardak 
Differential Revision: https://phabricator.services.mozilla.com/D137210
 2022-02-03 18:16:05 +00:00
Iulian Moraru
43e96c0e53 Backed out 2 changesets (bug 1752183) for causing multiple failures. CLOSED TREE 
Backed out changeset b85880f20aa5 (bug 1752183)
Backed out changeset c4bd523a463a (bug 1752183)
 2022-02-03 07:33:40 +02:00
Barret Rennie
c36b2cd877 Bug 1752183 - Support remote images in Spotlight r=Mardak 
Differential Revision: https://phabricator.services.mozilla.com/D137210
 2022-02-03 04:39:42 +00:00
Andrei Oprea
f64147a52f Bug 1746598 - Route MS messages to PB newtab r=dmose,extension-reviewers,rpl 
Differential Revision: https://phabricator.services.mozilla.com/D134157
 2022-01-25 13:02:30 +00:00
Sandor Molnar
3e20f2d917 Backed out changeset ea22083f5525 (bug 1746598) for causing bc failures in browser/components/extensions/test/browser/browser_ext_menus_incognito.js CLOSED TREE 2022-01-24 10:53:24 +02:00
Andrei Oprea
96287321db Bug 1746598 - Route MS messages to PB newtab r=dmose 
Differential Revision: https://phabricator.services.mozilla.com/D134157
 2022-01-24 07:49:45 +00:00
Gijs Kruitbosch
1e142f4319 Bug 1719939 - remove browser.proton.enabled from new tab code, r=mviar 
Differential Revision: https://phabricator.services.mozilla.com/D134308
 2021-12-22 21:41:40 +00:00
Andrei Oprea
02d7dc18a9 Bug 1740718 - Switch Messaging System to use the NimbusFeatures API r=k88hudson 
Differential Revision: https://phabricator.services.mozilla.com/D131241
 2021-11-26 11:34:50 +00:00
Ed Lee
527bb6cf07 Bug 1735841 - Update template with hidden text that is shown on a link click for Total Cookie Protection r=andreio 
Introduce an extra expanded text with a learn more toggle button. Allow for message configuration of various sizes.

Differential Revision: https://phabricator.services.mozilla.com/D129556
 2021-10-28 14:24:59 +00:00
Andrei Oprea
52cf1b8ef5 Bug 1729943 - Fix json schema for Messaging System Spotlight component r=dmose 
Differential Revision: https://phabricator.services.mozilla.com/D125389
 2021-09-22 10:00:01 +00:00
Butkovits Atila
91d0db9a30 Backed out 3 changesets (bug 1719939, bug 1726437, bug 1730262) for causing failures on test_browserGlue_migration_ctrltab_recently_used_order.js. 
Backed out changeset ea1653e9644f (bug 1719939)
Backed out changeset 01f90db715a7 (bug 1726437)
Backed out changeset c0e23b2acfbb (bug 1730262)
 2021-09-21 05:15:31 +03:00
Junjie Ying
11151d13b2 Bug 1719939 - Remove last fragments of code manually checking the browser.proton.enabled pref. r=mhowell 
Differential Revision: https://phabricator.services.mozilla.com/D125345
 2021-09-21 00:03:49 +00:00
Andrei Oprea
bb93a041e0 Bug 1730497 - Add targeting attribute to detect browser pinned status r=Mardak 
Differential Revision: https://phabricator.services.mozilla.com/D125858
 2021-09-17 11:54:54 +00:00
Harry Twyford
bd18b6c4d2 Bug 1727319 - Part 2 - Remove intermediary variables in _theme.scss. r=Mardak 
Differential Revision: https://phabricator.services.mozilla.com/D125608
 2021-09-16 21:50:29 +00:00
Harry Twyford
2c68cf2971 Bug 1727317 - Define set of color variables to use in newtab. r=Mardak 
Differential Revision: https://phabricator.services.mozilla.com/D125606
 2021-09-16 21:50:29 +00:00
Harry Twyford
75f4dc3868 Bug 1727321 - Part 4 - Stop using color variables elsewhere in newtab. r=thecount 
Differential Revision: https://phabricator.services.mozilla.com/D124401
 2021-09-08 22:06:27 +00:00
Harry Twyford
1cbd7abe67 Bug 1727321 - Part 3 - Stop using color variables in box-shadows. r=thecount 
Differential Revision: https://phabricator.services.mozilla.com/D124399
 2021-09-08 22:06:27 +00:00
Harry Twyford
a327978c95 Bug 1727321 - Part 2 - Stop using color variables in buttons. r=thecount 
Differential Revision: https://phabricator.services.mozilla.com/D124398
 2021-09-08 22:06:26 +00:00
Andrei Oprea
3cbae7f729 Bug 1728420 - New messaging surface Spotlight r=Mardak,dmose,nanj 
Differential Revision: https://phabricator.services.mozilla.com/D121913
 2021-09-03 13:41:21 +00:00
Andrei Oprea
4d599e6e9a Bug 1726739 - Adjust profile activity related targeting to 28 day time interval r=Mardak 
Differential Revision: https://phabricator.services.mozilla.com/D123212
 2021-08-23 17:51:26 +00:00
Andrei Oprea
14419b8a91 Bug 1725131 - Remove messaging system code related to the Bookmark panel r=pdahiya,Mardak,webdriver-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D122342
 2021-08-19 13:17:13 +00:00
Andrei Oprea
4f5577e8d4 Bug 1722465 - Investigate using telemetry archived data for determining profile activity r=Mardak 
Differential Revision: https://phabricator.services.mozilla.com/D120959
 2021-07-30 15:57:54 +00:00
Punam Dahiya
19d97ff4a9 Bug 1720758 - Remove browser.aboutwelcome.protonDesign pref and pre-MR1 multistage onboarding r=Mardak 
Cleanup pre-MR1 new user onboarding experience  by
 - removing browser.aboutwelcome.protonDesign pref
 - removing pre-MR1 multistage screen
 - removing pre-MR1 AboutWelcomeDefault content
 - fix respective tests

Differential Revision: https://phabricator.services.mozilla.com/D120038
 2021-07-22 16:57:32 +00:00
Csoregi Natalia
26e41dfbdb Backed out changeset c2cb820e5a69 (bug 1720758) for causing failures on browser_aboutwelcome_multistage_default.js. CLOSED TREE 2021-07-22 10:03:54 +03:00
Punam Dahiya
d83c14f45e Bug 1720758 - Remove browser.aboutwelcome.protonDesign pref and pre-MR1 multistage onboarding r=Mardak 
Cleanup pre-MR1 new user onboarding experience  by
 - removing browser.aboutwelcome.protonDesign pref
 - removing pre-MR1 multistage screen
 - removing pre-MR1 AboutWelcomeDefault content
 - fix respective tests

Differential Revision: https://phabricator.services.mozilla.com/D120038
 2021-07-22 05:18:06 +00:00
Sebastian Hengst
27ba6f2cb6 Bug 1714664 - Update onboarding documentation on source doc: change words to make spell linter happy. CLOSED TREE DONTBUILD 2021-07-07 20:50:41 +02:00
Punam Dahiya
b69f17dadf Bug 1714664 - Update onboarding documentation on source doc with latest MR1 r=Mardak 
Differential Revision: https://phabricator.services.mozilla.com/D118048
 2021-07-07 17:46:35 +00:00
Sam Foster
ddf71985d6 Bug 1708502 - De-dupe about:newtab icons. r=thecount 
Differential Revision: https://phabricator.services.mozilla.com/D118863
 2021-07-07 17:08:28 +00:00
Andrei Oprea
6c35401053 Bug 1717871 - Add targeting attribute to detect any active policies r=k88hudson 
Differential Revision: https://phabricator.services.mozilla.com/D118611
 2021-06-25 12:31:02 +00:00
Andrei Oprea
55a44da2ef Bug 1695764 - Remove code related to CFR ML Experiment r=k88hudson 
Differential Revision: https://phabricator.services.mozilla.com/D113963
 2021-06-15 10:44:15 +00:00
Bernard Igiri
872b3d586d Bug 1705855 - Fix newtab padding r=thecount 
Modified padding on newtab eliminate unnecessary scrollbars and only apply snippet specific padding when snippets are present.

Differential Revision: https://phabricator.services.mozilla.com/D114530
 2021-05-21 00:27:42 +00:00
Csoregi Natalia
afa9449e7e Backed out changeset 335bbc7eb086 (bug 1705855) for causing newtab failures. CLOSED TREE 2021-05-20 20:46:14 +03:00