There's are a couple of issues that this fixes, they are both based around the issue that because
tests run fast they tend to not give time for batches to complete. This can lead to incomplete
batches between tests, which tends to mess up subsequent tests or cause hangs.
In normal usage this is not an issue, as the user is not able to go as fast as tests.
The first issue is that in PlacesUIUtils.showBookmarkDialog we may resolve the dialog deferred
promise before the transaction batch has had change to complete.
The second issue is that the star UI runs batches, and that again we do not wait for the batch
to be complete. Working an await into the star UI/tests is more difficult due to the way that
code is structured. With a planned switch to non-instant apply, it also feels too complicated
to be worth it at this time. As a workaround for this issue, we ensure that the transaction
queue is cleared between each test run via a registerCleanupFunction in the head.js file.
Differential Revision: https://phabricator.services.mozilla.com/D147535
The virtual click event is also removed. It seems this event is only used to check whether this was a key or mouse event in PanelMultiView.jsm
This also removes support for pressing the enter key to trigger these toolbarbuttons on Mac which shouldn't be happening anyway.
Differential Revision: https://phabricator.services.mozilla.com/D149285
There's are a couple of issues that this fixes, they are both based around the issue that because
tests run fast they tend to not give time for batches to complete. This can lead to incomplete
batches between tests, which tends to mess up subsequent tests or cause hangs.
In normal usage this is not an issue, as the user is not able to go as fast as tests.
The first issue is that in PlacesUIUtils.showBookmarkDialog we may resolve the dialog deferred
promise before the transaction batch has had change to complete.
The second issue is that the star UI runs batches, and that again we do not wait for the batch
to be complete. Working an await into the star UI/tests is more difficult due to the way that
code is structured. With a planned switch to non-instant apply, it also feels too complicated
to be worth it at this time. As a workaround for this issue, we ensure that the transaction
queue is cleared between each test run via a registerCleanupFunction in the head.js file.
Differential Revision: https://phabricator.services.mozilla.com/D147535
The Nimbus Features corresponding to FxMS messaging surfaces are actually
intended to map to FxMS message groups, which can accept *any* FxMS message.
The features have been updated with schemas that accept any FxMS message.
As part of this, all FxMS schemas have been updated with an `$id` so that they
can be bundled into feature schemas and have their internal `$ref`s work.
(Otherwise, a `$ref` would be relative to the top-level schema instead of the
sub-schema).
Schemas for individual message types are no longer exposed as resource:// URIs,
except in tests, as indivual schemas are no longer required at runtime.
Additionally, each FxMS schema has had its `template` field become required and
requires a constant value for that schema (e.g., Spotlight requires a template
value of "spotlight").
A test has been added to ensure that if any of the messaging surfaces schemas
change that the feature schemas are also updated. The feature schemas can be
regenerated via:
```
cd ./browser/components/newtab/content-src/asrouter/schemas
../../../../../../mach make-schemas.py
```
Differential Revision: https://phabricator.services.mozilla.com/D147332
The virtual click event is also removed. It seems this event is only used to check whether this was a key or mouse event in PanelMultiView.jsm
This also removes support for pressing the enter key to trigger these toolbarbuttons on Mac which shouldn't be happening anyway.
Differential Revision: https://phabricator.services.mozilla.com/D149285
Please see the bug for info. This revision changes the URL of the adaptive
history doc to the new published doc. Ultimately this doc should live in-tree
but until then this is a nice, simple improvement.
Differential Revision: https://phabricator.services.mozilla.com/D150516
The documentation says this change was made in 103 because I'll request uplift
to Beta 103.
This also adds documentation for the new `sid` and `seq` Merino params from
D150289. I should have update the doc there, and since I'm modifying it now
anyway let's do it here.
Differential Revision: https://phabricator.services.mozilla.com/D150490
The virtual click event is also removed. It seems this event is only used to check whether this was a key or mouse event in PanelMultiView.jsm
This also removes support for pressing the enter key to trigger these toolbarbuttons on Mac which shouldn't be happening anyway.
Differential Revision: https://phabricator.services.mozilla.com/D149285
