corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
892,246 Commits 1 Branch 0 Tags
73f4f0146549173f51fd9f2950fd988ce646edfe
Commit Graph

302 Commits

Author SHA1 Message Date
Marc Seibert
5fc5f53f97 Bug 1845710 - [UrlbarView] Add LRM to URLs with the protocol trimmed in the results pane.r=mak 
Differential Revision: https://phabricator.services.mozilla.com/D186124
 2023-09-26 15:00:54 +00:00
Dão Gottwald
dbfff57b2c Bug 1853954 - Rename actionoverride to action-override and make it a standard boolean attribute. r=adw 
Differential Revision: https://phabricator.services.mozilla.com/D188606
 2023-09-20 07:45:01 +00:00
Daisuke Akatsuka
f21d94cded Bug 1850902: Remove browser.fixup.alternate.enabled pref and its code path r=jteow,mak 
Differential Revision: https://phabricator.services.mozilla.com/D187237
 2023-09-10 22:33:27 +00:00
Daisuke Akatsuka
3f4dba67c3 Bug 1637408: Append the protocol when copying if the urlbar value is autofilled r=adw 
Differential Revision: https://phabricator.services.mozilla.com/D187364
 2023-09-05 23:40:06 +00:00
Marc Seibert
3b6cce5a81 Bug 1848271 - Editing suggested URL is broken.r=dao 
Differential Revision: https://phabricator.services.mozilla.com/D185985
 2023-08-14 11:09:41 +00:00
Marc Seibert
3b461e98a2 Bug 1067293 - Omit "https://".r=dao 
Differential Revision: https://phabricator.services.mozilla.com/D184933
 2023-08-09 22:27:21 +00:00
Marc Seibert
398f67d307 Bug 1846261 - Editing autocompleted domains in URL bar is broken.r=mak 
Differential Revision: https://phabricator.services.mozilla.com/D185051
 2023-08-09 09:54:52 +00:00
Cristian Tuns
064737db44 Backed out changeset e99b30fd0931 (bug 1067293) for causing bc failures in browser_preferences_usage.js CLOSED TREE 2023-08-08 20:40:06 -04:00
Marc Seibert
6447bd4fab Bug 1067293 - Omit "https://".r=dao 
Differential Revision: https://phabricator.services.mozilla.com/D184933
 2023-08-08 19:19:57 +00:00
Karandeep
b0382c3163 Bug 1842230 - URL bar suggested action for paste when clipboard contains valid URL. r=mak,flod 
Differential Revision: https://phabricator.services.mozilla.com/D183747
 2023-08-01 11:51:59 +00:00
Marc Seibert
6bb93e734c Bug 1836962 - Only trim URL if directionality doesn't change to RTL.r=dao 
Differential Revision: https://phabricator.services.mozilla.com/D184629
 2023-07-27 11:46:46 +00:00
Gregory Pappas
e9950eccfd Bug 1845311 - Use ChromeUtils.defineLazyGetter in more places r=arai,webdriver-reviewers,geckoview-reviewers,extension-reviewers,application-update-reviewers,credential-management-reviewers,devtools-reviewers,fxview-reviewers,anti-tracking-reviewers,sessionstore-reviewers,pbz,joschmidt,robwu,issammani,bytesized,owlish,dao 
Differential Revision: https://phabricator.services.mozilla.com/D184481
 2023-07-26 16:28:11 +00:00
Marc Seibert
77df2cb8ef Bug 1416881 - Entering characters with character/accent marks on macOS doesn't remove the autofilled selected part.r=mak 
Differential Revision: https://phabricator.services.mozilla.com/D182664
 2023-07-18 08:00:38 +00:00
Mark Banner
88e658c23d Bug 1792824 - Convert ObjectUtils.jsm to an ES module. r=barret,necko-reviewers,devtools-reviewers,kershaw 
Depends on D183308

Differential Revision: https://phabricator.services.mozilla.com/D183309
 2023-07-12 08:07:23 +00:00
Marco Bonardo
ff3c4323fc Bug 1827770 - Remove QueryContext.view and pass the controller to onEngagement() instead. r=daleharvey 
Differential Revision: https://phabricator.services.mozilla.com/D182771
 2023-07-07 10:01:50 +00:00
Norisz Fay
bdd652b5e3 Backed out changeset 909fc50c54a1 (bug 1838743) for causing failures on browser_947914_button_paste.js CLOSED TREE 2023-07-07 05:57:07 +03:00
Daisuke Akatsuka
a083b83b1c Bug 1838743: Ignore paste event if the event was fired from not urlbar r=masayuki,dao 
Differential Revision: https://phabricator.services.mozilla.com/D182880
 2023-07-07 00:43:34 +00:00
Dão Gottwald
31cca62565 Bug 1840827 - Restore Go button when switching tabs. r=jteow 
Differential Revision: https://phabricator.services.mozilla.com/D182453
 2023-06-30 15:47:03 +00:00
Butkovits Atila
56c7c23b88 Backed out changeset a72a5e849a5d (bug 1840827) for causing failures at browser_windowopen.js. CLOSED TREE 2023-06-29 18:19:55 +03:00
Dão Gottwald
8f1c558608 Bug 1840827 - Restore Go button when switching tabs. r=jteow 
Differential Revision: https://phabricator.services.mozilla.com/D182453
 2023-06-29 13:35:07 +00:00
Stephanie Cunnane
ddcbc18d91 Bug 1589602 - Improve urlbar performance with very long search strings. r=mak 
Differential Revision: https://phabricator.services.mozilla.com/D180734
 2023-06-27 13:13:11 +00:00
Dão Gottwald
760282cdb1 Bug 1777870 - Format the urlbar value after tab select and focus change, and avoid formatting multiple times when handling blur events. r=jteow 
Differential Revision: https://phabricator.services.mozilla.com/D181888
 2023-06-27 12:42:07 +00:00
Chris H-C
eca601ffd9 Bug 1836283 - Reinstrument contextual services PingCentre pings in parallel with Glean r=perry.mcmanis,nanj,wstuckey 
Covers topsites and quicksuggest impressions, clicks, and blocks.

Removes unused and not-to-be-used topsites-in-urlbar pingcentre instrumentation
rather than reinstrumenting it.

Differential Revision: https://phabricator.services.mozilla.com/D179856
 2023-06-26 19:02:46 +00:00
Katherine Patenio
ce9d8a5dad Bug 1834831 - update imports of browser/modules JSMs r=webdriver-reviewers,perftest-reviewers,zeid,extension-reviewers,settings-reviewers,pip-reviewers,credential-management-reviewers,devtools-reviewers,fxview-reviewers,sessionstore-reviewers,tabbrowser-reviewers,whimboo,mhowell,sgalich,robwu,sparky,Standard8,mconley,dao,sclements 
Differential Revision: https://phabricator.services.mozilla.com/D179169
 2023-06-19 18:44:48 +00:00
Cristian Tuns
f826f1b621 Backed out 2 changesets (bug 1834831) for causing node failures with checkBundles CLOSED TREE 
Backed out changeset 58b351a155c8 (bug 1834831)
Backed out changeset 1acbb5231d14 (bug 1834831)
 2023-06-19 13:22:35 -04:00
Katherine Patenio
333197cd22 Bug 1834831 - update imports of browser/modules JSMs r=webdriver-reviewers,perftest-reviewers,zeid,extension-reviewers,settings-reviewers,pip-reviewers,credential-management-reviewers,devtools-reviewers,fxview-reviewers,sessionstore-reviewers,tabbrowser-reviewers,whimboo,mhowell,sgalich,robwu,sparky,Standard8,mconley,dao,sclements 
Differential Revision: https://phabricator.services.mozilla.com/D179169
 2023-06-19 16:46:18 +00:00
Mark Banner
0677cff70b Bug 1838155 - Clean up some console.error calls that had been migrated from Cu.reportError. r=jdescottes,perftest-reviewers,geckoview-reviewers,credential-management-reviewers,search-reviewers,sgalich,owlish,jteow,sparky 
This goes through the previous changes in the dependencies of bug 877389, and does two things:
1) Remove instances of \n
2) Change reporting of exceptions so that they are passed as separate arguments. This should result
   in an improved display of the exception in the browser console, should it occur.

Differential Revision: https://phabricator.services.mozilla.com/D180843
 2023-06-15 08:33:57 +00:00
Daisuke Akatsuka
c1ce24fd5a Bug 1836051: Restore selection range when tab switching r=tabbrowser-reviewers,mconley 
Differential Revision: https://phabricator.services.mozilla.com/D180415
 2023-06-14 22:16:21 +00:00
Itiel
213e2bd9a9 Bug 1830679 - Convert element.setAttribute(data-l10n-{id,args}) uses in the codebase to document.l10n.setAttributes(element, id, args) r=eemeli,Gijs,willdurand,extension-reviewers,settings-reviewers,search-reviewers,devtools-reviewers,fxview-reviewers,mconley,Standard8,jdescottes,kcochrane,tabbrowser-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D176791
 2023-06-14 17:16:39 +00:00
Butkovits Atila
e013ce3291 Backed out 2 changesets (bug 1836051) for causing failures at browser_keepStateAcrossTabSwitches.js. CLOSED TREE 
Backed out changeset 1b340c6a4e28 (bug 1836051)
Backed out changeset b15e56c19bb7 (bug 1836051)
 2023-06-14 19:19:31 +03:00
Daisuke Akatsuka
f01241b6d9 Bug 1836051: Restore selection range when tab switching r=tabbrowser-reviewers,mconley 
Differential Revision: https://phabricator.services.mozilla.com/D180415
 2023-06-14 12:53:12 +00:00
Marc Seibert
493096de39 Bug 1833091 - Replacing all set refs of UrlbarInput 'inputField.value'.r=dao 
Differential Revision: https://phabricator.services.mozilla.com/D180228
 2023-06-14 12:45:55 +00:00
Iulian Moraru
ff572127aa Backed out changeset 76c5afdda762 (bug 1830679) for causing xpcshell failures on test_VariablesView_filtering-without-controller.js. CLOSED TREE 2023-06-12 22:03:43 +03:00
Itiel
548aeccf66 Bug 1830679 - Convert element.setAttribute(data-l10n-{id,args}) uses in the codebase to document.l10n.setAttributes(element, id, args) r=eemeli,Gijs,willdurand,extension-reviewers,settings-reviewers,search-reviewers,devtools-reviewers,fxview-reviewers,mconley,Standard8,jdescottes,kcochrane,tabbrowser-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D176791
 2023-06-12 17:16:35 +00:00
Marc Seibert
a2861ac6c5 Bug 1833091 - Replacing all get refs of UrlbarInput 'inputField.value' with '.value'.r=mak 
Differential Revision: https://phabricator.services.mozilla.com/D180085
 2023-06-12 13:43:39 +00:00
Natalia Csoregi
64cf294e7c Backed out changeset e44f4d43b823 (bug 1833091) for causing permafailures on browser_topsites_annotation.js. CLOSED TREE 2023-06-08 03:17:53 +03:00
Marc Seibert
288359ceb2 Bug 1833091 - Replacing all get refs of UrlbarInput 'inputField.value' with '.value'.r=dao 
Differential Revision: https://phabricator.services.mozilla.com/D180085
 2023-06-07 14:59:13 +00:00
Narcis Beleuzu
ec23d338d8 Backed out changeset 862bd1ab18fd (bug 1833091) for bc failure on browser_ext_webNavigation_urlbar_transitions.js . CLOSED TREE 2023-06-06 19:05:07 +03:00
Marc Seibert
7d202de3f8 Bug 1833091 - Replacing all get refs of UrlbarInput 'inputField.value' with '.value'.r=dao 
Differential Revision: https://phabricator.services.mozilla.com/D180085
 2023-06-06 13:46:55 +00:00
mcheang
9864559021 Bug 1648188 - Fix SearchService init failures so that the address bar can be used to search history and bookmarks. r=Standard8,mak 
This patch refactors the SearchService private initialized variables and how
the SearchService stores its initialization status. These changes capture whether
the SearchService has succeeded, failed or hasn't finished initialization yet.

There are also changes made to UrlbarSearchUtils on handling when SearchService
has failed to initialize or when it hasn't finished initializing yet and we wait.
In the case where the SearchService has failed on initialization, We allow
the code to continue so that it can reach UrlbarProviderPlaces. Once we
are able to reach UrlbarProviderPlaces, we can make database calls for the user's
history and bookmarks. This allows the user to interact with the addressbar and
search their history and bookmarks even if SearchService has failed to initialize.

Differential Revision: https://phabricator.services.mozilla.com/D176936
 2023-05-30 18:34:51 +00:00
Daisuke Akatsuka
994b06d295 Bug 1834218: Set userTypedValue to the selected browser when pasting value on the urlbar r=adw 
Differential Revision: https://phabricator.services.mozilla.com/D178993
 2023-05-25 02:12:57 +00:00
Karandeep
bab497399a Bug 1806120 - Pass down window handle to provider. r=mak 
Differential Revision: https://phabricator.services.mozilla.com/D178436
 2023-05-24 14:19:01 +00:00
Mark Banner
0666077666 Bug 1826062 - Automatic fixes for upgrading Prettier to 2.8.8. r=mossop,perftest-reviewers,webcompat-reviewers,geckoview-reviewers,denschub,devtools-reviewers,sparky,calu 
Differential Revision: https://phabricator.services.mozilla.com/D177027
 2023-05-20 12:26:53 +00:00
Iulian Moraru
9a36d620f9 Backed out changeset bbb3bbd9b6af (bug 1830679) for causing dt failures on browser_storage_cache_delete.js. CLOSED TREE 2023-05-18 22:09:25 +03:00
Itiel
801dad3de3 Bug 1830679 - Convert element.setAttribute(data-l10n-{id,args}) uses in the codebase to document.l10n.setAttributes(element, id, args) r=eemeli,willdurand,extension-reviewers,settings-reviewers,search-reviewers,devtools-reviewers,fxview-reviewers,mconley,Standard8,jdescottes,kcochrane 
Differential Revision: https://phabricator.services.mozilla.com/D176791
 2023-05-18 17:19:45 +00:00
Hannah Peuckmann
f8ce125f0a Bug 1823338 - Strip url when copying from url bar.r=pbz,flod,adw 
Differential Revision: https://phabricator.services.mozilla.com/D174251
 2023-05-11 14:14:41 +00:00
Drew Willcoxon
42a104c6fa Bug 1830385 - Implement the dismissal "Thanks for your feedback" message in Suggest results. r=dao,fluent-reviewers,flod 
This implements the second "thanks for your feedback" UI for weather, Pocket,
addon, MDN, etc. suggestions. The first UI is in D175729, which this revision
builds on.

This UI is shown when a result is dismissed. It's essentially a tip with a
smaller icon and padding. It has the "Got it" button that dismisses the tip
itself when clicked.

I noticed tip top and bottom borders use `--panel-separator-color`, which
doesn't seem right. They're supposed to be the same color as the borders between
the input and view and between the results and one-off buttons, which is
`--autocomplete-popup-separator-color`. The spec for this feature uses the same
colors too. So I changed that too. (The use of `--panel-separator-color` goes
back to [the initial tip implementation](https://hg.mozilla.org/mozilla-central/rev/78886081d45b09987c1825cc5a160fd6bec61cb8) in 70, but search tips and
interventions weren't added until 74, in bug 1606909 and bug 1606917. I checked,
and in 74 all the borders are the same color.)

References:

* [Figma](https://www.figma.com/file/Hdi0oHB7trRcncyVAKZypO/accuweather-explorations?node-id=2421%3A62540&t=svOk7TxQv4V7Y9L4-1) (see "A11y review - user feedback" in sidebar)
* [Clickable prototype](https://www.figma.com/proto/Hdi0oHB7trRcncyVAKZypO/accuweather-explorations?page-id=2192%3A42825&node-id=2394-52468&viewport=246%2C526%2C0.12&scaling=min-zoom&starting-point-node-id=2394%3A52468&show-proto-sidebar=1) (see "Revised 4/3" in sidebar)
* [Content design](https://docs.google.com/document/d/1Mgt_oAIEDz_sF-YBqqUGtfKHQCAtRzEQohpfqk-2X8U/edit?usp=sharing)

Depends on D175729

Differential Revision: https://phabricator.services.mozilla.com/D176468
 2023-05-02 20:15:18 +00:00
Norisz Fay
75705bdd6e Backed out changeset d09e87ed0a41 (bug 1830385) for causing xpcshell failures on test_weather.js CLOSED TREE 2023-05-02 22:05:41 +03:00
Drew Willcoxon
374c34715d Bug 1830385 - Implement the dismissal "Thanks for your feedback" message in Suggest results. r=dao,fluent-reviewers,flod 
This implements the second "thanks for your feedback" UI for weather, Pocket,
addon, MDN, etc. suggestions. The first UI is in D175729, which this revision
builds on.

This UI is shown when a result is dismissed. It's essentially a tip with a
smaller icon and padding. It has the "Got it" button that dismisses the tip
itself when clicked.

I noticed tip top and bottom borders use `--panel-separator-color`, which
doesn't seem right. They're supposed to be the same color as the borders between
the input and view and between the results and one-off buttons, which is
`--autocomplete-popup-separator-color`. The spec for this feature uses the same
colors too. So I changed that too. (The use of `--panel-separator-color` goes
back to [the initial tip implementation](https://hg.mozilla.org/mozilla-central/rev/78886081d45b09987c1825cc5a160fd6bec61cb8) in 70, but search tips and
interventions weren't added until 74, in bug 1606909 and bug 1606917. I checked,
and in 74 all the borders are the same color.)

References:

* [Figma](https://www.figma.com/file/Hdi0oHB7trRcncyVAKZypO/accuweather-explorations?node-id=2421%3A62540&t=svOk7TxQv4V7Y9L4-1) (see "A11y review - user feedback" in sidebar)
* [Clickable prototype](https://www.figma.com/proto/Hdi0oHB7trRcncyVAKZypO/accuweather-explorations?page-id=2192%3A42825&node-id=2394-52468&viewport=246%2C526%2C0.12&scaling=min-zoom&starting-point-node-id=2394%3A52468&show-proto-sidebar=1) (see "Revised 4/3" in sidebar)
* [Content design](https://docs.google.com/document/d/1Mgt_oAIEDz_sF-YBqqUGtfKHQCAtRzEQohpfqk-2X8U/edit?usp=sharing)

Depends on D175729

Differential Revision: https://phabricator.services.mozilla.com/D176468
 2023-05-02 16:50:43 +00:00
Cosmin Sabou
eadc2a4afd Backed out changeset ea52cdb6d093 (bug 1684017) as requested by fchasen for being something we don't want to change by UX. 2023-05-01 23:46:53 +03:00