Commit Graph

284 Commits

Author SHA1 Message Date
Rebecca King
15d22f75bd Bug 1868633 - Use moz-card in the Shopping UI - r=shopping-reviewers,reusable-components-reviewers,desktop-theme-reviewers,hjones,kpatenio
Differential Revision: https://phabricator.services.mozilla.com/D232406
2025-01-13 21:22:26 +00:00
Mark Banner
d0718e3c69 Bug 1937739. r=frontend-codestyle-reviewers,perftest-reviewers,mossop,sparky
Differential Revision: https://phabricator.services.mozilla.com/D232598
2024-12-19 17:05:08 +00:00
Logan Rosen
d24c9d9ff4 Bug 1857834 - auto-formatting with Prettier v3 r=linter-reviewers,webdriver-reviewers,perftest-reviewers,search-reviewers,devtools-reviewers,sync-reviewers,reusable-components-reviewers,profiler-reviewers,dom-storage-reviewers,android-reviewers,firefox-ai-ml-reviewers,hjones,mcheang,mstange,sparky,janv,nchevobbe,tarek,Standard8,markh
# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D230598
2024-11-29 15:18:25 +00:00
Mark Striemer
fab35fa7e3 Bug 1900122 - Part 1: Standardise mapped attributes with mapped:true Lit properties r=reusable-components-reviewers,hjones
Differential Revision: https://phabricator.services.mozilla.com/D221891
2024-10-17 02:32:41 +00:00
Mike Conley
dd4373aecb Bug 1920799 - Add a new messaging surface to the AppMenu and PXI menus for describing the value of signing into an FxA. r=pdahiya,Gijs,desktop-theme-reviewers,omc-reviewers,home-newtab-reviewers,fluent-reviewers,hjones,skhamis,nbarrett
Developing tests in a later patch in this series.

Differential Revision: https://phabricator.services.mozilla.com/D223409
2024-10-15 16:15:09 +00:00
Sidharth Sachdev
f99cdcff23 Bug 1911121 - Create a LoginForm Component for Contextual Password Manager. r=fluent-reviewers,desktop-theme-reviewers,bolsson,hjones,issammani,ayeddi,dao,accessibility-frontend-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D218341
2024-09-14 15:27:32 +00:00
Hanna Jones
29258bedd7 Bug 1901572 - auto import moz- custom elements in Storybook r=reusable-components-reviewers,mstriemer
We've allowed for auto importing moz- custom elements since Bug 1803678. This means that often custom elements will use moz- elements without explicitly importing them. This sometimes causes problems in Storybook, since the auto import logic doesn't apply there, and as of Storybook v7 all stories are lazily compiled. This patch ensures that we load all moz- elements and other reusable components up front to avoid display issues in domain specific component stories.

Differential Revision: https://phabricator.services.mozilla.com/D221702
2024-09-10 20:13:02 +00:00
Mark Banner
ea82bec0f5 Bug 1916093 - Enable more documentation generation warnings as fatal. r=sylvestre,devtools-reviewers,nchevobbe
Differential Revision: https://phabricator.services.mozilla.com/D220766
2024-09-03 18:48:46 +00:00
kpatenio
6be27e8fff Bug 1914057 - hide sponsor label if served recommendations in review checker. r=shopping-reviewers,Gijs
Differential Revision: https://phabricator.services.mozilla.com/D219935
2024-08-27 18:38:48 +00:00
kpatenio
263dc34615 Bug 1914057 - update strings for review checker recommendations and settings, plus other minor UX changes. r=fluent-reviewers,shopping-reviewers,bolsson,Gijs
Differential Revision: https://phabricator.services.mozilla.com/D219791
2024-08-27 18:38:47 +00:00
Stanca Serban
ef505e2fa5 Backed out 3 changesets (bug 1914057) for causing mochitests failures in browser_recommended_ad_test.js. CLOSED TREE
Backed out changeset 9d215f25967c (bug 1914057)
Backed out changeset 4105f16f245b (bug 1914057)
Backed out changeset 873a53c675ba (bug 1914057)
2024-08-27 01:59:48 +03:00
kpatenio
37c6ca0c59 Bug 1914057 - hide sponsor label if served recommendations in review checker. r=shopping-reviewers,Gijs
Differential Revision: https://phabricator.services.mozilla.com/D219935
2024-08-26 21:52:19 +00:00
kpatenio
c008efa598 Bug 1914057 - update strings for review checker recommendations and settings, plus other minor UX changes. r=fluent-reviewers,shopping-reviewers,bolsson,Gijs
Differential Revision: https://phabricator.services.mozilla.com/D219791
2024-08-26 21:52:19 +00:00
Stuart Colville
67cd79d978 Bug 1912562 - add autofocus to searchbox component and use in sidebar history and synctabs r=sidebar-reviewers,fxview-reviewers,nsharpley
Differential Revision: https://phabricator.services.mozilla.com/D219617
2024-08-21 12:33:17 +00:00
Cieara Meador
25cd9380db Bug 1858998 - Add global color theme switcher to Storybook r=reusable-components-reviewers,cmkm,hjones
Differential Revision: https://phabricator.services.mozilla.com/D208413
2024-07-11 18:02:19 +00:00
Louis Mascari
637385fd6b Bug 1905975 - Remove the old button story in Storybook. r=tgiles
Differential Revision: https://phabricator.services.mozilla.com/D216069
2024-07-09 18:46:43 +00:00
isaacylee
70cb112052 Bug 1901573 - The fxview-tab-list stories do not correctly render the meatball button. r=nsharpley
Differential Revision: https://phabricator.services.mozilla.com/D215689
2024-07-09 14:25:27 +00:00
Mark Striemer
0ff35eb22d Bug 1901336 - Support generating data-l10n-attrs based on reactive property definition in MozLitElement r=reusable-components-reviewers,hjones
Differential Revision: https://phabricator.services.mozilla.com/D213329
2024-06-19 18:37:36 +00:00
Sandor Molnar
34e807bc63 Backed out 5 changesets (bug 1897529, bug 1901336, bug 1900126) for causing bc failures @ browser_a11y_sidebar.js CLOSED TREE
Backed out changeset 334b820a4c19 (bug 1897529)
Backed out changeset 70350abadcba (bug 1900126)
Backed out changeset 3d631de2ce01 (bug 1897529)
Backed out changeset 1d654154d5ea (bug 1897529)
Backed out changeset a8f7b541a548 (bug 1901336)
2024-06-14 22:41:48 +03:00
Mark Striemer
d109128d95 Bug 1901336 - Support generating data-l10n-attrs based on reactive property definition in MozLitElement r=reusable-components-reviewers,hjones
Differential Revision: https://phabricator.services.mozilla.com/D213329
2024-06-14 18:18:18 +00:00
Tamas Szentpeteri
7b9a55f977 Backed out 4 changesets (bug 1900126, bug 1897529, bug 1901336) for causing mochitest failures on test_moz_message_bar.html. CLOSED TREE
Backed out changeset 212bac58cc17 (bug 1900126)
Backed out changeset efaba56826e3 (bug 1897529)
Backed out changeset 9c52e2ac9df2 (bug 1897529)
Backed out changeset fc94dfe91c29 (bug 1901336)
2024-06-14 06:09:39 +03:00
Mark Striemer
41c6b349d4 Bug 1901336 - Support generating data-l10n-attrs based on reactive property definition in MozLitElement r=reusable-components-reviewers,hjones
Differential Revision: https://phabricator.services.mozilla.com/D213329
2024-06-13 21:52:52 +00:00
Mark Striemer
e6dff4fa84 Bug 1896837 - Only sync import widget modules after DOMContentLoaded r=reusable-components-reviewers,settings-reviewers,mconley,hjones
Co-author/investigator: Tim Giles <tgiles@mozilla.com>

Delay sychronous loading of ESM based custom elements until the
DOMContentLoaded event. With D212190--which this patch depends on--the
components that have already been used on the page will be synchronously
loaded when customElements.setElementCreationCallback is registered.

Differential Revision: https://phabricator.services.mozilla.com/D212191
2024-06-04 23:18:01 +00:00
Hanna Jones
dcb0c96a69 Bug 1894499 - Implement base moz-radio and moz-radio-group r=reusable-components-reviewers,desktop-theme-reviewers,accessibility-frontend-reviewers,tgiles,dao,nlapre
This is just a basic implementation of our proposed `moz-radio` and `moz-radio` group elements.

Differential Revision: https://phabricator.services.mozilla.com/D209983
2024-05-31 22:23:14 +00:00
Jonathan Sudiaman
8dec778c2c Bug 1859774 - Add new Firefox View search component to Storybook r=kcochrane,fluent-reviewers,fxview-reviewers,reusable-components-reviewers,hjones
Simplified debouncing logic to avoid depending on DeferredTask. Add missing `aria-label` which is needed for the edge case of showing a search box without placeholder.

Differential Revision: https://phabricator.services.mozilla.com/D210701
2024-05-24 20:32:56 +00:00
Norisz Fay
f646873f96 Backed out changeset 223f467f78df (bug 1859774) for causing mochitest failures on test_fxview_search_textbox.html CLOSED TREE 2024-05-24 19:04:17 +03:00
Jonathan Sudiaman
dec03dc0a3 Bug 1859774 - Add new Firefox View search component to Storybook r=kcochrane,fluent-reviewers,fxview-reviewers,reusable-components-reviewers,hjones
Simplified debouncing logic to avoid depending on DeferredTask. Add missing `aria-label` which is needed for the edge case of showing a search box without placeholder.

Differential Revision: https://phabricator.services.mozilla.com/D210701
2024-05-24 15:16:26 +00:00
Sandor Molnar
a92ccd5e4d Backed out changeset 56007d13fdf6 (bug 1859774) for causing mochitest failures @ browser/components/firefoxview/tests/chrome/test_fxview_search_textbox.html CLOSED TREE 2024-05-24 00:46:06 +03:00
Jonathan Sudiaman
37a0386948 Bug 1859774 - Add new Firefox View search component to Storybook r=kcochrane,fluent-reviewers,fxview-reviewers,reusable-components-reviewers,hjones
Simplified debouncing logic to avoid depending on DeferredTask. Add missing `aria-label` which is needed for the edge case of showing a search box without placeholder.

Differential Revision: https://phabricator.services.mozilla.com/D210701
2024-05-23 20:20:03 +00:00
Gijs Kruitbosch
d4ea70da14 Bug 1895692 - turn off import/no-unassigned-import for storybook files, r=reusable-components-reviewers,frontend-codestyle-reviewers,hjones
Differential Revision: https://phabricator.services.mozilla.com/D210475
2024-05-15 16:08:57 +00:00
Mark Striemer
a069b9cdf1 Bug 1895944 - Fix moz-label webpack config in Storybook r=reusable-components-reviewers,hjones
Differential Revision: https://phabricator.services.mozilla.com/D209968
2024-05-13 21:08:36 +00:00
Mike Conley
5b979dc884 Bug 1893269 - Build out basic infrastructure for backup management UI. r=backup-reviewers,settings-reviewers,firefox-desktop-core-reviewers ,Gijs,fluent-reviewers,kpatenio
Differential Revision: https://phabricator.services.mozilla.com/D209161
2024-05-09 21:34:35 +00:00
Tim Giles
604b3381af Bug 1893685 - Add link to the "Reusable Component Adoption" site in docs. r=reusable-components-reviewers,jules DONTBUILD
Differential Revision: https://phabricator.services.mozilla.com/D208772
2024-04-26 17:54:16 +00:00
Hanna Jones
21849b1def Bug 1803678 - enable lazy loading of ESModule based moz- custom elements r=reusable-components-reviewers,pip-reviewers,credential-management-reviewers,translations-reviewers,kpatenio,issammani,mstriemer
Differential Revision: https://phabricator.services.mozilla.com/D207445
2024-04-24 19:16:46 +00:00
Stanca Serban
29d6ee2faf Backed out changeset 58e1e96263b7 (bug 1803678) mochitests failures in test_confirm_delete_dialog.html. CLOSED TREE 2024-04-24 03:14:45 +03:00
Jonathan Sudiaman
a1780ebc7d Bug 1867614 - fxview-tab-list story is broken, shows a "ChromeUtils is not defined" error r=fxview-reviewers,reusable-components-reviewers,hjones,nsharpley
Remove transitive dependency on `ChromeUtils` that is causing this error.

Differential Revision: https://phabricator.services.mozilla.com/D208380
2024-04-23 21:26:09 +00:00
Hanna Jones
9413513b0d Bug 1803678 - enable lazy loading of ESModule based moz- custom elements r=reusable-components-reviewers,pip-reviewers,credential-management-reviewers,translations-reviewers,kpatenio,issammani,mstriemer
Differential Revision: https://phabricator.services.mozilla.com/D207445
2024-04-23 19:28:47 +00:00
Aron Cseh
08943f7f60 Backed out changeset 421fd8a0360c (bug 1803678) for causing mochitest failures on browser_translations_select_panel_init_failure.js CLOSED TREE 2024-04-23 18:16:55 +03:00
Hanna Jones
cf0399a238 Bug 1803678 - enable lazy loading of ESModule based moz- custom elements r=reusable-components-reviewers,pip-reviewers,credential-management-reviewers,translations-reviewers,kpatenio,issammani,mstriemer
Differential Revision: https://phabricator.services.mozilla.com/D207445
2024-04-23 13:52:27 +00:00
Hanna Jones
07e447494b Bug 1855471 - Replace last <message-bar> instances with <div>s r=shopping-reviewers,Gijs
The `<shopping-message-bar>` component is the last place we're using the deprecated `<message-bar>` component. As such, it's the one thing standing preventing us from remvoing the old `<message-bar>` implementation (see Bug 1845151). I took a quick look and the `<message-bar>`s here aren't actually providing any styling/layout and seem to be easily replacable with `<div>`s.

Differential Revision: https://phabricator.services.mozilla.com/D207989
2024-04-22 18:06:17 +00:00
Tim Giles
0da31e01a1 Bug 1890586 - Fix broken Storybook link in Source Docs. r=reusable-components-reviewers,mstriemer
This also makes the Storybook overview doc the first in the list, so
that https://firefoxux.github.io/firefox-desktop-components/ will show
the Storybook overview doc on the redirect.

Differential Revision: https://phabricator.services.mozilla.com/D207074
2024-04-09 21:25:36 +00:00
hjones
12d5c44a41 Bug 1890433 - Fix interactive docs component imports on Windows r=tgiles
Differential Revision: https://phabricator.services.mozilla.com/D206959
2024-04-08 22:13:09 +00:00
Hanna Jones
c5fc021fec Bug 1857330 - Add a design tokens table to storybook r=reusable-components-reviewers,desktop-theme-reviewers,tgiles,jules
Differential Revision: https://phabricator.services.mozilla.com/D205927
2024-04-08 17:43:54 +00:00
Tim Giles
d1bd603726 Bug 1888511 - Add design tokens docs to Firefox Source Docs. r=reusable-components-reviewers,hjones
These docs were already present when running `mach storybook` but were
not hooked up to Firefox Source Docs. I also moved the files to a docs/
directory so that the folder structure is more clear.

I also changed the post-it notes layout to images so that the styling
would be consistent between Storybook and Firefox Source Docs. As part
of this, I added alt text to each graphic so that we weren't losing
information.

Differential Revision: https://phabricator.services.mozilla.com/D206070
2024-04-02 20:49:28 +00:00
Irene Ni
ea6c87d4f9 Bug 1876432 - Added support for custom themes as its own menu in Reader View. r=reader-mode-reviewers,fluent-reviewers,desktop-theme-reviewers,hjones,accessibility-frontend-reviewers,bolsson,devtools-reviewers,sfoster,cmkm,jules,ayeddi
Differential Revision: https://phabricator.services.mozilla.com/D204519
2024-04-02 00:08:46 +00:00
Jules Simplicio
00bd9923d0 Bug 1881821 - Clean up tokens files ahead of JSON source of truth setup r=desktop-theme-reviewers,reusable-components-reviewers,hjones,dao,mstriemer,devtools-reviewers
Changed
* `--color-background-*` are now part of the group of `--background-color` tokens
* `--box-background-color` is now part of the group of `--background-color` tokens as `--background-color-box`
* `--color-canvas` is now part of the group of `--background-color` tokens as `--background-color-canvas`
* `--border-interactive-*` are now part of the group of `--border-color` tokens and consequently now start with `--border-color`
* `--color-error-outline` is now an outline-specific token as `--outline-color-error`
* Comment headings were cleaned up as to follow the existing standard
* Better documentation behind the difference of "Base", "Application", and "Component" tiers in the design tokens documentation
* Tokens files are alphabetized

Removed
* `--outline-color-error` had duplicates in both high contrast mode media queries, so its value under `forced-colors` was removed
* "Base" and "Application" headings in tokens files were removed in order to lean in on the alphabetical order organization of token groups and promote a cleaner file and less confusion
* Documentation was edited down to not incude any guidance that we don't adhere to
* Remove duplicate interactive border color high contrast mode tokens in `tokens-brand.css` in favor of `tokens-shared.css`
* Remove `--button-border-color-primary` duplicate in `tokens-brand.css`
* Remove duplicate `--button-text-color` in `tokens-shared.css`

Differential Revision: https://phabricator.services.mozilla.com/D202767
2024-03-26 13:50:00 +00:00
Cristian Tuns
ff99f2334a Backed out changeset a695fb3d1edd (bug 1881821) for causing dt failures in browser_markup_screenshot_node_about_page.js CLOSED TREE 2024-03-25 21:23:57 -04:00
Jules Simplicio
37e13bc4c4 Bug 1881821 - Clean up tokens files ahead of JSON source of truth setup r=desktop-theme-reviewers,reusable-components-reviewers,hjones,dao,mstriemer
Changed
* `--color-background-*` are now part of the group of `--background-color` tokens
* `--box-background-color` is now part of the group of `--background-color` tokens as `--background-color-box`
* `--color-canvas` is now part of the group of `--background-color` tokens as `--background-color-canvas`
* `--border-interactive-*` are now part of the group of `--border-color` tokens and consequently now start with `--border-color`
* `--color-error-outline` is now an outline-specific token as `--outline-color-error`
* Comment headings were cleaned up as to follow the existing standard
* Better documentation behind the difference of "Base", "Application", and "Component" tiers in the design tokens documentation
* Tokens files are alphabetized

Removed
* `--outline-color-error` had duplicates in both high contrast mode media queries, so its value under `forced-colors` was removed
* "Base" and "Application" headings in tokens files were removed in order to lean in on the alphabetical order organization of token groups and promote a cleaner file and less confusion
* Documentation was edited down to not incude any guidance that we don't adhere to
* Remove duplicate interactive border color high contrast mode tokens in `tokens-brand.css` in favor of `tokens-shared.css`
* Remove `--button-border-color-primary` duplicate in `tokens-brand.css`
* Remove duplicate `--button-text-color` in `tokens-shared.css`

Differential Revision: https://phabricator.services.mozilla.com/D202767
2024-03-26 00:04:25 +00:00
Cristian Tuns
a9153f0427 Backed out changeset 6461d8999f47 (bug 1881821) for causing bc failures in /browser_parsable_css.js CLOSED TREE 2024-03-25 17:00:45 -04:00
Jules Simplicio
a12cd48132 Bug 1881821 - Clean up tokens files ahead of JSON source of truth setup r=desktop-theme-reviewers,reusable-components-reviewers,hjones,dao,mstriemer
Changed
* `--color-background-*` are now part of the group of `--background-color` tokens
* `--box-background-color` is now part of the group of `--background-color` tokens as `--background-color-box`
* `--color-canvas` is now part of the group of `--background-color` tokens as `--background-color-canvas`
* `--border-interactive-*` are now part of the group of `--border-color` tokens and consequently now start with `--border-color`
* `--color-error-outline` is now an outline-specific token as `--outline-color-error`
* Comment headings were cleaned up as to follow the existing standard
* Better documentation behind the difference of "Base", "Application", and "Component" tiers in the design tokens documentation
* Tokens files are alphabetized

Removed
* `--outline-color-error` had duplicates in both high contrast mode media queries, so its value under `forced-colors` was removed
* "Base" and "Application" headings in tokens files were removed in order to lean in on the alphabetical order organization of token groups and promote a cleaner file and less confusion
* Documentation was edited down to not incude any guidance that we don't adhere to
* Remove duplicate interactive border color high contrast mode tokens in `tokens-brand.css` in favor of `tokens-shared.css`
* Remove `--button-border-color-primary` duplicate in `tokens-brand.css`
* Remove duplicate `--button-text-color` in `tokens-shared.css`

Differential Revision: https://phabricator.services.mozilla.com/D202767
2024-03-25 20:12:21 +00:00