Commit Graph

227 Commits

Author SHA1 Message Date
Tom Schuster
a662ebb228 Bug 1942618 - Remove inline event handler and use restrictive CSP for old ClearSiteDataDialog. r=settings-reviewers,mconley
Differential Revision: https://phabricator.services.mozilla.com/D235156
2025-01-23 08:45:44 +00:00
Tom Schuster
7e36c664d1 Bug 1942618 - Remove inline event handler and use restrictive CSP for LanguagesDialog. r=settings-reviewers,mconley
Differential Revision: https://phabricator.services.mozilla.com/D235122
2025-01-23 08:45:44 +00:00
Tom Schuster
c3df36aa31 Bug 1942618 - Remove inline event handler and use restrictive CSP for ConnectionsDialog. r=settings-reviewers,mconley
Differential Revision: https://phabricator.services.mozilla.com/D234982
2025-01-23 08:45:43 +00:00
Tom Schuster
e34f2d5ce2 Bug 1942618 - Remove inline event handler and use restrictive CSP for ContainersDialog. r=settings-reviewers,mconley
Differential Revision: https://phabricator.services.mozilla.com/D234967
2025-01-23 08:45:43 +00:00
Tom Schuster
3617397c51 Bug 1942618 - Remove inline event handler and use restrictive CSP for FontsDialog. r=settings-reviewers,mconley
Differential Revision: https://phabricator.services.mozilla.com/D234884
2025-01-23 08:45:43 +00:00
Tom Schuster
0a15fc2f0f Bug 1942618 - Remove inline event handler and use restrictive CSP for ColorsDialog. r=settings-reviewers,mconley
Differential Revision: https://phabricator.services.mozilla.com/D234881
2025-01-23 08:45:42 +00:00
Tom Schuster
d5d4f3d230 Bug 1941751 - Remove inline event handlers and use restrictive CSP for SiteDataSettingsDialog. r=settings-reviewers,Gijs
Differential Revision: https://phabricator.services.mozilla.com/D234315
2025-01-15 18:01:45 +00:00
Tom Schuster
b3d0b231de Bug 1941585 - Remove remaining inline event handlers and use restrictive CSP for SitePermissionsDialog. r=settings-reviewers,Gijs
Differential Revision: https://phabricator.services.mozilla.com/D234192
2025-01-15 18:01:19 +00:00
Tom Schuster
20a74cb0b0 Bug 1941585 - Remove inline command event handlers from SitePermissionsDialog. r=settings-reviewers,Gijs
Differential Revision: https://phabricator.services.mozilla.com/D234179
2025-01-15 18:01:19 +00:00
Tom Schuster
c5f0b4d7a8 Bug 1941585 - Remove inline load/unload event handlers from SitePermissionsDialog. r=settings-reviewers,Gijs
Differential Revision: https://phabricator.services.mozilla.com/D234178
2025-01-15 18:01:18 +00:00
Simon Friedberger
b4d9976bc4 Bug 1935670. Remove inline event handlers from permissions.xhtml r=settings-reviewers,mossop
Differential Revision: https://phabricator.services.mozilla.com/D231389
2024-12-09 13:43:03 +00:00
Logan Rosen
d24c9d9ff4 Bug 1857834 - auto-formatting with Prettier v3 r=linter-reviewers,webdriver-reviewers,perftest-reviewers,search-reviewers,devtools-reviewers,sync-reviewers,reusable-components-reviewers,profiler-reviewers,dom-storage-reviewers,android-reviewers,firefox-ai-ml-reviewers,hjones,mcheang,mstange,sparky,janv,nchevobbe,tarek,Standard8,markh
# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D230598
2024-11-29 15:18:25 +00:00
Oskar Mansfeld
f5dbbf2e15 Bug 1909436 - Added telemetry to record proxy type preferences set in the network settings UI. r=necko-reviewers,settings-reviewers,kershaw,mossop
Differential Revision: https://phabricator.services.mozilla.com/D228017
2024-11-26 10:04:05 +00:00
Sammy Khamis
b55e774133 Bug 1927644: Choose what to sync UI updates r=sync-reviewers,fluent-reviewers,settings-reviewers,desktop-theme-reviewers,dao,mossop,markh
Differential Revision: https://phabricator.services.mozilla.com/D227434
2024-11-12 23:30:23 +00:00
Dão Gottwald
6663959384 Bug 1924496 - Replace tab-loading.png, tab-connecting.png, and their 2x / inverted variants with loading.svg. r=settings-reviewers,tabbrowser-reviewers,omc-reviewers,aminomancer,mak
Differential Revision: https://phabricator.services.mozilla.com/D225500
2024-10-17 16:39:52 +00:00
jabram
32769d20ee Bug 1865371 - Replace --in-content-box-background with --background-color-box r=cmkm,desktop-theme-reviewers,credential-management-reviewers,omc-reviewers,aminomancer,dao,issammani
Differential Revision: https://phabricator.services.mozilla.com/D222674
2024-10-07 20:15:01 +00:00
Florian Quèze
30f68dada3 Bug 1918702 - Migrate telemetry events to use Glean APIs for intl.ui.browserLanguage, r=chutten,settings-reviewers,mossop.
Differential Revision: https://phabricator.services.mozilla.com/D222605
2024-09-20 13:58:18 +00:00
Marco Bonardo
c23719eb3b Bug 1904909 - PlacesUtils::GatherDataText and GatherDataHtml should not recurse into queries r=daisuke,places-reviewers
There's a few problems in the code gathering text data for nodes.
First it should not recurse into queries (included folder shortcuts) as it's
easy to create infinite recursion with them. The first level is excluded though,
as otherwise it would not be possible to copy contents of left pane roots.
Second it should requery folder shortcut contents in excludeItems results,
as otherwise it's not possible to copy contents of a root as text.
There's no longer the risk of dragging around root folders as this code is only
used for text flavors today, drag&drop uses serializeNode instead.

Differential Revision: https://phabricator.services.mozilla.com/D215068
2024-07-02 13:45:37 +00:00
Javier Rueda
9bd6329fe4 Bug 1896527 - Add aria-labelledby attribute so a11y checks pass. r=mconley,settings-reviewers,ayeddi
Differential Revision: https://phabricator.services.mozilla.com/D210457
2024-05-29 16:17:09 +00:00
Henry Wilkes
27df525213 Bug 1851618 - Allow removing packaged locales from requestedLocales. r=settings-reviewers,eemeli,Gijs
We open up the UI to allow the user to remove locales from their
requestedLocales list, except for the default locale.

Differential Revision: https://phabricator.services.mozilla.com/D209930
2024-05-29 11:10:18 +00:00
Manuel Bucher
992ee2f190 Bug 1454850 - Add "Proxy DNS when using SOCKS v4" option to proxy preferences r=necko-reviewers,fluent-reviewers,settings-reviewers,bolsson,Gijs,valentin
With Bug 1741375 this is a separate config variable.

Differential Revision: https://phabricator.services.mozilla.com/D211060
2024-05-28 11:41:39 +00:00
Manuel Bucher
acacdfe55c Bug 1741375 - Proxy DNS by default when using SOCKS v5 r=necko-reviewers,extension-reviewers,kershaw,perftest-reviewers,robwu,sparky
Initially reported and discussed in Bug 610896.

The simple solution of just flipping the pref `network.proxy.socks_remote_dns`
is risky due to potentially breaking SOCKS4 proxy users.  Proxying
DNS on SOCKS4 isn't supported.  Therefore we speak the incompatible
SOCKS4a protocol when `socks_remote_dns` is enabled, potentially
breaking users setup.

To keep backwards compatibility on SOCKS4 proxy users, that don't have
SOCKS4a support, the pref `network.proxy.socks_remote_dns` is split into
two prefs:

* `network.proxy.socks_remote_dns`: remote DNS for SOCKS4
* `network.proxy.socks5_remote_dns`: remote DNS for SOCKS5.

This way we proxy DNS by default on SOCKS5 while keeping user settings
on SOCKS4.  This is a similar approach to the one described in
[Bug 610896 comment 17].

Proxying DNS in SOCKS4 by default is desireable (See [Bug 610896 comment 11]),
but out of scope for this patch.  [Telemetry] on proxy usage by socks
version indicated that changing the default for SOCKS4 is likely break
some users setup and needs to be taken with more care.

The default values of [proxyDNS] now defaults to true for SOCKS5 proxies.
When creating nsIProxyInfo objects of SOCKS4 proxies, the default value
false is kept.  Setting proxyDNS affects both SOCKS4 and SOCKS5 proxy by
modifying both `socks_remote_dns` and `socks5_remote_dns`.  Therefore no
extension breakage is expected.

The enterprise policy can also modify the new pref
`network.proxy.socks5_remote_dns`.

Follow up bugs filed while implementing:

* Bug 1890542 - Also disable Prefetch non-manual configurations of socks
                proxy
* Bug 1890554 - Use `ProxyInfo::TRANSPARENT_PROXY_RESOLVES_HOST` flag in
                `nsHttpChannel::GetProxyDNSStrategy`
* Bug 1890549 - nsHttpChannel implementation DNS resolve strategy for
                proxies incomplete
* Bug 1893670 - Proxy DNS by default for SOCK4 proxies. Defaulting to
                SOCKS4a

[Bug 610896 comment 17]: https://bugzilla.mozilla.org/show_bug.cgi?id=610896#c17
[Bug 610896 comment 11]: https://bugzilla.mozilla.org/show_bug.cgi?id=610896#c11
[Telemetry]: https://bugzilla.mozilla.org/show_bug.cgi?id=1741375#c27
[proxyDNS]: https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/API/proxy/settings#proxydns

Differential Revision: https://phabricator.services.mozilla.com/D207532
2024-05-21 11:55:26 +00:00
Javier Rueda
03ec1bde2b Bug 1896360 - Disable Add button when no language is selected. r=mconley
Differential Revision: https://phabricator.services.mozilla.com/D210206
2024-05-13 21:31:26 +00:00
dschomburg
9f03a40c4f Bug 1853818 - Remove toolkit/branding/accounts.ftl file r=flod,fluent-reviewers,settings-reviewers,credential-management-reviewers,fxview-reviewers,omc-reviewers,firefox-desktop-core-reviewers ,mconley,aminomancer,mak,sgalich,nsharpley,mkaply
Differential Revision: https://phabricator.services.mozilla.com/D190612
2024-04-22 16:24:30 +00:00
Masatoshi Kimura
4d07b74011 Bug 1891926 - Make "network.proxy.system_wpad.allowed" actually work. r=settings-reviewers,Gijs
Differential Revision: https://phabricator.services.mozilla.com/D207701
2024-04-17 14:49:40 +00:00
Javier Rueda
5e40504c38 Bug 1884135 - Button to add exception in Manage DNS-over-HTTPS subdialog is enabled when input box is empty. r=mossop,settings-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D204033
2024-03-11 13:21:37 +00:00
dylan
f70687a436 Bug 621429 - added check to only show the Use system Web Proxy Auto-Discovery setting checkbox on windows. r=kershaw,settings-reviewers,mossop
Depends on D183429

Differential Revision: https://phabricator.services.mozilla.com/D203387
2024-03-08 04:38:56 +00:00
dylan
49d5f21cb7 Bug 621429 - Added button to allow WPAD while using system proxy settings. r=necko-reviewers,fluent-reviewers,settings-reviewers,kershaw,bolsson,Gijs
Differential Revision: https://phabricator.services.mozilla.com/D183429
2024-03-08 04:38:55 +00:00
Dave Townsend
b7532be063 Bug 1864896: Autofix unused function arguments (browser/components/preferences). r=settings-reviewers,Gijs
Differential Revision: https://phabricator.services.mozilla.com/D202952
2024-03-01 18:28:32 +00:00
Natalia Csoregi
66cb0e397f Backed out 2 changesets (bug 1864896) for causing node failures. CLOSED TREE
Backed out changeset adba0b352699 (bug 1864896)
Backed out changeset 153146ce081c (bug 1864896)
2024-03-01 18:25:05 +02:00
Dave Townsend
b6eba7ca5c Bug 1864896: Autofix unused function arguments (browser/components/preferences). r=settings-reviewers,Gijs
Differential Revision: https://phabricator.services.mozilla.com/D202952
2024-03-01 15:20:18 +00:00
Iulian Moraru
d067b329de Backed out 5 changesets (bug 1864896) for causing newtab failures related to bundles. CLOSED TREE
Backed out changeset 2cd1cc279f99 (bug 1864896)
Backed out changeset e48d6928bdcb (bug 1864896)
Backed out changeset 1abbcaf91693 (bug 1864896)
Backed out changeset 06a05e5257d5 (bug 1864896)
Backed out changeset b1955ae3e9e2 (bug 1864896)
2024-03-01 12:58:03 +02:00
Dave Townsend
2a38962b3a Bug 1864896: Autofix unused function arguments (browser/components/preferences). r=settings-reviewers,Gijs
Differential Revision: https://phabricator.services.mozilla.com/D202952
2024-03-01 10:10:09 +00:00
Jules Simplicio
7adf282ac7 Bug 1880223 - Set auto min-height in textareas and fix heading sizing in connection settings r=desktop-theme-reviewers,settings-reviewers,emilio
This fixes an existing scrollbar issue pointed out on this patch's bug that became more predominant with some of the heading standardization work in bug 1877793.

I'm making sure the heading looks like how it used to. I also noticed textareas had a very small min-height that seemed to be causing this issue.

Differential Revision: https://phabricator.services.mozilla.com/D202018
2024-02-20 20:39:19 +00:00
Jules Simplicio
23705875ae Bug 1872788 - Improve spacing in preferences upon standardizing line height values r=desktop-theme-reviewers,settings-reviewers,dao,Gijs,reusable-components-reviewers,hjones
Differential Revision: https://phabricator.services.mozilla.com/D197614
2024-01-30 15:39:26 +00:00
Norisz Fay
77b1e70097 Backed out 2 changesets (bug 1872788) for causing mochitest failure on test_moz_button_group.html CLOSED TREE
Backed out changeset a9528d76a91b (bug 1872788)
Backed out changeset 4fde278ae659 (bug 1872788)
2024-01-30 15:59:23 +02:00
Jules Simplicio
eaaed0558d Bug 1872788 - Improve spacing in preferences upon standardizing line height values r=desktop-theme-reviewers,settings-reviewers,dao,Gijs,reusable-components-reviewers,hjones
Differential Revision: https://phabricator.services.mozilla.com/D197614
2024-01-30 05:28:27 +00:00
Jaydeep Das
95cda128bf Bug 328707 - Allow only valid IP/Hostname for Proxy Config, r=mconley,necko-reviewers,valentin
Differential Revision: https://phabricator.services.mozilla.com/D198425
2024-01-22 14:28:41 +00:00
Javier Rueda
d6535e0523 Bug 1764694 - Disable 'Remove' button when there are no accepted languages. r=Gijs,settings-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D197635
2024-01-04 23:50:16 +00:00
Olivia Hall
16d733113b Bug 1865727 - GeckoView Runtime Never Translate Site Option r=geckoview-reviewers,settings-reviewers,translations-reviewers,gregtatum,owlish,boek
This patch adds an option for GeckoView to change site settings outside
of the session. These APIs should be used for global modifications to
the "never translate these sites" list.

Additionally, this patch moves some Desktop translations logic to the
toolkit for shared use.

Differential Revision: https://phabricator.services.mozilla.com/D195790
2023-12-13 14:50:08 +00:00
jneuberger
7cccf3fb15 Bug 1869300 - Remove (desktop only) from sync-engine-payment-methods r=credential-management-reviewers,fluent-reviewers,settings-reviewers,dimi,flod
Differential Revision: https://phabricator.services.mozilla.com/D196046
2023-12-12 16:47:26 +00:00
jneuberger
5946f0e354 Bug 1867020 - Update about:preferences strings for exceptions modal r=credential-management-reviewers,fluent-reviewers,settings-reviewers,joschmidt,bolsson,Gijs
Differential Revision: https://phabricator.services.mozilla.com/D195279
2023-12-12 16:02:06 +00:00
Sandor Molnar
5e9ca11c9d Backed out 5 changesets (bug 1867017, bug 1867019, bug 1867018, bug 1867020) for causing bc failures at browser/components/preferences/tests/browser_search_subdialogs_within_preferences_5.js CLOSED TREE
Backed out changeset 0c4bc9a698ba (bug 1867017)
Backed out changeset ea95d41995f0 (bug 1867017)
Backed out changeset 56289937eb65 (bug 1867020)
Backed out changeset 022c1f63a6fe (bug 1867019)
Backed out changeset fa5b89f2d1b6 (bug 1867018)
2023-12-12 05:54:37 +02:00
jneuberger
777f61f0ec Bug 1867020 - Update about:preferences strings for exceptions modal r=credential-management-reviewers,fluent-reviewers,settings-reviewers,joschmidt,bolsson,Gijs
Differential Revision: https://phabricator.services.mozilla.com/D195279
2023-12-11 21:54:34 +00:00
Johannes J. Schmidt
0b4bf0b0eb Bug 1867015 - Update Strings for about:preferences - Sync page - r=credential-management-reviewers,fluent-reviewers,settings-reviewers,flod,issammani
Differential Revision: https://phabricator.services.mozilla.com/D195118
2023-12-04 13:55:36 +00:00
Dale Harvey
3abcf233ac Bug 1794752 - Increase status column width. r=Gijs,settings-reviewers,desktop-theme-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D192598
2023-11-04 11:25:19 +00:00
Emilio Cobos Álvarez
f8e535d8d7 Bug 1860346 - Simplify site permissions markup and styling. r=settings-reviewers,Gijs
Differential Revision: https://phabricator.services.mozilla.com/D191564
2023-10-25 11:08:08 +00:00
Emilio Cobos Álvarez
ed873d6616 Bug 1644612 - Add a height and cleanup languages listbox styling. r=desktop-theme-reviewers,dao
The "righter" way to do this is adding a bunch of min-height: 0 to the
grid, the dialog, the content box, etc. But this is more similar to what
other dialogs do.

Differential Revision: https://phabricator.services.mozilla.com/D180890
2023-10-24 11:11:18 +00:00
Dave Townsend
108be2cdee Bug 1857999: Manually fix some spacing and comments. r=Gijs,settings-reviewers,places-reviewers,Standard8
Manually re-apply comments and spacing that existed prior to the automated
changes.

Differential Revision: https://phabricator.services.mozilla.com/D190682
2023-10-18 07:04:42 +00:00
Dave Townsend
f2f7777e96 Bug 1857999: Move XML stylesheet processing instructions to link elements. r=Gijs,webdriver-reviewers,settings-reviewers,application-update-reviewers,devtools-reviewers,places-reviewers,Standard8,whimboo,bytesized,ochameau
The result of running the automated script available at https://github.com/Mossop/depi

Differential Revision: https://phabricator.services.mozilla.com/D190681
2023-10-18 07:04:41 +00:00