This also removes some tests of `MOZ_SELECTABLE_PROFILES` from `browser/components/profiles` files
where the test is pointless because that test is excluded from the build if `MOZ_SELECTABLE_PROFILES`
is unset.
Differential Revision: https://phabricator.services.mozilla.com/D227372
This also removes some tests of `MOZ_SELECTABLE_PROFILES` from `browser/components/profiles` files
where the test is pointless because that test is excluded from the build if `MOZ_SELECTABLE_PROFILES`
is unset.
Differential Revision: https://phabricator.services.mozilla.com/D227372
Removes the react_to_trigger test that causes intermittent failures on different platforms. The method that renders the infobar message (showInfoBarMessage) and the defaultBrowserCheck trigger are covered by other tests separately.
Differential Revision: https://phabricator.services.mozilla.com/D225532
To manually test the message, make sure to set
`browser.newtabpage.activity-stream.asrouter.devtoolsEnabled` to `true`,
and then visit about:asrouter. Scroll down to the message with ID
FXA_ACCOUNTS_APPMENU_PROTECT_BROWSING_DATA, and click "Show".
This will default to opening the AppMenu with the message. You can open
it for the PXI menu by changing `testingTriggerContext` in the test
message definition from "app_menu" to "pxi_menu".
Differential Revision: https://phabricator.services.mozilla.com/D224790
Depends on D216814.
This patch enables the new attachment bundling/extraction logic for the intermediate certificate downloads.
In my local testing, this gives a significant improvement in the time it takes to download and unpack all the intermediate attachments.
Testing on my laptop (linux laptop on good wifi and gigiabit).
Before: 3.2-4.1 seconds to download and unpack
After: 0.75-0.95 seconds to download and unpack
Would love to pull before/after data for a variety of devices.
Differential Revision: https://phabricator.services.mozilla.com/D216815
For starters, replace all newtab styles and functions. Since we're
removing these styles, I conformed the asrouter admin to the reusable
components team's design tokens. So, it now uses global system page
styles. This is a pretty general overhaul since there are so many styles
to replace. In addition to the style changes, I've added a new Filters
UI and moved the groups table to the General tab. This allows us to
remove the Message Groups tab since that functionality is now rolled
into the Filters UI. The same with the Private Browsing tab: when you
hit Show on a pb_newtab message, it will open a PB window and override
the message. And you can filter by template now, so you can view only PB
messages on the General tab. I also fixed spellchecking. Instead of
spellchecking, which only works for natural languages, we just validate
that the text is valid JSON. If it's not valid, we show a red border on
the textarea. That way messages won't just mysteriously fail to show. I
also moved a few elements around to conserve space. Now, everything
should be able to fit on the screen of a default window size of 1500px.
Finally, I removed some old cruft that was left over from when the admin
interface was part of the newtab page.
Differential Revision: https://phabricator.services.mozilla.com/D213865
This patch updates the targeting for two in-tree messages that include “source == ‘startup’” in their targeting and are triggered on default browser check. There are currently edge cases where these messages can collide with about:welcome. See [[ https://bugzilla.mozilla.org/show_bug.cgi?id=1897804#c4 | this comment ]] for steps to replicate an example.
By adding additional targeting that ensures this isn’t the user’s first session, we can avoid about:welcome collisions.
Differential Revision: https://phabricator.services.mozilla.com/D213456
Also add a global `browserIsSelected` context property for all triggers,
so you can entirely avoid showing a message if the triggering browser
was in the background. You can use the selector and the context property
together or separately.
Context targeting:
`browserIsSelected`
Background tab selector:
`#tabbrowser-tabs:not([overflow]):not([haspinnedtabs]) %triggerTab%`
Current tab selector:
`#tabbrowser-tabs:not([overflow]):not([haspinnedtabs]) %triggerTab%[visuallyselected]`
Child of tab selector:
`#tabbrowser-tabs:not([overflow]):not([haspinnedtabs]) %triggerTab% .tab-icon-image`
Differential Revision: https://phabricator.services.mozilla.com/D212494
Also add a global `browserIsSelected` context property for all triggers,
so you can entirely avoid showing a message if the triggering browser
was in the background. You can use the selector and the context property
together or separately.
Context targeting:
`browserIsSelected`
Background tab selector:
`#tabbrowser-tabs:not([overflow]):not([haspinnedtabs]) %triggerTab%`
Current tab selector:
`#tabbrowser-tabs:not([overflow]):not([haspinnedtabs]) %triggerTab%[visuallyselected]`
Child of tab selector:
`#tabbrowser-tabs:not([overflow]):not([haspinnedtabs]) %triggerTab% .tab-icon-image`
Differential Revision: https://phabricator.services.mozilla.com/D212494
