Commit Graph

298 Commits

Author SHA1 Message Date
Mark Banner
5407bdffa8 Bug 1792341 - Migrate more toolkit/modules consumers to use direct ES module import. r=Gijs,webdriver-reviewers,perftest-reviewers,necko-reviewers,geckoview-reviewers,preferences-reviewers,application-update-reviewers,pip-reviewers,credential-management-reviewers,sgalich,owlish,bytesized,AlexandruIonescu,whimboo,mconley,mixedpuppy
Mainly automated changes. Some manual ESLint fixes and whitespace cleanup.

Differential Revision: https://phabricator.services.mozilla.com/D158452
2022-10-18 11:21:26 +00:00
Eemeli Aro
77f0749aa7 Bug 1793572 - Convert WebRTCParent.jsm from .properties to Fluent. r=mconley,flod
The code is slightly cleaned up to not construct identifiers by concatenating strings, and to avoid using the requestTypes array when determining the prompt contents.

A few messages are moved to and from browser.ftl to group them better, though all of the "WebRTC Pop-up notifications" messages could also be moved from there to webrtcIndicator.ftl, which is now also included by browser.xhtml.

The message `webrtc-allow-share-audio-capture-unsafe-delegation` is added, as it appears to have been missed previously -- it's referred to in code, but the message itself was not defined.

Differential Revision: https://phabricator.services.mozilla.com/D158762
2022-10-08 07:35:29 +00:00
Eemeli Aro
b9ac23276f Bug 1793572 - Convert getUserMedia.sharingMenu strings from browser.properties to Fluent. r=mconley,flod
The list of items is now formatted using ListFormat rather than manually, which requires a new message webrtc-sharing-menuitem. Based on a review of the existing solutions [1], it should be acceptable to use the same pattern for all of them, even though this may effect a small change for the zh-TW locale.

[1] https://transvision.flod.org/string/?entity=browser/chrome/browser/browser.properties:getUserMedia.sharingMenuCamera&repo=gecko_strings

Differential Revision: https://phabricator.services.mozilla.com/D158761
2022-10-08 07:35:28 +00:00
Eemeli Aro
ee8885056b Bug 1793572 - Convert webrtcIndicator.properties to Fluent. r=mconley,flod
Differential Revision: https://phabricator.services.mozilla.com/D158760
2022-10-08 07:35:28 +00:00
Mike Conley
7b4982e14e Bug 1783918 - Part 4: Plumb trigger event through to calls to webrtcUI.showSharingDoorhanger and have it call openPopup directly. r=pbz
Differential Revision: https://phabricator.services.mozilla.com/D154130
2022-08-10 15:05:33 +00:00
Tooru Fujisawa
328d63ce7f Bug 1777486 - Part 2: Migrate XPCOMUtils.jsm consumers with automatic migration. r=webdriver-reviewers,geckoview-reviewers,preferences-reviewers,application-update-reviewers,pip-reviewers,kmag,owlish,whimboo
Differential Revision: https://phabricator.services.mozilla.com/D151214
2022-07-12 04:21:34 +00:00
Andreea Pavel
f009ba2983 Backed out 11 changesets (Bug 1777486) for failing bc at browser_startup.js on a CLOSED TREE
Backed out changeset b6c4c386f1a6 (Bug 1777486)
Backed out changeset 195cc2de8433 (Bug 1777486)
Backed out changeset 20c746fb1648 (Bug 1777486)
Backed out changeset d5fd8173d62d (Bug 1777486)
Backed out changeset 6d758fab5a3e (Bug 1777486)
Backed out changeset e938b601ba15 (Bug 1777486)
Backed out changeset 0c4ea0b9416b (Bug 1777486)
Backed out changeset 0559c53cc668 (Bug 1777486)
Backed out changeset eea573d3a9f9 (Bug 1777486)
Backed out changeset 9ce3a6496a49 (bug 1777486)
Backed out changeset b0867652fc48 (bug 1777486)
2022-07-11 22:24:40 +03:00
Tooru Fujisawa
bf0a8b781b Bug 1777486 - Part 2: Migrate XPCOMUtils.jsm consumers with automatic migration. r=webdriver-reviewers,geckoview-reviewers,preferences-reviewers,application-update-reviewers,pip-reviewers,kmag,owlish,whimboo
Differential Revision: https://phabricator.services.mozilla.com/D151214
2022-07-11 15:09:13 +00:00
Tooru Fujisawa
b10d0289af Bug 1667455 - Part 4: Stop importing Services.jsm from JSM. r=kmag,webdriver-reviewers,perftest-reviewers,webcompat-reviewers,geckoview-reviewers,application-update-reviewers,pip-reviewers,twisniewski,devtools-reviewers,m_kato,jdescottes,ochameau,mconley,sfoster,AlexandruIonescu
Differential Revision: https://phabricator.services.mozilla.com/D150893
2022-07-11 12:41:50 +00:00
Tooru Fujisawa
d70795732d Bug 1775250 - Do not define XPCOMUtils as lazy getter. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D149973
2022-06-22 19:26:58 +00:00
Michael Kohler
e280cee9f3 Bug 1683099 - Remove expired probe webrtc.ui.show_indicator#show_indicator r=mconley DONTBUILD
Differential Revision: https://phabricator.services.mozilla.com/D148355
2022-06-07 11:14:04 +00:00
Tooru Fujisawa
e39bca0c9a Bug 1772007 - Part 2: Use plain object for lazy getter in browser/modules/. r=mossop
Differential Revision: https://phabricator.services.mozilla.com/D148008
2022-06-06 18:59:45 +00:00
Tooru Fujisawa
bf94464e91 Bug 1772351 - Part 1: Stop calling ChromeUtils.defineModuleGetter for AppConstants. r=florian
Differential Revision: https://phabricator.services.mozilla.com/D148164
2022-06-06 04:42:08 +00:00
Molnar Sandor
4c2b06df41 Backed out 15 changesets (bug 1772313, bug 1772351, bug 1772360) for causing xpc failures in telemetry/tests/unit/test_SocketScalars.js CLOSED TREE
Backed out changeset c8b0a2ed239e (bug 1772360)
Backed out changeset 1922adad6abe (bug 1772351)
Backed out changeset 6d3634cce489 (bug 1772351)
Backed out changeset f03968a9d053 (bug 1772351)
Backed out changeset e7a38ef90fe4 (bug 1772351)
Backed out changeset b389e7654771 (bug 1772313)
Backed out changeset 59a33598ff51 (bug 1772313)
Backed out changeset ab60885a8a93 (bug 1772313)
Backed out changeset aad8efac9d05 (bug 1772313)
Backed out changeset 4378e519a8e7 (bug 1772313)
Backed out changeset 302ac54741f8 (bug 1772313)
Backed out changeset 74c59f9fd51c (bug 1772313)
Backed out changeset 575fb877c56c (bug 1772313)
Backed out changeset 2eaa68f10b19 (bug 1772313)
Backed out changeset 4a8b3ba193dc (bug 1772313)
2022-06-06 07:04:25 +03:00
Tooru Fujisawa
6ed0357d29 Bug 1772351 - Part 1: Stop calling ChromeUtils.defineModuleGetter for AppConstants. r=florian
Differential Revision: https://phabricator.services.mozilla.com/D148164
2022-06-06 02:49:12 +00:00
Jon Barson
0650e62d36 Bug 1632476 changed hostname for media permissions to include the port r=johannh
Differential Revision: https://phabricator.services.mozilla.com/D128109
2021-10-21 11:56:35 +00:00
Bryce Seager van Dyk
d328d4e34a Bug 1706164 - Share screen and window sharing status from webrtcUI via sharedData. r=mconley
Differential Revision: https://phabricator.services.mozilla.com/D115416
2021-05-24 16:50:19 +00:00
Sandor Molnar
af01e6d592 Backed out 4 changesets (bug 1706164) for causing build bustages in media/eme/MediaKeys. CLOSED TREE
Backed out changeset 5d3f67175482 (bug 1706164)
Backed out changeset 4630540c3717 (bug 1706164)
Backed out changeset 4a2463270858 (bug 1706164)
Backed out changeset a2b896ddc631 (bug 1706164)
2021-05-21 23:21:58 +03:00
Bryce Seager van Dyk
09bde975f9 Bug 1706164 - Share screen and window sharing status from webrtcUI via sharedData. r=mconley
Differential Revision: https://phabricator.services.mozilla.com/D115416
2021-05-21 19:59:53 +00:00
Jan-Ivar Bruaroey
8f28732e8f Bug 1703674 - Revoking cam or mic permission revokes both if either is capturing. r=pbz
Differential Revision: https://phabricator.services.mozilla.com/D111174
2021-04-09 20:48:41 +00:00
Paul Zuehlcke
d428189879 Bug 1698513 - Do not start WebRTC permission grace-period on permission revoke. r=johannh
Differential Revision: https://phabricator.services.mozilla.com/D108842
2021-03-25 11:21:16 +00:00
Alexandru Michis
cc988b542f Backed out changeset 24ff7bb331e0 (bug 1698513) for causing bc failures in browser_devices_get_user_media_in_frame.js
CLOSED TREE
2021-03-24 22:56:07 +02:00
Paul Zuehlcke
0d748fa8d8 Bug 1698513 - Do not start WebRTC permission grace-period on permission revoke. r=johannh
Differential Revision: https://phabricator.services.mozilla.com/D108842
2021-03-24 19:40:48 +00:00
Florian Quèze
7ab653dac1 Bug 1697800 - webrtcUI.getActiveStreams should not throw during tab closing, r=johannh.
Depends on D108011

Differential Revision: https://phabricator.services.mozilla.com/D108012
2021-03-17 17:39:31 +00:00
Mike Conley
f943bc8e5a Bug 1693677 - Add a 50s grace period for re-requesting a camera or microphone device in a tab. r=mconley,johannh
Depends on D106160

Differential Revision: https://phabricator.services.mozilla.com/D106043
2021-03-13 19:15:55 +00:00
Bogdan Tara
73bd7f34e3 Backed out 3 changesets (bug 1693677) for browser_devices_get_user_media_grace.js failures CLOSED TREE
Backed out changeset df230c366ab3 (bug 1693677)
Backed out changeset 816d2b917939 (bug 1693677)
Backed out changeset f9895c7f1b26 (bug 1693677)
2021-03-13 01:16:10 +02:00
Mike Conley
63e9c154b2 Bug 1693677 - Add a 50s grace period for re-requesting a camera or microphone device in a tab. r=mconley,johannh
Depends on D106160

Differential Revision: https://phabricator.services.mozilla.com/D106043
2021-03-12 19:15:13 +00:00
Paul Zuehlcke
09e816bda6 Bug 1695615 - Updated permission panel for double-keyed WebRTC permissions. r=johannh
Differential Revision: https://phabricator.services.mozilla.com/D107071
2021-03-12 10:06:16 +00:00
Paul Zuehlcke
927176d829 Bug 1695615 - Removed obsolete per-frame permission tracking for geolocation and WebRTC permissions. r=johannh
Differential Revision: https://phabricator.services.mozilla.com/D107070
2021-03-12 10:06:16 +00:00
Neil Deakin
8f89b771ca Bug 1682442, prioritize tab unloader based on how many processes are used by a tab, how much memory is used by the tab, and whether sound/webrtc/picture in picture is in use for a tab, r=gsvelto
Differential Revision: https://phabricator.services.mozilla.com/D99738
2021-02-25 00:56:15 +00:00
Paul Zuehlcke
a1d23766c7 Bug 1596897 - Moved permission list from site identity to separate permission panel. r=johannh
- Added a new permission panel managed by the gPermissionPanel object
- Updated identity-box to separate identity and permission section

Differential Revision: https://phabricator.services.mozilla.com/D99892
2021-02-05 13:40:35 +00:00
Narcis Beleuzu
926d2f6257 Backed out 2 changesets (bug 1596897) for bc failures on browser_search_discovery.js
Backed out changeset 635972f169e7 (bug 1596897)
Backed out changeset a84b667007e2 (bug 1596897)
2021-01-30 04:01:21 +02:00
Paul Zuehlcke
480794a586 Bug 1596897 - Moved permission list from site identity to separate permission panel. r=johannh
- Added a new permission panel managed by the gPermissionPanel object
- Updated identity-box to separate identity and permission section

Differential Revision: https://phabricator.services.mozilla.com/D99892
2021-01-29 16:06:08 +00:00
Brindusan Cristian
b0f9bc02f2 Backed out 2 changesets (bug 1596897) for mochitest failures at browser_setIgnoreCertificateErrors.js. CLOSED TREE
Backed out changeset 00c45a405129 (bug 1596897)
Backed out changeset 61304ccbaada (bug 1596897)
2021-01-28 21:53:46 +02:00
Paul Zuehlcke
032c94dfc0 Bug 1596897 - Moved permission list from site identity to separate permission panel. r=johannh
- Added a new permission panel managed by the gPermissionPanel object
- Updated identity-box to separate identity and permission section

Differential Revision: https://phabricator.services.mozilla.com/D99892
2021-01-28 18:00:44 +00:00
Mike Conley
bccd5b3efd Bug 1672432 - Don't remove persistent device permissions when clicking 'Stop Sharing' in the WebRTC global indicator. r=pbz
Differential Revision: https://phabricator.services.mozilla.com/D94501
2020-10-27 16:28:25 +00:00
Mike Conley
f645f9baab Bug 1663784 - Rename mozilla.org/widget/macsystemstatusbar to mozilla.org/widget/systemstatusbar. r=spohl
Differential Revision: https://phabricator.services.mozilla.com/D89786
2020-09-15 17:38:27 +00:00
Mike Conley
0510a0c94a Bug 1656127 - Remove some unneeded WebRTC UI probes. r=pbz
Differential Revision: https://phabricator.services.mozilla.com/D89790
2020-09-10 17:36:46 +00:00
Mike Conley
a29011cee1 Bug 1658052 - Only remember allowed shared browser tabs for tabbrowser <browser> elements. r=pbz
Differential Revision: https://phabricator.services.mozilla.com/D86444
2020-08-10 09:20:29 +00:00
Mike Conley
00807a7677 Bug 1656274 - Add a probe to record when users cause the WebRTC sharing indicator to open. r=pbz,data-review=chutten
Differential Revision: https://phabricator.services.mozilla.com/D85422
2020-08-04 22:37:39 +00:00
Mike Conley
d39711da49 Bug 1649032 - If the user manages to close the WebRTC indicator, close all of the active streams. r=pbz
Differential Revision: https://phabricator.services.mozilla.com/D82989
2020-07-17 01:22:10 +00:00
Bogdan Tara
17ab4cfa11 Backed out 2 changesets (bug 1649032) for leakcheck failures CLOSED TREE
Backed out changeset ef80a597db37 (bug 1649032)
Backed out changeset a8462c37bef1 (bug 1649032)
2020-07-16 00:37:06 +03:00
Mike Conley
c702848ffa Bug 1649032 - If the user manages to close the WebRTC indicator, close all of the active streams. r=pbz
Differential Revision: https://phabricator.services.mozilla.com/D82989
2020-07-15 10:22:12 +00:00
pbz
6b4d784f13 Bug 1636496 - Only show global sharing indicator window if we have a media indicator to show. r=johannh
The webrtc global indicator shows media indicators based on the indicator state
of the individual tabs.
Determining the visibility of the global indicator based on if there are active
streams (globally), but saving that state on tab level, lead to conditions where,
after a stream had ended, no tab had any indicators set, but a stray global
indicator without any icons would still be shown.
This patch fixes that by only showing the global indicator if there is actually
a tab with an indicator.

Differential Revision: https://phabricator.services.mozilla.com/D79315
2020-06-12 19:18:25 +00:00
Mike Conley
e8637fc196 Bug 1641546 - Make the new WebRTC global sharing indicator a dialog instead of a popup. r=pbz
Depends on D77696

Differential Revision: https://phabricator.services.mozilla.com/D77504
2020-06-08 18:36:24 +00:00
Coroiu Cristina
5622ff32da Backed out 6 changesets (bug 1641546) for permafailing browser-chrome at browser_devices_get_user_media_unprompted_access_tear_off_tab.js
Backed out changeset 2652e1c084a7 (bug 1641546)
Backed out changeset 72a62a455c47 (bug 1641546)
Backed out changeset 4746c37be3e6 (bug 1641546)
Backed out changeset a2b64d290c0b (bug 1641546)
Backed out changeset 2dc2a430c2e7 (bug 1641546)
Backed out changeset 041cd14e3893 (bug 1641546)
2020-06-06 19:13:06 +03:00
Mike Conley
75a71620a7 Bug 1641546 - Make the new WebRTC global sharing indicator a dialog instead of a popup. r=pbz
Depends on D77696

Differential Revision: https://phabricator.services.mozilla.com/D77504
2020-06-05 14:29:29 +00:00
Mike Conley
8fc3e30761 Bug 1639997 - Have webrtcUI handle the case where the selectedTab is set to null. r=pbz
It's possible for gBrowser.selectedTab to be set to null. This should be a no-op, but this
part of webrtcUI that tabbrowser calls doesn't handle the case, and causes an exception to
be thrown. This patch allows the no-op case to occur properly.

Differential Revision: https://phabricator.services.mozilla.com/D76736
2020-05-26 18:01:04 +00:00
Mike Conley
3029be8e7d Bug 1639997 - Use more appropriate window features for new WebRTC global indicator. r=pbz
These features allow the indicator to not pull focus from the originating window, which
is important to maintain user task continuity, especially for screenreader users.

Differential Revision: https://phabricator.services.mozilla.com/D76735
2020-05-26 18:00:46 +00:00
Mike Conley
3f869ebd2a Bug 1639337 - Factor out the macOS status bar WebRTC indicator into a reusable class. r=pbz
Differential Revision: https://phabricator.services.mozilla.com/D76388
2020-05-26 18:00:36 +00:00