corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
766,165 Commits 1 Branch 0 Tags
739b51aee122798f1d049575ff9f0747ca1fdea5
Commit Graph

52 Commits

Author SHA1 Message Date
Daisuke Akatsuka
d82f055d58 Bug 1800414: Implement the abandonment event. r=mak,Dexter 
Differential Revision: https://phabricator.services.mozilla.com/D161977
 2022-12-01 23:37:32 +00:00
Daisuke Akatsuka
f12f72c9eb Bug 1797265: Implement the engagement event. r=mak,adw,Dexter 
Differential Revision: https://phabricator.services.mozilla.com/D160193
 2022-12-01 12:05:48 +00:00
Dão Gottwald
f745f36b17 Bug 1790019 - Implement placeholder urlbar result menu button and popup. r=mak,fluent-reviewers,flod,jteow 
Differential Revision: https://phabricator.services.mozilla.com/D161776
 2022-11-18 20:14:46 +00:00
Dan Robertson
a2f5784df5 Bug 1796690 - Update urlbar text overflow direction calculation. r=mak 
Update the urlbar text overflow direction calculation after recent scrollend
changes do not result in scrollend events fired for scrolls that do not change
the scroll position.

Depends on D160156

Differential Revision: https://phabricator.services.mozilla.com/D161846
 2022-11-18 15:12:10 +00:00
Cristian Tuns
8339eb2abf Backed out 3 changesets (bug 1796690) for causing mochitest failures on browser_primaryUI.js CLOSED TREE 
Backed out changeset 28f9e04d3500 (bug 1796690)
Backed out changeset 70903d77e4f0 (bug 1796690)
Backed out changeset 66ddf8488393 (bug 1796690)
 2022-11-16 18:22:14 -05:00
Drew Willcoxon
05db5ab826 Bug 1800810 - Always record visible quick suggest results in engagement telemetry. r=dao 
This is a follow up to D161866 and effectively reverts and replaces it with a
different approach. Please see bug 1800810 for background. In short, engagement
telemetry should be based on the result that's visible in the view, not on the
result the provider added last.

D161866 fixed the case where the last-added result is in the view but hidden.
There's another case we need to handle, when the last-added result is not in the
view at all. That can happen when you type something and hit enter really
quickly, before the view can update. I was able to trigger it several times.
When that happens, there are two possibilities:

* No quick suggest result is visible in the view. `result.rowIndex` is its
  initial value of -1, so we record an engagement for a result that is not
  visible and that doesn't have a valid index.

* A quick suggest result from a previous query is visible in the view. Here
  again, `result.rowIndex` is -1 so we record an engagement for a result that is
  not visible and that doesn't have a valid index, and we miss recording an
  engagement for the result that's actually visible.

Right now it's not easy to fix this inside the provider because providers don't
know anything about the view(s). I could record this telemetry in the view but
that's not its role. I think it makes sense to include the view in the query
context, so that's what this does. I added `view.visibleResults` to make getting
the visible results easy.

Daisuke's new Glean telemetry in D160193 uses `context.results`, which has this
same problem of not being based on actually visible results. We'll need to use
`context.view.visibleResults` there too, and there may be other existing cases
as well.

Depends on D161866

Differential Revision: https://phabricator.services.mozilla.com/D162182
 2022-11-16 21:47:55 +00:00
Dan Robertson
36a5c7cc40 Bug 1796690 - Update urlbar text overflow direction calculation. r=mak 
Update the urlbar text overflow direction calculation after recent scrollend
changes do not result in scrollend events fired for scrolls that do not change
the scroll position.

Depends on D160156

Differential Revision: https://phabricator.services.mozilla.com/D161846
 2022-11-16 16:52:24 +00:00
Ben Hearsum
27a4fed094 Bug 1797010: default private window feature to UrlbarInput.isPrivate r=adw 
Differential Revision: https://phabricator.services.mozilla.com/D160103
 2022-11-08 21:31:12 +00:00
James Teow
374baa5f1d Bug 1798938 - Move getSearchTermIfDefaultSerp helper into a common place - r=adw 
Differential Revision: https://phabricator.services.mozilla.com/D161458
 2022-11-07 22:00:22 +00:00
James Teow
57cbb18445 Bug 1779470 - Part 1: Add Nimbus variable, feature gate preference, and rename showSearchTerms prefs - r=adw 
Differential Revision: https://phabricator.services.mozilla.com/D159462
 2022-11-05 02:13:28 +00:00
James Teow
39f9af11ee Bug 1779471 - Rename pref and add telemetry for persistent search term searches - r=adw,Standard8 
Differential Revision: https://phabricator.services.mozilla.com/D156706
 2022-10-27 15:53:11 +00:00
trickypr
4b9c23b007 Bug 1510561 - Part 7: Apply plugin:mozilla/require-jsdoc to browser/components/urlbar. r=Standard8 
Differential Revision: https://phabricator.services.mozilla.com/D159472
 2022-10-24 13:32:38 +00:00
trickypr
f28fa5aa80 Bug 1510561 - Part 6: Apply plugin:mozilla/valid-jsdoc to browser/components/urlbar. r=Standard8 
Differential Revision: https://phabricator.services.mozilla.com/D159471
 2022-10-24 13:32:37 +00:00
James Teow
8448fad066 Bug 1788953 - Part 2: Use cached originalURI in setURI - r=adw 
Depends on D157485

Differential Revision: https://phabricator.services.mozilla.com/D157486
 2022-10-18 13:38:49 +00:00
Mark Banner
5407bdffa8 Bug 1792341 - Migrate more toolkit/modules consumers to use direct ES module import. r=Gijs,webdriver-reviewers,perftest-reviewers,necko-reviewers,geckoview-reviewers,preferences-reviewers,application-update-reviewers,pip-reviewers,credential-management-reviewers,sgalich,owlish,bytesized,AlexandruIonescu,whimboo,mconley,mixedpuppy 
Mainly automated changes. Some manual ESLint fixes and whitespace cleanup.

Differential Revision: https://phabricator.services.mozilla.com/D158452
 2022-10-18 11:21:26 +00:00
Daisuke Akatsuka
c2da12f995 Bug 1792513: Do not show full list of Quick Actions while scrolling one off buttons. r=daleharvey,adw 
Depends on D158220

Differential Revision: https://phabricator.services.mozilla.com/D158245
 2022-10-13 21:35:09 +00:00
Mark Banner
a49b8ef78f Bug 1792365 - Convert toolkit/modules consumers to use ES module imports directly. r=webdriver-reviewers,perftest-reviewers,geckoview-reviewers,extension-reviewers,preferences-reviewers,desktop-theme-reviewers,application-update-reviewers,pip-reviewers,credential-management-reviewers,robwu,Gijs,sgalich,bytesized,AlexandruIonescu,dao,m_kato 
Differential Revision: https://phabricator.services.mozilla.com/D158094
 2022-09-29 06:52:34 +00:00
Mark Banner
79b9557a71 Bug 1792398 - Enable ESLint rule 'strict' on mjs files as the directive is not necessary for modules. r=arai,pip-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D158115
 2022-09-26 21:47:50 +00:00
Marian-Vasile Laza
b7f6194b8d Backed out changeset 0679274d6ed5 (bug 1792398) for causing bc failures on browser_sendQuery.js. CLOSED TREE 2022-09-26 22:53:00 +03:00
Mark Banner
5dcae1ed44 Bug 1792398 - Enable ESLint rule 'strict' on mjs files as the directive is not necessary for modules. r=arai,pip-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D158115
 2022-09-26 18:51:57 +00:00
Narcis Beleuzu
95ae6b7d0f Backed out changeset 849faf753208 (bug 1792398) for bc failures on browser_sendQuery.js . CLOSED TREE 2022-09-26 20:44:40 +03:00
Mark Banner
ff212fab8b Bug 1792398 - Enable ESLint rule 'strict' on mjs files as the directive is not necessary for modules. r=arai,pip-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D158115
 2022-09-26 16:51:10 +00:00
James Teow
e58290f857 Bug 1789677 - All query params of URI should match the engine generated URI - r=adw 
Differential Revision: https://phabricator.services.mozilla.com/D156711
 2022-09-08 03:23:41 +00:00
James Teow
b809ede12b Bug 1779467 - Don't show search term if search bar is enabled - r=adw 
Differential Revision: https://phabricator.services.mozilla.com/D156566
 2022-09-06 20:39:12 +00:00
James Teow
59257bb25c Bug 1788941 - Check if resultDetails is non-null - r=adw 
Differential Revision: https://phabricator.services.mozilla.com/D156319
 2022-09-02 17:48:07 +00:00
James Teow
d8e65a02b2 Bug 1779465 - Part 1: Show search term on default SERP - r=adw 
Differential Revision: https://phabricator.services.mozilla.com/D153280
 2022-09-01 19:26:29 +00:00
Daisuke Akatsuka
05818fe5ec Bug 1565751: Wait for processing needed before selecting text. r=adw 
Differential Revision: https://phabricator.services.mozilla.com/D155042
 2022-08-24 00:43:03 +00:00
Dale Harvey
5b3b730caa Bug 1779219 - Add onboarding link to QuickActions. r=adw 
Differential Revision: https://phabricator.services.mozilla.com/D154676
 2022-08-18 12:53:56 +00:00
Marian-Vasile Laza
90505c45a8 Backed out changeset 629fc32c6f5e (bug 1779219) for causing xpcshell failures on test_quickactions.js. CLOSED TREE 2022-08-18 01:47:00 +03:00
Dale Harvey
9d202554f0 Bug 1779219 - Add onboarding link to QuickActions. r=adw 
Differential Revision: https://phabricator.services.mozilla.com/D154676
 2022-08-17 21:03:59 +00:00
Daisuke Akatsuka
9f95d1975d Bug 1776607: Record search source for urlbar. r=mak 
Differential Revision: https://phabricator.services.mozilla.com/D151573
 2022-08-08 21:07:31 +00:00
Daisuke Akatsuka
41e7c036b0 Bug 1776609: Record source and triggeringPlaceId for sponsored item on urlbar. r=mak 
Differential Revision: https://phabricator.services.mozilla.com/D151572
 2022-08-01 00:27:50 +00:00
Butkovits Atila
fe05967e94 Backed out 2 changesets (bug 1776609) for causing failures at browser_topsites_annotation.js. CLOSED TREE 
Backed out changeset cac795fd16d2 (bug 1776609)
Backed out changeset 88ec1cca8540 (bug 1776609)
 2022-08-01 00:52:35 +03:00
Daisuke Akatsuka
6c863b3799 Bug 1776609: Record source and triggeringPlaceId for sponsored item on urlbar. r=mak 
Differential Revision: https://phabricator.services.mozilla.com/D151572
 2022-07-31 20:26:31 +00:00
Butkovits Atila
efbdfe270f Backed out 2 changesets (bug 1776609) for causing gtest failures. CLOSED TREE 
Backed out changeset 7630fea97777 (bug 1776609)
Backed out changeset 426cbe0fac73 (bug 1776609)
 2022-07-29 13:42:33 +03:00
Daisuke Akatsuka
b690baaec7 Bug 1776609: Record source and triggeringPlaceId for sponsored item on urlbar. r=mak 
Differential Revision: https://phabricator.services.mozilla.com/D151572
 2022-07-29 09:24:28 +00:00
Mark Banner
89c201a8bd Bug 1780347 - Switch from using importESModule to standard imports for XPCOMUtils in converted system modules. r=arai 
Differential Revision: https://phabricator.services.mozilla.com/D152253
 2022-07-26 15:11:31 +00:00
Mark Banner
cd9bed2e7a Bug 1780017 - Migrate urlbar consumers to use ESM imports directly. r=adw,preferences-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D152057
 2022-07-26 15:11:30 +00:00
Mark Banner
52a7ce13c9 Bug 1780017 - Migrate browser/components/urlbar to ESM. r=adw 
Differential Revision: https://phabricator.services.mozilla.com/D152056
 2022-07-26 15:11:29 +00:00
smolnar
4cb3dcaaa2 Backed out 5 changesets (bug 1780017, bug 1780347) for causing bc failures in browser/base/content/test/performance/browser_preferences_usage.js CLOSED TREE 
Backed out changeset 86c3a9142535 (bug 1780347)
Backed out changeset 35abe35417a0 (bug 1780017)
Backed out changeset f448f044f028 (bug 1780017)
Backed out changeset a400cbe83084 (bug 1780017)
Backed out changeset 0a23c9e27f01 (bug 1780017)
 2022-07-25 21:00:07 +03:00
Mark Banner
41d1e736b0 Bug 1780347 - Switch from using importESModule to standard imports for XPCOMUtils in converted system modules. r=arai 
Differential Revision: https://phabricator.services.mozilla.com/D152253
 2022-07-25 12:46:49 +00:00
Mark Banner
bf597b1f3a Bug 1780017 - Migrate urlbar consumers to use ESM imports directly. r=adw,preferences-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D152057
 2022-07-25 12:46:48 +00:00
Mark Banner
373fefff8f Bug 1780017 - Migrate browser/components/urlbar to ESM. r=adw 
Differential Revision: https://phabricator.services.mozilla.com/D152056
 2022-07-25 12:46:47 +00:00
smolnar
ee079d37e2 Backed out 8 changesets (bug 1779982, bug 1780017, bug 1780347) for causing doc generate failures. CLOSED TREE 
Backed out changeset 3f22c0f99cf1 (bug 1780347)
Backed out changeset 6f20b7e4b21b (bug 1780017)
Backed out changeset ae6062c69aeb (bug 1780017)
Backed out changeset e668d7778d97 (bug 1780017)
Backed out changeset e158fc41594b (bug 1780017)
Backed out changeset d4c69c956271 (bug 1779982)
Backed out changeset 145212fd826d (bug 1779982)
Backed out changeset 54079aaa1857 (bug 1779982)
 2022-07-20 22:43:53 +03:00
Mark Banner
1a7f25b6f9 Bug 1780347 - Switch from using importESModule to standard imports for XPCOMUtils in converted system modules. r=arai 
Differential Revision: https://phabricator.services.mozilla.com/D152253
 2022-07-20 15:50:43 +00:00
Mark Banner
78524564fc Bug 1780017 - Migrate urlbar consumers to use ESM imports directly. r=adw,preferences-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D152057
 2022-07-20 15:50:42 +00:00
Mark Banner
1bde6670d7 Bug 1780017 - Migrate browser/components/urlbar to ESM. r=adw 
Differential Revision: https://phabricator.services.mozilla.com/D152056
 2022-07-20 15:50:41 +00:00
Iulian Moraru
bc13570de5 Backed out 7 changesets (bug 1779982, bug 1780017) for causing multiple failures. CLOSED TREE 
Backed out changeset f33a58aa2f3f (bug 1780017)
Backed out changeset e21c85d61b91 (bug 1780017)
Backed out changeset 213ee5578e7c (bug 1780017)
Backed out changeset ea9b3bf42ea1 (bug 1780017)
Backed out changeset d2d8530f3c4d (bug 1779982)
Backed out changeset 088e5148c307 (bug 1779982)
Backed out changeset 267e08f3868a (bug 1779982)
 2022-07-20 15:44:53 +03:00
Iulian Moraru
df431be6b8 Backed out 3 changesets (bug 1780074, bug 1780347) for causing multiple failures. CLOSED TREE 
Backed out changeset ee4c4d34816c (bug 1780347)
Backed out changeset a13d3939b98a (bug 1780074)
Backed out changeset 3bc739f7de43 (bug 1780074)
 2022-07-20 14:57:48 +03:00
Mark Banner
2302d51735 Bug 1780347 - Switch from using importESModule to standard imports for XPCOMUtils in converted system modules. r=arai 
Differential Revision: https://phabricator.services.mozilla.com/D152253
 2022-07-20 10:36:53 +00:00