Emilio Cobos Álvarez
07c539563d
Bug 1799580 - Remove display: -moz-popup. r=TYLin
...
We already rely on it applying only to XULPopupElement's. Make it
explicit and remove the CSS value.
Differential Revision: https://phabricator.services.mozilla.com/D161552
2022-11-09 20:38:04 +00:00
Csoregi Natalia
4e859d7b1a
Backed out 3 changesets (bug 1799343, bug 1799580) for causing failures on /browser_history_after_appMenu.js. CLOSED TREE
...
Backed out changeset 63c270ba91ad (bug 1799343)
Backed out changeset 713e6f0fbd20 (bug 1799580)
Backed out changeset 42d1b8742662 (bug 1799343)
2022-11-09 21:26:06 +02:00
Emilio Cobos Álvarez
80aaaacfe0
Bug 1799580 - Remove display: -moz-popup. r=TYLin
...
We already rely on it applying only to XULPopupElement's. Make it
explicit and remove the CSS value.
Differential Revision: https://phabricator.services.mozilla.com/D161552
2022-11-09 14:19:22 +00:00
Cristian Tuns
0e3ee79a08
Backed out 2 changesets (bug 1799580, bug 1799343) for causing mochitest failures on win7 CLOSED TREE
...
Backed out changeset fb0df93a4719 (bug 1799580)
Backed out changeset 493c9ca00c91 (bug 1799343)
2022-11-09 07:15:51 -05:00
Emilio Cobos Álvarez
f496edbc02
Bug 1799580 - Remove display: -moz-popup. r=TYLin
...
We already rely on it applying only to XULPopupElement's. Make it
explicit and remove the CSS value.
Differential Revision: https://phabricator.services.mozilla.com/D161552
2022-11-09 09:17:22 +00:00
Mark Banner
433fff5bca
Bug 1795322 - Update toolkit modules references in browser/ code. r=mossop,Gijs,preferences-reviewers,desktop-theme-reviewers,dao
...
Differential Revision: https://phabricator.services.mozilla.com/D160031
2022-10-26 08:06:35 +00:00
Csoregi Natalia
5edbe31601
Backed out 12 changesets (bug 1795322) for causing multiple failures e.g. test_deletion_request_ping.py. CLOSED TREE
...
Backed out changeset aba25cbcda51 (bug 1795322)
Backed out changeset a4a35005ada9 (bug 1795322)
Backed out changeset 8e8d790eb0f4 (bug 1795322)
Backed out changeset db8903454bd3 (bug 1795322)
Backed out changeset 60cc71c61cad (bug 1795322)
Backed out changeset bc6a674994ad (bug 1795322)
Backed out changeset 6ac8a611f8c7 (bug 1795322)
Backed out changeset 9fb873ecfb31 (bug 1795322)
Backed out changeset c8a7a40c2a2f (bug 1795322)
Backed out changeset f2c118b6c6ce (bug 1795322)
Backed out changeset 38df43b4a70f (bug 1795322)
Backed out changeset 89aea8373411 (bug 1795322)
2022-10-25 23:47:58 +03:00
Mark Banner
6bff0ab996
Bug 1795322 - Update toolkit modules references in browser/ code. r=mossop,Gijs,preferences-reviewers,desktop-theme-reviewers,dao
...
Differential Revision: https://phabricator.services.mozilla.com/D160031
2022-10-25 19:49:26 +00:00
Emilio Cobos Álvarez
a354c85b02
Bug 1796199 - Remove script access to XUL layout attributes. r=Gijs
...
These don't work on emulated flexbox. We only have a couple of uses.
See D159726 for the diagnostic patch I used to catch these.
Differential Revision: https://phabricator.services.mozilla.com/D159727
2022-10-20 08:36:00 +00:00
Butkovits Atila
82536ebfc5
Backed out changeset 39f39360ae48 (bug 1796199) for causing failures at test_panel.xhtml. CLOSED TREE
2022-10-20 00:39:56 +03:00
Emilio Cobos Álvarez
5d4865adb2
Bug 1796199 - Remove script access to XUL layout attributes. r=Gijs
...
These don't work on emulated flexbox. We only have a couple of uses.
See D159726 for the diagnostic patch I used to catch these.
Differential Revision: https://phabricator.services.mozilla.com/D159727
2022-10-19 19:18:04 +00:00
Mark Banner
5407bdffa8
Bug 1792341 - Migrate more toolkit/modules consumers to use direct ES module import. r=Gijs,webdriver-reviewers,perftest-reviewers,necko-reviewers,geckoview-reviewers,preferences-reviewers,application-update-reviewers,pip-reviewers,credential-management-reviewers,sgalich,owlish,bytesized,AlexandruIonescu,whimboo,mconley,mixedpuppy
...
Mainly automated changes. Some manual ESLint fixes and whitespace cleanup.
Differential Revision: https://phabricator.services.mozilla.com/D158452
2022-10-18 11:21:26 +00:00
Mark Hammond
21bd24ad69
Bug 1792550 - ensure the primary password is unlocked before signing in to sync. r=Mardak,sfoster
...
Differential Revision: https://phabricator.services.mozilla.com/D158719
2022-10-12 22:31:37 +00:00
Angel_V129
e3be76313a
Bug 1788756 - [Themes] Convert browser/theme JSM modules to ESMs. r=kpatenio
...
Differential Revision: https://phabricator.services.mozilla.com/D157037
2022-10-04 19:02:24 +00:00
Mark Banner
a49b8ef78f
Bug 1792365 - Convert toolkit/modules consumers to use ES module imports directly. r=webdriver-reviewers,perftest-reviewers,geckoview-reviewers,extension-reviewers,preferences-reviewers,desktop-theme-reviewers,application-update-reviewers,pip-reviewers,credential-management-reviewers,robwu,Gijs,sgalich,bytesized,AlexandruIonescu,dao,m_kato
...
Differential Revision: https://phabricator.services.mozilla.com/D158094
2022-09-29 06:52:34 +00:00
Mark Banner
c34ea601d2
Bug 1634555 - Send event telemetry for search default engine changes. r=daleharvey
...
Differential Revision: https://phabricator.services.mozilla.com/D157471
2022-09-28 09:40:36 +00:00
Brian
0b327f0974
Bug 1788925 - Convert AboutReader from JSM to ESM. r=Gijs.
...
Differential Revision: https://phabricator.services.mozilla.com/D157034
2022-09-23 21:19:12 +00:00
Emilio Cobos Álvarez
abab9b2db7
Bug 1788273 - Tweak popup alignment so that it looks good on mirrored wayland popups. r=dao,mak
...
When these panels had arrows, I guess the bottomcenter topleft alignment
made sense so that you could precisely align the arrow, but that's not
what we do now.
Don't use bottomcenter / leftcenter / rightcenter, since we really want
the sides to align.
This shouldn't change behavior on any platform except Linux + Wayland,
where the alignment looks good now in the case of bug 1784876.
Differential Revision: https://phabricator.services.mozilla.com/D156099
2022-09-02 20:26:29 +00:00
Butkovits Atila
e4a4a23311
Backed out changeset 368a7ce1b104 (bug 1788273) for causing failures at browser_recently_closed_tabs.js. CLOSED TREE
2022-09-02 16:35:55 +03:00
Emilio Cobos Álvarez
72c00adfaa
Bug 1788273 - Tweak popup alignment so that it looks good on mirrored wayland popups. r=dao,mak
...
When these panels had arrows, I guess the bottomcenter topleft alignment
made sense so that you could precisely align the arrow, but that's not
what we do now.
Don't use bottomcenter / leftcenter / rightcenter, since we really want
the sides to align.
This shouldn't change behavior on any platform except Linux + Wayland,
where the alignment looks good now in the case of bug 1784876.
Differential Revision: https://phabricator.services.mozilla.com/D156099
2022-09-02 11:18:54 +00:00
Mark Banner
1e3410cbdd
Bug 1782008 - Remove now unnecessary .eslintrc.js files. r=webcompat-reviewers,extension-reviewers,media-playback-reviewers,pip-reviewers,denschub,rpl,alwu,mossop
...
Differential Revision: https://phabricator.services.mozilla.com/D152736
2022-08-03 11:16:20 +00:00
Tooru Fujisawa
328d63ce7f
Bug 1777486 - Part 2: Migrate XPCOMUtils.jsm consumers with automatic migration. r=webdriver-reviewers,geckoview-reviewers,preferences-reviewers,application-update-reviewers,pip-reviewers,kmag,owlish,whimboo
...
Differential Revision: https://phabricator.services.mozilla.com/D151214
2022-07-12 04:21:34 +00:00
Andreea Pavel
f009ba2983
Backed out 11 changesets (Bug 1777486) for failing bc at browser_startup.js on a CLOSED TREE
...
Backed out changeset b6c4c386f1a6 (Bug 1777486)
Backed out changeset 195cc2de8433 (Bug 1777486)
Backed out changeset 20c746fb1648 (Bug 1777486)
Backed out changeset d5fd8173d62d (Bug 1777486)
Backed out changeset 6d758fab5a3e (Bug 1777486)
Backed out changeset e938b601ba15 (Bug 1777486)
Backed out changeset 0c4ea0b9416b (Bug 1777486)
Backed out changeset 0559c53cc668 (Bug 1777486)
Backed out changeset eea573d3a9f9 (Bug 1777486)
Backed out changeset 9ce3a6496a49 (bug 1777486)
Backed out changeset b0867652fc48 (bug 1777486)
2022-07-11 22:24:40 +03:00
Tooru Fujisawa
bf0a8b781b
Bug 1777486 - Part 2: Migrate XPCOMUtils.jsm consumers with automatic migration. r=webdriver-reviewers,geckoview-reviewers,preferences-reviewers,application-update-reviewers,pip-reviewers,kmag,owlish,whimboo
...
Differential Revision: https://phabricator.services.mozilla.com/D151214
2022-07-11 15:09:13 +00:00
Tooru Fujisawa
b10d0289af
Bug 1667455 - Part 4: Stop importing Services.jsm from JSM. r=kmag,webdriver-reviewers,perftest-reviewers,webcompat-reviewers,geckoview-reviewers,application-update-reviewers,pip-reviewers,twisniewski,devtools-reviewers,m_kato,jdescottes,ochameau,mconley,sfoster,AlexandruIonescu
...
Differential Revision: https://phabricator.services.mozilla.com/D150893
2022-07-11 12:41:50 +00:00
Ryan VanderMeulen
5a3c54219d
Bug 1776496 - Re-enable some passing browser-chrome tests. r=preferences-reviewers,Gijs
...
Differential Revision: https://phabricator.services.mozilla.com/D150280
2022-06-27 13:57:41 +00:00
Tooru Fujisawa
7ae4cb6726
Bug 1772100 - Part 20: Use plain object for lazy getter in browser/components/uitour/. r=MattN
...
Differential Revision: https://phabricator.services.mozilla.com/D148030
2022-06-06 22:46:26 +00:00
Tooru Fujisawa
ebcb6dfd9c
Bug 1772360 - Remove unnecessary call for XPCOMUtils.defineLazyGlobalGetters. r=florian,webdriver-reviewers,webcompat-reviewers,denschub,whimboo
...
Differential Revision: https://phabricator.services.mozilla.com/D148168
2022-06-06 04:42:10 +00:00
Tooru Fujisawa
f947410342
Bug 1772351 - Part 3: Stop calling XPCOMUtils.defineLazyModuleGetters for AppConstants. r=florian,webdriver-reviewers,whimboo,robwu
...
Differential Revision: https://phabricator.services.mozilla.com/D148166
2022-06-06 04:42:09 +00:00
Tooru Fujisawa
3e483c26e8
Bug 1772313 - Part 7: Stop calling XPCOMUtils.defineLazyModuleGetters for Services. r=kmag,webdriver-reviewers,whimboo
...
Differential Revision: https://phabricator.services.mozilla.com/D148160
2022-06-06 04:42:06 +00:00
Molnar Sandor
4c2b06df41
Backed out 15 changesets (bug 1772313, bug 1772351, bug 1772360) for causing xpc failures in telemetry/tests/unit/test_SocketScalars.js CLOSED TREE
...
Backed out changeset c8b0a2ed239e (bug 1772360)
Backed out changeset 1922adad6abe (bug 1772351)
Backed out changeset 6d3634cce489 (bug 1772351)
Backed out changeset f03968a9d053 (bug 1772351)
Backed out changeset e7a38ef90fe4 (bug 1772351)
Backed out changeset b389e7654771 (bug 1772313)
Backed out changeset 59a33598ff51 (bug 1772313)
Backed out changeset ab60885a8a93 (bug 1772313)
Backed out changeset aad8efac9d05 (bug 1772313)
Backed out changeset 4378e519a8e7 (bug 1772313)
Backed out changeset 302ac54741f8 (bug 1772313)
Backed out changeset 74c59f9fd51c (bug 1772313)
Backed out changeset 575fb877c56c (bug 1772313)
Backed out changeset 2eaa68f10b19 (bug 1772313)
Backed out changeset 4a8b3ba193dc (bug 1772313)
2022-06-06 07:04:25 +03:00
Tooru Fujisawa
81758ebac5
Bug 1772360 - Remove unnecessary call for XPCOMUtils.defineLazyGlobalGetters. r=florian,webdriver-reviewers,webcompat-reviewers,denschub,whimboo
...
Differential Revision: https://phabricator.services.mozilla.com/D148168
2022-06-06 02:49:14 +00:00
Tooru Fujisawa
b580e51d8f
Bug 1772351 - Part 3: Stop calling XPCOMUtils.defineLazyModuleGetters for AppConstants. r=florian,webdriver-reviewers,whimboo,robwu
...
Differential Revision: https://phabricator.services.mozilla.com/D148166
2022-06-06 02:49:13 +00:00
Tooru Fujisawa
c98ea942de
Bug 1772313 - Part 7: Stop calling XPCOMUtils.defineLazyModuleGetters for Services. r=kmag,webdriver-reviewers,whimboo
...
Differential Revision: https://phabricator.services.mozilla.com/D148160
2022-06-06 02:49:10 +00:00
Tooru Fujisawa
d1bd5e4401
Bug 1771463 - Do not export lazy getter "fxAccounts" from services/fxaccounts/FxAccounts.jsm. r=markh,preferences-reviewers,Mardak
...
Instead of exporting lazy getter, export a function that returns the FxAccount
singleton, lazily creating on the first call, and define the lazy getter on the
consumer side that calls the function.
Differential Revision: https://phabricator.services.mozilla.com/D147634
2022-05-31 14:09:10 +00:00
Cosmin Sabou
dd73bafd11
Backed out changeset 697ab99d1c61 (bug 1771463) for causing node newtab failures. CLOSED TREE
2022-05-31 07:16:41 +03:00
Tooru Fujisawa
7f15e8996c
Bug 1771463 - Do not export lazy getter "fxAccounts" from services/fxaccounts/FxAccounts.jsm. r=markh,preferences-reviewers
...
Instead of exporting lazy getter, export a function that returns the FxAccount
singleton, lazily creating on the first call, and define the lazy getter on the
consumer side that calls the function.
Differential Revision: https://phabricator.services.mozilla.com/D147634
2022-05-31 03:12:22 +00:00
Ed Lee
35c4c70124
Bug 1767361 - Skip some colorway tests if none are available for testing r=Gijs
...
Differential Revision: https://phabricator.services.mozilla.com/D145288
2022-05-03 13:35:19 +00:00
Gijs Kruitbosch
edda40141b
Bug 1753696 - Automatic rewrite: replace add_task(setup with add_setup in browser mochitest, r=Standard8,webcompat-reviewers,twisniewski
...
Differential Revision: https://phabricator.services.mozilla.com/D141437
2022-03-30 16:16:42 +00:00
Norisz Fay
e1d7571cc8
Backed out 2 changesets (bug 1753696) for causing multiple dt and bc failures CLOSED TREE
...
Backed out changeset 67fd9edfbcea (bug 1753696)
Backed out changeset a9d957ea887b (bug 1753696)
2022-03-30 12:17:55 +03:00
Gijs Kruitbosch
1214ac636b
Bug 1753696 - Automatic rewrite: replace add_task(setup with add_setup in browser mochitest, r=Standard8,webcompat-reviewers,twisniewski
...
Differential Revision: https://phabricator.services.mozilla.com/D141437
2022-03-30 08:18:51 +00:00
Mark Banner
7ea3c792f2
Bug 1758474 - Implement an ESLint rule to disallow passing {} as the target parameter for ChromeUtils.import. r=Gijs,mossop,perftest-reviewers,preferences-reviewers,sparky
...
Differential Revision: https://phabricator.services.mozilla.com/D140517
2022-03-11 16:41:29 +00:00
smolnar
19781d16c7
Backed out changeset 5018856d8fee (bug 1758474) for causing node eslint failure. CLOSED TREE
2022-03-10 11:58:45 +02:00
Mark Banner
de1754318e
Bug 1758474 - Implement an ESLint rule to disallow passing {} as the target parameter for ChromeUtils.import. r=Gijs,mossop,perftest-reviewers,preferences-reviewers,sparky
...
Differential Revision: https://phabricator.services.mozilla.com/D140517
2022-03-10 09:25:28 +00:00
Ed Lee
5a7e0ffa17
Bug 1754124 - Filter out expired themes for UITour colorways r=Gijs
...
Differential Revision: https://phabricator.services.mozilla.com/D138135
2022-02-09 20:07:03 +00:00
Ed Lee
26fc6a6bd4
Bug 1754124 - Test fix filter out expired themes for UITour colorways r=Gijs
...
Differential Revision: https://phabricator.services.mozilla.com/D138134
2022-02-09 20:07:02 +00:00
criss
68483bb0dd
Bug 1754124 - temporarily disable browser_UITour_colorway.js on all platforms CLOSED TREE
2022-02-08 09:23:17 +02:00
Sylvestre Ledru
aa55fd2be8
Bug 1753413 - fx doc: Remove whitespaces, trailing lines & windows CR r=andi,perftest-reviewers,sparky
...
Differential Revision: https://phabricator.services.mozilla.com/D137741
2022-02-03 18:34:58 +00:00
Ed Lee
7455973eb4
Bug 1746067 - Allow activating colorway themes from some websites r=Gijs
...
Add colorways that can be queried with getConfiguration and activated/reset with setConfiguration.
Differential Revision: https://phabricator.services.mozilla.com/D134454
2022-01-07 18:15:23 +00:00
Neil Deakin
0d6adaeabb
Bug 1733786, replace uitour implementation of show how button with one that focuses the item on the app menu and submenu instead, r=Gijs
...
Differential Revision: https://phabricator.services.mozilla.com/D128428
2021-10-19 14:54:45 +00:00