corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
766,165 Commits 1 Branch 0 Tags
739b51aee122798f1d049575ff9f0747ca1fdea5
Commit Graph

1575 Commits

Author SHA1 Message Date
Mark Banner
319bc25bd8 Bug 1802855 - Convert toolkit/components/satchel JSM modules to ES modules. r=credential-management-reviewers,daleharvey,sgalich 
Differential Revision: https://phabricator.services.mozilla.com/D163201
 2022-11-29 15:53:20 +00:00
Mark Banner
104bf81d34 Bug 1801808 - Automatically replace Cu.reportError with console.error (search). r=scunnane 
Manual fixing of tests.

Differential Revision: https://phabricator.services.mozilla.com/D162696
 2022-11-23 12:29:20 +00:00
Marco Castelluccio
5bcb4a1506 Bug 1790816 - Reformat browser/ with isort. r=linter-reviewers,search-reviewers,Standard8 DONTBUILD 
# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D162667
 2022-11-22 11:09:34 +00:00
Mark Banner
11b4005c4f Bug 1791974 - Use setAsDefault* parameters where appropriate for consumers of SearchTestUtils.installSearchExtension. r=mcheang 
Differential Revision: https://phabricator.services.mozilla.com/D161045
 2022-11-18 14:30:27 +00:00
Mark Banner
9181f205be Bug 1791974 - Add set as default (private) search engine options to SearchTestUtils.promiseNewSearchEngine. r=mcheang 
Differential Revision: https://phabricator.services.mozilla.com/D161043
 2022-11-18 14:30:26 +00:00
Mark Banner
56d933d059 Bug 1702180 - Remove obsolete search SERP telemetry probes. r=scunnane 
Differential Revision: https://phabricator.services.mozilla.com/D161563
 2022-11-09 08:06:45 +00:00
Mark Banner
d992655f01 Bug 1799440 - Remove redundant locales in the Google application provided search engine. r=daleharvey 
Depends on D161444

Differential Revision: https://phabricator.services.mozilla.com/D161445
 2022-11-08 16:31:36 +00:00
Mark Banner
8decdffc9f Bug 1799438 - Update application search engines to use browser_specific_settings instead of applications in their manifests. r=daleharvey 
Differential Revision: https://phabricator.services.mozilla.com/D161444
 2022-11-08 16:31:35 +00:00
Michael Kohler
bbab2c851a Bug 1688599 - Remove old browser.search.with_ads/browser.search.ad_clicks scalars r=Standard8 
Differential Revision: https://phabricator.services.mozilla.com/D148383
 2022-11-07 11:41:36 +00:00
James Teow
57cbb18445 Bug 1779470 - Part 1: Add Nimbus variable, feature gate preference, and rename showSearchTerms prefs - r=adw 
Differential Revision: https://phabricator.services.mozilla.com/D159462
 2022-11-05 02:13:28 +00:00
William Durand
12a393c465 Bug 1797050 - Part 6 - Use browser_specific_settings instead of applications in test manifests. r=rpl,perftest-reviewers,sparky 
We want to encourage extension developers to use `browser_specific_settings` instead of `applications`, which will be unsupported in Manifest Version 3+. This patch makes sure test manifests in m-c won't cause any issues in the future.

Depends on D160541

Differential Revision: https://phabricator.services.mozilla.com/D160668
 2022-11-03 16:23:03 +00:00
Marco Bonardo
6859ef34b1 Bug 1429108 - Switch FormHistory::update to promises. r=sgalich,mconley 
Differential Revision: https://phabricator.services.mozilla.com/D160925
 2022-11-03 09:35:39 +00:00
Sam Johnson
386bc0ca68 Bug 1795986 - Fix compact mode urlbar icon alignment and macOS toolbar height r=desktop-theme-reviewers,dao,Gijs,Itiel 
Modern flexbox increased the macOS compact mode toolbar height by 2px due to a line-height rule from bug 1402368. The issue from that bug no longer reproduces on current Nightly, even without the added rule, so it seems safe to remove.

There was also some extra spacing introduced with Proton that should have been only applied to the search "go" button, so I scoped that more tightly and also fixed the alignment of that button while at it.

Differential Revision: https://phabricator.services.mozilla.com/D159975
 2022-11-02 19:41:50 +00:00
Stephanie Cunnane
b2b562b410 Bug 1798046 - Update Search Telemetry docs (replace .jsm with .sys.mjs as needed). r=mcheang 
Differential Revision: https://phabricator.services.mozilla.com/D160679
 2022-10-28 21:26:38 +00:00
Stephanie Cunnane
74f8cbb8da Bug 1789450 - Add search shortcut keyword for Qwant. r=mcheang 
Differential Revision: https://phabricator.services.mozilla.com/D159530
 2022-10-28 16:43:57 +00:00
James Teow
39f9af11ee Bug 1779471 - Rename pref and add telemetry for persistent search term searches - r=adw,Standard8 
Differential Revision: https://phabricator.services.mozilla.com/D156706
 2022-10-27 15:53:11 +00:00
trickypr
ed1b5fe3ae Bug 1510561 - Part 5: Apply plugin:mozilla/require-jsdoc to browser/components/search. r=Standard8 
Differential Revision: https://phabricator.services.mozilla.com/D159470
 2022-10-24 13:32:37 +00:00
trickypr
beac0753a6 Bug 1510561 - Part 4: Apply plugin:mozilla/valid-jsdoc to browser/components/search. r=Standard8 
Differential Revision: https://phabricator.services.mozilla.com/D159469
 2022-10-24 13:32:36 +00:00
Mark Banner
5407bdffa8 Bug 1792341 - Migrate more toolkit/modules consumers to use direct ES module import. r=Gijs,webdriver-reviewers,perftest-reviewers,necko-reviewers,geckoview-reviewers,preferences-reviewers,application-update-reviewers,pip-reviewers,credential-management-reviewers,sgalich,owlish,bytesized,AlexandruIonescu,whimboo,mconley,mixedpuppy 
Mainly automated changes. Some manual ESLint fixes and whitespace cleanup.

Differential Revision: https://phabricator.services.mozilla.com/D158452
 2022-10-18 11:21:26 +00:00
Emilio Cobos Álvarez
1f2ad76857 Bug 1790616 - Minor CSS tweaks that are needed for modern flexbox. r=dao 
These fix rendering or test issues with flex emulation, but don't change
rendering without, so can land separately.

Differential Revision: https://phabricator.services.mozilla.com/D159073
 2022-10-13 14:38:01 +00:00
Dale Harvey
923e5085f4 Bug 1792988 - Dont reset prefs on startup for users not in experiment. r=Standard8 
Differential Revision: https://phabricator.services.mozilla.com/D158889
 2022-10-11 14:09:50 +00:00
Masayuki Nakano
89ceba2ffb Bug 1792759 - part 3: Add nsIEditor.undoAll r=m_kato,Standard8 
`nsIEditor.undo` and `nsIEditor.redo` are called with `1` except by the search
bar, and search bar wants to undo everything to reset the value.  Therefore,
search bar needs an API to undo all, and the others do not need the number of
undoing/redoing transactions.  Therefore, this patch adds `nsIEditor.undoAll`
for search bar, and remove the arguments from `nsIEditor.undo` and
`nsIEditor.redo`.

Differential Revision: https://phabricator.services.mozilla.com/D158338
 2022-10-09 01:13:50 +00:00
Masayuki Nakano
3ee9858ad2 Bug 1792759 - part 1: Add nsIEditor.clearUndoRedo() to get rid of nsIEditor.transactionManager r=m_kato,NeilDeakin,Standard8 
`nsIEditor.transactionManager` is used only for some simple purposes, however,
`nsIEditor` exposes the rich API.  That makes it harder to maintain internal
code around transactions.  Instead, `nsIEditor` exposes only simple and
necessary APIs.

This patch creates a new API to clear undo/redo history and make the users in
mozilla-central use it instead of using `nsITransactionManager.clear()`.

Differential Revision: https://phabricator.services.mozilla.com/D158336
 2022-10-09 01:13:49 +00:00
Mark Banner
8bd836f9f4 Bug 1793414 - Remove MozSearchbar reliance on BrowserSearch where possible. r=jteow 
Also moves modules to be loaded lazily to avoid unnecessarily loading them on startup.

Differential Revision: https://phabricator.services.mozilla.com/D158500
 2022-10-07 07:12:18 +00:00
Mark Banner
97bfe28c29 Bug 1793414 - Move paste and search handling for the search bar into the search bar code itself. r=jteow 
Differential Revision: https://phabricator.services.mozilla.com/D158499
 2022-10-07 07:12:18 +00:00
Sandor Molnar
6dd3eab3a1 Backed out 2 changesets (bug 1793414) for causing browser-chrome failures in browser/components/search/test/browser/browser_searchbar_context.js CLOSED TREE 
Backed out changeset f27b2a93224e (bug 1793414)
Backed out changeset 1f011637d116 (bug 1793414)
 2022-10-06 12:03:15 +03:00
Mark Banner
c4a14a2fb6 Bug 1793414 - Remove MozSearchbar reliance on BrowserSearch where possible. r=jteow 
Also moves modules to be loaded lazily to avoid unnecessarily loading them on startup.

Differential Revision: https://phabricator.services.mozilla.com/D158500
 2022-10-06 07:44:51 +00:00
Mark Banner
b97f8b371b Bug 1793414 - Move paste and search handling for the search bar into the search bar code itself. r=jteow 
Differential Revision: https://phabricator.services.mozilla.com/D158499
 2022-10-06 07:44:51 +00:00
Mark Banner
e73ca1c871 Bug 1792673 - Correctly set the separate private default urlbar result preference from experiments. r=daleharvey 
Differential Revision: https://phabricator.services.mozilla.com/D158249
 2022-09-28 09:54:46 +00:00
Mark Banner
c34ea601d2 Bug 1634555 - Send event telemetry for search default engine changes. r=daleharvey 
Differential Revision: https://phabricator.services.mozilla.com/D157471
 2022-09-28 09:40:36 +00:00
Mark Banner
79b9557a71 Bug 1792398 - Enable ESLint rule 'strict' on mjs files as the directive is not necessary for modules. r=arai,pip-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D158115
 2022-09-26 21:47:50 +00:00
Marian-Vasile Laza
b7f6194b8d Backed out changeset 0679274d6ed5 (bug 1792398) for causing bc failures on browser_sendQuery.js. CLOSED TREE 2022-09-26 22:53:00 +03:00
Mark Banner
5dcae1ed44 Bug 1792398 - Enable ESLint rule 'strict' on mjs files as the directive is not necessary for modules. r=arai,pip-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D158115
 2022-09-26 18:51:57 +00:00
Narcis Beleuzu
95ae6b7d0f Backed out changeset 849faf753208 (bug 1792398) for bc failures on browser_sendQuery.js . CLOSED TREE 2022-09-26 20:44:40 +03:00
Mark Banner
ff212fab8b Bug 1792398 - Enable ESLint rule 'strict' on mjs files as the directive is not necessary for modules. r=arai,pip-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D158115
 2022-09-26 16:51:10 +00:00
Mathew Hodson
f84488ba91 Bug 1776578 - Replace init tasks with add_setup in mochitests. r=application-update-reviewers,Standard8 
Differential Revision: https://phabricator.services.mozilla.com/D149486
 2022-09-26 13:58:49 +00:00
Dale Harvey
3e229c9f49 Bug 1790790 - Add Nimbus flag to control Search Private Default. r=Standard8 
Differential Revision: https://phabricator.services.mozilla.com/D157605
 2022-09-26 00:34:11 +00:00
Butkovits Atila
62f9f0eda3 Backed out changeset f6031e0a3a0b (bug 1790790) for causing telemetry failures. CLOSED TREE 2022-09-25 02:06:13 +03:00
Dale Harvey
3677c9ceb6 Bug 1790790 - Add Nimbus flag to control Search Private Default. r=Standard8 
Differential Revision: https://phabricator.services.mozilla.com/D157605
 2022-09-24 21:12:51 +00:00
Cosmin Sabou
87e3afb738 Backed out changeset d3302226f71f (bug 1790790) for casuing xpcshell failures on test_defaultEngine_experiments.js. CLOSED TREE 2022-09-24 00:01:57 +03:00
Dale Harvey
ee07814dbd Bug 1790790 - Add Nimbus flag to control Search Private Default. r=Standard8 
Differential Revision: https://phabricator.services.mozilla.com/D157605
 2022-09-23 19:15:34 +00:00
Nolan Ishii
2041eb398c Bug 1790225 Convert browser/actors/ContentSearch* JSM modules to ESMs r=mconley 
Differential Revision: https://phabricator.services.mozilla.com/D157043
 2022-09-20 14:08:07 +00:00
Alexander Nicholson
9029aeac65 Bug 1786670 Renew newtab metrics r=chutten DONTBUILD 
Differential Revision: https://phabricator.services.mozilla.com/D157157
 2022-09-12 21:02:32 +00:00
Daisuke Akatsuka
5dfee86e94 Bug 1461844: Add bonus for searched visit. r=mak 
Differential Revision: https://phabricator.services.mozilla.com/D153557
 2022-08-27 09:49:38 +00:00
Mark Banner
24d0fe0f57 Bug 1786899 - Remove unused BrowserSearch.loadAddEngines and remove formatURL. r=jteow,preferences-reviewers 
formatURL is only used in one other place - nsContextMenu.js, so we don't really need that when we can call the necessary function direct.

Also moves `searchEnginesURL` into SearchUIUtils, as that seems a reasonable place to start storing things like that.

Differential Revision: https://phabricator.services.mozilla.com/D155496
 2022-08-26 07:55:44 +00:00
Mark Banner
1cfda0cc28 Bug 1783256 - Fix typo in Search SAP counts telemetry documentation. r=sylvestre 
Differential Revision: https://phabricator.services.mozilla.com/D155453
 2022-08-24 09:47:31 +00:00
James Teow
cddf4a59b6 Bug 1786555 - Add Bing ESR PC to test - r=Standard8 
Differential Revision: https://phabricator.services.mozilla.com/D155400
 2022-08-23 16:17:56 +00:00
Daisuke Akatsuka
7bb745d2b1 Bug 1782311: Avoid flickering due to showing/hiding one-off buttons. r=adw 
Differential Revision: https://phabricator.services.mozilla.com/D154784
 2022-08-21 21:35:52 +00:00
Daisuke Akatsuka
ca83f90a92 Bug 1782311: Do not hide oneoff buttons area when there is additional engine. r=Standard8,adw 
The cause of this bug was that we don’t consider the Add Engines to show/hide the
container of SearchOneOffs. To resolve the issue, we incorporated that into
__rebuild() function. This feature is only for search bar.

Differential Revision: https://phabricator.services.mozilla.com/D154627
 2022-08-21 21:35:51 +00:00
Iulian Moraru
93ab026b85 Backed out 2 changesets (bug 1782311) for causing mochitest failures on browser_heuristicNotAddedFirst.js. CLOSED TREE 
Backed out changeset 23414a710c13 (bug 1782311)
Backed out changeset 7307730b93c9 (bug 1782311)
 2022-08-19 11:53:36 +03:00