corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
766,165 Commits 1 Branch 0 Tags
739b51aee122798f1d049575ff9f0747ca1fdea5
Commit Graph

510 Commits

Author SHA1 Message Date
Drew Willcoxon
be3aec58a7 Bug 1756162 - Make the visibility of the "Top Pick" checkbox depend entirely on whether the best match feature is enabled. r=preferences-reviewers,Gijs 
We've made a few changes to this "Top pick" checkbox recently based on shifting
Product requirements, and the problem here is that the checkbox used to be
inside the Firefox Suggest container, but we recently moved it outside the
container. The Firefox Suggest container is properly hidden or shown depending
on whether the Suggest feature is enabled, so when the checkbox was inside the
container and Suggest was disabled, the checkbox properly got hidden too. Now
that the checkbox is outside that container, its visibility needs to entirely
depend on whether the best match feature is enabled.

So all this revision does is move the checkbox's `hidden` assignment from inside
the "is Suggest enabled" if-block to outside the if-block. It also sets
`hidden=true` on the checkbox in the markup for good measure.

I also improved the test so it checks every combination of enabled statuses
between the Suggest and best match features.

Depends on D138987

Differential Revision: https://phabricator.services.mozilla.com/D139161
 2022-02-23 03:43:14 +00:00
Iulian Moraru
d0fad6b244 Backed out changeset 15e745e8ec74 (bug 1756162) for causing mochitest failures on browser_privacy_firefoxSuggest.js. CLOSED TREE 2022-02-23 03:53:19 +02:00
Drew Willcoxon
84ae271fd3 Bug 1756162 - Make the visibility of the "Top Pick" checkbox depend entirely on whether the best match feature is enabled. r=preferences-reviewers,Gijs 
We've made a few changes to this "Top pick" checkbox recently based on shifting
Product requirements, and the problem here is that the checkbox used to be
inside the Firefox Suggest container, but we recently moved it outside the
container. The Firefox Suggest container is properly hidden or shown depending
on whether the Suggest feature is enabled, so when the checkbox was inside the
container and Suggest was disabled, the checkbox properly got hidden too. Now
that the checkbox is outside that container, its visibility needs to entirely
depend on whether the best match feature is enabled.

So all this revision does is move the checkbox's `hidden` assignment from inside
the "is Suggest enabled" if-block to outside the if-block. It also sets
`hidden=true` on the checkbox in the markup for good measure.

I also improved the test so it checks every combination of enabled statuses
between the Suggest and best match features.

Depends on D138987

Differential Revision: https://phabricator.services.mozilla.com/D139161
 2022-02-22 19:13:58 +00:00
Daisuke Akatsuka
a3f9df135b Bug 1755828: Add a Learn more link to the top pick checkbox. r=preferences-reviewers,adw,fluent-reviewers,mstriemer 
Differential Revision: https://phabricator.services.mozilla.com/D138987
 2022-02-18 17:50:22 +00:00
Punam Dahiya
116a5bda3d Bug 1754110 - Update Send email link in MoreFromMozilla r=preferences-reviewers,mstriemer 
Differential Revision: https://phabricator.services.mozilla.com/D139092
 2022-02-18 17:48:22 +00:00
Sergey Galich
277f54a286 Bug 1653486 - Replace all non-user-facing references to "master" password. r=dimi,tgiles,preferences-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D138113
 2022-02-17 17:29:57 +00:00
Daisuke Akatsuka
e1e86d3db9 Bug 1755100: Change the best match toggle in the preferences UI to a checkbox. r=adw,preferences-reviewers 
Depends on D138584

Differential Revision: https://phabricator.services.mozilla.com/D138631
 2022-02-17 02:37:28 +00:00
Drew Willcoxon
ce7c4cb8fb Bug 1755057 - Part 2: Don't show best match in the preferences UI if the best match feature is disabled. r=daisuke,Gijs,preferences-reviewers 
This is based on part 1 in D138583. It hides the best match toggle switch when
the best match feature is disabled. The best match feature is a sub-feature of
Firefox Suggest, so the toggle is also hidden if Suggest is disabled, along with
all the other Suggest UI.

Depends on D138583

Differential Revision: https://phabricator.services.mozilla.com/D138584
 2022-02-17 01:52:26 +00:00
Daisuke Akatsuka
28588d206f Bug 1753738: Update the preferences UI for Firefox Suggest best match. r=preferences-reviewers,adw 
Differential Revision: https://phabricator.services.mozilla.com/D138254
 2022-02-17 01:52:25 +00:00
Meg Viar
51b15e5d34 Bug 1747149 - Consolidate logic for when to show VPN promo and add BrowserUtils test r=dmose,preferences-reviewers,prathiksha,Gijs 
Differential Revision: https://phabricator.services.mozilla.com/D134874
 2022-02-14 14:21:04 +00:00
smolnar
9f23ccb51e Backed out changeset 260a3d2ed070 (bug 1747149) for causing android xpc failures in test_BrowserUtils. 2022-02-11 05:04:29 +02:00
Meg Viar
e8992b0b02 Bug 1747149 - Consolidate logic for when to show VPN promo and add BrowserUtils tests r=dmose,preferences-reviewers,prathiksha,Gijs 
Differential Revision: https://phabricator.services.mozilla.com/D134874
 2022-02-11 02:06:56 +00:00
Hannah Peuckmann
6ad4e83fd6 Bug 1724690 - Check for invalid combination of capability and type. r=pbz,preferences-reviewers,Gijs 
Differential Revision: https://phabricator.services.mozilla.com/D137733
 2022-02-10 15:53:46 +00:00
Marian-Vasile Laza
955d57fe74 Backed out changeset 9c6f30f619d7 (bug 1747149) for causing xpcshell failures on test_BrowserUtils.js. CLOSED TREE 2022-02-09 02:08:44 +02:00
Meg Viar
91b66923e1 Bug 1747149 - Consolidate logic for when to show VPN promo and add BrowserUtils tests r=dmose,preferences-reviewers,prathiksha,Gijs 
Differential Revision: https://phabricator.services.mozilla.com/D134874
 2022-02-08 21:39:38 +00:00
Tim Giles
685cd4d006 Bug 1745248 - Allow each autofill feature to detect if it should be enabled depending on search region. r=dimi,sgalich,preferences-reviewers,skhamis,LougeniaBailey 
Differential Revision: https://phabricator.services.mozilla.com/D133818
 2022-02-08 19:31:58 +00:00
Meg Viar
6b15a32793 Bug 1751057 - Add tests for updated Fx98 MfM utm_content values on Rally promo page r=pdahiya 
Differential Revision: https://phabricator.services.mozilla.com/D136424
 2022-02-03 14:24:40 +00:00
Iulian Moraru
e13fe3ef05 Backed out 4 changesets (bug 1745248) for causing issues with credit card sync. a=backout 
Backed out changeset 324a6acb8612 (bug 1745248)
Backed out changeset f54ce6b7dd26 (bug 1745248)
Backed out changeset c7212ce535e4 (bug 1745248)
Backed out changeset 06d57e874522 (bug 1745248)
 2022-02-03 00:50:29 +02:00
Meg Viar
5013ef4e7c Bug 1752814 - Resolve issues with showing email link to users based on accept language header given en-US/en-GB/en fallbacks used r=preferences-reviewers,pdahiya 
Differential Revision: https://phabricator.services.mozilla.com/D137483
 2022-02-02 02:53:36 +00:00
Paul Zuehlcke
32983959c3 Bug 1748993 - Add a preferences section for privacy segmentation. r=preferences-reviewers,Gijs CLOSED TREE 
- Show data collection section in about:preferences#privacy when privacy segmentation
  section is enabled.
  This is to ensure we can always show the privacy segmentation checkbox, even if data
  reporting is disabled.
- Add checkbox and learnMore label for privacy segmentation pref.
- Add pref for section visibility and learnMore link suffix.
- Provisional copy, final copy to be added in Bug 1752172.

Differential Revision: https://phabricator.services.mozilla.com/D136650
 2022-01-31 22:51:28 +00:00
Cosmin Sabou
83f0a62ead Backed out changeset 269b4d7154ec (bug 1748993) for causing privacy related bc failures. 2022-02-01 02:24:07 +02:00
Paul Zuehlcke
1b61e7c93c Bug 1748993 - Add a preferences section for privacy segmentation. r=preferences-reviewers,Gijs 
- Show data collection section in about:preferences#privacy when privacy segmentation
  section is enabled.
  This is to ensure we can always show the privacy segmentation checkbox, even if data
  reporting is disabled.
- Add checkbox and learnMore label for privacy segmentation pref.
- Add pref for section visibility and learnMore link suffix.
- Provisional copy, final copy to be added in Bug 1752172.

Differential Revision: https://phabricator.services.mozilla.com/D136650
 2022-01-31 22:51:28 +00:00
Meg Viar
e9327a9bf8 Bug 1750312 - Mfm Fx98 - remove email link for locales not supported by email r=preferences-reviewers,pdahiya,Gijs 
Differential Revision: https://phabricator.services.mozilla.com/D136373
 2022-01-28 16:49:59 +00:00
Dan Mosedale
7dc5d3ac05 Bug 1746509 - Replace More from Mozilla XUL tags with HTML, r=pdahiya,Gijs,preferences-reviewers,flod 
Differential Revision: https://phabricator.services.mozilla.com/D135733
 2022-01-27 19:11:27 +00:00
Tim Giles
c5cbdd8cd4 Bug 1745248 - Allow each autofill feature to detect if it should be enabled depending on search region. r=dimi,sgalich,preferences-reviewers,skhamis,LougeniaBailey 
Differential Revision: https://phabricator.services.mozilla.com/D133818
 2022-01-26 20:11:41 +00:00
Punam Dahiya
2707ea7ffe Bug 1749245 - Switch MfM as default for Fx98 r=preferences-reviewers,Gijs 
Differential Revision: https://phabricator.services.mozilla.com/D136431
 2022-01-26 18:28:19 +00:00
Punam Dahiya
a9251d546a Bug 1750309 - Add experiment params for users enrolled in MfM experiments r=preferences-reviewers,mviar,mstriemer 
Differential Revision: https://phabricator.services.mozilla.com/D136261
 2022-01-22 18:23:30 +00:00
Greg Tatum
1f2718ca13 Bug 1740067 - Add live language reloading tests; r=mstriemer,preferences-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D136022
 2022-01-20 21:42:28 +00:00
Greg Tatum
79d3b1c3a1 Bug 1740067 - Rename language switching variables to be more explicit; r=mstriemer,platform-i18n-reviewers,preferences-reviewers,nordzilla 
These were all areas that were confusing me when I was onboarding on to
this code, so I tried to make the terminology less ambiguous and more
precise.

The default language is now the primary language.

UI is now appended to words that are dealing with DOM elements rather
than data stores.

Differential Revision: https://phabricator.services.mozilla.com/D136019
 2022-01-20 21:42:27 +00:00
Meg Viar
bf8ae6a133 Bug 1749243 - Update Fx98 MfM utm_content values to add region r=pdahiya 
Differential Revision: https://phabricator.services.mozilla.com/D135903
 2022-01-20 19:11:22 +00:00
Barret Rennie
77ce6a1148 Bug 1747461 - Remove FileUtils.getFile from browser/components/preferences r=preferences-reviewers,Gijs 
Differential Revision: https://phabricator.services.mozilla.com/D134898
 2022-01-19 18:37:25 +00:00
Valentin Gosu
aab3fb7c11 Bug 1741554 - Prevent browser_connection_dnsoverhttps.js from connecting to non-local DoH IP r=preferences-reviewers,Gijs 
Differential Revision: https://phabricator.services.mozilla.com/D136230
 2022-01-19 10:23:30 +00:00
Paul Zuehlcke
2af411c1df Bug 1748877 - Add a pref and telemetry for privacy segmentation opt-in state. r=timhuang,Gijs 
Differential Revision: https://phabricator.services.mozilla.com/D135247
 2022-01-17 14:27:15 +00:00
Punam Dahiya
aa5bdcaeb1 Bug 1741795 - Make More from Mozilla content customizable by partner repacks r=preferences-reviewers,mviar,hectorz 
Differential Revision: https://phabricator.services.mozilla.com/D134574
 2022-01-14 22:57:34 +00:00
Kershaw Chang
74a65c68ee Bug 1741425 - Enable more mochitest with socket process, r=ahal,webdriver-reviewers,preferences-reviewers,whimboo 
Differential Revision: https://phabricator.services.mozilla.com/D134485
 2022-01-11 09:49:45 +00:00
Cosmin Sabou
af66b13655 Backed out 3 changesets (Bug 1745248) for causing issues with FormAutofill.jsm. CLOSED TREE 
Backed out changeset b39b99edef97 (bug 1745248)
Backed out changeset b09a96820c2c (bug 1745248)
Backed out changeset 03dd6cedf996 (bug 1745248)
 2022-01-06 20:56:43 +02:00
Dan Mosedale
1fd43a06e6 Bug 1746946 - remove moreFromMozilla URL params for experiments, r=Gijs,preferences-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D134985
 2022-01-05 16:44:08 +00:00
Butkovits Atila
5caee35951 Bug 1741554 - disable browser_connection_dnsoverhttps.js on Win_64_opt for frequent failures. r=intermittent-reviewers,preferences-reviewers,jmaher,Gijs DONTBUILD 
Differential Revision: https://phabricator.services.mozilla.com/D134760
 2022-01-05 08:32:13 +00:00
Sergey Galich
b2acb270f6 Bug 1747288 - Fix test pref setup r=tgiles,preferences-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D134519
 2022-01-04 16:08:48 +00:00
Meg Viar
863c68436c Bug 1746657 - Only show Rally in MoreForMozilla when region is US and language is en r=preferences-reviewers,dmose,Gijs 
Differential Revision: https://phabricator.services.mozilla.com/D134191
 2021-12-30 20:54:53 +00:00
Narcis Beleuzu
1188940ea2 Backed out changeset a717ea6f73fe (bug 1746657) browser_privacy_firefoxSuggest.js . CLOSED TREE 2021-12-30 20:20:06 +02:00
Meg Viar
eba5256fd4 Bug 1746657 - Only show Rally in MoreForMozilla when region is US and language is en r=preferences-reviewers,dmose,Gijs 
Differential Revision: https://phabricator.services.mozilla.com/D134191
 2021-12-30 17:29:50 +00:00
Meg Viar
69fcd838a1 Bug 1741741 - Avoid showing Mozilla VPN in unsupported countries r=dmose,preferences-reviewers,pdahiya,Gijs 
Differential Revision: https://phabricator.services.mozilla.com/D133903
 2021-12-22 19:55:29 +00:00
Sam Foster
cca45e0c64 Bug 1738916 - when users want asking where to save files, do not ask for files automatically opened with helper applications, r=mhowell 
Differential Revision: https://phabricator.services.mozilla.com/D133957
 2021-12-21 22:20:26 +00:00
Punam Dahiya
0caa598886 Bug 1746696 - Update UTM Params used for More From Mozilla Fx96 r=preferences-reviewers,dmose 
Differential Revision: https://phabricator.services.mozilla.com/D134218
 2021-12-20 21:26:11 +00:00
Andrei Oprea
a7951796c6 Bug 1745264 - More From Mozilla section should be searchable inside about:preferences r=preferences-reviewers,pdahiya,mstriemer 
Differential Revision: https://phabricator.services.mozilla.com/D133875
 2021-12-19 21:47:07 +00:00
Iulian Moraru
41cab5e8ee Backed out changeset 7bd019078917 (bug 1745264) for causing mochitest failures on browser_moreFromMozilla.js. CLOSED TREE 2021-12-19 22:48:02 +02:00
Andrei Oprea
bd217f0054 Bug 1745264 - More From Mozilla section should be searchable inside about:preferences r=preferences-reviewers,pdahiya,mstriemer 
Differential Revision: https://phabricator.services.mozilla.com/D133875
 2021-12-19 19:58:35 +00:00
Tim Giles
bc1b91771d Bug 1745248 - Fix tests from removing the form autofill module pref and allowing each feature to determine if it should be available or not. r=dimi,sgalich 
Differential Revision: https://phabricator.services.mozilla.com/D133820
 2021-12-17 21:41:23 +00:00
Sandor Molnar
f00947fe24 Backed out 3 changesets (bug 1745248) for causing bc failures in browser_first_time_use_doorhanger. CLOSED TREE 
Backed out changeset ef2454116a21 (bug 1745248)
Backed out changeset 8aeb5a348950 (bug 1745248)
Backed out changeset b1808ec2fe97 (bug 1745248)
 2021-12-17 21:12:27 +02:00