corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
766,165 Commits 1 Branch 0 Tags
739b51aee122798f1d049575ff9f0747ca1fdea5
Commit Graph

3744 Commits

Author SHA1 Message Date
Cristian Tuns
9796804d31 Backed out changeset b4f24df08c5a (bug 1802564) for causing bc failures on browser_glean_telemetry_engagement_interaction.js CLOSED TREE 2022-12-01 20:24:11 -05:00
James Teow
c0621f6f3d Bug 1802564 - Toggle showSearchTerms to true on Nightly - r=adw 
Differential Revision: https://phabricator.services.mozilla.com/D163221
 2022-12-01 23:06:14 +00:00
Emilio Cobos Álvarez
ecba84bda4 Bug 1802508 - Use width property rather than attribute for site permission label/menulists. r=mconley,settings-reviewers 
Width attribute stopped working the moment we made labels use modern
flex / block layout.

Differential Revision: https://phabricator.services.mozilla.com/D163253
 2022-11-28 22:11:01 +00:00
James Teow
14f7ec50f1 Bug 1800851 - showSearchTerms checkbox should listen to search bar changes - r=adw,settings-reviewers 
While trying to simplify the test code prior to landing the initial preference
panel update, I removed some checks in the test that ensured the checkbox
was actually being checked if the user enabled the search bar while the search
panel was opened. Hence how the tests passed despite the fact that I neglected
to include a listener.

Differential Revision: https://phabricator.services.mozilla.com/D162583
 2022-11-22 18:20:22 +00:00
scott
35e4f02b0f Bug 1798956 - Pocket newtab ensure we clear spocs in cases where sponsored topsites applies to Pocket data. r=nanj 
Differential Revision: https://phabricator.services.mozilla.com/D162028
 2022-11-21 20:24:29 +00:00
Norisz Fay
e02f711c8c Backed out changeset e87383813223 (bug 1643309) for causing bc failures on browser_aboutDialog_fc_check_cantApply.js CLOSED TREE 2022-11-18 21:55:40 +02:00
Max Christian Pohle
116159b915 Bug 1643309 - About dialog falsely claims App "is up to date" when offline, r=bytesized,application-update-reviewers,fluent-reviewers,settings-reviewers,bhearsum,flod 
This commit is based on a patch written by Priyank Singh <preyunk>. Thank you
for your contribution, which is strongly appreciated. The original patch was
discussed here: https://phabricator.services.mozilla.com/D97972#3405294

Differential Revision: https://phabricator.services.mozilla.com/D159907
 2022-11-18 17:16:55 +00:00
Mark Banner
11b4005c4f Bug 1791974 - Use setAsDefault* parameters where appropriate for consumers of SearchTestUtils.installSearchExtension. r=mcheang 
Differential Revision: https://phabricator.services.mozilla.com/D161045
 2022-11-18 14:30:27 +00:00
Emilio Cobos Álvarez
c81a0b84cb Bug 1800828 - Simplify markup of fonts dialog. r=Gijs,settings-reviewers 
This doesn't fix the bug but removes some unnecessary elements (now that the
prefs search was improved), and moves some CSS out of inline styles into
already-existing rules.

Differential Revision: https://phabricator.services.mozilla.com/D162342
 2022-11-18 13:34:42 +00:00
Mark Banner
5d1820b074 Bug 1799314 - Convert consumers of testing modules to import ES modules direct (browser/). r=Gijs,settings-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D161914
 2022-11-17 12:00:30 +00:00
Emilio Cobos Álvarez
9e70efc4e9 Bug 1800379 - Fix layout of network settings description with long text. r=mconley 
Differential Revision: https://phabricator.services.mozilla.com/D161969
 2022-11-14 21:44:12 +00:00
Gijs Kruitbosch
7c2395c270 Bug 1329643 - implement generic richlistbox improvements for keyboard focus, r=Jamie,settings-reviewers,mossop 
Rather than having each richlistbox consumer having to reinvent focus patterns for
buttons and menulists in its 'rich' items, let's just teach richlistbox and
richlistitem to not suck at keyboard navigation. That way we won't keep forgetting
to deal with this whenever we add new lists anywhere.

This allows us to remove the custom handling in sitePermissions.js, and the same
handling should be covered by the existing test, ie
browser/components/preferences/tests/browser_permissions_dialog.js

To summarize the desired keyboard behaviour:
- tab/shift-tab move focus to controls inside selected items only (not other rows)
- arrow keys move the list selection up/down
- when arrowing to move the list selection, focus moves with the selection if it
  was previously on a control in the previously selected item.

Differential Revision: https://phabricator.services.mozilla.com/D161528
 2022-11-14 21:07:08 +00:00
Sammy Khamis
d33b8692ad Bug 1706909: QR code provided not fully displayed on small screens r=Gijs,settings-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D160867
 2022-11-08 18:56:44 +00:00
Sandor Molnar
b849d26f92 Backed out changeset fc4182143aad (bug 1706909) for causing crashes in nsCSSFrameConstructor::ConstructFramesFromItem 2022-11-08 02:35:20 +02:00
Sammy Khamis
97e6615ffd Bug 1706909: QR code provided not fully displayed on small screens r=Gijs,settings-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D160867
 2022-11-07 23:11:17 +00:00
Mark Banner
df52ac2d97 Bug 1798212 - Replace defineModuleGetter in Integration.sys.mjs with a ES version. r=settings-reviewers,mossop 
Differential Revision: https://phabricator.services.mozilla.com/D161014
 2022-11-07 17:56:10 +00:00
Mark Banner
19c189e131 Bug 1798212 - Convert consumers of downloads code to ES modules. r=mak,geckoview-reviewers,extension-reviewers,settings-reviewers,credential-management-reviewers,sgalich,mconley,m_kato 
Differential Revision: https://phabricator.services.mozilla.com/D161013
 2022-11-07 17:56:10 +00:00
James Teow
cc3a7abd51 Bug 1779470 - Part 2: Add show search terms in url bar feature to about:preferences#search - r=adw,flod 
See https://www.figma.com/file/Ock0cYjzi7I1GmcctqOr9K/Search-settings-updates?node-id=2%3A112 for mockup.

Depends on D159462

Differential Revision: https://phabricator.services.mozilla.com/D155866
 2022-11-05 02:13:29 +00:00
Paul Zuehlcke
5dff2bab6e Bug 1796397 - Remove privacy_segmentation.status telemetry. r=bvandersloot,settings-reviewers,mconley 
Differential Revision: https://phabricator.services.mozilla.com/D161131
 2022-11-03 19:45:13 +00:00
William Durand
12a393c465 Bug 1797050 - Part 6 - Use browser_specific_settings instead of applications in test manifests. r=rpl,perftest-reviewers,sparky 
We want to encourage extension developers to use `browser_specific_settings` instead of `applications`, which will be unsupported in Manifest Version 3+. This patch makes sure test manifests in m-c won't cause any issues in the future.

Depends on D160541

Differential Revision: https://phabricator.services.mozilla.com/D160668
 2022-11-03 16:23:03 +00:00
Sandor Molnar
beb9ba4391 Backed out changeset 7593b0f809da (bug 1706909) for causing assertion failures at !disp->IsAbsolutelyPositionedStyle() CLOSED TREE 2022-11-03 00:18:27 +02:00
Sammy Khamis
4130ea0544 Bug 1706909: QR code provided not fully displayed on small screens r=Gijs,settings-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D160867
 2022-11-02 20:06:31 +00:00
mcheang
7aba04e4e0 Bug 1786324 - Change SearchService to reference engines by Ids rather than names. r=Standard8 
An id is created for every new instance of SearchEngine. The new
getEngineById method should be called to return an engine rather than
calling getEngineByName.

Differential Revision: https://phabricator.services.mozilla.com/D155236
 2022-11-02 12:17:38 +00:00
Drew Willcoxon
209873a1d6 Bug 1798595 - Refactor quick suggest [Part 4]: Move help URL from UrlbarProviderQuickSuggest to QuickSuggest and change how the test utils are initialized. r=daisuke 
This moves the help URL const out of UrlbarProviderQuickSuggest in order to make
UrlbarProviderQuickSuggest focused on being a urlbar provider.

It also changes how QuickSuggestTestUtils is initialized to be more similar to
MerinoTestUtils. There's no need for a separate `init()` method when the
constructor will do. I'd like to make this change in a different revision but I
did it here because I want to include all changes to about:preferences in one
revision for easier review.

Please see bug 1798595 for details.

Depends on D160984

Differential Revision: https://phabricator.services.mozilla.com/D160985
 2022-11-02 06:50:14 +00:00
Neil Deakin
6cc6947dde Bug 1676492, show the bookmarks toolbar when a new window is opened when the preference is set to show a blank page, r=Mardak,settings-reviewers 
w

Differential Revision: https://phabricator.services.mozilla.com/D155003
 2022-11-01 20:43:02 +00:00
Mark Banner
0008510845 Bug 1798018 - Convert consumers of toolkit/modules/tests to import ES modules direct. r=Gijs,webdriver-reviewers,extension-reviewers,settings-reviewers,credential-management-reviewers,sgalich 
Differential Revision: https://phabricator.services.mozilla.com/D160664
 2022-11-01 13:26:38 +00:00
Emilio Cobos Álvarez
ba0666dbcd Bug 1798171 - Remove vertical spacers in site permission dialog. r=mconley 
We size to the minimum vertical size, so by default they don't take any space
at all anyways.

When scrolling, the min size of the content flexes along with them causing
broken sizing.

Differential Revision: https://phabricator.services.mozilla.com/D160723
 2022-10-31 21:54:33 +00:00
Mike Kaply
ebded06c38 Bug 1769265 - Disabling updater for packages should not be Windows specific. r=bhearsum,settings-reviewers,application-update-reviewers,bytesized 
Differential Revision: https://phabricator.services.mozilla.com/D160069
 2022-10-28 12:49:24 +00:00
William Durand
646444ad1e Bug 1797050 - Part 4 - Use browser_specific_settings instead of applications in remaining tests. r=rpl,application-update-reviewers,bytesized 
Differential Revision: https://phabricator.services.mozilla.com/D160060
 2022-10-28 09:53:10 +00:00
Joel Maher
7ba743bfbb Bug 1797751 - carry over skip-if conditions from win10 to win11. r=bxbrenden,necko-reviewers,settings-reviewers,credential-management-reviewers,valentin,sgalich 
Differential Revision: https://phabricator.services.mozilla.com/D160529
 2022-10-28 00:00:40 +00:00
Cristian Tuns
698f6bd3a6 Backed out changeset 2fd5aae2c05a (bug 1769265) for causing xpcshell failures on win 2004 CLOSED TREE 2022-10-27 13:25:48 -04:00
Mark Banner
452d7aa6a7 Bug 1797689 - Clean up strict violations in browser/ r=mossop,settings-reviewers 
Depends on D160490

Differential Revision: https://phabricator.services.mozilla.com/D160491
 2022-10-27 15:58:25 +00:00
Mike Kaply
bb512df335 Bug 1769265 - Disabling updater for packages should not be Windows specific. r=bhearsum,settings-reviewers,application-update-reviewers,bytesized 
Differential Revision: https://phabricator.services.mozilla.com/D160069
 2022-10-27 15:18:35 +00:00
Emilio Cobos Álvarez
9f20e4d1f4 Bug 1797345 - Use width property rather than attribute in permission dialogs and so. r=pbz 
While at it, contain the permission list so that adding items doesn't
grow the dialog.

Differential Revision: https://phabricator.services.mozilla.com/D160302
 2022-10-27 09:12:09 +00:00
Mike Kaply
4a14a16be0 Bug 1793905 - Disable HTTPS only preferences when locked. r=settings-reviewers,Gijs,mconley 
Differential Revision: https://phabricator.services.mozilla.com/D160373
 2022-10-26 16:01:19 +00:00
Sandor Molnar
9fbee3a9f1 Backed out changeset 53ce60b1b515 (bug 1797050) for causing bc failures in browser/components/preferences/tests/browser_extension_controlled.js CLOSED TREE 2022-10-26 15:01:23 +03:00
William Durand
00c4a3becb Bug 1797050 - Part 4 - Use browser_specific_settings instead of applications in remaining tests. r=rpl,application-update-reviewers,bytesized 
Differential Revision: https://phabricator.services.mozilla.com/D160060
 2022-10-26 11:15:12 +00:00
Sebastian Hengst
2b1cea57e1 Bug 1797454 - update meta data which links Firefox Settings UI files to their Bugzilla component. r=Gijs,preferences-reviewers DONTBUILD 
Differential Revision: https://phabricator.services.mozilla.com/D160335
 2022-10-26 09:30:07 +00:00
Mark Banner
433fff5bca Bug 1795322 - Update toolkit modules references in browser/ code. r=mossop,Gijs,preferences-reviewers,desktop-theme-reviewers,dao 
Differential Revision: https://phabricator.services.mozilla.com/D160031
 2022-10-26 08:06:35 +00:00
Csoregi Natalia
5edbe31601 Backed out 12 changesets (bug 1795322) for causing multiple failures e.g. test_deletion_request_ping.py. CLOSED TREE 
Backed out changeset aba25cbcda51 (bug 1795322)
Backed out changeset a4a35005ada9 (bug 1795322)
Backed out changeset 8e8d790eb0f4 (bug 1795322)
Backed out changeset db8903454bd3 (bug 1795322)
Backed out changeset 60cc71c61cad (bug 1795322)
Backed out changeset bc6a674994ad (bug 1795322)
Backed out changeset 6ac8a611f8c7 (bug 1795322)
Backed out changeset 9fb873ecfb31 (bug 1795322)
Backed out changeset c8a7a40c2a2f (bug 1795322)
Backed out changeset f2c118b6c6ce (bug 1795322)
Backed out changeset 38df43b4a70f (bug 1795322)
Backed out changeset 89aea8373411 (bug 1795322)
 2022-10-25 23:47:58 +03:00
Mark Banner
6bff0ab996 Bug 1795322 - Update toolkit modules references in browser/ code. r=mossop,Gijs,preferences-reviewers,desktop-theme-reviewers,dao 
Differential Revision: https://phabricator.services.mozilla.com/D160031
 2022-10-25 19:49:26 +00:00
mleclair
012c4866f3 Bug 1741955: allow value set through about:config for trr mode to precede about:pref r=kershaw,pbz 
Differential Revision: https://phabricator.services.mozilla.com/D159369
 2022-10-19 20:06:30 +00:00
Mike Conley
38730598bb Bug 1795188 - Migrate all uriloader/exthandler JSMs to ESMs. r=kpatenio 
Differential Revision: https://phabricator.services.mozilla.com/D159345
 2022-10-19 18:34:02 +00:00
Gijs Kruitbosch
450ac5ac39 Bug 1794757 - autoplay dialog should wait for translation to finish before showing and determining size to avoid buttons being cut off, r=kpatenio 
The sitePermissions code is reused, and all dialogs work OK except the autoplay one.
This is because the autoplay code adds extra content not present in the other
dialogs, and localizes it.
The SubDialog code relies on determining the size of the dialog once the
mozSubDialogReady promise resolves, which it does before fluent puts in l10n data
for the content that was just added. This patch fixes that.

It also, as a driveby, correctly pauses and resumes observing l10n attributes
in the doc when making modifications, to avoid fluent doing a second pass for
the same content.

Differential Revision: https://phabricator.services.mozilla.com/D159543
 2022-10-19 14:59:22 +00:00
Mark Banner
5407bdffa8 Bug 1792341 - Migrate more toolkit/modules consumers to use direct ES module import. r=Gijs,webdriver-reviewers,perftest-reviewers,necko-reviewers,geckoview-reviewers,preferences-reviewers,application-update-reviewers,pip-reviewers,credential-management-reviewers,sgalich,owlish,bytesized,AlexandruIonescu,whimboo,mconley,mixedpuppy 
Mainly automated changes. Some manual ESLint fixes and whitespace cleanup.

Differential Revision: https://phabricator.services.mozilla.com/D158452
 2022-10-18 11:21:26 +00:00
Alexandre Poirot
bde84f5b65 Bug 1793604 - [devtools] Convert Loader.jsm to ESM. r=perftest-reviewers,geckoview-reviewers,preferences-reviewers,owlish,kshampur,jdescottes 
Differential Revision: https://phabricator.services.mozilla.com/D158582
 2022-10-14 12:19:42 +00:00
Emilio Cobos Álvarez
e5685e8457 Bug 1794987 - Simplify preferences find-in-page tooltip implementation. r=mconley,Gijs,preferences-reviewers 
<menulist> still uses legacy XUL layout (for reasons, I plan to fix it
but it can take a little bit).

The issue here is a poor interaction between one of the wrapping hboxes
and the xul layout. But we can simplify the code and fix the bug at the
same time, so do that.

Differential Revision: https://phabricator.services.mozilla.com/D159254
 2022-10-14 10:41:35 +00:00
Sammy Khamis
1b9b14c41e Bug 1794940 - Copy change to the Sync QR Code screen r=Gijs,fluent-reviewers,preferences-reviewers,flod 
Differential Revision: https://phabricator.services.mozilla.com/D159227
 2022-10-13 21:59:49 +00:00
Sammy Khamis
bebe842cd0 Bug 1792328 - remove min-height from choose what to sync dialog r=emilio,fluent-reviewers,flod,preferences-reviewers,Gijs 
Differential Revision: https://phabricator.services.mozilla.com/D159133
 2022-10-13 21:07:55 +00:00
Mark Hammond
21bd24ad69 Bug 1792550 - ensure the primary password is unlocked before signing in to sync. r=Mardak,sfoster 
Differential Revision: https://phabricator.services.mozilla.com/D158719
 2022-10-12 22:31:37 +00:00