Commit Graph

70 Commits

Author SHA1 Message Date
trickypr
e2590adbcc Bug 1510561 - Part 10: Apply plugin:mozilla/require-jsdoc to browser/components/pagedata. r=Standard8
Depends on D160634

Differential Revision: https://phabricator.services.mozilla.com/D160635
2022-10-28 13:44:29 +00:00
trickypr
056004ba76 Bug 1510561 - Part 9: Apply plugin:mozilla/valid-jsdoc to browser/components/pagedata. r=Standard8
Depends on D160633

Differential Revision: https://phabricator.services.mozilla.com/D160634
2022-10-28 13:44:29 +00:00
Mark Banner
5407bdffa8 Bug 1792341 - Migrate more toolkit/modules consumers to use direct ES module import. r=Gijs,webdriver-reviewers,perftest-reviewers,necko-reviewers,geckoview-reviewers,preferences-reviewers,application-update-reviewers,pip-reviewers,credential-management-reviewers,sgalich,owlish,bytesized,AlexandruIonescu,whimboo,mconley,mixedpuppy
Mainly automated changes. Some manual ESLint fixes and whitespace cleanup.

Differential Revision: https://phabricator.services.mozilla.com/D158452
2022-10-18 11:21:26 +00:00
Mark Banner
a49b8ef78f Bug 1792365 - Convert toolkit/modules consumers to use ES module imports directly. r=webdriver-reviewers,perftest-reviewers,geckoview-reviewers,extension-reviewers,preferences-reviewers,desktop-theme-reviewers,application-update-reviewers,pip-reviewers,credential-management-reviewers,robwu,Gijs,sgalich,bytesized,AlexandruIonescu,dao,m_kato
Differential Revision: https://phabricator.services.mozilla.com/D158094
2022-09-29 06:52:34 +00:00
Mark Banner
79b9557a71 Bug 1792398 - Enable ESLint rule 'strict' on mjs files as the directive is not necessary for modules. r=arai,pip-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D158115
2022-09-26 21:47:50 +00:00
Marian-Vasile Laza
b7f6194b8d Backed out changeset 0679274d6ed5 (bug 1792398) for causing bc failures on browser_sendQuery.js. CLOSED TREE 2022-09-26 22:53:00 +03:00
Mark Banner
5dcae1ed44 Bug 1792398 - Enable ESLint rule 'strict' on mjs files as the directive is not necessary for modules. r=arai,pip-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D158115
2022-09-26 18:51:57 +00:00
Narcis Beleuzu
95ae6b7d0f Backed out changeset 849faf753208 (bug 1792398) for bc failures on browser_sendQuery.js . CLOSED TREE 2022-09-26 20:44:40 +03:00
Mark Banner
ff212fab8b Bug 1792398 - Enable ESLint rule 'strict' on mjs files as the directive is not necessary for modules. r=arai,pip-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D158115
2022-09-26 16:51:10 +00:00
Mark Banner
d026f430f6 Bug 1779982 - Migrate places consumers to use ESM imports directly. r=mak,preferences-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D152005
2022-07-20 22:34:21 +00:00
smolnar
ee079d37e2 Backed out 8 changesets (bug 1779982, bug 1780017, bug 1780347) for causing doc generate failures. CLOSED TREE
Backed out changeset 3f22c0f99cf1 (bug 1780347)
Backed out changeset 6f20b7e4b21b (bug 1780017)
Backed out changeset ae6062c69aeb (bug 1780017)
Backed out changeset e668d7778d97 (bug 1780017)
Backed out changeset e158fc41594b (bug 1780017)
Backed out changeset d4c69c956271 (bug 1779982)
Backed out changeset 145212fd826d (bug 1779982)
Backed out changeset 54079aaa1857 (bug 1779982)
2022-07-20 22:43:53 +03:00
Mark Banner
8715b062f5 Bug 1779982 - Migrate places consumers to use ESM imports directly. r=mak,preferences-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D152005
2022-07-20 15:50:40 +00:00
Iulian Moraru
bc13570de5 Backed out 7 changesets (bug 1779982, bug 1780017) for causing multiple failures. CLOSED TREE
Backed out changeset f33a58aa2f3f (bug 1780017)
Backed out changeset e21c85d61b91 (bug 1780017)
Backed out changeset 213ee5578e7c (bug 1780017)
Backed out changeset ea9b3bf42ea1 (bug 1780017)
Backed out changeset d2d8530f3c4d (bug 1779982)
Backed out changeset 088e5148c307 (bug 1779982)
Backed out changeset 267e08f3868a (bug 1779982)
2022-07-20 15:44:53 +03:00
Mark Banner
2bd76952c1 Bug 1779982 - Migrate places consumers to use ESM imports directly. r=mak,preferences-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D152005
2022-07-20 10:36:49 +00:00
Tooru Fujisawa
e28ef8c35e Bug 1779539 - Use static import for XPCOMUtils.jsm in system ESMs in browser/components/pagedata. r=mossop
Differential Revision: https://phabricator.services.mozilla.com/D151802
2022-07-14 08:54:01 +00:00
Tooru Fujisawa
1c0d027da3 Bug 1777488 - Migrate browser/components/pagedata to ESM. r=mossop
Differential Revision: https://phabricator.services.mozilla.com/D151222
2022-07-12 10:05:04 +00:00
Tooru Fujisawa
328d63ce7f Bug 1777486 - Part 2: Migrate XPCOMUtils.jsm consumers with automatic migration. r=webdriver-reviewers,geckoview-reviewers,preferences-reviewers,application-update-reviewers,pip-reviewers,kmag,owlish,whimboo
Differential Revision: https://phabricator.services.mozilla.com/D151214
2022-07-12 04:21:34 +00:00
Andreea Pavel
f009ba2983 Backed out 11 changesets (Bug 1777486) for failing bc at browser_startup.js on a CLOSED TREE
Backed out changeset b6c4c386f1a6 (Bug 1777486)
Backed out changeset 195cc2de8433 (Bug 1777486)
Backed out changeset 20c746fb1648 (Bug 1777486)
Backed out changeset d5fd8173d62d (Bug 1777486)
Backed out changeset 6d758fab5a3e (Bug 1777486)
Backed out changeset e938b601ba15 (Bug 1777486)
Backed out changeset 0c4ea0b9416b (Bug 1777486)
Backed out changeset 0559c53cc668 (Bug 1777486)
Backed out changeset eea573d3a9f9 (Bug 1777486)
Backed out changeset 9ce3a6496a49 (bug 1777486)
Backed out changeset b0867652fc48 (bug 1777486)
2022-07-11 22:24:40 +03:00
Tooru Fujisawa
bf0a8b781b Bug 1777486 - Part 2: Migrate XPCOMUtils.jsm consumers with automatic migration. r=webdriver-reviewers,geckoview-reviewers,preferences-reviewers,application-update-reviewers,pip-reviewers,kmag,owlish,whimboo
Differential Revision: https://phabricator.services.mozilla.com/D151214
2022-07-11 15:09:13 +00:00
Tooru Fujisawa
48c568867c Bug 1667455 - Part 5: Stop importing Services.jsm from chrome-priv JS code, top-level single-line cases. r=kmag,webdriver-reviewers,perftest-reviewers,webcompat-reviewers,geckoview-reviewers,extension-reviewers,application-update-reviewers,pip-reviewers,twisniewski,m_kato,jdescottes,mconley,AlexandruIonescu,mossop
Differential Revision: https://phabricator.services.mozilla.com/D150894
2022-07-11 12:41:50 +00:00
Tooru Fujisawa
b10d0289af Bug 1667455 - Part 4: Stop importing Services.jsm from JSM. r=kmag,webdriver-reviewers,perftest-reviewers,webcompat-reviewers,geckoview-reviewers,application-update-reviewers,pip-reviewers,twisniewski,devtools-reviewers,m_kato,jdescottes,ochameau,mconley,sfoster,AlexandruIonescu
Differential Revision: https://phabricator.services.mozilla.com/D150893
2022-07-11 12:41:50 +00:00
Tooru Fujisawa
8f9bf2f553 Bug 1608282 - Part 3: Remove Cu.importGlobalProperties from JSM. r=extension-reviewers,kmag
Depends on D149195

Differential Revision: https://phabricator.services.mozilla.com/D149196
2022-06-16 00:19:54 +00:00
Butkovits Atila
0642580e74 Backed out 4 changesets (bug 1608282) for causing hazard failures. CLOSED TREE
Backed out changeset 32aebc8be201 (bug 1608282)
Backed out changeset 37c970364269 (bug 1608282)
Backed out changeset ced8d82cc2d2 (bug 1608282)
Backed out changeset e26e480c7dd6 (bug 1608282)
2022-06-16 03:10:02 +03:00
Tooru Fujisawa
f094b522e1 Bug 1773829 - Part 3: Stop using lazy getter unnecessarily in browser/components/. r=MattN
Depends on D149011

Differential Revision: https://phabricator.services.mozilla.com/D149012
2022-06-15 20:56:23 +00:00
Tooru Fujisawa
a4b321722f Bug 1608282 - Part 3: Remove Cu.importGlobalProperties from JSM. r=extension-reviewers,kmag
Depends on D149195

Differential Revision: https://phabricator.services.mozilla.com/D149196
2022-06-15 20:34:35 +00:00
Tooru Fujisawa
7d6884e4d1 Bug 1772100 - Part 11: Use plain object for lazy getter in browser/components/pagedata/. r=mossop
Differential Revision: https://phabricator.services.mozilla.com/D148021
2022-06-06 22:46:23 +00:00
Tooru Fujisawa
3e483c26e8 Bug 1772313 - Part 7: Stop calling XPCOMUtils.defineLazyModuleGetters for Services. r=kmag,webdriver-reviewers,whimboo
Differential Revision: https://phabricator.services.mozilla.com/D148160
2022-06-06 04:42:06 +00:00
Molnar Sandor
4c2b06df41 Backed out 15 changesets (bug 1772313, bug 1772351, bug 1772360) for causing xpc failures in telemetry/tests/unit/test_SocketScalars.js CLOSED TREE
Backed out changeset c8b0a2ed239e (bug 1772360)
Backed out changeset 1922adad6abe (bug 1772351)
Backed out changeset 6d3634cce489 (bug 1772351)
Backed out changeset f03968a9d053 (bug 1772351)
Backed out changeset e7a38ef90fe4 (bug 1772351)
Backed out changeset b389e7654771 (bug 1772313)
Backed out changeset 59a33598ff51 (bug 1772313)
Backed out changeset ab60885a8a93 (bug 1772313)
Backed out changeset aad8efac9d05 (bug 1772313)
Backed out changeset 4378e519a8e7 (bug 1772313)
Backed out changeset 302ac54741f8 (bug 1772313)
Backed out changeset 74c59f9fd51c (bug 1772313)
Backed out changeset 575fb877c56c (bug 1772313)
Backed out changeset 2eaa68f10b19 (bug 1772313)
Backed out changeset 4a8b3ba193dc (bug 1772313)
2022-06-06 07:04:25 +03:00
Tooru Fujisawa
c98ea942de Bug 1772313 - Part 7: Stop calling XPCOMUtils.defineLazyModuleGetters for Services. r=kmag,webdriver-reviewers,whimboo
Differential Revision: https://phabricator.services.mozilla.com/D148160
2022-06-06 02:49:10 +00:00
Dave Townsend
be3877db55 Bug 1757725: Expire page data in memory when no longer needed. r=Standard8
Currently we cache page data in memory until the browser is closed but this is
too long. We know there could be a couple of consumers of page data, snapshots
and AVM being two so we want to keep any discovered data in memory until we
know that no-one is interested anymore.

This adds a cache and a way for an "actor" (ugh!) to register interest in a url.
As long as there is an actor interested in a url any data for that url will be
cached in memory.

The idea is that when we start tracking a new interaction we start caching any
data for that url. When interactions have been flushed to disk and we've made
any decision about snapshotting we allow the data to expire.

We also by default keep data in the cache until the browser it came from is
destroyed.

Later the AVM can keep a page's data alive until it no longer exists in the
river.

Differential Revision: https://phabricator.services.mozilla.com/D140056
2022-03-18 09:46:06 +00:00
Marco Bonardo
9a6cb6e013 Bug 1759548 - MR2-1988 - Support some kind of lazy loading of images in schema.org definitions. r=mossop
Differential Revision: https://phabricator.services.mozilla.com/D140995
2022-03-16 15:27:32 +00:00
Dave Townsend
dc998dd871 Bug 1746167: Support parsing JSON-LD page data. r=Standard8
This is just a start and there are a number of JSON-LD features not currently
handled.

Differential Revision: https://phabricator.services.mozilla.com/D133878
2021-12-16 16:27:52 +00:00
Dave Townsend
da7b276891 Bug 1746022: Correctly parse nested microdata properties. r=Standard8
This parses the entire set of microdata in the page into a structure similar to
the JSON-LD format for page data and then parses the data from that. This sets
us up for adding support for parsing JSON-LD at somepoint in the future.

Differential Revision: https://phabricator.services.mozilla.com/D133877
2021-12-16 16:27:52 +00:00
Dave Townsend
bc497a82ac Bug 1746022: Fix some encoding warnings in tests. r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D133876
2021-12-16 15:30:29 +00:00
Dave Townsend
95373c7c4c Bug 1744753: Use floats not integers for prices. r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D133080
2021-12-09 20:12:12 +00:00
Dave Townsend
593c52d3fd Bug 1741588: Allow retrieving page data in the background. r=Standard8,mconley
Some of the specifics of this aren't worked out yet, so this is currently unused and expect changes to the specific load behaviour in the future.

Differential Revision: https://phabricator.services.mozilla.com/D131333
2021-12-07 09:24:24 +00:00
Sandor Molnar
94dd1b72ae Backed out changeset 84391bad8a10 (bug 1741588) for causing multiple xpc/mochitest failures. CLOSED TREE 2021-12-01 15:27:13 +02:00
Dave Townsend
87e088a1d2 Bug 1741588: Allow retrieving page data in the background. r=Standard8
Some of the specifics of this aren't worked out yet, so this is currently unused and expect changes to the specific load behaviour in the future.

Differential Revision: https://phabricator.services.mozilla.com/D131333
2021-12-01 12:28:31 +00:00
Dave Townsend
a11af1f95f Bug 1740539: Get siteName, image and description from twitter cards. r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D130884
2021-11-16 14:54:09 +00:00
Dave Townsend
6c6dae53e1 Bug 1740538: Get site name from organization microdata. r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D130883
2021-11-16 14:54:09 +00:00
Dave Townsend
96b0777e4d Bug 1740536: Support descriptions for pages. r=mak
Differential Revision: https://phabricator.services.mozilla.com/D130882
2021-11-16 14:54:08 +00:00
criss
5e47505361 Backed out 3 changesets (bug 1740536, bug 1740538, bug 1740539) for causing xpcshell failures on test_snapshots_page_image.js. CLOSED TREE
Backed out changeset 5799bb789d17 (bug 1740539)
Backed out changeset 7b6d2c239663 (bug 1740538)
Backed out changeset 6d91e21a9ae3 (bug 1740536)
2021-11-16 16:12:08 +02:00
Dave Townsend
df3b6a7b91 Bug 1740539: Get siteName, image and description from twitter cards. r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D130884
2021-11-16 13:13:26 +00:00
Dave Townsend
bec5a1464c Bug 1740538: Get site name from organization microdata. r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D130883
2021-11-16 13:13:26 +00:00
Dave Townsend
bbec2b1b41 Bug 1740536: Support descriptions for pages. r=mak
Differential Revision: https://phabricator.services.mozilla.com/D130882
2021-11-16 13:13:25 +00:00
Dave Townsend
ac43fa3462 Bug 1740531: Move page data collection into PageDataSchema for easier testing. r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D130881
2021-11-16 10:29:17 +00:00
Sylvestre Ledru
bb153e4e07 Bug 1714788 - doc: Fix a Pygments warning r=firefox-source-docs-reviewers,championshuttler DONTBUILD
Warning:
lexer name 'bz_comment_text' is not known

Depends on D131047

Differential Revision: https://phabricator.services.mozilla.com/D131095
2021-11-16 07:59:49 +00:00
Dave Townsend
07a9af3023 Bug 1740729: Catch and log any errors during page data collection. r=Standard8
This logs any exceptions during data collection and turns the result of
destroying the page while collection is happening into a return of null data as
we probably don't need to log that every time.

Differential Revision: https://phabricator.services.mozilla.com/D130982
2021-11-14 17:09:50 +00:00
Dave Townsend
1e602d5571 Bug 1739379: Collect page data in the new schema. r=Standard8,mak
Note that this includes an uplift from MR2-839.

Differential Revision: https://phabricator.services.mozilla.com/D130360
2021-11-09 11:36:58 +00:00
Dave Townsend
cb52d2509a Bug 1739377: Add JSON schemas for page data. r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D130358
2021-11-09 09:06:06 +00:00