Commit Graph

132 Commits

Author SHA1 Message Date
Barret Rennie
d1a2566d45 Bug 1541508 - Use Services.env in browser/ r=mossop
Differential Revision: https://phabricator.services.mozilla.com/D160136
2022-11-25 19:09:06 +00:00
Shane Hughes
f15f8a12bf Bug 1802333 - Idle trigger debug logging. r=barret
To debug the idle trigger's interaction with OS sleep state, it's
helpful to know whether sleep/wake notifications were sent. This allows
most of the idle trigger activity to be logged to the console, if the
pref `messaging-system.log` is set to `debug`. The new logging will also
be used to debug the behavior reported in bug 1801301.

Differential Revision: https://phabricator.services.mozilla.com/D163010
2022-11-25 10:42:25 +00:00
Mark Banner
9ecec1531f Bug 1800319 - Change newtab code so that the ESLint rule no-console is an error, except for console.error calls. r=Mardak
Differential Revision: https://phabricator.services.mozilla.com/D161942
2022-11-13 21:02:41 +00:00
Shane Hughes
9ee16ecf2d Bug 1786336 - Resolve some idle trigger issues. r=mviar
Differential Revision: https://phabricator.services.mozilla.com/D161237
2022-11-09 22:37:44 +00:00
Shane Hughes
3a879faacf Bug 1786336 - Add idle message surface trigger. r=mviar
This patch adds a new trigger that will be used to deliver messages to
the user without disrupting their work. The trigger will only fire when
the user starts interacting with the browser (e.g. moving the mouse or
pressing a key) after a given period of time has passed without any user
activity or audio playback. In the initial messages planned for this
trigger, the necessary period of idle time will be 20 minutes. The
trigger fires after a 2 second delay to ensure the user does not miss
the message. Putting the computer to sleep or waking it up from sleep
will reset the idle "timer" to avoid messages being delivered as soon as
the computer is woken up from sleep.

Differential Revision: https://phabricator.services.mozilla.com/D160454
2022-10-29 07:08:59 +00:00
Punam Dahiya
f332fca018 Bug 1789192 - MR Onboarding Mobile Cross promo QRCode for MozillaOnline partner repack r=jprickett,hectorz
Differential Revision: https://phabricator.services.mozilla.com/D157000
2022-09-13 18:35:01 +00:00
Iulian Moraru
dcf1f3817e Backed out changeset b81337fc9ed1 (bug 1789192) for causing multiple bc failures. CLOSED TREE 2022-09-13 19:44:44 +03:00
Punam Dahiya
31a79a1338 Bug 1789192 - MR Onboarding Mobile Cross promo QRCode for MozillaOnline partner repack r=jprickett,hectorz
Patch updates QR code svg as confirmed in https://bugzilla.mozilla.org/show_bug.cgi?id=1789192#c3

Differential Revision: https://phabricator.services.mozilla.com/D157000
2022-09-13 15:52:27 +00:00
Chris H-C
03ec4b9f67 Bug 1786612 - Instrument Pocket interactions with events r=thecount
Differential Revision: https://phabricator.services.mozilla.com/D155756
2022-09-07 17:28:36 +00:00
Chris H-C
589fc52a3e Bug 1786612 - Add topsites and top stories prefs to 'newtab' ping r=nanj,thecount
Also include pocket logged in status, which (because it's not a pref) is
sampled over time.

Also also, include the search field pref.

Differential Revision: https://phabricator.services.mozilla.com/D155755
2022-09-07 17:28:35 +00:00
Mark Banner
0263c56d1f Bug 1780825 - Allow defineESModuleGetters to be handed in newtab unit tests. r=daleharvey
Depends on D152253

Differential Revision: https://phabricator.services.mozilla.com/D152535
2022-08-02 15:07:48 +00:00
smolnar
a8099b19fc Bug 1780445 - Fix ES lint failure. a=lint-fix 2022-07-21 06:03:41 +03:00
Barret Rennie
f1d3a85827 Bug 1780445 - Fix Remote Settings server URL lookup in ASRouter and Remote Images r=pdahiya,nalexander
Differential Revision: https://phabricator.services.mozilla.com/D152306
2022-07-21 02:28:59 +00:00
Barret Rennie
8fbde5b119 Bug 1775187 - Refactor out localizableText and localizedText from FxMS schemas r=nalexander,dmose
Several kinds of FxMS messages support a common pattern of taking either a
string or an object containing a string ID, allowing for both raw strings and
translated string IDs to be used in messages. This patch refactors that pattern
out into a common definition (localizedText and localizableText) in a common
schema which other schemas can then reference.

Our schema bundling script has been updated to bundle these definitions from
the common schema as top-level definitions (and subsequently rewrite the
references from FxMSCOmmon.schema.json to the generated schema) because Nimbus
and Experimenter only support a single schema file per feature.

To ensure compatability with Experimenter, all our in-tree messages have been
extracted into a test corpus that is validated with the Experimenter JSON
Schema validator. A future patch in this series will clean this up so we don't
need to have separate copies of messages in the tree.

We are now also validating all messages from the CFRMessageProvider with our
in-tree JSON Schema validator that Nimbus uses. The OnboardingMessageProvider
and PanelTestProvider tests have also been updated so that all three are using
the same testing infrastructure.

Differential Revision: https://phabricator.services.mozilla.com/D150704
2022-07-21 00:47:44 +00:00
Barret Rennie
d49d4f6987 Bug 1743570 - Remove FeatureAPI.isEnabled r=emcminn
Differential Revision: https://phabricator.services.mozilla.com/D150693
2022-07-12 10:04:38 +00:00
Tooru Fujisawa
e61dea0b36 Bug 1778336 - Support ChromeUtils.importESModule in newtab karma test. r=Mardak
Differential Revision: https://phabricator.services.mozilla.com/D151143
2022-07-07 09:33:17 +00:00
Chris H-C
b16d177a8c Bug 1766887 - Decorate handoff searches with newtab session ids r=nanj,Standard8
Differential Revision: https://phabricator.services.mozilla.com/D146225
2022-06-17 20:21:50 +00:00
Chris H-C
dbda5399ca Bug 1766887 - Gate 'newtab' ping submission behind Nimbus feature variable r=TravisLong
Differential Revision: https://phabricator.services.mozilla.com/D146847
2022-06-17 20:21:50 +00:00
Chris H-C
69a594ce29 Bug 1766887 - Introduce a minimal "newtab" ping for holistic data collection r=nanj,Dexter
It doesn't actually collect anything new, but by collecting it all in one place
we should make analysis easier.

Can be shut off by setting `browser.newtabpage.ping.enabled` to `false`.

Differential Revision: https://phabricator.services.mozilla.com/D146224
2022-06-17 20:21:49 +00:00
Cristian Tuns
b967cfd2bb Backed out 8 changesets (bug 1766887) for causing mochitest failures on browser_newtab_ping.js CLOSED TREE
Backed out changeset a6b01c1e8823 (bug 1766887)
Backed out changeset 1ef2dd2b779e (bug 1766887)
Backed out changeset f248baea014a (bug 1766887)
Backed out changeset 3f3066906403 (bug 1766887)
Backed out changeset 3ad63b0fa7b8 (bug 1766887)
Backed out changeset 06a0a6ef295a (bug 1766887)
Backed out changeset abe659b175cb (bug 1766887)
Backed out changeset f90e9e70f6d4 (bug 1766887)
2022-06-17 10:49:00 -04:00
Chris H-C
86f5e18f2f Bug 1766887 - Decorate handoff searches with newtab session ids r=nanj,Standard8
Differential Revision: https://phabricator.services.mozilla.com/D146225
2022-06-17 13:47:05 +00:00
Chris H-C
522825441b Bug 1766887 - Gate 'newtab' ping submission behind Nimbus feature variable r=TravisLong
Differential Revision: https://phabricator.services.mozilla.com/D146847
2022-06-17 13:47:04 +00:00
Chris H-C
3e21f3e2ba Bug 1766887 - Introduce a minimal "newtab" ping for holistic data collection r=nanj,Dexter
It doesn't actually collect anything new, but by collecting it all in one place
we should make analysis easier.

Can be shut off by setting `browser.newtabpage.ping.enabled` to `false`.

Differential Revision: https://phabricator.services.mozilla.com/D146224
2022-06-17 13:47:04 +00:00
Dan Mosedale
b2502351c9 Bug 1753915 - Add logging to ASRouter, r=barret
Differential Revision: https://phabricator.services.mozilla.com/D137968
2022-06-10 14:16:24 +00:00
Tooru Fujisawa
a535834d86 Bug 1771930 - Part 3: Add a workaround to support plain object in lazy getter API. r=Mardak
Differential Revision: https://phabricator.services.mozilla.com/D147798
2022-06-01 21:31:20 +00:00
Tooru Fujisawa
d1bd5e4401 Bug 1771463 - Do not export lazy getter "fxAccounts" from services/fxaccounts/FxAccounts.jsm. r=markh,preferences-reviewers,Mardak
Instead of exporting lazy getter, export a function that returns the FxAccount
singleton, lazily creating on the first call, and define the lazy getter on the
consumer side that calls the function.

Differential Revision: https://phabricator.services.mozilla.com/D147634
2022-05-31 14:09:10 +00:00
Scott
207f8eb326 Bug 1746066 - Fixing Pocket newtab Nimbus update event removal r=andreio,gvn
Differential Revision: https://phabricator.services.mozilla.com/D133784
2021-12-16 16:38:37 +00:00
Scott
7808e0a62e Bug 1624481 - Pocket newtab personalization hash checker for remote settings attachments r=gvn
Differential Revision: https://phabricator.services.mozilla.com/D133292
2021-12-09 18:46:25 +00:00
Scott
cc3020fbe8 Bug 1724984 - Remove OS.File from PersonalityProviderWorkerClass r=barret,emcminn
Differential Revision: https://phabricator.services.mozilla.com/D131427
2021-11-23 21:56:31 +00:00
Emily McMinn
327b48eac3 Bug 1724985 - Remove OS.File from RemoteL10n.jsm and associated tests r=andreio
Differential Revision: https://phabricator.services.mozilla.com/D129871
2021-11-09 16:10:27 +00:00
Cristian Tuns
91a8623198 Backed out changeset 781b6946a619 (bug 1724985) for causing mochitest failures. CLOSED TREE 2021-11-03 12:20:35 -04:00
Emily McMinn
d657f0e201 Bug 1724985 - Remove OS.File from RemoteL10n.jsm and associated tests r=andreio
Differential Revision: https://phabricator.services.mozilla.com/D129871
2021-11-03 14:27:15 +00:00
Mark Banner
f321dfd6b1 Bug 1729460 - Change users of defineLazyServiceGetter(s) to use Services.* where appropriate. r=mossop,webdriver-reviewers,extension-reviewers,whimboo,robwu
Differential Revision: https://phabricator.services.mozilla.com/D124838
2021-09-10 12:09:49 +00:00
Nan Jiang
a19595d894 Bug 1721525 - Replace Cu.reportError with log warnings for Contile r=mythmon
Differential Revision: https://phabricator.services.mozilla.com/D122285
2021-08-10 20:07:24 +00:00
Andrei Oprea
5bbb536fe9 Bug 1713812 - Remove NimbusFeature.getValue and convert all usages to getAllVariables r=k88hudson
Differential Revision: https://phabricator.services.mozilla.com/D119738
2021-07-29 12:27:45 +00:00
Gavin Lazar Suntop
51de92789f Bug 1717891 - Spoc position pref r=thecount
Differential Revision: https://phabricator.services.mozilla.com/D119435
2021-07-23 16:34:12 +00:00
Dorel Luca
75f451c3b6 Backed out changeset cfd1a5096364 (bug 1717891) for XPCshell failures in toolkit/components/nimbus/test/unit/test_FeatureManifest.js. CLOSED TREE 2021-07-23 07:38:21 +03:00
Gavin Lazar Suntop
0c96676823 Bug 1717891 - Spoc position pref r=thecount
Differential Revision: https://phabricator.services.mozilla.com/D119435
2021-07-23 01:07:38 +00:00
Kate Hudson
dabeafdf54 Bug 1715281 - Rename ExperimentFeature to _ExperimentFeature r=andreio
Differential Revision: https://phabricator.services.mozilla.com/D119201
2021-07-07 13:54:21 +00:00
Nan Jiang
d8d7071031 Bug 1717847 - Filter the blocked sponsored top sites from RemoteSettings r=dao
Differential Revision: https://phabricator.services.mozilla.com/D118650
2021-06-27 08:25:39 +00:00
Ed Lee
ab80e5196f Bug 1711899 - Remove "Sign in" button and FxA metrics from about:welcome when FxA is disabled r=emcminn
Prepare content for both isProton and pre-proton designs. Also deep clone to avoid directly deleting from pre-proton DEFAULT object.

Differential Revision: https://phabricator.services.mozilla.com/D115834
2021-05-26 21:29:18 +00:00
Punam Dahiya
185a506bdc Bug 1707749 - New user onboarding Import primary button label to use download source r=Mardak
Differential Revision: https://phabricator.services.mozilla.com/D113749
2021-04-30 20:27:48 +00:00
Butkovits Atila
d1bfad928c Backed out changeset 77dc7ca6680f (bug 1707749) for causing failures at browser_aboutwelcome_multistage.js. CLOSED TREE 2021-04-30 11:37:41 +03:00
Punam Dahiya
0591691e73 Bug 1707749 - New user onboarding Import primary button label to use download source r=Mardak
Differential Revision: https://phabricator.services.mozilla.com/D113749
2021-04-30 07:33:17 +00:00
Ed Lee
87a020f68e Bug 1707140 - [win7] Remove theme screen from new user onboarding r=pdahiya
Use prepareContentForReact to remove any screen that uses theme tiles. Only show steps if there's more than 1 step.

Differential Revision: https://phabricator.services.mozilla.com/D113610
2021-04-28 20:03:25 +00:00
emcminn
a066509df3 Bug 1703327 - Get Attribution data on about:welcome import page r=Mardak,pdahiya
Differential Revision: https://phabricator.services.mozilla.com/D112437
2021-04-27 21:33:59 +00:00
Ed Lee
5bafc72016 Bug 1705121 - Proton new user onboarding welcome screen primary CTA r=pdahiya
Async dynamically modify default proton content based on if app needs pin. Also hide en-only caption.

Differential Revision: https://phabricator.services.mozilla.com/D112443
2021-04-17 01:20:15 +00:00
Barret Rennie
2fd15efd16 Bug 1649607 - Migrate PersistentCache.jsm to IOUtils and PathUtils r=Mardak
Differential Revision: https://phabricator.services.mozilla.com/D96887
2021-03-24 18:17:57 +00:00
Nan Jiang
dc87844103 Bug 1688698 - Add telemetry for sponsored TopSites r=thecount
Differential Revision: https://phabricator.services.mozilla.com/D104846
2021-02-22 20:03:18 +00:00
Kate Hudson
17c048556f Bug 1672202 - Add Feature API with default values r=andreio
Differential Revision: https://phabricator.services.mozilla.com/D104056
2021-02-06 01:24:06 +00:00